Florian Hockmann created TINKERPOP-2187:
-------------------------------------------

             Summary: Two issues with the ShortestPathVertexProgram
                 Key: TINKERPOP-2187
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2187
             Project: TinkerPop
          Issue Type: Bug
          Components: process
    Affects Versions: 3.4.1
            Reporter: Florian Hockmann


While trying to update JanusGraph to TinkerPop 3.4.0, I encountered two issues 
with the {{ShortestPathVertexProgramm}}:
 # [{{ShortestPathVertexProgram.getMessageScopes()}} returns an empty
 
collection|https://github.com/apache/tinkerpop/blob/350897aaf0e5f3cd95742c9930998ce574b1934e/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/search/path/ShortestPathVertexProgram.java#L192]
 which doesn't work for a graph computer that uses these scopes to execute the 
edge traversal. I think the scopes should be {{Global}} and {{Local}} with the 
edge traversal.
 # The {{ShortestPathVertexProgram}} defines no message combiner, but 
{{sendMessages()}} can apparently still send multiple messages for the same 
vertex.
For some reason, this doesn't lead to any problems for the 
{{TinkerGraphComputer}}. (Maybe it receives each message before another one can 
be sent for the same vertex?)
For {{FulgoraGraphComputer}} however some tests result in a situation where 
multiple messages are sent to the same vertex which fails because no combiner 
is defined.
So, I'd say that the {{ShortestPathVertexProgram}} should have a message 
combiner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to