Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2066644940 I like it!! Definitely way better than my change which now seems like a bad hack 藍 I can close this PR in favor of yours  -- This is an automated message from the Apache Git

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez closed pull request #720: Re-adding support for fractional seconds in access log URL: https://github.com/apache/tomcat/pull/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2066468644 Please have a look at a different PR which builds on some refactoring I just pushed: https://github.com/apache/tomcat/pull/721 I think I like mine better. -- This is an

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2064310044 > Are you specifically talking about the ExtendedAccessLogValve's `time-taken` token? If so, you're right, that documentation did not change yet the underlying implementation did

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063868914 Oh, I'm' sorry I didn't pick-up on the subtleties of your report. Tomcat 10.1 is documented that the value for `%T` is in (presumably _whole_) seconds. Tomcat 9 says it's

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063746801 It can, but in this case the documentation states that it didn't so I was trying to bring it back to how it behaved before (which as an added bonus helps us not change our scripts).

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2063733345 So nothing can ever change, then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061838297 > Why not use `%D` which is in milliseconds (Tomcat <10) or microseconds (Tomcat >= 10)? I wanted to keep parity on the behavior here with previous versions, especially because

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061821679 > From memory that change was to align Tomcat's access log configuration with httpd. It may well be that the correct fix here is to correct the documentation. Separately, comparing this

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061771435 Why not use `%D` which is in milliseconds (Tomcat <10) or microseconds (Tomcat >= 10)? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

markt-asf commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2061540617 From memory that change was to align Tomcat's access log configuration with httpd. It may well be that the correct fix here is to correct the documentation. Separately, comparing this