(tomcat) branch main updated (cbefe8624e -> 1ddcd538a8)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from cbefe8624e Fix disastrous cookie-logging patch. new 06ecc62163 Fix typos new 50d4b6fd94 SocketTimeout has no

(tomcat) 04/06: Refactor to specify acceptor stop wait time in ms rather than s

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ef2e8f9c0639a247e68c304a587a5e8b12f8bc3c Author: Mark Thomas AuthorDate: Fri Apr 19 18:04:36 2024 +0100 Refactor to

(tomcat) 02/06: SocketTimeout has no impact for acceptor unlock - remove it

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 50d4b6fd940928ca8a11420297503f563503b501 Author: Mark Thomas AuthorDate: Fri Apr 19 17:45:56 2024 +0100 SocketTimeout

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

markt-asf commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1572780769 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char pattern)

(tomcat) 03/06: Allow any positive value for socket.unlockTimeout rather than >=2s

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2bbee3883dd40f3612fc2620fc58b2f43ee5debd Author: Mark Thomas AuthorDate: Fri Apr 19 17:49:26 2024 +0100 Allow any

(tomcat) 05/06: Reduce the default wait time for the acceptor unlock

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 59c53815d0cead640663d6a1fcdef826335e283e Author: Mark Thomas AuthorDate: Fri Apr 19 18:08:09 2024 +0100 Reduce the

(tomcat) 01/06: Fix typos

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 06ecc621637d2e9119a8640eaa71cd748e7013c3 Author: Mark Thomas AuthorDate: Fri Apr 19 17:44:32 2024 +0100 Fix typos ---

(tomcat) 06/06: Remove deprecated code

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1ddcd538a8b2328d02e98cb9d207940256a19f5e Author: Mark Thomas AuthorDate: Fri Apr 19 19:16:07 2024 +0100 Remove

(tomcat) branch 10.1.x updated (443e9be641 -> b76216af5d)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 443e9be641 getDeferAccept() always returns false - remove unused code new d30a545b31 SocketTimeout has no impact

(tomcat) 03/04: Refactor to specify acceptor stop wait time in ms rather than s

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ba98642273f1ce9a81857506dffb6dc370d7d2f9 Author: Mark Thomas AuthorDate: Fri Apr 19 18:04:36 2024 +0100 Refactor to

(tomcat) branch 10.1.x updated: Fix typos

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 0b00fdb313 Fix typos 0b00fdb313 is described

(tomcat) 03/04: Refactor to specify acceptor stop wait time in ms rather than s

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3d81c5cd9e3836be806b651b0f81dc68f58fc4f4 Author: Mark Thomas AuthorDate: Fri Apr 19 18:04:36 2024 +0100 Refactor to

(tomcat) 02/04: Allow any positive value for socket.unlockTimeout rather than >=2s

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3f9b18d7788300571178b6d3f95e96fdbd80504b Author: Mark Thomas AuthorDate: Fri Apr 19 17:49:26 2024 +0100 Allow any

(tomcat) 04/04: Reduce the default wait time for the acceptor unlock

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 725467428b4cfe14b325168bf9849f3d5fe4ae9d Author: Mark Thomas AuthorDate: Fri Apr 19 18:08:09 2024 +0100 Reduce the

(tomcat) 01/04: Fix typos

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit acc9a94f89a1c3a6e6829c0bcb1c732e59df7bf1 Author: Mark Thomas AuthorDate: Fri Apr 19 17:44:32 2024 +0100 Fix typos

(tomcat) branch 9.0.x updated (31fc71858f -> 725467428b)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 31fc71858f Dispatch after AsyncListener.onError() should actually dispatch new acc9a94f89 Fix typos new

(tomcat) branch 10.1.x updated: getDeferAccept() always returns false - remove unused code

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 443e9be641 getDeferAccept() always returns false

(tomcat) 04/04: Reduce the default wait time for the acceptor unlock

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b76216af5d8ad0608c3da5f0a9a273f3b46f647e Author: Mark Thomas AuthorDate: Fri Apr 19 18:08:09 2024 +0100 Reduce the

(tomcat) 02/04: Allow any positive value for socket.unlockTimeout rather than >=2s

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b79a946cbc3fa55073c733dbf4a9ab1c5fdbd003 Author: Mark Thomas AuthorDate: Fri Apr 19 17:49:26 2024 +0100 Allow any

(tomcat) 01/04: SocketTimeout has no impact for acceptor unlock - remove it

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d30a545b319abfcdadc9f94d26a529324c9401b5 Author: Mark Thomas AuthorDate: Fri Apr 19 17:45:56 2024 +0100

[Bug 68911] Newly introduced ConfigurationSource doesn't respect environment variables

https://bz.apache.org/bugzilla/show_bug.cgi?id=68911 --- Comment #7 from Rainer Jung --- Your reproduction suggestion sounds easy, but it misses a lot of important precision. Since separating out CATALINA_BASE is a working recipe for many of us, could you please answer: - which OS is this on?

[Bug 68911] Newly introduced ConfigurationSource doesn't respect environment variables

https://bz.apache.org/bugzilla/show_bug.cgi?id=68911 7elem...@mail.bg changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

(tomcat) branch main updated (899e06a7ba -> d3482c35bf)

This is an automated email from the ASF dual-hosted git repository. schultz pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 899e06a7ba Merge branch 'main' of https://github.com/apache/tomcat new cbc2b3500f Clarify that time-taken is now

(tomcat) 02/02: Re-factor ElapsedTimeElement to use a customizable Style

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d3482c35bf144cc891dfa325b2f2f50460708c23 Author: Christopher Schultz AuthorDate: Thu Apr 18 10:22:16 2024 -0400

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

ChristopherSchultz commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2066468644 Please have a look at a different PR which builds on some refactoring I just pushed: https://github.com/apache/tomcat/pull/721 I think I like mine better. -- This is an

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

markt-asf commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1572301203 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char pattern)

Re: (tomcat) 02/02: Re-factor ElapsedTimeElement to use a customizable Style

On 19/04/2024 13:31, Mark Thomas wrote: On 19/04/2024 13:12, schu...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit

[Bug 68919] New: Make Tomcat return 503 on stopped web applications

https://bz.apache.org/bugzilla/show_bug.cgi?id=68919 Bug ID: 68919 Summary: Make Tomcat return 503 on stopped web applications Product: Tomcat 9 Version: 9.0.x Hardware: All OS: All Status: NEW Severity:

(tomcat) 01/02: Clarify that time-taken is now in seconds and not fractional-seconds.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cbc2b3500fc4051d6a94530c50d451cf0c79e54d Author: Christopher Schultz AuthorDate: Thu Apr 18 09:38:23 2024 -0400

(tomcat) branch 10.1.x updated (1ffc62afa7 -> 1448eccfd8)

This is an automated email from the ASF dual-hosted git repository. schultz pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 1ffc62afa7 Add openssl ffm testing new 89433ad101 Clarify that time-taken is now in seconds and not

(tomcat) 01/02: Clarify that time-taken is now in seconds and not fractional-seconds.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 89433ad101747669eb34d3e30f26caf4e8d59232 Author: Christopher Schultz AuthorDate: Thu Apr 18 09:38:23 2024 -0400

(tomcat) 02/02: Re-factor ElapsedTimeElement to use a customizable Style

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1448eccfd86ef6385e0af629c138ab28405ed6c2 Author: Christopher Schultz AuthorDate: Thu Apr 18 10:22:16 2024 -0400

Re: (tomcat) 02/02: Re-factor ElapsedTimeElement to use a customizable Style

On 19/04/2024 13:12, schu...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d3482c35bf144cc891dfa325b2f2f50460708c23 Author: Christopher Schultz

Re: (tomcat) 02/02: Re-factor ElapsedTimeElement to use a customizable Style

Mark, On 4/19/24 08:31, Mark Thomas wrote: On 19/04/2024 13:12, schu...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit

Re: (tomcat) branch main updated: Don't create a StringBuilder object until we know we have at least one Cookie value to log.

Ping. Just making sure this veto hasn't been lost in the recent flurry of commits. Mark On 18/04/2024 16:12, Mark Thomas wrote: On 18/04/2024 14:31, schu...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in

[Bug 68919] Make Tomcat return 503 on stopped web applications

https://bz.apache.org/bugzilla/show_bug.cgi?id=68919 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 68911] Newly introduced ConfigurationSource doesn't respect environment variables

https://bz.apache.org/bugzilla/show_bug.cgi?id=68911 --- Comment #8 from 7elem...@mail.bg --- (In reply to Rainer Jung from comment #7) > Your reproduction suggestion sounds easy, but it misses a lot of important > precision. Since separating out CATALINA_BASE is a working recipe for many > of

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez closed pull request #720: Re-adding support for fractional seconds in access log URL: https://github.com/apache/tomcat/pull/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Re-adding support for fractional seconds in access log [tomcat]

jose-galvez commented on PR #720: URL: https://github.com/apache/tomcat/pull/720#issuecomment-2066644940 I like it!! Definitely way better than my change which now seems like a bad hack 藍 I can close this PR in favor of yours  -- This is an automated message from the Apache Git

Re: (tomcat) branch main updated: Don't create a StringBuilder object until we know we have at least one Cookie value to log.

Mark, On 4/18/24 11:12, Mark Thomas wrote: On 18/04/2024 14:31, schu...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were

(tomcat) branch main updated: Fix disastrous cookie-logging patch.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new cbefe8624e Fix disastrous cookie-logging patch.

[PR] Tomcat-jdbc causes problem with graalvm [tomcat]

MartinLei opened a new pull request, #722: URL: https://github.com/apache/tomcat/pull/722 Using the Tomcat-JDBC library inside a Spring Native project causes the compilation step of a GraalVM native image to crash with the given error. > Exception in thread "main"

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

ChristopherSchultz commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1572451843 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char

Re: (tomcat) branch main updated: Fix disastrous cookie-logging patch.

> On Apr 19, 2024, at 09:18, Christopher Schultz > wrote: > > Hopefully this patch has the intended effect. ;) I’m not convinced this change will have any measurable performance improvement. The JVM C2 compiler is pretty good with escape analysis, so an unused StringBuilder object may not

Re: (tomcat) branch main updated: Don't create a StringBuilder object until we know we have at least one Cookie value to log.

Mark, On 4/19/24 08:38, Mark Thomas wrote: Ping. Just making sure this veto hasn't been lost in the recent flurry of commits. ACK I'll revert and re-evaluate. Thanks, -chris On 18/04/2024 16:12, Mark Thomas wrote: On 18/04/2024 14:31, schu...@apache.org wrote: This is an automated email

Re: (tomcat) branch main updated: Fix disastrous cookie-logging patch.

All, Hopefully this patch has the intended effect. ;) -chris On 4/19/24 10:17, schu...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following

Re: [PR] Add support for timescales with time-taken access log token. [tomcat]

ChristopherSchultz commented on code in PR #721: URL: https://github.com/apache/tomcat/pull/721#discussion_r1572455403 ## java/org/apache/catalina/valves/AbstractAccessLogValve.java: ## @@ -1756,10 +1776,14 @@ protected AccessLogElement createAccessLogElement(String name, char