xxeol2 commented on PR #654:
URL: https://github.com/apache/tomcat/pull/654#issuecomment-1706706294
I'm curious if following code changes would introduce any side effects.
### Origin
```java
public ServletOutputStream getOutputStream() throws IOException {
checkFacade();
xxeol2 opened a new pull request, #657:
URL: https://github.com/apache/tomcat/pull/657
https://github.com/apache/tomcat/pull/654#issuecomment-1706706294
This was discussed in the comments above!
--
This is an automated message from the Apache Git Service.
To respond to the message,
ingpyo opened a new pull request, #655:
URL: https://github.com/apache/tomcat/pull/655
Hello,
I have fixed a typo in the Tomcat codebase by changing "CookiePreocessor" to
"CookieProcessor" for better code clarity and correctness.
--
This is an automated message from the Apache Git
markt-asf merged PR #655:
URL: https://github.com/apache/tomcat/pull/655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
greeng00se opened a new pull request, #656:
URL: https://github.com/apache/tomcat/pull/656
Existing code calls getConfiguredSessionCookieName even if the context is
empty.
In getConfiguredSessionCookieName, only act to get the session cookie if the
context is non-null.
I
woosung1223 opened a new pull request, #653:
URL: https://github.com/apache/tomcat/pull/653
Hi there!
I found unnecessary code in the Response class.
Currently, it seems that only headers of Content-Length or Content-Type are
called Special Headers.
However, as you can
markt-asf commented on PR #653:
URL: https://github.com/apache/tomcat/pull/653#issuecomment-1706758159
Those checks were added for performance reasons. They were significantly
quicker than calling `checkSpecialHeader()`. Unless a benchmark (as a unit
test) is provided that demonstrates
xxeol2 commented on PR #654:
URL: https://github.com/apache/tomcat/pull/654#issuecomment-1706772038
@markt-asf
I was wondering if I shouldn't avoid duplicate calls to `checkFacade()` in
the `getOutputStream()` and `getWriter()` methods!
iamjooon2 opened a new pull request, #652:
URL: https://github.com/apache/tomcat/pull/652
Hello!
i deleted needless brackets for consistency with the other code.
Thx :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
markt-asf commented on PR #654:
URL: https://github.com/apache/tomcat/pull/654#issuecomment-1706766432
Nice catch. Tx for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
xxeol2 opened a new pull request, #654:
URL: https://github.com/apache/tomcat/pull/654
This PR is closely related to https://github.com/apache/tomcat/pull/649.
Prevent double execution of the checkFacade() logic when invoking the
isCommitted() method.
thanks !!
--
This is an
iamjooon2 closed pull request #652: Remove unnecessary brackets
URL: https://github.com/apache/tomcat/pull/652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
woosung1223 commented on PR #653:
URL: https://github.com/apache/tomcat/pull/653#issuecomment-1706779668
> Those checks were added for performance reasons. They were significantly
quicker than calling checkSpecialHeader(). Unless a benchmark (as a unit test)
is provided that demonstrates
woosung1223 closed pull request #653: unnecessary work is done before
determining if it is a special header
URL: https://github.com/apache/tomcat/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
markt-asf commented on PR #654:
URL: https://github.com/apache/tomcat/pull/654#issuecomment-1706867922
Those refactorings look OK. Please submit another PR for those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
greeng00se commented on PR #656:
URL: https://github.com/apache/tomcat/pull/656#issuecomment-1706941221
I didn't think about when neither priority 1 nor 2 is present in pr, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
markt-asf commented on PR #652:
URL: https://github.com/apache/tomcat/pull/652#issuecomment-1706738930
We have started to get a lot of PRs removing single instances of unnecessary
parentheses. While we are generally in favour of this sort of clean-up, one PR
per instance is not scaleable
markt-asf merged PR #654:
URL: https://github.com/apache/tomcat/pull/654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
greeng00se closed pull request #656: Optimization when call
getSessionCookieName & getSessionUriParamName
URL: https://github.com/apache/tomcat/pull/656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
greeng00se commented on PR #656:
URL: https://github.com/apache/tomcat/pull/656#issuecomment-1707231871
sorry. Case 3 is not considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf commented on PR #660:
URL: https://github.com/apache/tomcat/pull/660#issuecomment-1707256734
Saving a single function call is unlikely to make any difference. I'd expect
the compiler to optimise that.
Changes that reduce duplication and/or improve the readability of the
Jaeyoung22 closed pull request #658: Unify conditional statement format for
some constants in http1 package
URL: https://github.com/apache/tomcat/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Jaeyoung22 opened a new pull request, #658:
URL: https://github.com/apache/tomcat/pull/658
Although I totally agree that there could be some unnecessary parentheses to
aid the readability of the code, I think that the unity of the code is still
important for readability.
###
greeng00se commented on PR #650:
URL: https://github.com/apache/tomcat/pull/650#issuecomment-1707230523
@markt-asf thx for merge my first contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
greeng00se opened a new pull request, #660:
URL: https://github.com/apache/tomcat/pull/660
### Description
Optimization when call getSessionCookieName & getSessionUriParamName
### Explanation
Existing code calls getConfiguredSessionCookieName even if the context is
greeng00se commented on PR #660:
URL: https://github.com/apache/tomcat/pull/660#issuecomment-1707265409
@markt-asf
Thanks for the nice comment.
I hadn't considered that partial compiler optimisation.
I agree, readable code should be a priority and I moved the null-check logic
to a
xxeol2 commented on code in PR #657:
URL: https://github.com/apache/tomcat/pull/657#discussion_r1316480032
##
java/org/apache/catalina/connector/ResponseFacade.java:
##
@@ -111,23 +111,19 @@ public String getCharacterEncoding() {
@Override
public ServletOutputStream
parkmuhyeun opened a new pull request, #659:
URL: https://github.com/apache/tomcat/pull/659
## Description
This PR made the following two modifications
- Unify constant delimiters
- Refactoring for better readability
## Explanation
### Unify constant delimiters
markt-asf commented on code in PR #657:
URL: https://github.com/apache/tomcat/pull/657#discussion_r1316282831
##
java/org/apache/catalina/connector/ResponseFacade.java:
##
@@ -111,23 +111,19 @@ public String getCharacterEncoding() {
@Override
public
markt-asf commented on code in PR #659:
URL: https://github.com/apache/tomcat/pull/659#discussion_r1316303250
##
java/org/apache/catalina/manager/StatusTransformer.java:
##
@@ -375,33 +375,33 @@ protected static void writeProcessorState(PrintWriter
writer,
switch
parkmuhyeun commented on PR #659:
URL: https://github.com/apache/tomcat/pull/659#issuecomment-1707218270
I reverted the stage constants back and modified the switch statements to
use the constants that were originally there!
--
This is an automated message from the Apache Git Service.
To
Jaeyoung22 closed pull request #658: Unify conditional statement format for
some constants in http1 package
URL: https://github.com/apache/tomcat/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Jaeyoung22 opened a new pull request, #661:
URL: https://github.com/apache/tomcat/pull/661
Although I totally agree that there could be some unnecessary parentheses to
aid the readability of the code, I think that the unity of the code is still
important for readability.
###
Jaeyoung22 commented on PR #658:
URL: https://github.com/apache/tomcat/pull/658#issuecomment-1707535138
This Pull Request UNINTENTIONALLY sended because of github incident :( So I
closed this PR and resend.
--
This is an automated message from the Apache Git Service.
To respond to the
parkmuhyeun commented on PR #659:
URL: https://github.com/apache/tomcat/pull/659#issuecomment-1707461772
Oh, sorry. I missed that one! I've fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
iamjooon2 closed pull request #652: Remove unnecessary brackets
URL: https://github.com/apache/tomcat/pull/652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
iamjooon2 commented on PR #652:
URL: https://github.com/apache/tomcat/pull/652#issuecomment-1707507180
@markt-asf I just saw [!This PR](https://github.com/apache/tomcat/pull/650)
and removed some brackets too
Regret for comment 'Automated tools'
--
This is an automated message
wonyongChoi05 opened a new pull request, #662:
URL: https://github.com/apache/tomcat/pull/662
Hello! Thank you for the PR. Upon reviewing these changes, I've noticed a
significant improvement in code readability. This enhanced readability stands
out and will make a substantial difference
markt-asf commented on code in PR #660:
URL: https://github.com/apache/tomcat/pull/660#discussion_r1317221552
##
java/org/apache/catalina/util/SessionConfig.java:
##
@@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) {
* @return the parameter
markt-asf merged PR #661:
URL: https://github.com/apache/tomcat/pull/661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #664:
URL: https://github.com/apache/tomcat/pull/664#issuecomment-1708352372
Included in #661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf closed pull request #664: Improved code readability
URL: https://github.com/apache/tomcat/pull/664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Jaeyoung22 commented on PR #661:
URL: https://github.com/apache/tomcat/pull/661#issuecomment-1708220046
I've taken note of what you've said.
## 1. remove unnecessary parentheses throughout the package
Personally, I find conditional statements with three or more conditions to
be
markt-asf merged PR #659:
URL: https://github.com/apache/tomcat/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on code in PR #661:
URL: https://github.com/apache/tomcat/pull/661#discussion_r1316875467
##
java/org/apache/coyote/http11/filters/ChunkedInputFilter.java:
##
@@ -574,7 +574,7 @@ private boolean parseHeader() throws IOException {
}
parkmuhyeun commented on PR #659:
URL: https://github.com/apache/tomcat/pull/659#issuecomment-1707887311
TransferENCODING wasn't mentioned, so I didn't recognize it. I reverted all
the stuff about constant names!
--
This is an automated message from the Apache Git Service.
To respond to
iamjooon2 commented on PR #652:
URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708163596
My mistake!
I rollbacked some codes.
I really appreciate for your comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
markt-asf commented on PR #660:
URL: https://github.com/apache/tomcat/pull/660#issuecomment-1708278473
Tx for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf merged PR #660:
URL: https://github.com/apache/tomcat/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ChrissW-R1 opened a new pull request, #665:
URL: https://github.com/apache/tomcat/pull/665
Solved issue with spaces in path.
If you install tomcat on windows in a path with spaces, the tool-wrapper.bat
could be executed. This PR adds two missing qoutes to solve this issue.
--
This
markt-asf commented on PR #659:
URL: https://github.com/apache/tomcat/pull/659#issuecomment-1708271503
Tx for the PR. I added a commit to remove an unnecessary line of code I
spotted while reviewing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the
markt-asf commented on code in PR #662:
URL: https://github.com/apache/tomcat/pull/662#discussion_r1317240076
##
java/org/apache/coyote/Request.java:
##
@@ -852,25 +854,17 @@ public boolean isProcessing() {
*
* @param contentType a content type header
*/
-
iamjooon2 commented on PR #652:
URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708308925
I rollbacked some codes.
I really appreciate for your comments.
Have a good Day
--
This is an automated message from the Apache Git Service.
To respond to the message, please
markt-asf commented on PR #661:
URL: https://github.com/apache/tomcat/pull/661#issuecomment-1708336648
Thanks for the PR. It is so much more efficient to review this sort of
change at this sort of scale.
Thanks for the De Morgan's law changes. I think those conditions are a lot
greeng00se commented on code in PR #660:
URL: https://github.com/apache/tomcat/pull/660#discussion_r1316896601
##
java/org/apache/catalina/util/SessionConfig.java:
##
@@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) {
* @return the parameter
greeng00se commented on code in PR #660:
URL: https://github.com/apache/tomcat/pull/660#discussion_r1316896601
##
java/org/apache/catalina/util/SessionConfig.java:
##
@@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) {
* @return the parameter
sosow0212 opened a new pull request, #664:
URL: https://github.com/apache/tomcat/pull/664
While seeing the code in the Coyote project, I came across this code
snippet:
`if (!(chr == Constants.SP || chr == Constants.HT))`.
It appears to be challenging to read, so I enhanced its
markt-asf commented on PR #664:
URL: https://github.com/apache/tomcat/pull/664#issuecomment-1707957682
See #661 - a single PR would be preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wonyongChoi05 commented on code in PR #662:
URL: https://github.com/apache/tomcat/pull/662#discussion_r1317009172
##
java/org/apache/coyote/Request.java:
##
@@ -853,24 +846,22 @@ public boolean isProcessing() {
* @param contentType a content type header
*/
iamjooon2 commented on PR #652:
URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708065150
HI @markt-asf
I read codes in apache/coyote
I found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
markt-asf merged PR #657:
URL: https://github.com/apache/tomcat/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apptie opened a new pull request, #663:
URL: https://github.com/apache/tomcat/pull/663
Hello!
While learning about Tomcat, I see something that I think I can contribute
to, so I write this PR.
## Explanation
There are two commits here:
- Remove the FQCN when
markt-asf commented on PR #661:
URL: https://github.com/apache/tomcat/pull/661#issuecomment-1707956244
See #663 - a single PR would be preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf commented on code in PR #660:
URL: https://github.com/apache/tomcat/pull/660#discussion_r1316890952
##
java/org/apache/catalina/util/SessionConfig.java:
##
@@ -49,38 +42,30 @@ public static String getSessionCookieName(Context context) {
* @return the parameter
markt-asf commented on code in PR #662:
URL: https://github.com/apache/tomcat/pull/662#discussion_r1316892872
##
java/org/apache/coyote/Request.java:
##
@@ -16,19 +16,8 @@
*/
package org.apache.coyote;
-import java.io.IOException;
-import
markt-asf commented on code in PR #663:
URL: https://github.com/apache/tomcat/pull/663#discussion_r1316972689
##
java/org/apache/catalina/startup/Tomcat.java:
##
@@ -1303,7 +1303,7 @@ public static void main(String[] args) throws Exception {
break;
iamjooon2 commented on PR #652:
URL: https://github.com/apache/tomcat/pull/652#issuecomment-1708120119
Hello from Korea @markt-asf
I unified all of conventions in package apache/coyote
1. unify conditional convention
e.g
```java
// from
if (type ==
markt-asf commented on code in PR #659:
URL: https://github.com/apache/tomcat/pull/659#discussion_r1316887097
##
java/org/apache/coyote/http11/Constants.java:
##
@@ -106,7 +106,7 @@ public final class Constants {
public static final String KEEP_ALIVE_HEADER_VALUE_TOKEN =
wonyongChoi05 opened a new pull request, #651:
URL: https://github.com/apache/tomcat/pull/651
Simplified the SSL certificate population logic by removing the unnecessary
null check and using an ArrayList for dynamic array management. The code is now
more concise and readable, and it
markt-asf commented on PR #650:
URL: https://github.com/apache/tomcat/pull/650#issuecomment-1706269180
The change is trivial but it makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
markt-asf merged PR #650:
URL: https://github.com/apache/tomcat/pull/650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on code in PR #648:
URL: https://github.com/apache/tomcat/pull/648#discussion_r1315332131
##
java/org/apache/catalina/connector/Request.java:
##
@@ -2288,12 +2288,7 @@ public String getServletPath() {
*/
@Override
public HttpSession
xxeol2 opened a new pull request, #649:
URL: https://github.com/apache/tomcat/pull/649
In the current implementation of the getSession method in the RequestFacade
class, the checkFacade logic was redundantly executed twice.
I improved this by eliminating the redundancy.
--
This is an
aooohan commented on PR #649:
URL: https://github.com/apache/tomcat/pull/649#issuecomment-1706095437
This change doesn't make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aooohan closed pull request #649: Eliminating duplicate execution of
checkFacade logic
URL: https://github.com/apache/tomcat/pull/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
aooohan closed pull request #650: Removed unnecessary brackets
URL: https://github.com/apache/tomcat/pull/650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
aooohan commented on PR #650:
URL: https://github.com/apache/tomcat/pull/650#issuecomment-1706094596
This change doesn't make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aooohan commented on PR #651:
URL: https://github.com/apache/tomcat/pull/651#issuecomment-1706113147
This change doesn't make any sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aooohan closed pull request #651: Refactor SSL certificate population method
URL: https://github.com/apache/tomcat/pull/651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf commented on PR #651:
URL: https://github.com/apache/tomcat/pull/651#issuecomment-1706340615
The switch to using a wildcard import would need to be reverted as would the
changes to blank lines between methods.
The null check is necessary in some form and it is more concise than
xxeol2 commented on code in PR #648:
URL: https://github.com/apache/tomcat/pull/648#discussion_r1315352368
##
java/org/apache/catalina/connector/Request.java:
##
@@ -2288,12 +2288,7 @@ public String getServletPath() {
*/
@Override
public HttpSession getSession()
aooohan merged PR #648:
URL: https://github.com/apache/tomcat/pull/648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on PR #648:
URL: https://github.com/apache/tomcat/pull/648#issuecomment-1706002731
Thanks for the PR. ; )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
greeng00se opened a new pull request, #650:
URL: https://github.com/apache/tomcat/pull/650
hello
I was looking at the code for the Request class in coyote.
Removed unnecessary brackets for consistency with the other code.
e.g. `contentLength = (clB == null ||
markt-asf merged PR #649:
URL: https://github.com/apache/tomcat/pull/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #649:
URL: https://github.com/apache/tomcat/pull/649#issuecomment-1706282024
The change makes sense to me. It removes a duplicate call to `checkFacade()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wonyongChoi05 commented on PR #651:
URL: https://github.com/apache/tomcat/pull/651#issuecomment-1706354873
> The switch to using a wildcard import would need to be reverted as would
the changes to blank lines between methods. The null check is necessary in some
form and it is more concise
rmaucher commented on PR #669:
URL: https://github.com/apache/tomcat/pull/669#issuecomment-1712763013
The ordering of these is often important. Please don't try to change this
for cosmetic reason since it needs time and expertise to review.
--
This is an automated message from the Apache
rmaucher closed pull request #669: Relocate the useCompression check and apply
parts back to back
URL: https://github.com/apache/tomcat/pull/669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aooohan merged PR #668:
URL: https://github.com/apache/tomcat/pull/668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on PR #668:
URL: https://github.com/apache/tomcat/pull/668#issuecomment-1713222910
> What LGTM means?
That means 'Looks Good To Me'.
> And is this doc the same that goes on the website or just a copy
integrated in the release? In case where to contribute to
aooohan commented on PR #668:
URL: https://github.com/apache/tomcat/pull/668#issuecomment-1713076196
Thanks for the PR. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
marcorobiati commented on PR #668:
URL: https://github.com/apache/tomcat/pull/668#issuecomment-1713209620
What LGTM means? And is this doc the same that goes on the website or just a
copy integrated in the release? In case where to contribute to the online doc?
--
This is an automated
aooohan merged PR #665:
URL: https://github.com/apache/tomcat/pull/665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on PR #665:
URL: https://github.com/apache/tomcat/pull/665#issuecomment-1713426562
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
anuragdy commented on PR #666:
URL: https://github.com/apache/tomcat/pull/666#issuecomment-1715600463
Benchmarks with JMH
JDK11
```
Benchmark Mode Cnt ScoreError Units
MyBenchmark.runNewTestthrpt5 20981286.747 ±
michael-o commented on code in PR #666:
URL: https://github.com/apache/tomcat/pull/666#discussion_r1318844150
##
java/javax/servlet/jsp/el/ImplicitObjectELResolver.java:
##
@@ -44,31 +44,32 @@
* @since JSP 2.1
*/
public class ImplicitObjectELResolver extends ELResolver {
+
anuragdy opened a new pull request, #666:
URL: https://github.com/apache/tomcat/pull/666
Fixes [67080](https://bz.apache.org/bugzilla/show_bug.cgi?id=67080).
Tested the speed using following Test Code -
```
package com.amazon.weblab;
import java.util.Arrays;
shin-mallang opened a new pull request, #669:
URL: https://github.com/apache/tomcat/pull/669
I think it can be confusing to read the code because there is a part that
checks for HTTP compression, and a part that applies the filter.
I've placed them back-to-back to improve readability.
anuragdy commented on code in PR #666:
URL: https://github.com/apache/tomcat/pull/666#discussion_r1319322612
##
java/javax/servlet/jsp/el/ImplicitObjectELResolver.java:
##
@@ -44,31 +44,32 @@
* @since JSP 2.1
*/
public class ImplicitObjectELResolver extends ELResolver {
+
1 - 100 of 1077 matches
Mail list logo
