Re: [DISCUSS] About the version number of TubeMQ

This is not related to legal issue, so no need to wait for SGA and ICLAs submission. We can continue the discussion. Thanks, Junping Goson zhang 于2020年1月9日周四 下午3:40写道： > Perhaps we can change them when we change the license after the submission > SGA and all ICLAs have been submitted. > >

Re: [DISCUSS] About the version number of TubeMQ

Perhaps we can change them when we change the license after the submission SGA and all ICLAs have been submitted. Saisai Shao 于2020年1月9日周四 下午3:28写道： > I see there're three open issues about about TubeMQ version number: > > 1. The version number is x.y-SNASHOT, typically it would be

[DISCUSS] About the version number of TubeMQ

I see there're three open issues about about TubeMQ version number: 1. The version number is x.y-SNASHOT, typically it would be x.y.z-SNAPHOST 2. For incubating project, it should have "incubating" suffix, x.y.z-incubating-SNAPSHOT. 3. There's no version number tracking for each JIRA. So I think

Re: [DISCUSS] standalone mode for debug tubemq code

+1. We should lower the adoption bar of TubeMQ in all possible ways. Thanks, Junping kaynewu 于2020年1月9日周四 上午11:07写道： > Hi developers, > There is no standalone mode to start tubemq and debug tubemq code > friendly, shall we develop a standalone way to achieve it? free to share > your opinion.

Re: [DISCUSS] Prefer rebase and merge for patch/pr

Thanks! Best, tison. Guangxu Cheng 于2020年1月9日周四 下午1:25写道： > Hi tison, > >I have created an infra JIRA, see: > >https://issues.apache.org/jira/browse/INFRA-19688 > > tison 于2020年1月9日周四 下午12:52写道： > > > @Guangxu, > > > > Sounds good. I think setting the configuration should be done by

Re: [DISCUSS] Prefer rebase and merge for patch/pr

Hi tison, I have created an infra JIRA, see: https://issues.apache.org/jira/browse/INFRA-19688 tison 于2020年1月9日周四 下午12:52写道： > @Guangxu, > > Sounds good. I think setting the configuration should be done by infra. > Will create an infra JIRA for it. > > Best, > tison. > > > Goson zhang

[GitHub] [incubator-tubemq] TisonKun commented on issue #6: [TUBEMQ-15] correct spelling

TisonKun commented on issue #6: [TUBEMQ-15] correct spelling URL: https://github.com/apache/incubator-tubemq/pull/6#issuecomment-572382380 Thanks for your contribution @Technoboy- ! This is an automated message from the

[GitHub] [incubator-tubemq] TisonKun merged pull request #6: [TUBEMQ-15] correct spelling

TisonKun merged pull request #6: [TUBEMQ-15] correct spelling URL: https://github.com/apache/incubator-tubemq/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #6: [TUBEMQ-15] correct spelling

Technoboy- opened a new pull request #6: [TUBEMQ-15] correct spelling URL: https://github.com/apache/incubator-tubemq/pull/6 https://issues.apache.org/jira/browse/TUBEMQ-15 This is an automated message from the Apache Git

[GitHub] [incubator-tubemq] TisonKun closed pull request #6: [TUBEMQ-15] correct spelling

TisonKun closed pull request #6: [TUBEMQ-15] correct spelling URL: https://github.com/apache/incubator-tubemq/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [DISCUSS] standalone mode for debug tubemq code

Hi, Good idea. Standalone mode will be more convenient for developers. +1 for the idea. kaynewu 于2020年1月9日周四 上午11:07写道： > Hi developers, > There is no standalone mode to start tubemq and debug tubemq code > friendly, shall we develop a standalone way to achieve it? free to share > your

Re: [DISCUSS] Prefer rebase and merge for patch/pr

+1 Guangxu Cheng 于2020年1月9日周四 上午11:12写道： > Hi tison, > > Nice discussion, these merge commits is noisy. > > IIRC GitHub supports disabling this button ("Create a merge commit"), So > it's a better choice to disable the button directly. > > WDYT? > > -- > Best Regards > Guangxu >

Re: [DISCUSS] Prefer rebase and merge for patch/pr

Hi tison, Nice discussion, these merge commits is noisy. IIRC GitHub supports disabling this button ("Create a merge commit"), So it's a better choice to disable the button directly. WDYT? -- Best Regards Guangxu

Re: [DISCUSS] Prefer rebase and merge for patch/pr

+1 tison 于2020年1月9日周四 上午10:39写道： > Hi developers, > > Recently I notice that the commit history contains a number of merge > commits. Per the discussion > of commit title commit IMO we prefer rebase (possibly squash) and merge > instead of merging with > a merge commit. > > If there is no

[DISCUSS] Prefer rebase and merge for patch/pr

Hi developers, Recently I notice that the commit history contains a number of merge commits. Per the discussion of commit title commit IMO we prefer rebase (possibly squash) and merge instead of merging with a merge commit. If there is no objection I'm going to document the standard on our wiki

[GitHub] [incubator-tubemq] kaynewu merged pull request #7: [TUBEMQ-14]: Some compilation errors

kaynewu merged pull request #7: [TUBEMQ-14]: Some compilation errors URL: https://github.com/apache/incubator-tubemq/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tubemq] kaynewu commented on issue #7: [TUBEMQ-14]: Some compilation errors

kaynewu commented on issue #7: [TUBEMQ-14]: Some compilation errors URL: https://github.com/apache/incubator-tubemq/pull/7#issuecomment-572352796 +1 for https://github.com/diffplug/spotless This is an automated message from

[GitHub] [incubator-tubemq] chenjunjiedada commented on issue #7: [TUBEMQ-14]: Some compilation errors

chenjunjiedada commented on issue #7: [TUBEMQ-14]: Some compilation errors URL: https://github.com/apache/incubator-tubemq/pull/7#issuecomment-572351751 Can we apply plugin to strip trailing space like this? How about https://github.com/diffplug/spotless. @gosonzhang, What do you think?

[GitHub] [incubator-tubemq] kaynewu opened a new pull request #7: TUBEMQ-14: Some compilation errors

kaynewu opened a new pull request #7: TUBEMQ-14: Some compilation errors URL: https://github.com/apache/incubator-tubemq/pull/7 Fixes Bug #<[TUBEMQ-14](https://issues.apache.org/jira/browse/TUBEMQ-14)> ### Motivation Bug fix, Syntax correct ### Modifications delete

[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #6: [TUBEMQ-15] correct spelling

Technoboy- opened a new pull request #6: [TUBEMQ-15] correct spelling URL: https://github.com/apache/incubator-tubemq/pull/6 https://issues.apache.org/jira/browse/TUBEMQ-15 This is an automated message from the Apache Git

Re: [Vote] Commit title format

+1 for option A and note that we might allow [hotfix] as a replacement of [TUBEMQ-XXX] for nit changes. Best, tison. kaynewu 于2020年1月9日周四 上午9:42写道： > +0, for all. No clear info about it's for bug fix or improvement or new > feature > > 俊平堵 于2020年1月8日 周三19:57写道： > > > +0 for all. No

Re: [Vote] Commit title format

+0, for all. No clear info about it's for bug fix or improvement or new feature 俊平堵 于2020年1月8日 周三19:57写道： > +0 for all. No preference. :) > > Thanks, > > Junping > > Yiheng Wang 于2020年1月8日周三 下午7:49写道： > > > Hi Community > > > > I would like to call a vote on standardizing the code commit title

Re: [Vote] Commit title format

+1 for option A On Wed, Jan 8, 2020 at 9:16 PM lamber liu wrote: > +1 for option A. > > On Wed, Jan 8, 2020 at 7:57 PM 俊平堵 wrote: > > > +0 for all. No preference. :) > > > > Thanks, > > > > Junping > > > > Yiheng Wang 于2020年1月8日周三 下午7:49写道： > > > > > Hi Community > > > > > > I would like to

[DISCUSS] Create a new repository for website?

Hi, Now the official website for Apache TubeMQ is under development. shall we create a new repository(incubator-tubemq-website.git) for official website? or use incubator-tubemq.git ? Other projects under ASF, such as livy,atlas,cassandra etc, created a new repository(xxx-website.git)

Re: [Vote] Commit title format

+1 for option A. On Wed, Jan 8, 2020 at 7:57 PM 俊平堵 wrote: > +0 for all. No preference. :) > > Thanks, > > Junping > > Yiheng Wang 于2020年1月8日周三 下午7:49写道： > > > Hi Community > > > > I would like to call a vote on standardizing the code commit title > format. > > > > Currently, the patch title

Re: [URGENT] Re: Project bootstrapping

I was a bit confused here and had the same question before. But given most of legal process from Tencent side has been done (in final review), I think the risk here is relatively low. Next time, let's pay more attention to it. Thanks, Junping Justin Mclean 于2020年1月8日周三 下午8:23写道： > Hi, > > >

Re: [URGENT] Re: Project bootstrapping

Hi, > I'm really sorry for the delay of the SGA. > > The legal affairs department of the company is still reviewing the SGA, > I've pushed them to review the SGA as soon as possible. But it seem the code has been transferred to the ASF repos before this is done and before the ICLAs have been

Re: Project bootstrapping(Internet mail)

Hi, > The development is still undergoing on my personal repo, What is the public URL of this repo? The development of the web site should be a collaborative effort, it needs to be in the open where anyone can contribute. It needs to be done on ASF infrastructure. A suggestion: The best

答复: [Vote] Commit title format(Internet mail)

+1 option A -邮件原件- 发件人: Yiheng Wang 发送时间: 2020年1月8日 19:49 收件人: dev@tubemq.apache.org 抄送: 奕恒 王 主题: [Vote] Commit title format(Internet mail) Hi Community I would like to call a vote on standardizing the code commit title format. Currently, the patch title format is a little casual.

Re: Project bootstrapping(Internet mail)

Hi Justin， The development is still undergoing on my personal repo, I volunteer already in dev list and jira. Will get public reviewed once get finished. Thanks， Zak > 在 2020年1月4日，上午4:28，Justin Mclean 写道： > > Hi, > >>> - Moving the repos over to ASF infrastructure >> >> Done > > This

[GitHub] [incubator-tubemq] kaynewu opened a new pull request #5: TUBEMQ-14: Some compilation errors

kaynewu opened a new pull request #5: TUBEMQ-14: Some compilation errors URL: https://github.com/apache/incubator-tubemq/pull/5 Fixes Bug #<[TUBEMQ-14](https://issues.apache.org/jira/browse/TUBEMQ-14)> ### Motivation Bug fix, Syntax correct ### Modifications

[Vote] Commit title format

Hi Community I would like to call a vote on standardizing the code commit title format. Currently, the patch title format is a little casual. This is not good for project maintenance and development. I propose several options for code commit title format. Option A: [TUBEMQ-XXX][optional

Re: [URGENT] Re: Project bootstrapping

FYI TUBEMQ-5: https://jira.apache.org/jira/browse/TUBEMQ-5 Best, tison. tison 于2020年1月8日周三 下午7:39写道： > > > Justin Mclean 于2020年1月8日周三 下午7:35写道： > >> Hi, >> >> > >> - Moving the repos over to ASF infrastructure >> > > Done >> > This cannot be done until the SGA has been signed. >> >> Again

[GitHub] [incubator-tubemq] TisonKun commented on issue #4: TUBEMQ-10 javadoc error

TisonKun commented on issue #4: TUBEMQ-10 javadoc error URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571976371 FYI https://lists.apache.org/x/thread.html/rb478cc59ca720d1ca9a6c1a2616108383fc7735a770284afe56d508b@%3Cdev.tubemq.apache.org%3E cc @yiheng

[GitHub] [incubator-tubemq] TisonKun commented on issue #4: TUBEMQ-10 javadoc error

TisonKun commented on issue #4: TUBEMQ-10 javadoc error URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571976067 Hi @chenjunjiedada , please prefer "Squash And Merge" which doesn't produce a redundant merge commit. We are discussing on dev mailing list about how

Re: Change TubeMQ's License to use Apache License V2 and enable RAT check

Hi Goson, if you want to start a discussion, the subject of the email should start with [DISCUSS]. Goson zhang 于2020年1月8日周三 下午5:35写道： > @Saisai Shao, this change will modify all the files, so I think it would be > a better way to ask everyone's opinions in the email and then mention a > JIRA. >

[GitHub] [incubator-tubemq] chenjunjiedada merged pull request #4: TUBEMQ-10 javadoc error

chenjunjiedada merged pull request #4: TUBEMQ-10 javadoc error URL: https://github.com/apache/incubator-tubemq/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tubemq] kaynewu merged pull request #3: optimization for delete unnecessary code

kaynewu merged pull request #3: optimization for delete unnecessary code URL: https://github.com/apache/incubator-tubemq/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tubemq] chenjunjiedada removed a comment on issue #4: TUBEMQ-10 javadoc error

chenjunjiedada removed a comment on issue #4: TUBEMQ-10 javadoc error URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571962690 LGTM This is an automated message from the Apache Git Service. To respond to

Re: Change TubeMQ's License to use Apache License V2 and enable RAT check

@Saisai Shao, this change will modify all the files, so I think it would be a better way to ask everyone's opinions in the email and then mention a JIRA. tison 于2020年1月8日周三 下午5:23写道： > +1 a JIRA is the proper way. > > Best, > tison. > > > Saisai Shao 于2020年1月8日周三 下午5:20写道： > > > Hi Goson, why

[GitHub] [incubator-tubemq] chenjunjiedada commented on issue #3: optimization for delete unnecessary code

chenjunjiedada commented on issue #3: optimization for delete unnecessary code URL: https://github.com/apache/incubator-tubemq/pull/3#issuecomment-571963192 LGTM +1 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tubemq] chenjunjiedada commented on issue #4: TUBEMQ-10 javadoc error

chenjunjiedada commented on issue #4: TUBEMQ-10 javadoc error URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571962690 LGTM This is an automated message from the Apache Git Service. To respond to the

Re: Change TubeMQ's License to use Apache License V2 and enable RAT check

+1 a JIRA is the proper way. Best, tison. Saisai Shao 于2020年1月8日周三 下午5:20写道： > Hi Goson, why don't you create a JIRA to track this issue? > > 俊平堵 于2020年1月8日周三 下午5:17写道： > > > +1. I think we *must* use standard Apache license given this is an apache > > project. > > Would like to hear other

Re: Change TubeMQ's License to use Apache License V2 and enable RAT check

Hi Goson, why don't you create a JIRA to track this issue? 俊平堵 于2020年1月8日周三 下午5:17写道： > +1. I think we *must* use standard Apache license given this is an apache > project. > Would like to hear other mentors' opinion here as well. > > Thanks, > > Junping > > Goson zhang 于2020年1月8日周三 下午5:14写道：

Change TubeMQ's License to use Apache License V2 and enable RAT check

Hi community I've noticed that the License in code files need modify, for example : /* * * Tencent is pleased to support the open source community by making TubeMQ available. * * Copyright (C) 2012-2019 Tencent. All Rights Reserved.* * * Licensed under the Apache License, Version 2.0 (the

Re: The website for Apache TubeMQ(Internet mail)

Hi bebe, Here is the thread that you can share the POC of TubeMQ website & continue discussion. Best, tison. zakwu(巫枫) 于2020年1月8日周三 下午2:57写道： > Hi Tison， > ok，I will share the POC on mailing list later > > Thank， > Zakwu > > > 在 2020年1月8日，下午2:49，tison 写道： > > > > Hi Zak, > > > > Is it

[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #4: TUBEMQ-10 javadoc error

Technoboy- opened a new pull request #4: TUBEMQ-10 javadoc error URL: https://github.com/apache/incubator-tubemq/pull/4 https://issues.apache.org/jira/browse/TUBEMQ-10 This is an automated message from the Apache Git Service.