Re: Replacing div/ with div/div

2007-11-02 Thread Philip A. Chapman
I agree with this stance. On Fri, 2007-11-02 at 09:19 -0600, John Ray wrote: I got bit by this problem yesterday. Although I was just previewing the page in the browser by loading the HTML file directly. Since Wicket wasn't running it wouldn't have mattered if it fixed my div tag for me or

Re: svn commit: r591368 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/n avigation/paging/IPageable.java

2007-11-02 Thread Martin Grigorov
Let it be IClusterable. please. On Fri, 2 Nov 2007, [EMAIL PROTECTED] wrote: Author: ivaynberg Date: Fri Nov 2 08:37:31 2007 New Revision: 591368 URL: http://svn.apache.org/viewvc?rev=591368view=rev Log: make ipageable serializable because we keep direct references to it Modified:

Wicket User Group Stockholm on Monday!

2007-11-02 Thread Björn Fant
Hi, anyone of you Swedish wicket developers interested in getting together on Monday for an evening session? http://wicket.jalbum.net/ We are having our first meeting on Monday November 5 where we will discuss Wicket and our applications. Per Ejeklint will present his latest project, using

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
Okay. Again. This is not about developer making error! Code like this: div/ Something Is perfectly legal. However, firefox interprets it as div Something ... Which is completely wrong. This is not correcting developer error! This is correcting browser error. And such thing is very

Re: Replacing div/ with div/div

2007-11-02 Thread Erik van Oosten
It does not matter who is making the error, John is still right imho. Regards, Erik. Matej Knopp wrote: Okay. Again. This is not about developer making error! Code like this: div/ Something Is perfectly legal. However, firefox interprets it as div Something ... Which is

Re: Replacing div/ with div/div

2007-11-02 Thread Juergen Donnerstag
A Html error finder (IMarkupFilter) already exists but is disabled by default. We could extend it or create a new one. Actually anybody can create it and provide it to us. Juergen

Re: Replacing div/ with div/div

2007-11-02 Thread Philip A. Chapman
Agreed. I understood from previous threads that it was not a developer error, but a firefox error. If we start going down this path, it is likely to get slippery indeed. I'd rather not see wicket modify markup any more than absolutely required. Are we going to fix code that breaks on all

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
But we already do that. Part of Wicket as framework is to shield you from browser inconsistencies and this is one of them. -Matej On 11/2/07, Philip A. Chapman [EMAIL PROTECTED] wrote: Agreed. I understood from previous threads that it was not a developer error, but a firefox error. If we

Re: Replacing div/ with div/div

2007-11-02 Thread Martijn Dashorst
-0.9 on 'fixing' something that is b0rken in an external browser. I don't mind having fixes in javascript libraries to wrinkle out inconsistencies or work around bugs: these are local to the functionality in the js libraries. 'Fixing' HTML feels like fixing Java code for our users. If for some

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
See reply below On 11/2/07, Martijn Dashorst [EMAIL PROTECTED] wrote: -0.9 on 'fixing' something that is b0rken in an external browser. I don't mind having fixes in javascript libraries to wrinkle out inconsistencies or work around bugs: these are local to the functionality in the js

Re: Replacing div/ with div/div

2007-11-02 Thread Igor Vaynberg
i am +1 to fix this. a) we already support span wicket:id=label/ which expands to span/span - give that is a wicket component, but still b) tag/ and tag/tag are semantically equivalent and thats how browsers represent tags internally anyways c) it solves a class of problems that is hard as hell

Re: Replacing div/ with div/div

2007-11-02 Thread Martijn Dashorst
From the firefox bugzilla [1]: Resolving INVALID. To cut a long story short, remember that if you're serving this kind of markup as text/html, it will be accepted by older user-agents and probably throw a monkey wrench into their parsing. If you don't care about these user-agents, you should

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
How is this relevant? You can't serve anything as text/xml or application/xml, unless you treat ie specially. I never said It's a bug in firefox, I now the behavior is intentional. But it doesn't matter for wicket, as we require that the markup is well formed (to a certain degree, e.g. not closed

Re: Replacing div/ with div/div

2007-11-02 Thread Igor Vaynberg
umm, so? that stuff is legal under xhtml which is what most apps are built with now, correct? -igor On 11/2/07, Martijn Dashorst [EMAIL PROTECTED] wrote: From the firefox bugzilla [1]: Resolving INVALID. To cut a long story short, remember that if you're serving this kind of markup as

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
See reply below: On 11/3/07, Martijn Dashorst [EMAIL PROTECTED] wrote: I think this change is controversial: several people have voiced their concerns regarding this change. It is something we have been opposed to until very recently (label with span/). You propose to change markup that is

passed the 600 unit tests....!!

2007-11-02 Thread Johan Compagner
700 here we come! johan