Hi Martin,
I am aware of that uglyness but I could not figure out a clean way to get
around it.
When fixing WICKET-3048 I needed a way to detect if the current request is of
type 'ajax'.
However the ctor from ServletWebResponse is
public ServletWebResponse(HttpServletRequest
Please review r998677.
I implemented the logic we discussed in IRC with you before your change.
On Mon, Sep 20, 2010 at 10:24 AM, Peter Ertl pe...@gmx.org wrote:
Hi Martin,
I am aware of that uglyness but I could not figure out a clean way to get
around it.
When fixing WICKET-3048 I needed
I don't know if the cast to (ServletWebRequest) in webapplicat...@383 is safe?
return new HeaderBufferingWebResponse(new
ServletWebResponse((ServletWebRequest)webRequest,
If it is safe then why not change
protected WebResponse newWebResponse(final WebRequest webRequest,
These are just the default implementations of these two methods.
If you change #newWebRequest() to return something else, e.g.
PortletWebRequest, then you will have to override #newWebResponse() as well
(e.g PortletWebResponse).
Until this change ServletWebResponse was working directly with
Am 20.09.2010 um 13:03 schrieb Martin Grigorov:
I chose WebResponse as type because this is in *Web*Application.
Isn't it even a ServletWebApplication ? :-)
There is a 'Will it play in app engine' page that tracks libraries that are
compatible with Google App Engine (aka GAE):
http://groups.google.com/group/google-appengine-java/web/will-it-play-in-app-engine?pli=1
Correctly, Wicket is listed as Semi-Compatible.
As a project I've been looking
Why not prefix all issue titles with something like
[GAE] problem description
?
This should be easy to filter or lookup
Am 20.09.2010 um 14:43 schrieb Clint Checketts:
There is a 'Will it play in app engine' page that tracks libraries that are
compatible with Google App Engine (aka GAE):
Sure I could take whichever approach the core team prefers. A bonus of
having a master issue is once it gets resolved that the release notes will
specifically mark that it is compatible with GAE.
On Mon, Sep 20, 2010 at 7:52 AM, Peter Ertl pe...@gmx.org wrote:
Why not prefix all issue titles
Jira supports tags right?
On Sep 20, 2010 8:55 AM, Clint Checketts checke...@gmail.com wrote:
Sure I could take whichever approach the core team prefers. A bonus of
having a master issue is once it gets resolved that the release notes will
specifically mark that it is compatible with GAE.
On
I think Wicket is listed as semi-compatible because it requires some
customization (override some methods, change some configuration) to make it
work, not because its internals are inherently incompatible to GAE, or
because it has some incompatible visual components.
Such customization are simply
...and those shouldn't change, since the defaults shoud target...
...I think nothing one could do would change the classification from
semi-compatible to compatible...
Sure you can, the defaults could change automatically by detecting that
GAE is the container.
Regards,
Erik.
Op
An auto-detected GAE-specific mode in Wicket core? I don't think this is a
good idea...
On Mon, Sep 20, 2010 at 3:07 PM, Erik van Oosten e.vanoos...@grons.nlwrote:
...and those shouldn't change, since the defaults shoud target...
...I think nothing one could do would change the
On Mon, Sep 20, 2010 at 1:18 PM, tetsuo ronald.tet...@gmail.com wrote:
An auto-detected GAE-specific mode in Wicket core? I don't think this is a
good idea...
I agree that this shouldn't go in core, but I think if someone like Clint
has the motivation to do so, I'd love to see a project that
13 matches
Mail list logo
