Re: Replacing div/ with div/div

2007-11-05 Thread Robert .
On 11/5/07, Matej Knopp [EMAIL PROTECTED] wrote: Okay, I might have overlooked the *or* part with implicates that empty element shorthand should not be used for non-empty elements. Still this leaves us with 3 options. a) ignore things silently and then support lot of weird bugreport of user

Re: Replacing div/ with div/div

2007-11-04 Thread Robert
Matej Knopp wrote: Hi, I noticed that if you add empty div / tags to firefox, it treats it like if you forgot to close it. There seem to be some misconceptions about what div / means in this thread. It is true that in XML div/div and div/ are equivalent. However XHTML (at least 1.0) has

Re: Replacing div/ with div/div

2007-11-03 Thread Erik van Oosten
Matej Knopp wrote: I haven't heard a single argument against replacing div/ with div/div except people being anxious of wicket touching the markup. The best real argument I know is that I want the HLTM to be viewable without Wicket. Of course it is fine to have Wicket provide optional

Re: Replacing div/ with div/div

2007-11-03 Thread Matej Knopp
On 11/3/07, Erik van Oosten [EMAIL PROTECTED] wrote: Matej Knopp wrote: I haven't heard a single argument against replacing div/ with div/div except people being anxious of wicket touching the markup. The best real argument I know is that I want the HLTM to be viewable without Wicket. I

Re: Replacing div/ with div/div

2007-11-03 Thread Al Maw
Matej Knopp wrote: Fixing this has practical benefits. And I haven't heard one argument against it except that wicket shouldn't do that because it's html. I have personally problems with such arguments. It just feels not pragmatic. We have three options here: 1. Fix the issue transparently

Re: Replacing div/ with div/div

2007-11-03 Thread Martijn Dashorst
Though I'm not pro on this change, I suggest putting it in before rc1. Martijn On 11/3/07, Al Maw [EMAIL PROTECTED] wrote: Matej Knopp wrote: Fixing this has practical benefits. And I haven't heard one argument against it except that wicket shouldn't do that because it's html. I have

Re: Replacing div/ with div/div

2007-11-03 Thread Eelco Hillenius
On 11/3/07, Eelco Hillenius [EMAIL PROTECTED] wrote: On 11/3/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Though I'm not pro on this change, I suggest putting it in before rc1. Why aren't you pro? Because you don't agree with the idea, or because it is too late in the game? Ugh, nevermind.

Re: Replacing div/ with div/div

2007-11-03 Thread Eelco Hillenius
On 11/3/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Though I'm not pro on this change, I suggest putting it in before rc1. Why aren't you pro? Because you don't agree with the idea, or because it is too late in the game? Eelco

Re: Replacing div/ with div/div

2007-11-03 Thread Matej Knopp
Done. -Matej On 11/3/07, Eelco Hillenius [EMAIL PROTECTED] wrote: On 11/3/07, Eelco Hillenius [EMAIL PROTECTED] wrote: On 11/3/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Though I'm not pro on this change, I suggest putting it in before rc1. Why aren't you pro? Because you don't

Re: Replacing div/ with div/div

2007-11-02 Thread Philip A. Chapman
I agree with this stance. On Fri, 2007-11-02 at 09:19 -0600, John Ray wrote: I got bit by this problem yesterday. Although I was just previewing the page in the browser by loading the HTML file directly. Since Wicket wasn't running it wouldn't have mattered if it fixed my div tag for me or

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
Okay. Again. This is not about developer making error! Code like this: div/ Something Is perfectly legal. However, firefox interprets it as div Something ... Which is completely wrong. This is not correcting developer error! This is correcting browser error. And such thing is very

Re: Replacing div/ with div/div

2007-11-02 Thread Erik van Oosten
It does not matter who is making the error, John is still right imho. Regards, Erik. Matej Knopp wrote: Okay. Again. This is not about developer making error! Code like this: div/ Something Is perfectly legal. However, firefox interprets it as div Something ... Which is

Re: Replacing div/ with div/div

2007-11-02 Thread Juergen Donnerstag
A Html error finder (IMarkupFilter) already exists but is disabled by default. We could extend it or create a new one. Actually anybody can create it and provide it to us. Juergen

Re: Replacing div/ with div/div

2007-11-02 Thread Philip A. Chapman
Agreed. I understood from previous threads that it was not a developer error, but a firefox error. If we start going down this path, it is likely to get slippery indeed. I'd rather not see wicket modify markup any more than absolutely required. Are we going to fix code that breaks on all

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
But we already do that. Part of Wicket as framework is to shield you from browser inconsistencies and this is one of them. -Matej On 11/2/07, Philip A. Chapman [EMAIL PROTECTED] wrote: Agreed. I understood from previous threads that it was not a developer error, but a firefox error. If we

Re: Replacing div/ with div/div

2007-11-02 Thread Martijn Dashorst
: This doesn't really lead anywhere. I haven't heard a single argument against replacing div/ with div/div except people being anxious of wicket touching the markup. But you should realize that without this, you can't even put div/ inside markup because it breaks the DOM in firefox. So what's

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
of valid markup is not user's fault. -Matej Martijn On 11/2/07, Matej Knopp [EMAIL PROTECTED] wrote: This doesn't really lead anywhere. I haven't heard a single argument against replacing div/ with div/div except people being anxious of wicket touching the markup. But you should realize

Re: Replacing div/ with div/div

2007-11-02 Thread Igor Vaynberg
to take this? Are we going to include spell checkers that automatically 'correct' misspelled words? Martijn On 11/2/07, Matej Knopp [EMAIL PROTECTED] wrote: This doesn't really lead anywhere. I haven't heard a single argument against replacing div/ with div/div except people being anxious

Re: Replacing div/ with div/div

2007-11-02 Thread Martijn Dashorst
argument against replacing div/ with div/div except people being anxious of wicket touching the markup. But you should realize that without this, you can't even put div/ inside markup because it breaks the DOM in firefox. So what's the point? I really don't think that I don't want

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
to include spell checkers that automatically 'correct' misspelled words? Martijn On 11/2/07, Matej Knopp [EMAIL PROTECTED] wrote: This doesn't really lead anywhere. I haven't heard a single argument against replacing div/ with div/div except people being anxious

Re: Replacing div/ with div/div

2007-11-02 Thread Igor Vaynberg
spell checkers that automatically 'correct' misspelled words? Martijn On 11/2/07, Matej Knopp [EMAIL PROTECTED] wrote: This doesn't really lead anywhere. I haven't heard a single argument against replacing div/ with div/div except people being anxious of wicket touching

Re: Replacing div/ with div/div

2007-11-02 Thread Matej Knopp
See reply below: On 11/3/07, Martijn Dashorst [EMAIL PROTECTED] wrote: I think this change is controversial: several people have voiced their concerns regarding this change. It is something we have been opposed to until very recently (label with span/). You propose to change markup that is

Re: Replacing div/ with div/div

2007-11-01 Thread Johan Compagner
until now we have the policy that we don't alter the markup. But we could expand all of them if needed. I don't mind to much On 11/1/07, Matej Knopp [EMAIL PROTECTED] wrote: Actually, I think that we might want to do this for all tags except for couple of selected ones, e.g. hr / This would

Re: Replacing div/ with div/div

2007-11-01 Thread Matej Knopp
That's not entirely true. E.g. we generate unique ids for script elements, that is altering markup (this is necessary for header contribution filtering). I don't think it would harm to expend those tags. -Matej On 11/1/07, Johan Compagner [EMAIL PROTECTED] wrote: until now we have the policy

Re: Replacing div/ with div/div

2007-11-01 Thread Matej Knopp
It is semanticaly the same. And Firefox really treats div/ etc. wrong way. Should we have a vote on this? -Matej On 11/1/07, Johan Compagner [EMAIL PROTECTED] wrote: yeah we are generating extra attributes but do we introduce tags itself ? On 11/1/07, Matej Knopp [EMAIL PROTECTED] wrote:

Re: Replacing div/ with div/div

2007-11-01 Thread Johan Compagner
yeah we are generating extra attributes but do we introduce tags itself ? On 11/1/07, Matej Knopp [EMAIL PROTECTED] wrote: That's not entirely true. E.g. we generate unique ids for script elements, that is altering markup (this is necessary for header contribution filtering). I don't think

Re: Replacing div/ with div/div

2007-11-01 Thread Gwyn Evans
It seems to me that while it's something that Wicket /could/ do, I'm not sure if it's something that Wicket /should/ do... Having said that, I think I'd be less against it if we restricted it to only tags that had a wicket:id attribute? /Gwyn Thursday, November 1, 2007, 2:18:34 PM, you wrote:

Re: Replacing div/ with div/div

2007-11-01 Thread Igor Vaynberg
On 11/1/07, Matej Knopp [EMAIL PROTECTED] wrote: This would also reduce confusion of new user when they do span wicket:id=label'/ have you tried that with the latest betas? :) -igor