[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2704 check jobs in Jenkins. try to merge the latest changes from master. ---

[GitHub] zeppelin issue #2706: ZEPPELIN-3105 Notebook not running via REST API after ...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2706 @weand CI still fails, but very probably it is flaky test, but could you retrigger the CI ? I'd like make sure these failed test is not caused by this PR before merging. ---

[GitHub] zeppelin issue #2705: ZEPPELIN-3106. User impersonation in SPARK is not work...

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2705 Will try this for both spark and shell interpreter, and post my finding later today. ---

[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2707 I see, Thanks. LGTM ---

[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2707 This is generated by npm v5 and it would not be changed until we change dependencies. If it doesn't exist, npm creates it again when it runs scripts. So adding it helps to reduce whole

Re: [DISCUSS] Review process

Agree with @Felix, especially for the large PR and PR of new features it is still necessary to have more than +1. I think committer have the ability to identity whether this PR is complicated enough that needs another committer's review. As long we as have consensus, we could commit some PR

[GitHub] zeppelin pull request #1323: [HOTFIX] Add logins authentication for hdfs fil...

Github user rawkintrevo closed the pull request at: https://github.com/apache/zeppelin/pull/1323 ---

[GitHub] zeppelin issue #1323: [HOTFIX] Add logins authentication for hdfs file inter...

Github user rawkintrevo commented on the issue: https://github.com/apache/zeppelin/pull/1323 closing this- lol at "hotfix" ---

[GitHub] zeppelin pull request #2708: [Zeppelin-3095] Fix UI when all paragraphs exec...

GitHub user tinkoff-dwh opened a pull request: https://github.com/apache/zeppelin/pull/2708 [Zeppelin-3095] Fix UI when all paragraphs executing sequentially ### What is this PR for? This PR fixes the incorrect behavior of UI during the execution of the RunAllParagraphs.

[GitHub] zeppelin issue #2701: [ZEPPELIN-3098] Livy Interpreter fails if row contains...

Github user bushnoh commented on the issue: https://github.com/apache/zeppelin/pull/2701 @zjffdu I was trying to show that the tests failing in master (that don't include my changes) are the same ones with the same errors that are failing on my branch with the changes ---

Re: [DISCUSS] Review process

I think it is still useful to have a time delay after one approve since often time there are very feedback and updates after one committer approval. Also github has a tab for all PRs you are subscribed to, it shouldn’t be very hard to review all the approved ones again.

Re: [DISCUSS] Review process

Good for summary. But actually, no committer merges without delay after reviewing it. So I thought we should clarify it officially. Now, some committers, including me, will be able to merge some PRs without delay and burden. On Mon, 18 Dec 2017 at 11:27 PM moon soo Lee wrote:

[GitHub] zeppelin issue #2698: [ZEPPELIN-3007] display a note name without any path i...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2698 @tinkoff-dwh Looks good to me! Merge to master if no further comment. ---

[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...

Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2687 Thanks @kjmrknsn. Merge to master if no further review! ---

Re: [DISCUSS] Review process

Hi, Current review process[1] does require either at least a +1 from committer or 24 hours for lazy consensus. Pullrequest can be open for 1 or 2 days for additional review, but i think they're not hard requirements. (e.g. Hotfixes are already being merged without waiting additional review) So,

[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2707 I was tested. Looks good :) Lgtm ---

[jira] [Created] (ZEPPELIN-3110) JDBCInterpreter, Metadata from getConnection is not getting cached, getDataModelMetadataCompletions gets invoked for every sql query

Srikanth G N created ZEPPELIN-3110: -- Summary: JDBCInterpreter, Metadata from getConnection is not getting cached, getDataModelMetadataCompletions gets invoked for every sql query Key: ZEPPELIN-3110 URL:

[GitHub] zeppelin pull request #2707: [ZEPPELIN-3100] Upgrade node and npm version

GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/2707 [ZEPPELIN-3100] Upgrade node and npm version ### What is this PR for? Reducing total build time ### What type of PR is it? [Improvement] ### Todos * [x] -

[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2707 @1ambda Can you review it? It's kind of your idea :-) ---

[GitHub] zeppelin issue #2705: ZEPPELIN-3106. User impersonation in SPARK is not work...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2705 @prabhjyotsingh Could you help review it ? Thanks ---

[GitHub] zeppelin issue #2704: ZEPPELIN-3061: Updated the SecurityUtils to add Shiro'...

Github user jithinchandranj commented on the issue: https://github.com/apache/zeppelin/pull/2704 Hi @tinkoff-dwh , Attached test case for the custom realm functionality. ---

RE: [DISCUSS] Review process

+1 for non-delay merging. Our team have opened approved PR [1] for 5 days. I didn't find any pages with `consensus how to review and merge contributions`. It would be nice to write a check list for reviewer. The development of Zeppelin is very important for us and we want to review new commits.

[GitHub] zeppelin issue #2700: [ZEPPELIN-3092] GitHub Integration

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2700 Can you restart some failed job on https://travis-ci.org/mohamagdy/zeppelin/builds/317797015 ? ---

Re: [DISCUSS] Review process

Thank you for the replying it. I think so On Mon, Dec 18, 2017 at 3:15 PM, Miquel Angel Andreu Febrer < miquelangeland...@gmail.com> wrote: > I agree, ig is necessary to have no delay afternoon merging. I think it > will help speed up processes and help contributors > > El 18 dic. 2017 4:33,