[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @weand Thank you! Some addition to 2. Over time user may not belong to group. At first we could store cronExecutingRoles and in future it's to be good to check groups on the fly.

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2905 @jongyoul I tried this PR and download the pig interpreter, and found several issues. 1. The helium.json still use plugin of 0.7.2, but my zeppelin server is on 0.9 (master). Zeppelin should

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2905 @zjffdu Can you check it again? ---

[jira] [Created] (ZEPPELIN-3422) Add JMX support

Jongyoul Lee created ZEPPELIN-3422: -- Summary: Add JMX support Key: ZEPPELIN-3422 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3422 Project: Zeppelin Issue Type: New Feature

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2903 looks good! merging if no more comment ---

[jira] [Created] (ZEPPELIN-3421) Skip running unit test when hitting failed test.

Jeff Zhang created ZEPPELIN-3421: Summary: Skip running unit test when hitting failed test. Key: ZEPPELIN-3421 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3421 Project: Zeppelin

Re: [DISCUSS] Adjust test logs for CI

I like this idea!! On Mon, Apr 23, 2018 at 12:14 PM, Jeff Zhang wrote: > Another thing we can do is to skip the remaining test when we hit test > failure. Currently, zeppelin wont't stop run testing code even hit failed > test. > >

[GitHub] zeppelin pull request #2934: [ZEPPELIN-3417] fix dependency in zeppelin-web/...

Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2934 ---

[GitHub] zeppelin issue #2936: MINOR Remove tracing logs when testing

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2936 Will merge it without any issues ---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2937 It is just used in 2 places, synchronized should be fine. ReadWriteLock is more suitable for the scenario of many reads & a few write ---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2937 It is just used in 2 places, synchronized should be fine. ReadWriteLock is more suitable for the scenario of many reads & a few write ---

[GitHub] zeppelin pull request #:

Github user prabhjyotsingh commented on the pull request: https://github.com/apache/zeppelin/commit/f4a798b6230b4f2389ad7ea9b41818b15d9ab5a7#commitcomment-28690929 @bern80 do you mind creating an issue for the same if it is not working? will try to look into it. ---

[GitHub] zeppelin issue #2936: MINOR Remove tracing logs when testing

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2936 Test passed. https://travis-ci.org/jongyoul/zeppelin/builds/369747157 ---

[GitHub] zeppelin pull request #2923: ZEPPELIN-3312 Add option to convert username to...

Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2923 ---

[GitHub] zeppelin pull request #2932: [ZEPPELIN-3415] Fix export notebook functionali...

Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2932 ---

[GitHub] zeppelin issue #2933: [ZEPPELIN-3416] Bump up the version of xercesImpl to 2...

Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2933 Merging this if no more discussion. ---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2937 IMHO, it would be better to use [ReentrantReadWriteLock](https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/ReentrantReadWriteLock.html). What do you think of it? ---

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2935 

Re: [DISCUSS] Adjust test logs for CI

Another thing we can do is to skip the remaining test when we hit test failure. Currently, zeppelin wont't stop run testing code even hit failed test. http://maven.apache.org/surefire/maven-surefire-plugin/examples/skip-after-failure.html Jeff Zhang 于2018年4月23日周一 上午11:00写道： >

Re: [DISCUSS] Adjust test logs for CI

Regarding selenium test, I agree with you that the log in selenium is almost useless. It is hard to figure out what's wrong when selenium test fails. Maybe other frontend expert can help on that. Jongyoul Lee 于2018年4月23日周一 上午10:55写道： > @felix, > We can enforce to set

Re: [DISCUSS] Adjust test logs for CI

@felix, We can enforce to set different log level like ERROR or WARN but I don't think it's a proper solution. @Jeff, I found current master might have a problem with Integration test of using Selenium but It's hard to see all logs from that tests because there are so many unrelated logs like

Re: [DISCUSS] Adjust test logs for CI

Jongyoul, What kind of problem do you have ? Each module has log4j.properties under its test folder that we can change the log level. Felix Cheung 于2018年4月23日周一 上午3:52写道： > Is there a way to do this via enable/disable component for logging in > log4j? > >

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2937 \cc @weand ---

[GitHub] zeppelin pull request #2937: ZEPPELIN-3401. Deadlock while restarting interp...

GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2937 ZEPPELIN-3401. Deadlock while restarting interpreter ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the

Re: [DISCUSS] Adjust test logs for CI

Is there a way to do this via enable/disable component for logging in log4j? From: Jongyoul Lee Sent: Sunday, April 22, 2018 7:01:54 AM To: dev Subject: [DISCUSS] Adjust test logs for CI Hello contributors, I wonder how you guys think of

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 Hi @felixcheung please let me know if any additional changes or adjustments are needed. The two failing tests are unrelated to the code in in this PR Thanks. ---

[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

Github user iijima-satoshi commented on the issue: https://github.com/apache/zeppelin/pull/2929 @felixcheung I addressed your comments. Case sensitive, and furthermore exact match are not required. thanks. ---

[DISCUSS] Adjust test logs for CI

Hello contributors, I wonder how you guys think of reducing test logs to help to debug with CI. Recently, Zeppelin's Travis log is too big to read anything. So I suggest these kinds of step: 1. leave test logs as much as you want to test your code passed in CI 2. If passed, please remove all of

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2935 @zjffdu Let me make it ---

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2935 Do you have jstack so that I can understand what the exact problem is ---

[GitHub] zeppelin issue #2936: MINOR Remove tracing logs when testing

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2936 Review this PR. It's very trivial :-) ---

[GitHub] zeppelin pull request #2936: MINOR Remove tracing logs when testing

GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/2936 MINOR Remove tracing logs when testing ### What is this PR for? Removing redundant code when testing integration tests. It's hard to debug because of that kind of less-useful messages of

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2935 This is not a critial issue when running normally. But in case of problemistic situation like restarting forcibly to stop long running job of SparkInterpreter, some logic hangs inside

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2935 Test passed. https://travis-ci.org/jongyoul/zeppelin/builds/367566398 ---

[GitHub] zeppelin pull request #2935: ZEPPELIN-3411 Long running logic inside synchro...

GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/2935 ZEPPELIN-3411 Long running logic inside synchronized block in InterpreterSettingManager ### What is this PR for? Removing redundant synchronized code to avoid blocking other logics.

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

GitHub user sanjaydasgupta reopened a pull request: https://github.com/apache/zeppelin/pull/2903 [ZEPPELIN-3377] Passing Z variables to JDBC interpreter ### What is this PR for? This PR enables the interpolation of ZeppelinContext objects into the paragraph text of JDBC cells.

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

Github user sanjaydasgupta commented on the issue: https://github.com/apache/zeppelin/pull/2903 Closing and reopening to trigger tests. ---

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

Github user sanjaydasgupta closed the pull request at: https://github.com/apache/zeppelin/pull/2903 ---