[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 Thanks for review, will merge if no more comments ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3039 @zjffdu Thanks for explaining. I thought it could change all of the properties by this settings. ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 No,this is not this ticket's purpose. If user want to change interpreter level properties, they need inline conf interpreter. This ticket is to allow customize paragraph level behavior, e.g.

[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3013 I agree that the hook up `ui-grid` from `old button` makes sense. @Tagar @sanjaydasgupta ---

[GitHub] zeppelin issue #3029: ZEPPELIN-621 - Bump Java version to Java 8

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3029 Wow~~ Now, we can use JDK8's wonderful features GREAT!! ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3039 In my guess, you might want to change some spark properties with executing Spark paragraph. In this case, we might need to restart SparkInterpreter to adopt some properties like

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 Sorry @jongyoul I don't understand that. Why do you think it would affect restarting interpreters ? Do you have any more detail examples ? ---

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3039 Hi, basically, parsing properties with every execution may not affect much in performance on interpreter side. But It might affect the behaviours of restarting interpreters. e. g. every

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3039 Specifically in this PR, LGTM though ---

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3019 One drawback of inline UI is that user can not switch from spark ui and notebook, this may make user annoyed . ---

[GitHub] zeppelin pull request #3037: [ZEPPELIN-3555] Zeppelin auth fails if `activeD...

2018-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3037 ---

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-06-25 Thread shahsank3t
Github user shahsank3t commented on the issue: https://github.com/apache/zeppelin/pull/3019 @zjffdu Apologies missed out the earlier notification. > I didn't try this PR, but I didn't see backend pass spark.ui.allowFramingFrom to frontend, so how does frontend know whether

[GitHub] zeppelin issue #3040: Branch 0.7

2018-06-25 Thread niuguidong
Github user niuguidong commented on the issue: https://github.com/apache/zeppelin/pull/3040 @zjffdu thank you ---

[GitHub] zeppelin issue #3040: Branch 0.7

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3040 PR: Pull Request. If you have any problems of using zeppelin, please ask question in zeppelin mail list instead of asking it in github. Regarding your problems, the error message is

[GitHub] zeppelin issue #3040: Branch 0.7

2018-06-25 Thread niuguidong
Github user niuguidong commented on the issue: https://github.com/apache/zeppelin/pull/3040 @zjffdu thank you for help what means PR the condition is hdp2.3.4 +spark2.1(hdp version)+zeppelin0.73 , when I use bin version,the condition hdp2.3.4 +spark2.1+zeppelin0.73 ,I get errors

[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3019 ping @shahsank3t Any updates ? ---

[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3027 But what is the meaning of this pop up window ? As a user, it's not clear to me what is the impact if I import this kind of notebook ---

[GitHub] zeppelin issue #3040: Branch 0.7

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3040 @niuguidong Could you close this PR ? ---

[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-25 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/3033 LGTM ---

[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3033 Will merge it if no more comments ---

[GitHub] zeppelin issue #3024: [ZEPPELIN-3545] save all tables to ResourcePool

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3024 @mebelousov There're many options for how to specify which result to be stored into resource pool. e.g. ``` %spark(saveToResourcePool=1,2,4) ``` Or ```

[GitHub] zeppelin pull request #3042: ZEPPELIN-3560. DisplayName in dynamic forms doe...

2018-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3042 ---

[GitHub] zeppelin pull request #3038: ZEPPELIN-3556. set spark.yarn.submit.waitAppCom...

2018-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3038 ---

[GitHub] zeppelin pull request #3031: ZEPPELIN-3336. Remove sending spark web url to ...

2018-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/3031 ---

[GitHub] zeppelin issue #3031: ZEPPELIN-3336. Remove sending spark web url to interpr...

2018-06-25 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3031 ok ---

[GitHub] zeppelin issue #3024: [ZEPPELIN-3545] save all tables to ResourcePool

2018-06-25 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3024 @zjffdu I support adding only selected table results to Resource Pool. As paragraph can have multiple results than I propose to add result level properties. ---

[GitHub] zeppelin issue #3042: ZEPPELIN-3560. DisplayName in dynamic forms doesn't wo...

2018-06-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/3042 Tested on local, works as expected, LGTM. ---

[jira] [Created] (ZEPPELIN-3564) Customize default path for new notes

2018-06-25 Thread Maxim Belousov (JIRA)
Maxim Belousov created ZEPPELIN-3564: Summary: Customize default path for new notes Key: ZEPPELIN-3564 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3564 Project: Zeppelin Issue

[GitHub] zeppelin issue #3042: ZEPPELIN-3560. DisplayName in dynamic forms doesn't wo...

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3042 @prabhjyotsingh Could you help review it ? Thanks ---

[GitHub] zeppelin pull request #3043: ZEPPELIN-3218. Plugins for Interpreter Launcher

2018-06-25 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3043 ZEPPELIN-3218. Plugins for Interpreter Launcher ### What is this PR for? Move launcher into zeppelin plugins ### What type of PR is it? [Refactoring] ### Todos * [ ]

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3039 Thanks @mebelousov for the feedback. We could do that in a followup PR to improve user friendliness. Because currently I can not imagine in what kind scenario user would add lots of parameters.

[GitHub] zeppelin issue #3037: [ZEPPELIN-3555] Zeppelin auth fails if `activeDirector...

2018-06-25 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/3037 Thanks for the review will merge this if no more discussion. ---

Re: [VOTE] Release Apache Zeppelin 0.8.0 (RC6)

2018-06-25 Thread Prabhjyot Singh
+1 On Mon, 25 Jun 2018 at 06:05, Jeff Zhang wrote: > Here's my +1. > > I build it from source successfully and ran spark tutorial in local, > yarn-client, yarn-cluster mode successfully. > > > > Jeff Zhang 于2018年6月25日周一 上午8:34写道: > > > Hi folks, > > > > I propose the following RC to be released

[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties

2018-06-25 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3039 @zjffdu great powerful feature! When the parameters will be a lot, it will be not easy to find and write the parameter name. I wish it would be more user-friendly with drop-down panel.

[GitHub] zeppelin pull request #3042: ZEPPELIN-3560. DisplayName in dynamic forms doe...

2018-06-25 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3042 ZEPPELIN-3560. DisplayName in dynamic forms doesn't work ### What is this PR for? Use the displayName as the label instead of name. ### What type of PR is it? [Bug Fix]