[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2018-01-09 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 @RoxanaTapia Could you file a Jira issue here https://issues.apache.org/jira/projects/ZEPPELIN so that it can be tracked & handled separately ? Once a patch is merged, can't be opened a

[GitHub] zeppelin issue #2660: Change Spell url to snapshot-8

2017-11-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2660 Merge to gh-pages branch if there is no more discussions ---

[GitHub] zeppelin issue #2660: Change Spell url to snapshot-8

2017-11-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2660 LGTM ---

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

2017-06-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2394 Yeah second option is better for me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...

2017-06-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2394 Thanks for the great work @soralee! And also thanks for detailed review @1ambda. Tested and looks nice! I really like the most of parts. Some minor suggestion

[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...

2017-06-04 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2381 Thank you for great work! Especially big +1 for adding this section https://cloud.githubusercontent.com/assets/10060731/26764287/e5b90aa2-4918-11e7-908c-1fdfd4870037.png;> I

[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page

2017-05-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2371 Cool! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2346: [gh-pages] Hide pagination btn if there is only 1 page

2017-05-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2346 `gh-pages` doesn't have CI check. So the red light is irrelevant with this change. Ready to review. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #2346: [gh-pages] Hide pagination btn if there is only...

2017-05-15 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2346 [gh-pages] Hide pagination btn if there is only 1 page ### What is this PR for? Same work with #2345 but for `gh-pages` ### What type of PR is it? Improvement

[GitHub] zeppelin issue #2345: [MINOR] Hide pagination button if there is only 1 page...

2017-05-15 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2345 @1ambda If you don't mind, could you help me to review this? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2345: [MINOR] Hide pagination button if there is only...

2017-05-15 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2345 [MINOR] Hide pagination button if there is only 1 page in Helium menu ### What is this PR for? It'll be better to hide the pagination button if there is only one page. ([`only-of-type

[GitHub] zeppelin issue #2340: [ZEPPELIN-2426] Improve graph setting DOMs

2017-05-13 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2340 Tested and it looks good. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...

2017-04-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2265 Tested and it looks great! +1 for this change ![record](https://cloud.githubusercontent.com/assets/10060731/25312979/a0406250-2860-11e7-90ea-6d656d468179.gif) --- If your project

[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...

2017-04-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2265 @1ambda Yeah right right I misapprehended actually. It was my bad. Btw I wanted to test this locally but failed when I run `yarn install` and got this below 404 error

[GitHub] zeppelin issue #2265: [ZEPPELIN-2427] Hide navbar and noteAction bar when sc...

2017-04-21 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2265 Cool! Then to reach to the menu, some users who have lots of paragraphs have to spend much time to scroll up. Then how about sticky "go to top" like button at bottom-right side

[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.

2017-04-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 @1ambda CI checks has been failed sadly. Can you check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.

2017-04-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 Oh.. Will merge into master right after CI turns into green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.

2017-04-19 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2255: [HOTFIX] Invalid method signature in GroovyInterpreter

2017-04-17 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2255 Merge into master as a hotfix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2244: [MINOR] fix typo from 'interpeter' to 'interpreter'

2017-04-17 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2244 Merge into master and branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.

2017-04-14 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 @1ambda Yeah makes sense. Looks GOOD to me 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium

2017-04-14 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2236 Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.

2017-04-14 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 @1ambda Great work! Quickly looked through the most of file changes and it looks good. Zeppelin web is getting bigger, everyone will feel the necessity of this kind of lint rule. btw

[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium

2017-04-10 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2236 @tae-jun Looks GOOD to merge :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium

2017-04-10 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2236 @tae-jun Thanks for the improvement. >You can add any dependencies in package.json, but you must include two dependencies: zeppelin-vis and zeppelin-tabledata. Yeah I th

[GitHub] zeppelin issue #2232: [ZEPPELIN-2373] Remove -Pyarn build profile

2017-04-08 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2232 @felixcheung Thanks! Merge into master if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2124: [ZEPPELIN-2154] Support zeppelin.server.port in dev mo...

2017-04-07 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2124 @soralee I just merged this PR into branch-0.7 but it's not closed automatically. Could you close it in your side? --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2222: add a configuration zeppelin.jdbc.auth.kerberos.proxy ...

2017-04-07 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/ @wary Thanks! Merge into master and branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2232: [ZEPPELIN-2373] Remove -Pyarn build profile

2017-04-07 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2232 CI is green now. @jongyoul Could you help me to review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #2232: [ZEPPELIN-2373] Remove -Pyarn build profile

2017-04-07 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2232 [ZEPPELIN-2373] Remove -Pyarn build profile ### What is this PR for? Currently users who build Zeppelin from source need to include `-Pyarn` build profile to enable Yarn for embedded

[GitHub] zeppelin issue #2220: [Minor] Fix wrong Python lib path in Matplotlib tutori...

2017-04-07 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2220 Merge into master and branch-0.7 if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...

2017-04-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2212 @1ambda Thanks. CI failure is irrelevant with gh-pages change. Merge into gh-pages if there are no more comments. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...

2017-04-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2224 @1ambda I just merged this into branch-0.7 but it's not closed automatically. Could you close in your side? --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2225: [ZEPPELIN-2357] fix: tooltip doesn't work in btn-group

2017-04-05 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2225 @1ambda Yeah I also knew it when I was adding the pagination to Helium menu for both zeppelin.apache.org and Zeppelin :) Tested again and it works well. LGTM --- If your project is set

[GitHub] zeppelin issue #2225: [ZEPPELIN-2357] fix: tooltip doesn't work in btn-group

2017-04-05 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2225 @1ambda If we update angular-bootstrap version, the pagination in Helium page won't work since they change the pagination lib name (`pagination` ->`ul uib-pagination`) So you might n

[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...

2017-04-05 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2224 LGTM Merge into branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #2215: [ZEPPELIN-2341] Remove -Psparkr build profile

2017-04-05 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2215 @Leemoonsoo Thanks! Merge into master if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2224: [ZEPPELIN-2304] Fix vis Icon sizes in helium page (bra...

2017-04-05 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2224 CI failure is irrelevant with this change. Looks good :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...

2017-04-04 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda Looks great! So sorry I forgot to mention that there is another place to be updated regarding [this change](https://github.com/apache/zeppelin/pull/2098#issuecomment-291390619

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

2017-04-04 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2199 Merge into master and branch-0.7 if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2222: add a configuration zeppelin.jdbc.auth.kerberos.proxy ...

2017-04-04 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/ Thanks! Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2222: add a configuration zeppelin.jdbc.auth.kerberos.proxy ...

2017-04-04 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/ @wary Thanks for your contribution. Could you add `zeppelin.jdbc.auth.kerberos.proxy.enable` info to [this table](https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md#more

[GitHub] zeppelin pull request #2220: [Minor] Fix wrong Python lib path in Matplotlib...

2017-04-04 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2220 [Minor] Fix wrong Python lib path in Matplotlib tutorial note ### What is this PR for? There is a wrong information about Zeppelin’s matplotlib backend files. It actually located under

[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...

2017-04-03 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2212 @1ambda Can you help review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one

2017-04-03 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2210 yeah I got same error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile

2017-04-03 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2213 Merge into master if there are no more comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' next to ...

2017-04-03 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2211 @felixcheung @Leemoonsoo Thanks. Merge into master if there are no further comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile

2017-04-03 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2213 @jongyoul Yup, will open a PR for that soon. @Leemoonsoo Thanks. Updated again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile

2017-04-03 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request: https://github.com/apache/zeppelin/pull/2213 [ZEPPELIN-2298] Remove -Ppyspark build profile ### What is this PR for? Currently users who build Zeppelin from source need to include `-Ppyspark` to use `%pyspark` with embedded local

[GitHub] zeppelin pull request #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile

2017-04-03 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]

2017-04-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Merge to master if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2205: [ZEPPELIN-2330] Helium.html doesn't render spell infor...

2017-04-02 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2205 Thanks. I'm merging into master now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile

2017-04-01 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2213 [ZEPPELIN-2298] Remove -Ppyspark build profile ### What is this PR for? Currently users who build Zeppelin from source need to include `-Ppyspark` to use `%pyspark` with embedded local

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

2017-04-01 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2199 CI is green now. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...

2017-04-01 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...

2017-04-01 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request: https://github.com/apache/zeppelin/pull/2211 [ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of interpreter type pkg ### What is this PR for? Currently "see more" is placed next to the

[GitHub] zeppelin pull request #2212: [gh-pages] set max size for pagination btn & hi...

2017-04-01 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2212 [gh-pages] set max size for pagination btn & hide arrows when current page is first/last ### What is this PR for? As the number of Helium packages is increasing, more pagination but

[GitHub] zeppelin issue #2204: ZEPPELIN-2189. The order of dynamic forms should be th...

2017-04-01 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2204 Merge into master and branch-0.7 if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #2211: [ZEPPELIN-2339] Change 'see more' -> 'enable' n...

2017-04-01 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2211 [ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of interpreter type pkg ### What is this PR for? Currently "see more" is placed next to the

[GitHub] zeppelin issue #2195: [ZEPPELIN-2319] new methods for ZeppelinContext

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2195 @meniluca Great initiative! Thanks for detailed explanation and it makes sense to me as well. That would be helpful to any other reviewers. But before you go further, need to setup travis

[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Looks good to me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2208: [HOTFIX][gh-pages] Fix Maven web link for INTERPRETER ...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2208 @felixcheung Thanks! CI failure is irrelevant with `gh-pages` change. Merge into gh-pages as a hotfix if there are no more comments on this. --- If your project is set up for it, you

[GitHub] zeppelin issue #2205: [ZEPPELIN-2330] Helium.html doesn't render spell infor...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2205 @1ambda Yup thanks for letting me know --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2207 @cloverhearts Great! Tested this patch and it works well as you described. - Before ![screen shot 2017-03-31 at 11 58 32 am](https://cloud.githubusercontent.com/assets/10060731

[GitHub] zeppelin issue #2177: [ZEPPELIN-2301] DON'T overwrite editor text when note ...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2177 Sure. I'll test it and get back you soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2189: [branch-0.7] Minor styling for Helium menu

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2189 I already merged into `branch-0.7` but not closed yet. So closing this manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #2208: [HOTFIX][gh-pages] Fix Maven web link for INTER...

2017-03-30 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2208 [HOTFIX][gh-pages] Fix Maven web link for INTERPRETER type pkg ### What is this PR for? In current https://zeppelin.apache.org/helium_packages.html page, `INTERPRETER` type package web

[GitHub] zeppelin issue #2202: [Minor][ZEPPELIN-2328] Separate Helium related docs fr...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2202 Thanks @1ambda for the confirmation! Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2205: [ZEPPELIN-2330] Helium.html doesn't render spell infor...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2205 Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2205: [ZEPPELIN-2330] Helium.html doesn't render spell infor...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2205 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda Appreciate for such detailed explanation! Regarding `no-group`, I can assume the other ppl can be confused like me. So it'll be better to add some description

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Thanks! Will merge into master if there are no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2204: ZEPPELIN-2189. The order of dynamic forms should be th...

2017-03-30 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2204 Tested and it works well now. Thanks for fixing it. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...

2017-03-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2151 @Remilito Tested and it works as expected. Regarding docs, how about adding new section for this feature instead of `subsequent parameter (optional)` as a subsection under "Run a para

[GitHub] zeppelin issue #2204: ZEPPELIN-2189. The order of dynamic forms should be th...

2017-03-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2204 Yeah I saw this as well. Let me take a look :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2135: Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]

2017-03-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2135 Thanks for addressing my comments! I left some minor comments again about "author name" in the source code and removing unnecessary `log.info`. Except these two thin

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @felixcheung Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu

2017-03-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2189 @felixcheung Thanks! Merge into branch-0.7 if there are no further comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda I updated the pagination as you said and this is the current status. Will be appreciated if you can take a look again. ![hide_first_last_arrows](https://cloud.githubusercontent.com

[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu

2017-03-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2189 @felixcheung Is this good to go now? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #2202: [Minor][ZEPPELIN-2328] Separate Helium related ...

2017-03-29 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2202 [Minor][ZEPPELIN-2328] Separate Helium related docs from 'Contribution' section ### What is this PR for? Actually writing "Visualization", "Spell" or "Application

[GitHub] zeppelin issue #2199: [ZEPPELIN-2326] - Updating Geode dependencies and impo...

2017-03-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2199 Hi @markito Thanks for your contribution and taking care of Geode interpreter. - Zeppelin build system relies on travis. So please setup your travis account and travis project

[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...

2017-03-28 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2098 @1ambda I feel so sorry for my late response. Tested this patch \w your Helium package: zeppelin-ultimate-line-chart. Here are some thought and question(?) in my head. 1. "

[GitHub] zeppelin issue #2200: [HOTFIX] Remove unintended characters from r tutorial

2017-03-28 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2200 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-28 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda Thanks for the detailed explanation. ![record](https://cloud.githubusercontent.com/assets/10060731/24408816/ae0257ec-1409-11e7-8534-8ef1b73a14d0.gif) --- If your project is set

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-28 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda No worries :) Then how about 1 page ? I mean if there is only 1 page, we can hide `<<` & `>>`. --- If your project is set up for it, you can reply to this ema

[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page

2017-03-28 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2181 @1ambda I couldn't auto merge this PR into branch-0.7 since there are some conflicts. If you don't mind, can you create separate PR for branch-0.7? --- If your project is set up for it, you

[GitHub] zeppelin issue #2181: [ZEPPELIN-2304] Fix vis Icon sizes in helium page

2017-03-28 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2181 Thanks. Merging into master and branch-0.7 now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @felixcheung Let me check again for that part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2174 @1ambda It's wired. This is what I can see when I build my branch. ![record](https://cloud.githubusercontent.com/assets/10060731/24363529/1863c144-134b-11e7-85c7-ae5c6acc8dd7.gif

[GitHub] zeppelin issue #2163: [ZEPPELIN-2287] Add more test to ensure 'RunOnSelectio...

2017-03-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2163 @Leemoonsoo Thanks! Merge into master and branch-0.7 if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #2189: [branch-0.7] Minor styling for Helium menu

2017-03-25 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request: https://github.com/apache/zeppelin/pull/2189 [branch-0.7] Minor styling for Helium menu ### What is this PR for? Since Helium online registry is available in develop version(0.8.0-SNAPSHOT) for now, people only can use their local

[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....

2017-03-25 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee And as you can see in the above gif image that i took, the tooltip in scatter chart is shown like "(age, value)". But before #2042 it looks like below. ![im

[GitHub] zeppelin issue #2163: [ZEPPELIN-2287] Add more test to ensure 'RunOnSelectio...

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2163 @Leemoonsoo Right it should be passed without refreshing. So I removed that part and added `waitForParagraph(1, "FINISHED");` before every selections for the stability. Now CI is

[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-24 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request: https://github.com/apache/zeppelin/pull/2174 [ZEPELIN-2209] Add pagination to Helium menu ### What is this PR for? Like I did in #2126, added pagination to Helium menu in Zeppelin. 10 pkgs will be shown per 1 page

[GitHub] zeppelin pull request #2174: [ZEPELIN-2209] Add pagination to Helium menu

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee Thanks for the explanation. I tested this branch to make sure it works well or not, but when I select "Line chart" below error ms

[GitHub] zeppelin issue #2180: [gh-pages][ZEPPELIN-2303] Fix lately published package...

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2180 CI failure is not related with this change since it's based on `gh-pages` branch. Merge into `gh-pages` if there are no more comments. --- If your project is set up for it, you can

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

2017-03-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1976 @del680202 Thanks for your time and effort to test it out. >But I seem when I edit interpreter config then the zombie process will be occurred I checked it with curr

  1   2   3   4   5   6   7   8   9   >