Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/3055
@zjffdu do we have an expected date for this fix?
---
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/2186
I will agree with @Remilito on this one.
I think we can come up with a workaround and keep 1.8.5.
---
If your project is set up for it, you can reply to this email and have your
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/2161
Tested with some basic case, look good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1934
Merging if no more discussion ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1934
@felixcheung thank you for your feedback, i have updated this part, please
let me know if something else need to be addressed.
---
If your project is set up for it, you can reply
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/2049
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1934
merging if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1934
[ZEPPELIN-2001] Publish Apache Zeppelin artifacts to snapshot repository
### What is this PR for?
Simple script that deploy Apache Zeppelin artifact to snapshot repository
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1721
Cam we use the same sorting icon than the one use in table in paragraph?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1722
LGTM thank for the contrib
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/zeppelin/commit/13178aee18c0a4aed1dda0c72750e08c9ed9f53c#commitcomment-20060217
In
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java:
In
zeppelin-zengine/src
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/zeppelin/commit/13178aee18c0a4aed1dda0c72750e08c9ed9f53c#commitcomment-20060216
In
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java:
In
zeppelin-zengine/src
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1720
@minahlee @khalidhuseynov thanks you for review, fixed the test and
hopefully merging it as a hotfix soon
---
If your project is set up for it, you can reply to this email and have your
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1720
Fix case where user use zeppelin in normal mode with token
### What is this PR for?
Fix the case where user use zeppelin in normal mode (doesnt use
authentication) and set
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1697
Please review otherwise i am merging it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1681
@khalidhuseynov thanks for the review, i addressed it.
Merging if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1697
[ZEPPELIN-1352] Refactor Notebook repo versioning to return Revision Empty
instead of NULL
### What is this PR for?
In Zeppelin notebookRepo, versioning (checkpoint, get
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1681
Please review otherwise i am merging it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1681
[ZEPPELIN-1691] Implement NotebookRepoSetting to ZeppelinHub notebookRepo
### What is this PR for?
Implement notebookRepo setting in ZeppelinHub notebook repo.
This change
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1635
CI is green, please review otherwise merging it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1651
[ZEPPELIN-1681] - Fix note permission settings order
### What is this PR for?
The list of option (Owner, Reader and Writer) doesnt look natural, it
should be from the stronger
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1635
@khalidhuseynov as you can see its a wip, i will let you know when its
ready for review
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1646
@khalidhuseynov i am re triggering travis and merging as a hot fix after
that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1646
ZEPPELIN-1672 - Fix import note
### What is this PR for?
Importing note from github doenst work, instead you will have the following
error
```
XMLHttpRequest cannot load
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1588
@Leemoonsoo i resolved the conflict :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1635
[WIP] - ZeppelinHubNotebookRepo multy user handling
### What is this PR for?
This PR bring multi user handling to ZeppelinHubNotebookRepo.
### What type of PR
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1588
CI is green after ~10 retry
---
If your project is set up
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1588
@Leemoonsoo looks like tests are falling for random reason...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1597
@khalidhuseynov its a know issue: logged here
https://issues.apache.org/jira/browse/ZEPPELIN-1623
---
If your project is set up for it, you can reply to this email and have your
reply
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1595
@Leemoonsoo thank you for the feedback, please fix the fix under PR #1604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1604
[HOT-FIX] - Prevent double injection of cross-origin headers from rest api
### What is this PR for?
Prevent error `XMLHttpRequest cannot load
http://localhost:8080/api/version
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1583
#1595 will fix this issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1591
travis is super slow today
Amerika is working to hard today :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1595
[ZEPPELIN-1615] - Zeppelin should be able to run without Shiro
### What is this PR for?
Right now, Zeppelin use Shiro by default even if you dont need it.
(It will use
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1565
@tae-jun This is a great sum of the status of the rest api in zeppelin, and
i think we all agree that currently zeppelin doenst follow rest standard (just
by looking at the endpoint
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1592
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1591
Fix latency on notebook save in ZeppelinHubNotebookRepo
### What is this PR for?
Fix latency issue when user save a notebook while using zeppelinhub
notebook storage
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1588
[ZEPPELIN-1610] [WIP] - Add notebook watcher
### What is this PR for?
Add a Simple way to switch a websocket connection to a new state; watcher.
A websocket watcher is a special
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1583
Good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1583
merging if no more discussion ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1567
Yeaay!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1567
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1567
[ZEPPELIN-1586] Add security check in NotebookRestApi
### What is this PR for?
Bring some security check in `NotebookRestApi`.
### What type of PR is it?
[Bug Fix
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1567
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1575
@minahlee yes please merge it asap this a total war zone here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1567
@tae-jun creating an issue doenst mean that you have to handle it, of
course if you want you are welcome to do so, but remember we are a community so
that mean we are here to help each
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1567
[ZEPPELIN-1586] Add security check in NotebookRestApi
### What is this PR for?
Bring some security check in `NotebookRestApi`.
### What type of PR is it?
[Bug Fix
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1567
@tae-jun After looking at the code base, I think this case should be handle
in another PR, this is kinda out of the scope of this PR and its already
becoming super big.
But your
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1567
@minahlee you are right, I guess the next step will be to abstract this
logic from rest api and apply to both rest and websocket.
---
If your project is set up for it, you can reply
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1567
@minahlee yeah, actually i am doing this right now, I also updated to todo
tasks thanks for your review!
---
If your project is set up for it, you can reply to this email and have your
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1567
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1567
[ZEPPELIN-1586] Add security check in NotebookRestApi
### What is this PR for?
Bring some security check in `NotebookRestApi`.
### What type of PR is it?
[Bug Fix
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1567
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1567
[ZEPPELIN-1586] Add security check in NotebookRestApi
### What is this PR for?
Bring some security check in `NotebookRestApi`.
### What type of PR is it?
[Bug Fix
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1571
[DOC] Update shiro after merging #1568
### What is this PR for?
A simple update of the documentation to let user know how that they need to
copy `shiro.ini.template` to `shiro.ini
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1571
merging if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1571
[DOC] Update shiro after merging #1568
### What is this PR for?
A simple update of the documentation to let user know how that they need to
copy `shiro.ini.template` to `shiro.ini
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1568
[ZEPPELIN-1590] Move shiro.ini to shiro.ini.template
### What is this PR for?
Move shiro.ini to shiro,ini.template for consistency.
### What type of PR
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1567
[ZEPPELIN-1586] Add security check in NotebookRestApi
### What is this PR for?
Bring some security check in `NotebookRestApi`.
### What type of PR is it?
[Bug Fix
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1540
Awesome, **LGTM**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1553
If no more discussion i am going to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1553
Please review this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1553
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1553
[ZEPPELIN-1575] Notebook Repo settings UI
### What is this PR for?
The idea behind this feature is to bring flexibility to the user to let him
configure his repo via UI without
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1553
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1553
[ZEPPELIN-1575] Notebook Repo settings UI
### What is this PR for?
The idea behind this feature is to bring flexibility to the user to let him
configure his repo via UI without
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1553
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1553
[ZEPPELIN-1575] Notebook Repo settings UI
### What is this PR for?
The idea behind this feature is to bring flexibility to the user to let him
configure his repo via UI without
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1553
@khalidhuseynov added some tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1537
LGTM merging if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1553
[ZEPPELIN-1575] [WIP] Notebook Repo settings UI
### What is this PR for?
Let user configure/change notebook repo setting via Zeppelin UI
We can imagine one case
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1542
Changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1497
@HeartSaVioR yeah i would love to have a class that manipulate redis cmd
and handle null, ussually i am not a huge fan of returning `null`, i would
prefer to return an `EMPTY` type
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1536
I see your point, but let say i want to import a note and i have a note
with the same name, it will not allow me to do that and i feel like its a
pretty bad user experience here. What do
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1536
I think its okay to have a duplicate name, if the noteId is different
nothing bad will happen. What kind of case are you trying to solve here?
---
If your project is set up for it, you
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1392
@Leemoonsoo is it possible to merge it in couple of hour? some of my work
will depends on this PR :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1515
look good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1528
LG*reat*TM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1497
@HeartSaVioR thank you for pointing that out, you are right we better
handle the potential `JedisException` exception to avoid leak.
---
If your project is set up for it, you can reply
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1517
Change looks great to me, that you for your contribution.
Awesome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1497
@darionyaphet do you need some help for the change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1505
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1494
@sixmen thank you for your contribution, this feature looks AWESOME.
I didnt dive into the code, but one question came in my mind;
This change is kinda *breaking change* since
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1498
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1496
@vectorijk thank you for the contribution
the change look good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1482
Changes look good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1483
Changes look good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1338
@khalidhuseynov fixed the issue, thank for testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1338
@bzz Regarding your comment, I couldnt agree more, i am not a big fan of
returning `null`. I created an issue in [JIRA -
1352](https://issues.apache.org/jira/browse/ZEPPELIN-1352) and I
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1338
**L**ets **G**et **T**o **M**erge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1344
look good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1340
Can you order them alphabetically ? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1338
[WIP ] Zeppelin 1307 - Implement notebook revision in Zeppelinhub repo
### What is this PR for?
Implement versioning in ZeppelinHub notebook storage.
### What type of PR
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1254
@bzz can you merge it asap? i need this change if i want to continue my work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1304
@khalidhuseynov are we really sure about sending `complex object` as a
parameter in the URL?
How will it be represented? encoded?
IMO it is not a good idea, if you ask
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1251
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1173
@jongyoul sure, no problemo
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 106 matches
Mail list logo
