Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3265
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3266
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3269
@HsuanXyz Thanks for the contribution, looks like the travis fails due to
code style check. You can get these errors by running `mvn package -DskipTests
-pl zeppelin-web`
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3266
@xueyumusic Thanks for the contribution, we can make it as subtask of
ZEPPELIN-3913. BTW I am curious to know whether you are using flink in zeppelin
? If yes, could you share more details
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3239
@monsieurp Is `Patrice Clement` your jira account ? I'd like to assign this
ticket to you.
---
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/3199
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3263
ZEPPELIN-3907. Add code statement into Spark JobGroup Id for
SparkInterpreter
### What is this PR for?
Straightforward change to add code statement into Spark JobGroupId, so that
we can
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3239
Thanks @monsieurp Could you also delete `common.max_count` from
`interpreter-setting.json` and test code ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3239
It is weird that I see another property `common.max_count` but it is never
used in `JdbcInterpreter`. I think we just need to keep one and remove others.
Personally I prefer
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3239
ping @monsieurp
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3249
Thanks @OrDTesters LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3244
@conker84 #3243 is fixed, could you rebase this PR ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3226
@Savalek I have merged it into master, could you create another PR for
branch-0.8 if you'd like to merge it into branch-0.8 as well ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3249
@OrDTesters What do you mean "run on its own" ? Do you mean to run it in
IDE ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3234
Test is added, will merge it no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3033
Thanks @HyukjinKwon feel free to take over this
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3226
LGTM, merge if more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3245
@liuxunorg This is the change what I suggest
https://github.com/zjffdu/zeppelin/commit/29593d74bac17f124e97fc43a4942e3365a12ed7
Could you verify whether it solve this issue ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3245
Hi @liuxunorg I would prefer to add another method
```
public boolean runParagraph(String noteId,
String paragraphId
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3239
@monsieurp I though about it again, and feel that providing 2 properties is
very confusing to users. I think it is better to give one property
(zeppelin.jdbc.maxRows) what is user care about
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3226
@Savalek Could you remove `ZP-25` from commit message ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3239
@monsieurp Could you do a rebase and retrigger the travis build ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3226
@Savalek Could you resolve the conflicts ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3239
@monsieurp This might be flaky test, let me take a look at it.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3239
Thanks @monsieurp for the contribution, I left a few comments, otherwise
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3226
@Savalek Could you remove `ZP-25` from PR title ?
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3238
ZEPPELIN-3870. Configuration in spark-defaults.conf doesn't take effect
### What is this PR for?
This is due to another version of kryo in zeppelin-interpreter-api, this PR
just exclude
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3237
ZEPPELIN-3871. Spark interpreter doesn't work with KryoSerializer
### What is this PR for?
This is due to another version of kryo in zeppelin-interpreter-api, this PR
just exclude
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3234
ZEPPELIN-3876. Unable to rename note
### What is this PR for?
This is trivial PR for fixing the issue of unable to rename note. The root
cause is that the notePath may has 2 leading
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3232
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3233
ping @prabhjyotsingh
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3227
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3229
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
I will try to do it by the end of 2018
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
It is merged to branch-0.8 and master branch. So yes it will be released in
zeppelin 0.9.0, but I believe 0.8.1 will be released before zeppelin 0.9.0
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3230
LGTM
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3228
ZEPPELIN-3865. Paragraph cancel is broken
### What is this PR for?
Paragraph cancel is broken due to previous code refactoring, This PR fix it
in straightforward way and add system test
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3222
Will merge if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3223
Will merge if no more comments
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3223
ZEPPELIN-3822. All interpreter folders (ZEPPELIN_HOME/interpreter) are
deleted when maven clean is invoked
### What is this PR for?
This PR is to fix the bug that `ZEPPELIN_HOME`/interpreter
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3222
ZEPPELIN-3815. No interpreter group name in spark interpreter log file
### What is this PR for?
Trivial PR for fixing group name missing in spark interpreter log file
### What
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
CI is passed, will merge it if no more comments
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3221
ZEPPELIN-3858. Code completion doesn't work for spark interpreter when
cursor is in the middle of code
### What is this PR for?
It is a trivial fix for the code completion of spark
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
@HyukjinKwon I created one PR for you to add test for spark 2.4, would mind
to merge that ? https://github.com/HyukjinKwon/zeppelin/pull/1
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Thanks for everyone, the only remaining thing is to update `.travis.yml` to
make sure the test pass again spark 2.4
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3215
The unit test in `SparkRInterpreterTest` did cover the error case. We need
to add this kind of unit test.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3220
Merge if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
That's correct, @dongjoon-hyun
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3220
ZEPPELIN-3846. Code Completion is broken
### What is this PR for?
Code completion is broken due to the shaded jar in
zeppelin-interpreter-api, this PR fix this issue and also add unit test
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3218
Thanks @Leemoonsoo +1
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3215
Can you attach unit for it ? Add it to `SparkRInterpreterTest.java`
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
@HyukjinKwon I don't see the official announcement of spark 2.4 release.
Zeppelin test also depends on the binary distribution of spark, so we have to
wait for the official binary release of spark
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Awesome @HyukjinKwon Let's wait for spark 2.4 release
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3210
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3209
I will merge it soon as currently travis is broken
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3209
ZEPPELIN-3818. Unit test failed: ZeppelinSparkClusterTest.testAngularObjects
### What is this PR for?
This is to fix the unit test failure of
ZeppelinSparkClusterTest.testAngularObjects
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3208
ZEPPELIN-3821. Yarn app is not killed after flink interpreter is restarted
### What is this PR for?
Trvial PR to shutdown cluster when flink shell is closed.
### What type of PR
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Yesï¼ we need to support scala 2.11 for spark 2.4 first.
And please also update travis.yml to build it with spark-2.4 profile
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Thanks @HyukjinKwon Have you checked this PR
(https://github.com/apache/zeppelin/pull/3034) for supporting scala 2.12
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3200
Will merge if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3201
It is not necessary to publish zeppelin-interpreter-api.jar to
lib/interpreter. zeppelin interpreter api jar is already included to all
interpreter jars under lib folder.
---
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/3195
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3195
Will merge if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3196
Will merge if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3200
That's right @liuxunorg This is my plan, I'd like to show the log in the
interpreter process monitoring page.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2709
@alonshoham Sorry I didn't notice you created the ticket, I have fixed via
this commit,
https://github.com/apache/zeppelin/commit/8b2f4a7bd89aa69661e09ef9ad73c04d862029ff
Could you help
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3200
ZEPPELIN-3804. Separate log file for each interpreter process
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3199
ZEPPELIN-3792. Support Kerberos Realm
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3198
ZEPPELIN-3801. Code refactoring of org.apache.zeppelin.interpreter.remote
### What is this PR for?
This PR is a refactoring PR which to refactor the code of package
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3197
LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3189
Many classes are old existing code which I just rename them. e.g.
`OldAzureNotebookRepo` is renamed from the old version of `AzureNotebookRepo`
---
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/3193
---
Github user zjffdu closed the pull request at:
https://github.com/apache/zeppelin/pull/3192
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3196
ZEPPELIN-3800. Allow to configure scheduler thread pool size
### What is this PR for?
This PR is for master branch. It just introduce new property
`zeppelin.scheduler.threadpool.size
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3195
ZEPPELIN-3800. Allow to configure scheduler thread pool size
### What is this PR for?
This PR is for branch-0.8. It just introduce new property
`zeppelin.scheduler.threadpool.size` and allow
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3188
Thanks @ajaygk95 LGTM
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3194
ZEPPELIN-3790. Move common interpreter dependencies into
zeppelin-interpreter-parent
### What is this PR for?
This is refactoring PR which move common dependencies into
zeppelin
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3183
LGTM, will merge if no more comments
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3193
[HOTFIX] Fix travis failure of branch-0.8
### What is this PR for?
This is for fixing the travis failure of branch-0.8
### What type of PR is it?
[Bug Fix]
### Todos
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3192
Will merge if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3191
Will merge it if no more comments
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3190
Will merge if no more comments
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3192
ZEPPELIN-3768. run all paragraphs sequential mode when using
ZeppelinContext api
### What is this PR for?
This PR is to fix the bugs of ZeppelinContext.run api. It should run
paragraph
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3191
ZEPPELIN-3794. NPE when running paragraph without interpreter specified
### What is this PR for?
This issue happens for the old note where no defaultInterpreterGroup is
specified in note.json
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3190
ZEPPELIN-3796. Polluted output for spark interpreter
### What is this PR for?
This PR is to clear polluted spark interpreter output.
### What type of PR is it?
[Bug Fix
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2709
Thanks @alonshoham feel free to create a PR for that.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3157
Thanks @selvinsource will merge it soon
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3188
@ajaygk95 Thanks for the contribution, please configure your travis to
enable CI.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3189
Good idea, I can do it in a follow up PR.
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3189
[ZEPPELIN-3758]. Convert old note file note.json to new style
### What is this PR for?
This PR is follow up of ZEPPELIN-261, it is to convert old note file
note.json to new style when user
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3187
LGTM
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3186
Zeppelin build fails with "Could not complete Mojo execution.."
### What is this PR for?
Maven build fails due to invalid file name character, this PR fix it by
renaming the note
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3184
[ZEPPELIN-3786]. Don't copy dependencies to target/lib for interpreter
modules
### What is this PR for?
Only module zeppelin-interpreter,zeppelin,zengine,zeppelin-server needs
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3163
Thanks all for reviewing and testing, will merge it soon
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3182
LGTM, can we add unit test for this ?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3180
Is it necessary to backport to branch-0.8 ? Does it fix some critical issue
?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3181
@jongyoul Could you help review and verify it ? Thanks
---
GitHub user zjffdu opened a pull request:
https://github.com/apache/zeppelin/pull/3181
ZEPPELIN-3633. ZeppelinContext Not Found in yarn-cluster Mode
### What is this PR for?
This issue is due to classpath in cluster mode. Because in cluster mode,
driver run in the node of yarn
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3180
Thanks @prabhjyotsingh LGTM
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3180
oops, it seems a large change, not sure why node npm package upgrade needs
so large change. I am not an frontend expert, just need some explanation. ð
---
1 - 100 of 1861 matches
Mail list logo
