Re: [DISCUSS] Review process

7 1:22:07 AM To: dev@zeppelin.apache.org Subject: RE: [DISCUSS] Review process We are speaking in this thread about two reviewers on big PR, but there are PRs without any reviewers =) What contributor can do if his PR have not been reviewed for 4 week? For example https://github.com/apache/ze

RE: [DISCUSS] Review process

: Jongyoul Lee [mailto:jongy...@gmail.com] Sent: Tuesday, December 19, 2017 8:34 PM To: dev <dev@zeppelin.apache.org> Subject: Re: [DISCUSS] Review process I agree with some large PR should be delayed a bit longer. What I meant is we don't have to wait for all kind of PRs. On Wed, Dec 20, 201

Re: [DISCUSS] Review process

t is > small and what is big? > > _ > From: Anthony Corbacho <anthonycorba...@apache.org> > Sent: Monday, December 18, 2017 3:02 PM > Subject: Re: [DISCUSS] Review process > To: <dev@zeppelin.apache.org> > > > I think for large PR (new f

Re: [DISCUSS] Review process

+1 What would be the rough heuristic people will be comfortable with- what is small and what is big? _ From: Anthony Corbacho <anthonycorba...@apache.org> Sent: Monday, December 18, 2017 3:02 PM Subject: Re: [DISCUSS] Review process To: <dev@zeppelin.apache

Re: [DISCUSS] Review process

> > > Also github has a tab for all PRs you are subscribed to, it shouldn’t be > > very hard to review all the approved ones again. > > > > > > From: Jongyoul Lee <jongy...@gmail.com> > > Sent: Monday, December 18, 2017 8:04:5

Re: [DISCUSS] Review process

. From: Jongyoul Lee <jongy...@gmail.com> Sent: Monday, December 18, 2017 8:04:51 AM To: dev@zeppelin.apache.org Subject: Re: [DISCUSS] Review process Good for summary. But actually, no committer merges without delay after reviewing it. So I thought we should clarify it officially

Re: [DISCUSS] Review process

lin/pull/2697 > > > > > > Thanks, > > Maksim Belousov > > > > -----Original Message- > > From: Jongyoul Lee [mailto:jongy...@gmail.com] > > Sent: Monday, December 18, 2017 12:12 PM > > To: dev <dev@zeppelin.apache.org> > > Subject: R

Re: [DISCUSS] Review process

8, 2017 12:12 PM > To: dev <dev@zeppelin.apache.org> > Subject: Re: [DISCUSS] Review process > > Thank you for the replying it. I think so > > On Mon, Dec 18, 2017 at 3:15 PM, Miquel Angel Andreu Febrer < > miquelangeland...@gmail.com> wrote: > > > I agr

RE: [DISCUSS] Review process

. [1] https://github.com/apache/zeppelin/pull/2697 Thanks, Maksim Belousov -Original Message- From: Jongyoul Lee [mailto:jongy...@gmail.com] Sent: Monday, December 18, 2017 12:12 PM To: dev <dev@zeppelin.apache.org> Subject: Re: [DISCUSS] Review process Thank you for the re

Re: [DISCUSS] Review process

Thank you for the replying it. I think so On Mon, Dec 18, 2017 at 3:15 PM, Miquel Angel Andreu Febrer < miquelangeland...@gmail.com> wrote: > I agree, ig is necessary to have no delay afternoon merging. I think it > will help speed up processes and help contributors > > El 18 dic. 2017 4:33,

Re: [DISCUSS] Review process

I agree, ig is necessary to have no delay afternoon merging. I think it will help speed up processes and help contributors El 18 dic. 2017 4:33, "Jongyoul Lee" escribió: Hi committers, I want to suggest one thing about our reviewing process. We have the policy to wait for

[DISCUSS] Review process

Hi committers, I want to suggest one thing about our reviewing process. We have the policy to wait for one-day before merging some PRs. AFAIK, It's because we reduce mistakes and prevent abuses from committing by owner without reviewing it concretely. I would like to change this policy to remove