[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-03 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3245 @jongyoul , pass of [CI](https://travis-ci.org/liuxunorg/zeppelin/builds/463120804) ---

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-03 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/3245 LGTM. Waiting for a pass of CI ---

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-03 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3245 @zjffdu , @felixcheung , Please help me review the code, thank you! ---

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-03 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3245 @zjffdu ,Thank you a for the suggestion, I wrote a comment on your issue. ---

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-03 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3245 @liuxunorg This is the change what I suggest https://github.com/zjffdu/zeppelin/commit/29593d74bac17f124e97fc43a4942e3365a12ed7 Could you verify whether it solve this issue ? ---

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-02 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3245 Hi @zjffdu , This bug fix contains test cases that are asynchronous to the runParagraph API. Should it be helpful for the zeppelin, or should the PR be merged first? When you submit a new

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-02 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3245 Hi @liuxunorg I would prefer to add another method ``` public boolean runParagraph(String noteId, String paragraphId,

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-02 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3245 merging if no more comment ---

[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...

2018-12-02 Thread liuxunorg
Github user liuxunorg commented on the issue: https://github.com/apache/zeppelin/pull/3245 Hi @felixcheung , I added a test case. Please help me review the code, thank you! ---