[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3258 in that case, can we make it build beam only when it has support for it. ie. build scala 2.10 - beam 2.0.0 build scala 2.11 - beam not included (but not failing) ---

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-17 Thread avnerl
Github user avnerl commented on the issue: https://github.com/apache/zeppelin/pull/3258 https://mvnrepository.com/artifact/org.apache.beam/beam-runners-flink ---

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-17 Thread avnerl
Github user avnerl commented on the issue: https://github.com/apache/zeppelin/pull/3258 > > that's what i did in: [ffca03c](https://github.com/apache/zeppelin/commit/ffca03cbd4c9d6cb756eef1b21a1319f8d8c5759) > > ah, that would make different versions of beam with scala-2.10

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-15 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3258 > that's what i did in: ffca03c ah, that would make different versions of beam with scala-2.10 or scala-2.11. is there a scio version that works with scala-2.11? what if

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-11 Thread avnerl
Github user avnerl commented on the issue: https://github.com/apache/zeppelin/pull/3258 > also we could upgrade beam interpreter to "require" beam 2.3 also (so it does build with scala-2.11) this's what i did in:

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3258 also we could upgrade beam interpreter to "require" beam 2.3 also (so it does build with scala-2.11) ---

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/3258 what about we don't build beam and scio if scala-2.11? ---

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-11 Thread avnerl
Github user avnerl commented on the issue: https://github.com/apache/zeppelin/pull/3258 do you think it's a good idea to tamper with beam version in `dev/change_scala_version.sh` too? build will not pass if you do not use the `-Pscala-2.11` profile explicitly ---

[GitHub] zeppelin issue #3258: fix beam-runners-flink and zeppelin-scio scala version...

2018-12-11 Thread avnerl
Github user avnerl commented on the issue: https://github.com/apache/zeppelin/pull/3258 you are right. it didn't make sense. the reason i did this is because i wanted the build to pass. i remove the beam interpreter afterwards as i dint need it. last 2 commits is reverting back