Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/1763
Thanks @fellixcheng, would I maybe have to retrigger the build for the
green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/1763
Hi @felixcheung, it seems the last change was by you. Could you please take
a look? I think I am not used to this and also not sure if this change is good
or not but just decided to submit
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/1763
Thank you, @AhyoungRyu.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/1763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/1763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
oops. I haven't. Will check that too while I am here.
BTW, my understanding is that we need this one as well since Spark still
can be compiled against Scala 2.11.x, am I in the right
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
This is a WIP. We should wait for Spark 2.4.0.
cc @zjffdu and @felixcheung
---
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/zeppelin/pull/3206
[WIP][ZEPPELIN-3810] Support Spark 2.4
### What is this PR for?
Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see
SPARK-24418).
There are two problems
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/3206
[WIP][ZEPPELIN-3810] Support Spark 2.4
### What is this PR for?
Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see
SPARK-24418).
There are two problems
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/3206
---
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/3206
---
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/3206
[WIP][ZEPPELIN-3810] Support Spark 2.4
### What is this PR for?
Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see
SPARK-24418).
There are two problems
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3034
> Spark 2.4 will officially support Scala 2.12, so it will be great if
Zeppelin will support it together with Spark. And also, there are some libs
that are Scala 2.12 o
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/3206
[WIP][ZEPPELIN-3810] Support Spark 2.4
### What is this PR for?
Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see
SPARK-24418).
There are two problems
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/3206
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
It should be usable if the changes is cherry-picked properly. This PR
basically just replace one line:
https://github.com/apache/zeppelin/blob/v0.8.0/spark/scala-2.11/src/main/scala
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
The error message:
```
[ERROR]
/home/cloud-user/ajay/code/csf-cc-zeppelin-k8szep/spark/scala-2.11/src/main/scala/org/apache/zeppelin/spark/SparkScala211Interpreter.scala:37
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Does that happen only with this code changes? The change here does not
touch signature at `class SparkScala211Interpreter(` and the error message
looks pretty unrelated. The whole change
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
I also tested this patch against Spark RC5.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
BTW, I tested this via my Travis CI -
https://travis-ci.org/HyukjinKwon/zeppelin/builds/448215776. Tests seems got
passed.
---
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/3206
---
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/3206
[WIP][ZEPPELIN-3810] Support Spark 2.4
### What is this PR for?
Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see
SPARK-24418).
There are two problems
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Thanks for confirmation.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Nope, it will work for both 2.11.8 and 2.11.12. I manually checked. This
change only uses the methods existing in both 2.11.8 and 2.11.12 at Scala.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Thank you all!!
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Thank you guys!
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
This should be ready for a look as is. I already tested Spark 2.4.0.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Ah, yeap. sure.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
Hey all ~ could this get in by any change maybe?
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3253
Spark 2.4 support was added at
https://github.com/apache/zeppelin/pull/3206, which exactly addresses the issue
you faced. This will be available in new release of Zeppelin.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3253
I'm not aware of release plan in Zeppelin since I'm just one of
contributors. For the current status, the Spark should be downgraded as far as
I can tell.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3033
Hey @zjffdu, busy? I can take this over - looks there's only minor conflict.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3034
Hey Jeff, I can take over this one too if you're busy since I took a look
for similar code paths.
---
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/zeppelin/pull/3253
[ZEPPELIN-3551] Upgrade Scala to 2.11.12
### What is this PR for?
This is just to update scala to 2.11.12 which to be consistent with spark
(SPARK-24418).
This PR takes over
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/zeppelin/pull/3253
---
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/3253
[ZEPPELIN-3551] Upgrade Scala to 2.11.12
### What is this PR for?
This is just to update scala to 2.11.12 which to be consistent with spark
(SPARK-24418).
This PR takes over
Github user HyukjinKwon commented on the issue:
https://github.com/apache/zeppelin/pull/3206
This fix is not released yet. This PR exactly fixes the problem you faced.
This fix will be available in the next release of Zeppelin.
---
40 matches
Mail list logo
