[
https://issues.apache.org/jira/browse/ZOOKEEPER-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574305#comment-16574305
]
Hadoop QA commented on ZOOKEEPER-3116:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2040/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 84.79 MB...]
[exec]
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/582
+1
Thanks @eolivelli. The new change looks good to me.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3116:
--
Labels: pull-request-available (was: )
> Make the DataTree.approximateDataSize
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/594
[ZOOKEEPER-3116] Make the DataTree.approximateDataSize more efficient
Cache the approximate data tree size, and update it when txns applied to
data tree, this could make this query not that
Fangmin Lv created ZOOKEEPER-3116:
-
Summary: Make the DataTree.approximateDataSize more efficient
Key: ZOOKEEPER-3116
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3116
Project: ZooKeeper
Github user MichaelScofield commented on the issue:
https://github.com/apache/zookeeper/pull/584
@anmolnar Sorry for the late response. I think what @lvfangmin wants to put
here, is that `createNode()` is called in single thread, so the race condition
does not exist. **IF** there
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/560#discussion_r208781421
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -399,8 +399,30 @@ public void save(DataTree dataTree,
Brian Nixon created ZOOKEEPER-3115:
--
Summary: Delete snapshot file on error
Key: ZOOKEEPER-3115
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3115
Project: ZooKeeper
Issue Type:
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1490/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 40.42 KB...]
[junit] Running
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/590
There is a PR in the Jira few years ago, which uses BitMap as well, but it
sacrificed the performance on triggering watches, this patch improved that and
uses lazy clean up for cleaning those
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/590
Based on internal benchmark, this may save more than 95% memory usage on
concentrate watches scenario. I'm working on adding some micro benchmark.
In the original Jira, @phunt also
Github user suyogmapara commented on the issue:
https://github.com/apache/zookeeper/pull/567
@anmholnar Sorry I got caught up in other work, I will update this PR with
the documents today.
---
Github user sl4mmy commented on the issue:
https://github.com/apache/zookeeper/pull/581
@anmolnar Done, and it passed. Thanks!
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2039/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.09 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573504#comment-16573504
]
Hadoop QA commented on ZOOKEEPER-3101:
--
+1 overall. GitHub Pull Request Build
+1
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/590
@lvfangmin interesting.where can we find a benchmark which shows how this
pr improves the memory?
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/584
sorry ,too embarrassed.I was wrong about my previous opinion. look at my
thread-pool [unit
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/590
@lvfangmin In which case you need to add exceptions to
`config/findbugsExcludeFile.xml`.
---
Hi team,
I compiled zookeeper 3.4.12 c client on solaris 11 machine and trying to test
it through cli.sh. Here is the sample code that I changed in cli.c. Whenever I
run the ./cli_mt file it always throws below error
2018-08-08 09:49:44,437:18000(0x2):ZOO_ERROR@handle_socket_error_msg@1670:
Github user brettKK commented on the issue:
https://github.com/apache/zookeeper/pull/496
@anmolnar , thanks for your attention, I will work on it on this weekend
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2038/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 81.80 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573271#comment-16573271
]
Hadoop QA commented on ZOOKEEPER-236:
-
-1 overall. GitHub Pull Request Build
+1
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
Btw. I think it's perfectly fine to choose option 2.
I was able to build ZooKeeper C client and run the tests on Ubuntu 18.04
with CMake.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/567
I still miss the documentation change here and I think it would be better
to commit it together with the code change, but I'm happy to approve it if you
create a separate Jira for that.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/567
@suyogmapara Would you please trigger the Jenkins build?
@maoling @breed Do approve this commit?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/584
@MichaelScofield Would you please respond to @lvfangmin 's comment?
If this change doesn't make creating ephemerals thread-safe, there's no
value in committing it.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/496
@brettKK Can we move on?
@phunt Do you approve this change?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/581
@sl4mmy Would you please trigger another Jenkins build, so that we get a
green one and I can commit.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
@phunt I ran a few cycles with the curl commit that you linked and here're
my results:
- there's no such thing with autotools that "check for a macro existence
and use it if present",
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1076/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 62.57 KB...]
[junit] Running
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572926#comment-16572926
]
Hadoop QA commented on ZOOKEEPER-3112:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2037/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.90 MB...]
[exec] +1
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm If you approve the change, please commit it. I don't want to commit
my PR. Thanks!
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r208507660
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -122,8 +122,8 @@
final Map outstandingChangesForPath =
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572791#comment-16572791
]
Hudson commented on ZOOKEEPER-2926:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #143 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572792#comment-16572792
]
Hudson commented on ZOOKEEPER-3110:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #143 (See
Github user PhantomThief commented on the issue:
https://github.com/apache/zookeeper/pull/592
@anmolnar a bad news is, after my test case, it won't fix the fd leak...so
I'm adding an another patch.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572773#comment-16572773
]
Hadoop QA commented on ZOOKEEPER-3109:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2036/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 71.62 MB...]
[exec]
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/588
Rebased the code to resolve the conflict.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/590
@hanm the code complained by Findbug are all correct and expected:
1. System.exit if create watch manager failed in DataTree
It's using the factory to create the watch manager based
42 matches
Mail list logo
