[jira] [Created] (ZOOKEEPER-3246) Publish more stats when learner gets a diff, full snapshot, or does a truncate when it connects with the leader

Dinesh Appavoo created ZOOKEEPER-3246: - Summary: Publish more stats when learner gets a diff, full snapshot, or does a truncate when it connects with the leader Key: ZOOKEEPER-3246 URL:

[jira] [Created] (ZOOKEEPER-3245) Add useful metrics for ZK pipeline and request/server states

Jie Huang created ZOOKEEPER-3245: Summary: Add useful metrics for ZK pipeline and request/server states Key: ZOOKEEPER-3245 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3245 Project:

[GitHub] jhuan31 closed pull request #769: ZOOKEEPER-3242: Add server side connecting throttling

jhuan31 closed pull request #769: ZOOKEEPER-3242: Add server side connecting throttling URL: https://github.com/apache/zookeeper/pull/769 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jhuan31 opened a new pull request #769: ZOOKEEPER-3242: Add server side connecting throttling

jhuan31 opened a new pull request #769: ZOOKEEPER-3242: Add server side connecting throttling URL: https://github.com/apache/zookeeper/pull/769 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jhuan31 closed pull request #769: ZOOKEEPER-3242: Add server side connecting throttling

jhuan31 closed pull request #769: ZOOKEEPER-3242: Add server side connecting throttling URL: https://github.com/apache/zookeeper/pull/769 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jhuan31 opened a new pull request #769: ZOOKEEPER-3242: Add server side connecting throttling

jhuan31 opened a new pull request #769: ZOOKEEPER-3242: Add server side connecting throttling URL: https://github.com/apache/zookeeper/pull/769 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (ZOOKEEPER-3191) Code clean up

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740969#comment-16740969 ] maoling commented on ZOOKEEPER-3191: [~achernatsky] * the code about 1 in the master branch has

[jira] [Updated] (ZOOKEEPER-3191) Code clean up

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3191: --- Description: Working on some feature for Zookeeper I've found strange and redundant code in

[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740916#comment-16740916 ] Brian Nixon commented on ZOOKEEPER-3240: [~hanm] could it be that the unclosed/unreaped

[GitHub] enixon closed pull request #767: ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so…

enixon closed pull request #767: ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so… URL: https://github.com/apache/zookeeper/pull/767 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] enixon opened a new pull request #767: ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so…

enixon opened a new pull request #767: ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so… URL: https://github.com/apache/zookeeper/pull/767 …cket This is an automated message from the Apache Git Service.

[GitHub] enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size

enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-453700900 Is there a good unit test to extend to check this behavior or ought I write an entirely new one?

[GitHub] enixon opened a new pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size

enixon opened a new pull request #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (ZOOKEEPER-3244) Add option to snapshot based on log size

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3244: -- Labels: pull-request-available (was: ) > Add option to snapshot based on log size

[jira] [Created] (ZOOKEEPER-3244) Add option to snapshot based on log size

Brian Nixon created ZOOKEEPER-3244: -- Summary: Add option to snapshot based on log size Key: ZOOKEEPER-3244 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3244 Project: ZooKeeper Issue

[GitHub] ivmaykov commented on issue #723: ZOOKEEPER-3202: Add timing margin to improve reliability of testClientServerSSL()

ivmaykov commented on issue #723: ZOOKEEPER-3202: Add timing margin to improve reliability of testClientServerSSL() URL: https://github.com/apache/zookeeper/pull/723#issuecomment-453700136 +1 (non-binding) This is an

[GitHub] ivmaykov commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-453699796 I can review this early next week, please wait for that before merging :) This

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-453699684 @anmolnar I might be able to fix the netty3 issues in reconfig tests. Could be that it's not a

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-453699373 It's also possible to release 3.5.5 with Quorum TLS support but without client TLS support

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-453699240 I can review the backport next week. It is risky, ideally someone would be able to take a

[GitHub] ivmaykov commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list

ivmaykov commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list URL: https://github.com/apache/zookeeper/pull/744#issuecomment-453698480 @anmolnar it doesn't fail when rebased on top of #681. I don't want to spend too much time figuring out why, since I

[GitHub] ivmaykov commented on issue #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation

ivmaykov commented on issue #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation URL: https://github.com/apache/zookeeper/pull/710#issuecomment-453695821 I think this is ready to merge This is an automated

[GitHub] ivmaykov commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list

ivmaykov commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list URL: https://github.com/apache/zookeeper/pull/744#issuecomment-453694475 @anmolnar I will take a look. That seems pretty weird, and I don't think we had that failure on our internal fork

[GitHub] enixon closed pull request #767: ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so…

enixon closed pull request #767: ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so… URL: https://github.com/apache/zookeeper/pull/767 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] enixon opened a new pull request #767: ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so…

enixon opened a new pull request #767: ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so… URL: https://github.com/apache/zookeeper/pull/767 …cket This is an automated message from the Apache Git Service.

[jira] [Updated] (ZOOKEEPER-3242) Add server side connecting throttling

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3242: -- Labels: pull-request-available (was: ) > Add server side connecting throttling >

[GitHub] jhuan31 opened a new pull request #769: ZOOKEEPER-3242: Add server side connecting throttling

jhuan31 opened a new pull request #769: ZOOKEEPER-3242: Add server side connecting throttling URL: https://github.com/apache/zookeeper/pull/769 This is an automated message from the Apache Git Service. To respond to the

[GitHub] enixon commented on a change in pull request #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read …

enixon commented on a change in pull request #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read … URL: https://github.com/apache/zookeeper/pull/684#discussion_r247273955 ## File path:

[GitHub] enixon commented on a change in pull request #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read …

enixon commented on a change in pull request #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read … URL: https://github.com/apache/zookeeper/pull/684#discussion_r247275731 ## File path:

[GitHub] enixon commented on a change in pull request #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read …

enixon commented on a change in pull request #684: ZOOKEEPER-3180: Add response cache to improve the throughput of read … URL: https://github.com/apache/zookeeper/pull/684#discussion_r247275626 ## File path:

Branch 3.4 and Maven...some problems found while porting Spotbugs patch

Hi, we have some problems on 3.4 branch with Maven migration. 1) There are references to 3.6.0-SNAPSHOT https://github.com/apache/zookeeper/blob/b8044eae3e700650a646969352a508122a4e5a98/zookeeper-contrib/zookeeper-contrib-loggraph/pom.xml#L26 2) Build fails with this error (after fixing poms):

ZooKeeper_branch34_openjdk7 - Build # 2177 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2177/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 44.77 KB...] [junit] Running

[jira] [Created] (ZOOKEEPER-3243) Add server side request throttling

Jie Huang created ZOOKEEPER-3243: Summary: Add server side request throttling Key: ZOOKEEPER-3243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3243 Project: ZooKeeper Issue Type:

[jira] [Created] (ZOOKEEPER-3242) Add server side connecting throttling

Jie Huang created ZOOKEEPER-3242: Summary: Add server side connecting throttling Key: ZOOKEEPER-3242 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3242 Project: ZooKeeper Issue Type:

[GitHub] jhuan31 closed pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to verify the ensemble name

jhuan31 closed pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to verify the ensemble name URL: https://github.com/apache/zookeeper/pull/768 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jhuan31 opened a new pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to verify the ensemble name

jhuan31 opened a new pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to verify the ensemble name URL: https://github.com/apache/zookeeper/pull/768 This is an automated message from the Apache Git Service. To

[jira] [Updated] (ZOOKEEPER-3239) Adding EnsembleAuthProvider to verify the ensemble name

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3239: -- Labels: pull-request-available (was: ) > Adding EnsembleAuthProvider to verify

[GitHub] jhuan31 opened a new pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to verify the ensemble name

jhuan31 opened a new pull request #768: ZOOKEEPER-3239: Adding EnsembleAuthProvider to verify the ensemble name URL: https://github.com/apache/zookeeper/pull/768 This is an automated message from the Apache Git Service. To

[GitHub] eolivelli closed pull request #763: ZOOKEEPER-3223: Configure Spotbugs

eolivelli closed pull request #763: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/763 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] anmolnar commented on issue #763: ZOOKEEPER-3223: Configure Spotbugs

anmolnar commented on issue #763: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/763#issuecomment-453511269 Committed to branch-3.5 Thanks @eolivelli ! Please close this PR. This is an

[GitHub] nkalmar closed pull request #765: MAVEN MIGRATION - 3.5 - ZOOKEEPER-3171

nkalmar closed pull request #765: MAVEN MIGRATION - 3.5 - ZOOKEEPER-3171 URL: https://github.com/apache/zookeeper/pull/765 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] nkalmar closed pull request #766: MAVEN MIGRATION - 3.4 - ZOOKEEPER-3171

nkalmar closed pull request #766: MAVEN MIGRATION - 3.4 - ZOOKEEPER-3171 URL: https://github.com/apache/zookeeper/pull/766 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] anmolnar commented on issue #766: MAVEN MIGRATION - 3.4 - ZOOKEEPER-3171

anmolnar commented on issue #766: MAVEN MIGRATION - 3.4 - ZOOKEEPER-3171 URL: https://github.com/apache/zookeeper/pull/766#issuecomment-453445748 Committed to branch-3.4. Thanks @nkalmar ! Please close this PR. This is an

[GitHub] anmolnar commented on issue #765: MAVEN MIGRATION - 3.5 - ZOOKEEPER-3171

anmolnar commented on issue #765: MAVEN MIGRATION - 3.5 - ZOOKEEPER-3171 URL: https://github.com/apache/zookeeper/pull/765#issuecomment-453444838 Committed to branch-3.5. Thanks @nkalmar ! Please close this PR. This is an

[GitHub] hanm commented on issue #757: ZOOKEEPER-3236 - Upgrade BouncyCastle

hanm commented on issue #757: ZOOKEEPER-3236 - Upgrade BouncyCastle URL: https://github.com/apache/zookeeper/pull/757#issuecomment-453430471 >> don't we have a list of third party libraries and licenses to update? not sure about this - typically update dependencies to later / latest

[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740161#comment-16740161 ] Michael Han commented on ZOOKEEPER-3240: [~nixon] Good catch, the fix looks reasonable.