[GitHub] [zookeeper] lvfangmin commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

lvfangmin commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474205055 @eolivelli thanks for making those changes, looks good to me in general, I have the same question

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader

jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#discussion_r266737276 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderMetricsTest.java ## @@

[GitHub] [zookeeper] lvfangmin commented on issue #800: ZOOKEEPER-3268: Add commit processor metrics

lvfangmin commented on issue #800: ZOOKEEPER-3268: Add commit processor metrics URL: https://github.com/apache/zookeeper/pull/800#issuecomment-474204490 @anmolnar is this looking good to you? This is an automated message from

[GitHub] [zookeeper] lvfangmin commented on issue #853: ZOOKEEPER-3316: Remove unused code in SyncRequestProcessor

lvfangmin commented on issue #853: ZOOKEEPER-3316: Remove unused code in SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/853#issuecomment-474202012 I'll merge it tomorrow if there is no objection from the other reviewers.

ZooKeeper_branch35_jdk8 - Build # 1348 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1348/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.28 KB...] [junit] Tests run: 1, Failures:

[GitHub] [zookeeper] jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] jhuan31 closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

jhuan31 closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader

jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#discussion_r266731253 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java ## @@ -101,6

[GitHub] [zookeeper] maoling commented on issue #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255

maoling commented on issue #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255 URL: https://github.com/apache/zookeeper/pull/832#issuecomment-474186545 - @lvfangmin the `validateServerId` logic in `EphemeralType` is not a good place.

[GitHub] [zookeeper] anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r266713330 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r266712939 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r266712939 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[jira] [Commented] (ZOOKEEPER-2168) Add C APIs for new createContainer Methods

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795577#comment-16795577 ] Hudson commented on ZOOKEEPER-2168: --- SUCCESS: Integrated in Jenkins build

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #856: ZOOKEEPER-3319: Add metrics for follower and observer

jhuan31 commented on a change in pull request #856: ZOOKEEPER-3319: Add metrics for follower and observer URL: https://github.com/apache/zookeeper/pull/856#discussion_r266711644 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java ## @@

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

jhuan31 commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#discussion_r266711426 ## File path:

[GitHub] [zookeeper] anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs

anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831#discussion_r266710758 ## File path:

[jira] [Updated] (ZOOKEEPER-3324) Add read/write metrics for top level znodes

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3324: -- Labels: pull-request-available (was: ) > Add read/write metrics for top level

[GitHub] [zookeeper] jhuan31 opened a new pull request #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes

jhuan31 opened a new pull request #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes URL: https://github.com/apache/zookeeper/pull/860 another example of Set metrics. This is an automated message from the

[GitHub] [zookeeper] ccma14 commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs

ccma14 commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831#discussion_r266701482 ## File path: zookeeper-client/zookeeper-client-c/src/mt_adaptor.c

[GitHub] [zookeeper] anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs

anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831#discussion_r266697000 ## File path:

[GitHub] [zookeeper] anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs

anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831#discussion_r266697000 ## File path:

[GitHub] [zookeeper] anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474153585 Thanks @eolivelli . Great stuff. Unfortunately I kinda lost tracking the conversation in the

[GitHub] [zookeeper] anmolnar commented on issue #33: ZOOKEEPER-2168 - first pass at C changes for containers

anmolnar commented on issue #33: ZOOKEEPER-2168 - first pass at C changes for containers URL: https://github.com/apache/zookeeper/pull/33#issuecomment-474149570 Committed by #838 This is an automated message from the Apache

[GitHub] [zookeeper] anmolnar closed pull request #33: ZOOKEEPER-2168 - first pass at C changes for containers

anmolnar closed pull request #33: ZOOKEEPER-2168 - first pass at C changes for containers URL: https://github.com/apache/zookeeper/pull/33 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] anmolnar commented on issue #838: ZOOKEEPER-2168 Add C APIs for new createContainer Methods

anmolnar commented on issue #838: ZOOKEEPER-2168 Add C APIs for new createContainer Methods URL: https://github.com/apache/zookeeper/pull/838#issuecomment-474149379 Merged to 3.5 and master branches. Thanks @meszibalu ! This

[jira] [Resolved] (ZOOKEEPER-2168) Add C APIs for new createContainer Methods

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2168. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue

[GitHub] [zookeeper] asfgit closed pull request #838: ZOOKEEPER-2168 Add C APIs for new createContainer Methods

asfgit closed pull request #838: ZOOKEEPER-2168 Add C APIs for new createContainer Methods URL: https://github.com/apache/zookeeper/pull/838 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] eolivelli commented on a change in pull request #856: ZOOKEEPER-3319: Add metrics for follower and observer

eolivelli commented on a change in pull request #856: ZOOKEEPER-3319: Add metrics for follower and observer URL: https://github.com/apache/zookeeper/pull/856#discussion_r266676199 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java ## @@

[GitHub] [zookeeper] eolivelli commented on a change in pull request #856: ZOOKEEPER-3319: Add metrics for follower and observer

eolivelli commented on a change in pull request #856: ZOOKEEPER-3319: Add metrics for follower and observer URL: https://github.com/apache/zookeeper/pull/856#discussion_r266676004 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java ## @@

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor

jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#discussion_r266645839 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush

enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush URL: https://github.com/apache/zookeeper/pull/851#issuecomment-474044383 @lvfangmin I'm not sure that we have performance data to share on this setting. We do use 20ms internally, is there a

[jira] [Commented] (ZOOKEEPER-3318) Add a complete backup mechanism for zookeeper internal

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795253#comment-16795253 ] Brian Nixon commented on ZOOKEEPER-3318: This would be great! > Add a complete backup

[jira] [Updated] (ZOOKEEPER-3323) Add TxnSnapLog metrics

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3323: -- Labels: pull-request-available (was: ) > Add TxnSnapLog metrics >

[GitHub] [zookeeper] jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] eolivelli commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor

eolivelli commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#discussion_r266555624 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor

jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#discussion_r266551859 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java ##

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor

jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#discussion_r266550581 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java ## @@ -78,6

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor

jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#discussion_r266550137 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java ##

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor

jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#discussion_r266547276 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java ##

[GitHub] [zookeeper] eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader

eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#discussion_r266537584 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderMetricsTest.java ##

[GitHub] [zookeeper] eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader

eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#discussion_r266520216 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java ## @@ -101,6

ZooKeeper_branch34_openjdk8 - Build # 267 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/267/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 44.63 KB...] [junit] Running

[jira] [Created] (ZOOKEEPER-3328) misc metrics

Jie Huang created ZOOKEEPER-3328: Summary: misc metrics Key: ZOOKEEPER-3328 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3328 Project: ZooKeeper Issue Type: Sub-task

[jira] [Created] (ZOOKEEPER-3327) Add unrecoverable error count

Jie Huang created ZOOKEEPER-3327: Summary: Add unrecoverable error count Key: ZOOKEEPER-3327 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3327 Project: ZooKeeper Issue Type: Sub-task

[jira] [Created] (ZOOKEEPER-3326) Add session/connection related metrics

Jie Huang created ZOOKEEPER-3326: Summary: Add session/connection related metrics Key: ZOOKEEPER-3326 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3326 Project: ZooKeeper Issue Type:

[jira] [Created] (ZOOKEEPER-3325) Add unavailable time metrics for quorum peers

Jie Huang created ZOOKEEPER-3325: Summary: Add unavailable time metrics for quorum peers Key: ZOOKEEPER-3325 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3325 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3324) Add read/write metrics for top level znodes

Jie Huang created ZOOKEEPER-3324: Summary: Add read/write metrics for top level znodes Key: ZOOKEEPER-3324 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3324 Project: ZooKeeper Issue

[jira] [Created] (ZOOKEEPER-3323) Add TxnSnapLog metrics

Jie Huang created ZOOKEEPER-3323: Summary: Add TxnSnapLog metrics Key: ZOOKEEPER-3323 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3323 Project: ZooKeeper Issue Type: Sub-task

[GitHub] [zookeeper] jhuan31 opened a new pull request #858: ZOOKEEPER-3321: Add metrics for Leader

jhuan31 opened a new pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] jhuan31 closed pull request #858: ZOOKEEPER-3321: Add metrics for Leader

jhuan31 closed pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (ZOOKEEPER-2621) ZooKeeper doesn't start on MINGW32 (Windows)

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794868#comment-16794868 ] Hudson commented on ZOOKEEPER-2621: --- SUCCESS: Integrated in Jenkins build

Re: Mavenized Zookeeper Roadmap

Hi all, When maven migration started, I created a google docs that planned the migration ( https://docs.google.com/document/d/1WXqhaPlCwchcWc8RCEzbCmVa4WbBDlfR3GQngikGjqc/edit?usp=sharing ). It was open for suggestions, and there are quite some comments on it. Anyway, the idea was something like:

[GitHub] [zookeeper] maoling commented on issue #688: reduce session revalidation time after zxid roll over

maoling commented on issue #688: reduce session revalidation time after zxid roll over URL: https://github.com/apache/zookeeper/pull/688#issuecomment-473825950 @TyqITstudent - I have some other concern: comparing the timestamp between leader and follwers in a distributed system may

[jira] [Commented] (ZOOKEEPER-2621) ZooKeeper doesn't start on MINGW32 (Windows)

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794808#comment-16794808 ] Hudson commented on ZOOKEEPER-2621: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #444 (See

[jira] [Commented] (ZOOKEEPER-3317) dynamic file for reconfig should support the relative path

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794778#comment-16794778 ] Enrico Olivelli commented on ZOOKEEPER-3317: Yes. I will assign this issue to myself as