[GitHub] [zookeeper] maoling commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-03-19 Thread GitBox
maoling commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r267165855 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-03-19 Thread GitBox
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r267153406 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[GitHub] [zookeeper] anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-19 Thread GitBox
anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474637051 Not a big difference though if you don't want to use the extra features of `AtomicReference`.

Failed: ZOOKEEPER-1621 PreCommit Build #3738

2019-03-19 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1621 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3738/ ### ## LAST 60 LINES OF THE CONSOLE ###

[GitHub] [zookeeper] anmolnar commented on issue #439: ZOOKEEPER-1621: Delete and skip txn log with incomplete header

2019-03-19 Thread GitBox
anmolnar commented on issue #439: ZOOKEEPER-1621: Delete and skip txn log with incomplete header URL: https://github.com/apache/zookeeper/pull/439#issuecomment-474636132 @abhishekrai please rebase this. This is an automated

[GitHub] [zookeeper] anmolnar commented on issue #438: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers

2019-03-19 Thread GitBox
anmolnar commented on issue #438: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers URL: https://github.com/apache/zookeeper/pull/438#issuecomment-474635872 Already resolved by @lavacat . Thanks. This

[GitHub] [zookeeper] anmolnar closed pull request #438: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers

2019-03-19 Thread GitBox
anmolnar closed pull request #438: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers URL: https://github.com/apache/zookeeper/pull/438 This is an automated message from the Apache Git Service. To

[jira] [Updated] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2338: -- Labels: pull-request-available (was: ) > c bindings should create socket's with

[GitHub] [zookeeper] anmolnar commented on issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defined

2019-03-19 Thread GitBox
anmolnar commented on issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defined URL: https://github.com/apache/zookeeper/pull/427#issuecomment-474635544 @fr0stbyte @phunt Do you still want this patch to be committed? 3.5 gets stable soon, Jira has already been closed, I'd

[GitHub] [zookeeper] anmolnar commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894

2019-03-19 Thread GitBox
anmolnar commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894 URL: https://github.com/apache/zookeeper/pull/363#issuecomment-474634875 ping @xoiss This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] anmolnar commented on issue #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891

2019-03-19 Thread GitBox
anmolnar commented on issue #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891 URL: https://github.com/apache/zookeeper/pull/360#issuecomment-474634769 ping @xoiss This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] anmolnar commented on issue #247: ZOOKEEPER-2778: Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2019-03-19 Thread GitBox
anmolnar commented on issue #247: ZOOKEEPER-2778: Potential server deadlock between follower sync with leader and follower receiving external connection requests. URL: https://github.com/apache/zookeeper/pull/247#issuecomment-474634011 Resolved by #707

[GitHub] [zookeeper] anmolnar closed pull request #247: ZOOKEEPER-2778: Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2019-03-19 Thread GitBox
anmolnar closed pull request #247: ZOOKEEPER-2778: Potential server deadlock between follower sync with leader and follower receiving external connection requests. URL: https://github.com/apache/zookeeper/pull/247 This is

[GitHub] [zookeeper] enixon commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-19 Thread GitBox
enixon commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474633770 I like this version. My only comment is to second with @anmolnar 's question about AtomicReference.

[jira] [Updated] (ZOOKEEPER-3326) Add session/connection related metrics

2019-03-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3326: -- Labels: pull-request-available (was: ) > Add session/connection related metrics >

[GitHub] [zookeeper] jhuan31 opened a new pull request #861: ZOOKEEPER-3326: Add session/connection related metrics

2019-03-19 Thread GitBox
jhuan31 opened a new pull request #861: ZOOKEEPER-3326: Add session/connection related metrics URL: https://github.com/apache/zookeeper/pull/861 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-19 Thread GitBox
anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474594384 @eolivelli I got you, I've just found the `enum` more readable (no need for `getMetrics()` call). In

[jira] [Commented] (ZOOKEEPER-3320) Leader election port stop listen when hostname unresolvable for some time

2019-03-19 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796341#comment-16796341 ] Brian Nixon commented on ZOOKEEPER-3320: This is an interesting error case! I would expect

[jira] [Resolved] (ZOOKEEPER-3325) Add unavailable time metrics for quorum peers

2019-03-19 Thread Jie Huang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Huang resolved ZOOKEEPER-3325. -- Resolution: Later These two metrics require ZabState. should be upstreamed together with

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-03-19 Thread GitBox
jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859#discussion_r266963336 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java

[jira] [Resolved] (ZOOKEEPER-723) ephemeral parent znodes

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar resolved ZOOKEEPER-723. -- Resolution: Duplicate > ephemeral parent znodes > --- > >

[jira] [Commented] (ZOOKEEPER-723) ephemeral parent znodes

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796073#comment-16796073 ] Norbert Kalmar commented on ZOOKEEPER-723: -- This functionality is implemented by Container

[GitHub] [zookeeper] Randgalt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255

2019-03-19 Thread GitBox
Randgalt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255 URL: https://github.com/apache/zookeeper/pull/832#discussion_r266876255 ## File path:

[GitHub] [zookeeper] Randgalt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255

2019-03-19 Thread GitBox
Randgalt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255 URL: https://github.com/apache/zookeeper/pull/832#discussion_r266876255 ## File path:

[jira] [Updated] (ZOOKEEPER-2750) Document SSL Support for Atomic Broadcast protocol

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-2750: -- Labels: pull-request-available ssl-tls (was: pull-request-available) > Document

[jira] [Assigned] (ZOOKEEPER-3053) add remove watches capabilities to the c cli

2019-03-19 Thread Tamas Penzes (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes reassigned ZOOKEEPER-3053: --- Assignee: Balazs Meszaros > add remove watches capabilities to the c cli >

Failed: ZOOKEEPER-2192 PreCommit Build #3737

2019-03-19 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2192 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3737/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Updated] (ZOOKEEPER-3229) [TLS] add AES-256 ciphers to default cipher list

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3229: -- Labels: pull-request-available ssl-tls (was: pull-request-available) > [TLS] add

[jira] [Updated] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3194: -- Labels: pull-request-available ssl-tls (was: pull-request-available) > Quorum TLS

[jira] [Updated] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-236: - Labels: pull-request-available ssl ssl-tls (was: pull-request-available ssl) > SSL

[jira] [Updated] (ZOOKEEPER-2125) SSL on Netty client-server communication

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-2125: -- Labels: ssl-tls (was: ) > SSL on Netty client-server communication >

[jira] [Updated] (ZOOKEEPER-3176) Quorum TLS - add SSL config options

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3176: -- Labels: pull-request-available ssl-tls (was: pull-request-available) > Quorum TLS

[jira] [Updated] (ZOOKEEPER-3195) TLS - disable client-initiated renegotiation

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3195: -- Labels: pull-request-available ssl-tls (was: pull-request-available) > TLS -

[jira] [Updated] (ZOOKEEPER-1736) Zookeeper SASL authentication allows anonymus users to log in

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-1736: -- Labels: ssl-tls (was: ) > Zookeeper SASL authentication allows anonymus users to

[jira] [Updated] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3172: -- Labels: pull-request-available ssl-tls (was: pull-request-available) > Quorum TLS

[jira] [Updated] (ZOOKEEPER-3174) Quorum TLS - support reloading trust/key store

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3174: -- Labels: pull-request-available ssl-tls (was: pull-request-available) > Quorum TLS

[jira] [Updated] (ZOOKEEPER-3228) [TLS] Fix key usage extension in test certs

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3228: -- Labels: ssl-tls (was: ) > [TLS] Fix key usage extension in test certs >

[jira] [Updated] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3173: -- Labels: pull-request-available ssl-tls (was: pull-request-available) > Quorum TLS

[jira] [Updated] (ZOOKEEPER-3175) Quorum TLS - test improvements

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3175: -- Labels: ssl-tls (was: ) > Quorum TLS - test improvements >

[jira] [Updated] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2019-03-19 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-2122: -- Labels: build pull-request-available security ssl-tls (was: build

[jira] [Updated] (ZOOKEEPER-834) Allow ephemeral znodes to have children created only by the owner session.

2019-03-19 Thread Tamas Penzes (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-834: --- Labels: container_znode_type (was: ) > Allow ephemeral znodes to have children created

[jira] [Updated] (ZOOKEEPER-2591) The deletion of Container znode doesn't check ACL delete permission

2019-03-19 Thread Tamas Penzes (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2591: Labels: container_znode_type (was: ) > The deletion of Container znode doesn't check

[jira] [Updated] (ZOOKEEPER-2192) Port "Introduce new ZNode type: container" to 3.4.x

2019-03-19 Thread Tamas Penzes (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2192: Labels: container_znode_type (was: ) > Port "Introduce new ZNode type: container" to

[jira] [Updated] (ZOOKEEPER-723) ephemeral parent znodes

2019-03-19 Thread Tamas Penzes (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-723: --- Labels: container_znode_type (was: ) > ephemeral parent znodes > ---

[jira] [Updated] (ZOOKEEPER-2168) Add C APIs for new createContainer Methods

2019-03-19 Thread Tamas Penzes (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2168: Labels: container_znode_type pull-request-available (was: pull-request-available) >

[jira] [Updated] (ZOOKEEPER-2163) Introduce new ZNode type: container

2019-03-19 Thread Tamas Penzes (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated ZOOKEEPER-2163: Labels: container_znode_type pull-request-available (was: pull-request-available) >

[GitHub] [zookeeper] eolivelli commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-03-19 Thread GitBox
eolivelli commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859#discussion_r266860647 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java

ZooKeeper_branch34_openjdk8 - Build # 268 - Still Failing

2019-03-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/268/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 44.21 KB...] [junit] Running

[GitHub] [zookeeper] eolivelli commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-19 Thread GitBox
eolivelli commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474259942 > Thanks @eolivelli . Great stuff. > > Unfortunately I kinda lost tracking the conversation

[GitHub] [zookeeper] eolivelli commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

2019-03-19 Thread GitBox
eolivelli commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#discussion_r266769668 ## File path:

[jira] [Updated] (ZOOKEEPER-3329) ZooKeeper Banner is too large to adapt to the windows or console size

2019-03-19 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3329: --- Priority: Minor (was: Major) > ZooKeeper Banner is too large to adapt to the windows or console

[jira] [Created] (ZOOKEEPER-3329) ZooKeeper Banner is too large to adapt to the windows or console size

2019-03-19 Thread maoling (JIRA)
maoling created ZOOKEEPER-3329: -- Summary: ZooKeeper Banner is too large to adapt to the windows or console size Key: ZOOKEEPER-3329 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3329 Project:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader

2019-03-19 Thread GitBox
eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#discussion_r266758349 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderMetricsTest.java ##

[jira] [Commented] (ZOOKEEPER-2168) Add C APIs for new createContainer Methods

2019-03-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795742#comment-16795742 ] Hudson commented on ZOOKEEPER-2168: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #446 (See