eolivelli edited a comment on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-477874357
@jhuan31
If this is not dead code we should have a test.
eolivelli commented on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-477874357
@jhuan31
If this is not dead code we should have a test.
Why this code is used only in standalone mode?
jhuan31 edited a comment on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-477867662
@lvfangmin @BELUGABEHR @phunt @eolivelli
It's so strange... I can't find in newPatchFindbugsWarnings.xml (I
jhuan31 commented on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-477867662
@lvfangmin @BELUGABEHR @phunt @eolivelli
It's so strange... I can't find in newPatchFindbugsWarnings.xml (I remember
it
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804538#comment-16804538
]
maoling commented on ZOOKEEPER-3334:
[~lvfangmin]
the zkCli.sh was used from zookeeper-3.4.10
maoling commented on issue #863: ZOOKEEPER-3320: Leader election port stop
listen when hostname unresolvable for some time
URL: https://github.com/apache/zookeeper/pull/863#issuecomment-477839636
I have reservations about extending `QuorumCnxManager.Listener `to the
tdunning commented on a change in pull request #730: Zookeeper-3188: Improve
resilience to network
URL: https://github.com/apache/zookeeper/pull/730#discussion_r270258630
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
##
@@
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3342:
--
Labels: pull-request-available (was: )
> Use StandardCharsets
>
BELUGABEHR opened a new pull request #882: ZOOKEEPER-3342: Use StandardCharsets
URL: https://github.com/apache/zookeeper/pull/882
This is an automated message from the Apache Git Service.
To respond to the message, please
David Mollitor created ZOOKEEPER-3342:
-
Summary: Use StandardCharsets
Key: ZOOKEEPER-3342
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3342
Project: ZooKeeper
Issue Type:
mattc41190 closed pull request #872: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/872
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mattc41190 commented on issue #872: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/872#issuecomment-477824667
I thought I closed all of my smaller PRs sorry
This is an automated message from the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804453#comment-16804453
]
Brian Nixon commented on ZOOKEEPER-3318:
In the interest of a compact backup, I would like to
enixon commented on issue #863: ZOOKEEPER-3320: Leader election port stop
listen when hostname unresolvable for some time
URL: https://github.com/apache/zookeeper/pull/863#issuecomment-477804567
Good find @maoling ! I don't see any discussion in ZOOKEEPER-602 about
criteria for what
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3341:
--
Labels: pull-request-available (was: )
> Remove Superfluous ByteBuffer Duplicate
BELUGABEHR opened a new pull request #881: ZOOKEEPER-3341: Remove Superfluous
ByteBuffer Duplicate
URL: https://github.com/apache/zookeeper/pull/881
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Mollitor updated ZOOKEEPER-3341:
--
Summary: Remove Superfluous ByteBuffer Duplicate (was: Superfluous
ByteBuffer
David Mollitor created ZOOKEEPER-3341:
-
Summary: Superfluous ByteBuffer Duplicate
Key: ZOOKEEPER-3341
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341
Project: ZooKeeper
Issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3340:
--
Labels: pull-request-available (was: )
> Improve Queue Usage in
BELUGABEHR opened a new pull request #880: ZOOKEEPER-3340: Improve Queue Usage
in QuorumCnxManager.java
URL: https://github.com/apache/zookeeper/pull/880
This is an automated message from the Apache Git Service.
To respond
David Mollitor created ZOOKEEPER-3340:
-
Summary: Improve Queue Usage in QuorumCnxManager.java
Key: ZOOKEEPER-3340
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3340
Project: ZooKeeper
mattc41190 commented on a change in pull request #879: fix: grammar fixes and
link adds
URL: https://github.com/apache/zookeeper/pull/879#discussion_r270158363
##
File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md
##
@@ -1513,7 +1513,7 @@
mattc41190 commented on a change in pull request #879: fix: grammar fixes and
link adds
URL: https://github.com/apache/zookeeper/pull/879#discussion_r270156793
##
File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md
##
@@ -1513,7 +1513,7 @@
lvfangmin commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable
metrics system for ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#discussion_r270146414
##
File path:
lvfangmin commented on issue #872: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/872#issuecomment-477720439
@mattc41190 looks like this is already covered in
https://github.com/apache/zookeeper/pull/879.
lvfangmin commented on a change in pull request #879: fix: grammar fixes and
link adds
URL: https://github.com/apache/zookeeper/pull/879#discussion_r270144979
##
File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md
##
@@ -1513,7 +1513,7 @@
lvfangmin commented on issue #848: ZOOKEEPER-3306: Fixing node not accessible
issue due the inconsistent ACL reference map after SNAP sync
URL: https://github.com/apache/zookeeper/pull/848#issuecomment-477719255
We've released this fix onto prod for more than 2 weeks, haven't hit this
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804164#comment-16804164
]
David Mollitor commented on ZOOKEEPER-3020:
---
Created a new PR
BELUGABEHR closed pull request #869: ZOOKEEPER-3020: Review of
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/869
This is an automated message from the Apache Git Service.
To respond to the message,
BELUGABEHR commented on a change in pull request #869: ZOOKEEPER-3020: Review
of SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/869#discussion_r270133326
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
BELUGABEHR commented on a change in pull request #869: ZOOKEEPER-3020: Review
of SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/869#discussion_r270131198
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
BELUGABEHR commented on issue #869: ZOOKEEPER-3020: Review of
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/869#issuecomment-477706678
@lvfangmin Thanks for the review!
Take a look at #876 for the latest PR with multiple commits. I wasn't sure
the best way to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804129#comment-16804129
]
Fangmin Lv commented on ZOOKEEPER-3336:
---
[~NIWIS] the FastLeaderElection used currently allow
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804122#comment-16804122
]
Fangmin Lv commented on ZOOKEEPER-3334:
---
[~maoling] can you enable debug log and attach it here
[
https://issues.apache.org/jira/browse/ZOOKEEPER-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804121#comment-16804121
]
Fangmin Lv commented on ZOOKEEPER-:
---
[~nkalmar] internally, we're using the real time
lvfangmin commented on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-477686445
Did another round of sanity check before kicking off merging, this code is
not used except in Standalone mode, where the
lvfangmin commented on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-477682544
@BELUGABEHR I don't think #869 should block this, given this is less risky,
I think we should go with this first.
lvfangmin commented on a change in pull request #869: ZOOKEEPER-3020: Review of
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/869#discussion_r270096198
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
lvfangmin commented on a change in pull request #869: ZOOKEEPER-3020: Review of
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/869#discussion_r270100909
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
lvfangmin commented on a change in pull request #869: ZOOKEEPER-3020: Review of
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/869#discussion_r270099253
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
mattc41190 commented on issue #871: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/871#issuecomment-477660059
@eolivelli I combined all changes to single PR -- Please see #879
This is an
mattc41190 closed pull request #871: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/871
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mattc41190 closed pull request #875: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/875
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mattc41190 closed pull request #873: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/873
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mattc41190 closed pull request #874: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/874
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mattc41190 opened a new pull request #879: fix: grammar fixes and link adds
URL: https://github.com/apache/zookeeper/pull/879
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jhuan31 commented on issue #876: Zookeeper 3020 2
URL: https://github.com/apache/zookeeper/pull/876#issuecomment-477658763
I'm wondering why findbugs didn't complain about the unused code... I filed
PR #853 because findbugs complained in PR #850, which seems pretty
innocent--just add a
mattc41190 commented on issue #875: Update zookeeperProgrammers.md
URL: https://github.com/apache/zookeeper/pull/875#issuecomment-477656329
Yeah, only reason I didn't already is that I wasn't totally finished reading
it. Made the issues as I read :)
Thanks for quick feedback.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3339:
--
Labels: pull-request-available (was: )
> Improve Debug and Trace Log Statements
>
BELUGABEHR opened a new pull request #878: ZOOKEEPER-3339: Improve Debug and
Trace Log Statements
URL: https://github.com/apache/zookeeper/pull/878
This is an automated message from the Apache Git Service.
To respond to the
David Mollitor created ZOOKEEPER-3339:
-
Summary: Improve Debug and Trace Log Statements
Key: ZOOKEEPER-3339
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3339
Project: ZooKeeper
BELUGABEHR commented on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-477587109
Id dint' remove this code, but I did do a bunch of other work in #869
Perhaps #869 can first be considered then
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3338:
--
Labels: pull-request-available (was: )
> Review of BufferStats Class
>
BELUGABEHR opened a new pull request #877: ZOOKEEPER-3338: Review of
BufferStats Class
URL: https://github.com/apache/zookeeper/pull/877
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Mollitor updated ZOOKEEPER-3338:
--
Summary: Review of BufferStats Class (was: Review of BufferStats)
> Review of
David Mollitor created ZOOKEEPER-3338:
-
Summary: Review of BufferStats
Key: ZOOKEEPER-3338
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3338
Project: ZooKeeper
Issue Type:
BELUGABEHR commented on a change in pull request #876: Zookeeper 3020 2
URL: https://github.com/apache/zookeeper/pull/876#discussion_r269982741
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
##
@@ -117,48 +118,46 @@
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maoling updated ZOOKEEPER-3318:
---
Description:
We already had some workaround ways for the backup, e.g
*scenario 1:* just write a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maoling updated ZOOKEEPER-3318:
---
Description:
we already had some workaround ways for the backup, e.g
scenario 1: just write a
maoling commented on issue #863: ZOOKEEPER-3320: Leader election port stop
listen when hostname unresolvable for some time
URL: https://github.com/apache/zookeeper/pull/863#issuecomment-477471802
- There was a
60 matches
Mail list logo
