[GitHub] [zookeeper] jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor

2019-04-04 Thread GitBox
jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor URL: https://github.com/apache/zookeeper/pull/855#discussion_r272449294 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java

[jira] [Resolved] (ZOOKEEPER-3316) Remove unused code in SyncRequestProcessor

2019-04-04 Thread Jie Huang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Huang resolved ZOOKEEPER-3316. -- Resolution: Invalid > Remove unused code in SyncRequestProcessor >

[GitHub] [zookeeper] jhuan31 closed pull request #858: ZOOKEEPER-3321: Add metrics for Leader

2019-04-04 Thread GitBox
jhuan31 closed pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zookeeper] jhuan31 opened a new pull request #858: ZOOKEEPER-3321: Add metrics for Leader

2019-04-04 Thread GitBox
jhuan31 opened a new pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] jhuan31 opened a new pull request #858: ZOOKEEPER-3321: Add metrics for Leader

2019-04-04 Thread GitBox
jhuan31 opened a new pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] jhuan31 closed pull request #858: ZOOKEEPER-3321: Add metrics for Leader

2019-04-04 Thread GitBox
jhuan31 closed pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3349: -- Labels: pull-request-available (was: ) > QuorumCnxManager socketTimeout unused >

[GitHub] [zookeeper] enixon opened a new pull request #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

2019-04-04 Thread GitBox
enixon opened a new pull request #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-04-04 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Nixon updated ZOOKEEPER-3349: --- Description: QuorumCnxManager member variable 'socketTimeout' is not used anywhere in

[jira] [Created] (ZOOKEEPER-3349) QuorumCnxManager socketTimeout unused

2019-04-04 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3349: -- Summary: QuorumCnxManager socketTimeout unused Key: ZOOKEEPER-3349 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3349 Project: ZooKeeper Issue

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-04-04 Thread GitBox
jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859#discussion_r272310011 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-04-04 Thread GitBox
jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859#discussion_r272308292 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ##

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics

2019-04-04 Thread GitBox
jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics URL: https://github.com/apache/zookeeper/pull/859#discussion_r272308070 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ##

[GitHub] [zookeeper] eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272258248 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[GitHub] [zookeeper] maoling commented on issue #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
maoling commented on issue #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#issuecomment-479961791 ![image](https://user-images.githubusercontent.com/11016631/55570853-ded71980-5736-11e9-81bf-3f9487cd760a.png)

[jira] [Updated] (ZOOKEEPER-3324) Add read/write metrics for top level znodes

2019-04-04 Thread Jie Huang (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Huang updated ZOOKEEPER-3324: - Description: These metrics provide bytes read from each branch under the root and bytes

[GitHub] [zookeeper] jhuan31 commented on issue #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes

2019-04-04 Thread GitBox
jhuan31 commented on issue #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes URL: https://github.com/apache/zookeeper/pull/860#issuecomment-479960837 Added description in the JIRA This is an automated message

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes

2019-04-04 Thread GitBox
jhuan31 commented on a change in pull request #860: ZOOKEEPER-3324: Add read/write metrics for top level znodes URL: https://github.com/apache/zookeeper/pull/860#discussion_r272243316 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java

[GitHub] [zookeeper] jhuan31 closed pull request #853: ZOOKEEPER-3316: Remove unused code in SyncRequestProcessor

2019-04-04 Thread GitBox
jhuan31 closed pull request #853: ZOOKEEPER-3316: Remove unused code in SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/853 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272195243 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[jira] [Updated] (ZOOKEEPER-3348) Make TxnLog and TxnLog Iterator Closable

2019-04-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3348: -- Labels: pull-request-available (was: ) > Make TxnLog and TxnLog Iterator Closable

[GitHub] [zookeeper] BELUGABEHR opened a new pull request #894: ZOOKEEPER-3348: Make TxnLog and TxnLog Iterator Closable

2019-04-04 Thread GitBox
BELUGABEHR opened a new pull request #894: ZOOKEEPER-3348: Make TxnLog and TxnLog Iterator Closable URL: https://github.com/apache/zookeeper/pull/894 This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (ZOOKEEPER-3348) Make TxnLog and TxnLog Iterator Closable

2019-04-04 Thread David Mollitor (JIRA)
David Mollitor created ZOOKEEPER-3348: - Summary: Make TxnLog and TxnLog Iterator Closable Key: ZOOKEEPER-3348 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3348 Project: ZooKeeper

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272180091 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272179092 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272175265 ## File path:

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272172476 ## File path:

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
BELUGABEHR commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272170987 ## File path:

[GitHub] [zookeeper] anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272167935 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big

2019-04-04 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809825#comment-16809825 ] Enrico Olivelli commented on ZOOKEEPER-3337: This is my comment

[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big

2019-04-04 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809824#comment-16809824 ] Enrico Olivelli commented on ZOOKEEPER-3337: I have an huge userid on my work laptop and

[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big

2019-04-04 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809802#comment-16809802 ] Norbert Kalmar commented on ZOOKEEPER-3337: --- I originally used posix, as seen on this PR:

[GitHub] [zookeeper] maoling commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
maoling commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272090767 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[GitHub] [zookeeper] eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272090574 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 1

2019-04-04 Thread Norbert Kalmar
Tested the release: - unpacked source tarball, run mvn clean install - run ZooKeeper from bin and Cli tool, tried basic commands - unpacked binary tarball - run ZooKeeper and tried basic commands - Checked jars in libs and their license files. Note that there are new dependencies since 3.5.4.

[GitHub] [zookeeper] anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272072869 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java

[GitHub] [zookeeper] nkalmar closed pull request #892: ZOOKEEPER-3122 - Rename zookeeper-server to zookeeper

2019-04-04 Thread GitBox
nkalmar closed pull request #892: ZOOKEEPER-3122 - Rename zookeeper-server to zookeeper URL: https://github.com/apache/zookeeper/pull/892 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-04 Thread GitBox
eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#discussion_r272037431 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java