[jira] [Updated] (ZOOKEEPER-3354) Improve efficiency of DeleteAllCommand

2019-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3354: -- Labels: pull-request-available (was: ) > Improve efficiency of DeleteAllCommand >

[jira] [Created] (ZOOKEEPER-3354) Improve efficiency of DeleteAllCommand

2019-04-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3354: -- Summary: Improve efficiency of DeleteAllCommand Key: ZOOKEEPER-3354 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3354 Project: ZooKeeper Issue

[GitHub] [zookeeper] enixon opened a new pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

2019-04-08 Thread GitBox
enixon opened a new pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899 This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (ZOOKEEPER-3353) Admin commands for showing initial settings

2019-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3353: -- Labels: pull-request-available (was: ) > Admin commands for showing initial

[GitHub] [zookeeper] enixon opened a new pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings

2019-04-08 Thread GitBox
enixon opened a new pull request #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898 This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] enixon commented on issue #876: ZOOKEEPER-3020: Review of SyncRequestProcessor

2019-04-08 Thread GitBox
enixon commented on issue #876: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/876#issuecomment-481106473 lgtm +1 (non-committer) This is an automated message from the Apache Git

[jira] [Created] (ZOOKEEPER-3353) Admin commands for showing initial settings

2019-04-08 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3353: -- Summary: Admin commands for showing initial settings Key: ZOOKEEPER-3353 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 Project: ZooKeeper

Re: Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2

2019-04-08 Thread Patrick Hunt
ic - thanks! Patrick On Mon, Apr 8, 2019 at 4:38 AM Justin Ling Mao wrote: > ---> "That's cool, thanks Justin. I'd be interested to know - did you use > the legacy/old c client binaries from the github repo or did you rebuild > them? What about zkpython itself? I could see benefits or

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #876: ZOOKEEPER-3020: Review of SyncRequestProcessor

2019-04-08 Thread GitBox
BELUGABEHR commented on a change in pull request #876: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/876#discussion_r273283081 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #876: ZOOKEEPER-3020: Review of SyncRequestProcessor

2019-04-08 Thread GitBox
BELUGABEHR commented on a change in pull request #876: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/876#discussion_r273282443 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java

[GitHub] [zookeeper] enixon commented on a change in pull request #876: ZOOKEEPER-3020: Review of SyncRequestProcessor

2019-04-08 Thread GitBox
enixon commented on a change in pull request #876: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/876#discussion_r273281479 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java ##

[GitHub] [zookeeper] enixon commented on a change in pull request #876: ZOOKEEPER-3020: Review of SyncRequestProcessor

2019-04-08 Thread GitBox
enixon commented on a change in pull request #876: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/876#discussion_r273278904 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java ##

[GitHub] [zookeeper] enixon commented on issue #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java

2019-04-08 Thread GitBox
enixon commented on issue #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#issuecomment-481046290 lgtm This is an automated message from the Apache Git

[jira] [Commented] (ZOOKEEPER-3343) Add a new doc: zookeeperTools.md

2019-04-08 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812869#comment-16812869 ] Brian Nixon commented on ZOOKEEPER-3343: This will be great, thanks [~maoling]! > Add a new

[GitHub] [zookeeper] enixon commented on issue #730: Zookeeper-3188: Improve resilience to network

2019-04-08 Thread GitBox
enixon commented on issue #730: Zookeeper-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/730#issuecomment-481041410 A couple of nits to point out, overall looks good to me. Given the size of the change, I'd recommend several reviewers go over this pr.

[jira] [Commented] (ZOOKEEPER-3018) Ephemeral node not deleted after session is gone

2019-04-08 Thread Daniel C (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812792#comment-16812792 ] Daniel C commented on ZOOKEEPER-3018: - [~clouds xu], sorry I missed your update. Our site was

[jira] [Created] (ZOOKEEPER-3352) Use LevelDB For Backend

2019-04-08 Thread David Mollitor (JIRA)
David Mollitor created ZOOKEEPER-3352: - Summary: Use LevelDB For Backend Key: ZOOKEEPER-3352 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3352 Project: ZooKeeper Issue Type:

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812782#comment-16812782 ] Enrico Olivelli commented on ZOOKEEPER-3351: My plan is to migrate all of the checks to

[jira] [Comment Edited] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812775#comment-16812775 ] Enrico Olivelli edited comment on ZOOKEEPER-3351 at 4/8/19 8:45 PM:

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812775#comment-16812775 ] Enrico Olivelli commented on ZOOKEEPER-3351: most of the work of that script can be

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812766#comment-16812766 ] Enrico Olivelli commented on ZOOKEEPER-3351: that task is calling

[jira] [Created] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

2019-04-08 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3351: -- Summary: Migrate qa-test-pullrequest ant task to maven Key: ZOOKEEPER-3351 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351 Project: ZooKeeper

[GitHub] [zookeeper] enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

2019-04-08 Thread GitBox
enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#issuecomment-480926500 The new test works in isolation but fails intermittently when run in the suite. Adding a 1 second sleep in the test appears

[GitHub] [zookeeper] eolivelli commented on issue #846: ZOOKEEPER-3302 ZooKeeper C client does not compile on Fedora 29

2019-04-08 Thread GitBox
eolivelli commented on issue #846: ZOOKEEPER-3302 ZooKeeper C client does not compile on Fedora 29 URL: https://github.com/apache/zookeeper/pull/846#issuecomment-480916682 @anmolnar if you and @phunt accept the patch in the current form I will be happier. I don't have time to spend on

[GitHub] [zookeeper] nkalmar opened a new pull request #897: ZOOKEEPER-3122 - fix files included in tarballs

2019-04-08 Thread GitBox
nkalmar opened a new pull request #897: ZOOKEEPER-3122 - fix files included in tarballs URL: https://github.com/apache/zookeeper/pull/897 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] nkalmar closed pull request #897: ZOOKEEPER-3122 - fix files included in tarballs

2019-04-08 Thread GitBox
nkalmar closed pull request #897: ZOOKEEPER-3122 - fix files included in tarballs URL: https://github.com/apache/zookeeper/pull/897 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zookeeper] nkalmar opened a new pull request #897: ZOOKEEPER-3122 - fix files included in tarballs

2019-04-08 Thread GitBox
nkalmar opened a new pull request #897: ZOOKEEPER-3122 - fix files included in tarballs URL: https://github.com/apache/zookeeper/pull/897 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] nkalmar closed pull request #897: ZOOKEEPER-3122 - fix files included in tarballs

2019-04-08 Thread GitBox
nkalmar closed pull request #897: ZOOKEEPER-3122 - fix files included in tarballs URL: https://github.com/apache/zookeeper/pull/897 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zookeeper] nkalmar commented on issue #897: ZOOKEEPER-3122 - fix files included in tarballs

2019-04-08 Thread GitBox
nkalmar commented on issue #897: ZOOKEEPER-3122 - fix files included in tarballs URL: https://github.com/apache/zookeeper/pull/897#issuecomment-480893025 retest maven build This is an automated message from the Apache Git

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java

2019-04-08 Thread GitBox
BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#discussion_r273057287 ## File path:

[GitHub] [zookeeper] nkalmar opened a new pull request #897: ZOOKEEPER-3122 - fix files included in tarballs

2019-04-08 Thread GitBox
nkalmar opened a new pull request #897: ZOOKEEPER-3122 - fix files included in tarballs URL: https://github.com/apache/zookeeper/pull/897 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java

2019-04-08 Thread GitBox
BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#discussion_r273068008 ## File path:

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java

2019-04-08 Thread GitBox
BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#discussion_r273067956 ## File path:

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java

2019-04-08 Thread GitBox
BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#discussion_r273057287 ## File path:

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java

2019-04-08 Thread GitBox
BELUGABEHR commented on a change in pull request #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#discussion_r273056327 ## File path:

[GitHub] [zookeeper] maoling opened a new pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-08 Thread GitBox
maoling opened a new pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823 - Thanks the original work from [arshad.mohammad ](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=arshad.mohammad)

[GitHub] [zookeeper] maoling closed pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-04-08 Thread GitBox
maoling closed pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823 This is an automated message from the Apache Git Service. To respond

[GitHub] [zookeeper] maoling commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements

2019-04-08 Thread GitBox
maoling commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-480798562 +1 This is an automated message from the Apache Git Service. To

Re: Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2

2019-04-08 Thread Justin Ling Mao
---> "That's cool, thanks Justin. I'd be interested to know - did you use the legacy/old c client binaries from the github repo or did you rebuild them? What about zkpython itself? I could see benefits or either/both." @PatrickTo use that(your) benchmark tool, I did something like following:cd

[jira] [Created] (ZOOKEEPER-3350) Get rid of CommonNames

2019-04-08 Thread TisonKun (JIRA)
TisonKun created ZOOKEEPER-3350: --- Summary: Get rid of CommonNames Key: ZOOKEEPER-3350 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350 Project: ZooKeeper Issue Type: Improvement

[GitHub] [zookeeper] marathom closed pull request #896: Branch 3.5.5

2019-04-08 Thread GitBox
marathom closed pull request #896: Branch 3.5.5 URL: https://github.com/apache/zookeeper/pull/896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zookeeper] marathom opened a new pull request #896: Branch 3.5.5

2019-04-08 Thread GitBox
marathom opened a new pull request #896: Branch 3.5.5 URL: https://github.com/apache/zookeeper/pull/896 Test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use