anmolnar commented on issue #855: ZOOKEEPER-3310: Add metrics for prep processor
URL: https://github.com/apache/zookeeper/pull/855#issuecomment-490754714
Got it. The counter of processed requested (cnt_)PREP_PROCESS_TIME is
updated in the `run()` method _after_ `pRequest()`.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836100#comment-16836100
]
Fangmin Lv commented on ZOOKEEPER-3358:
---
[~belugabehr] When we contributed that back, most of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836096#comment-16836096
]
Fangmin Lv commented on ZOOKEEPER-3352:
---
Had an intern done some prototype with me by building
anmolnar commented on issue #855: ZOOKEEPER-3310: Add metrics for prep processor
URL: https://github.com/apache/zookeeper/pull/855#issuecomment-490750148
@jhuan31 Looks like a new flaky test has been introduced by this patch:
Hi Shuxin,
What's the zk client version you are testing? Sync apis were removed from c
client in https://issues.apache.org/jira/browse/ZOOKEEPER-761, but it's
only done for 3.5.3 and master branch only. There was a discussion in JIRA
regarding whether or not to do the same for 3.4 branch which
>> My proposal is to use github's feature of Co-author
+1. The commit script would have to be updated to incorporate this feature.
>> if someone participate in the review of PR, no matter whether he/she is
a committer, we all need include his/her name
We already do this when commit a change so
Congratulations, Andor!
On Mon, Apr 29, 2019 at 9:10 AM Brian Nixon
wrote:
> Awesome! Congrats, Andor, you've been doing great work!
>
>
> On Mon, Apr 29, 2019 at 7:31 AM Patrick Hunt wrote:
>
> > Kudos Andor!
> >
> > Patrick
> >
> > On Mon, Apr 29, 2019 at 2:07 AM Enrico Olivelli
> > wrote:
jhuan31 commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet
Metrics
URL: https://github.com/apache/zookeeper/pull/933#issuecomment-490712538
CC @anmolnar This addresses your comment for JIRA 3305
This is
lvfangmin commented on issue #922: ZOOKEEPER-3361: Add multi version of
getChildren request
URL: https://github.com/apache/zookeeper/pull/922#issuecomment-490703229
Is it cleaner to add a new getChildren batch API instead of adding a fake
txn in multi-op? Any use case and benefit of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835988#comment-16835988
]
Hudson commented on ZOOKEEPER-3364:
---
SUCCESS: Integrated in Jenkins build
lvfangmin commented on issue #843: ZOOKEEPER-3296: Explicitly closing the
sslsocket when it failed handshake to prevent issue where peers cannot join
quorum
URL: https://github.com/apache/zookeeper/pull/843#issuecomment-490696659
@anmolnar do you mind to take a look and merge this if it
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835937#comment-16835937
]
Hudson commented on ZOOKEEPER-3364:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #512 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835936#comment-16835936
]
Hudson commented on ZOOKEEPER-3362:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #512 (See
See https://builds.apache.org/job/ZooKeeper-trunk/512/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 189.07 KB...]
[junit] Running
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835914#comment-16835914
]
Hudson commented on ZOOKEEPER-3362:
---
FAILURE: Integrated in Jenkins build
anmolnar commented on issue #910: ZOOKEEPER-3364 Compile with strict options in
order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-490631264
Committed to master branch. Thanks @eolivelli !
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3364.
-
Resolution: Fixed
Issue resolved by pull request 910
asfgit closed pull request #910: ZOOKEEPER-3364 Compile with strict options in
order to check code quality
URL: https://github.com/apache/zookeeper/pull/910
This is an automated message from the Apache Git Service.
To
Yes, it is a good idea to have a common practice for tracking the original
author.
IMHO this is up to the person who is picking up an old patch, it is his own
responsibility.
IIRC In Bookkeeper we keep the original author of the patch if the patch is
a straight port from another private company
+1 to the idea of multiple authors, particularly for rescued code
-1 to including all reviewers in the commit proper, this information is
easily enough found from poking at the mail archive where "original author"
requires studying a ticket on jira
awesome idea!
On Wed, May 8, 2019 at 6:32 AM
eolivelli closed pull request #918: ZOOKEEPER-3366: Pluggable metrics system
for ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918
This is an automated message from the
eolivelli opened a new pull request #918: ZOOKEEPER-3366: Pluggable metrics
system for ZooKeeper - move remaining metrics to MetricsProvider
URL: https://github.com/apache/zookeeper/pull/918
Migrate all remaining metrics to MetricsProvider.
We are introducing now Gauges which are
eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options
in order to check code quality
URL: https://github.com/apache/zookeeper/pull/910#issuecomment-490558063
retest ant build
This is an automated
anmolnar commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file
URL: https://github.com/apache/zookeeper/pull/909#issuecomment-490542616
Thanks, committed to master.
This is an automated message from the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3362.
-
Resolution: Fixed
Issue resolved by pull request 909
asfgit closed pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file
URL: https://github.com/apache/zookeeper/pull/909
This is an automated message from the Apache Git Service.
To respond to the message, please
anmolnar commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file
URL: https://github.com/apache/zookeeper/pull/909#issuecomment-490536056
@eolivelli Why isn't the new checkstyle file not the same as the ant version?
eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle
file
URL: https://github.com/apache/zookeeper/pull/909#issuecomment-490538183
@anmolnar thank you for checking this patch
> @eolivelli Why isn't the new checkstyle file not the same as the ant
version?
Well, HBase does it for example, commits have a "Signed-off-by: ..." line.
All right, votes on for co-author and signed-off-by :)
On Wed, May 8, 2019 at 2:58 PM Norbert Kalmar wrote:
> Thanks Maoling, I also think encouraging code review as well is a good
> idea, but, unfortunately I have a
Sorry everyone for the multiple emails...
So, I get your suggestion now Maoling, sorry for the confusion.
We already indicate the reviewer if it's from an apache email, as it looks
to me. (Doesn't have to be ZooKeeper committer). We should add external
emails as well.
So I just clarified this
Peter Szecsi created ZOOKEEPER-3381:
---
Summary: Add multi watchregistration support for multi getChildren
Key: ZOOKEEPER-3381
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3381
Project:
Thanks Maoling, I also think encouraging code review as well is a good
idea, but, unfortunately I have a "but" :)
I see two issues with including reviewers in the commit message.
First, I don't think there is a method to automate this, although I think
the commit script the committers are using
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835582#comment-16835582
]
David Mollitor commented on ZOOKEEPER-3301:
---
Also be sure to take a look at
+1,A very good Suggestion.Thanks Norbert.I also suggest about the sign-off of
the Reviewers' name.For the incentive, if someone participate in the review of
PR, no matter whether he/she is a committer, we all need include his/her name?
- Original Message -
From: Norbert Kalmar
To:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maoling updated ZOOKEEPER-3301:
---
Summary: Enforce the quota limit (was: do a hard constraint on the
"setquota",make it can
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835538#comment-16835538
]
maoling commented on ZOOKEEPER-3301:
find another issue:
[zk: 127.0.0.1:2180(CONNECTED) 6]
Hi Devs,
I've got this idea from HBase.
So: when there is a patch that is abandoned by its original author for any
reason, and it can no longer be merged, someone comes by, and asks to
continue to work on it. Usually the reply is to use the change freely or no
reply at all. Either way, what
37 matches
Mail list logo
