Re: [DISCUSS] Voting on pull requests

Il ven 14 giu 2019, 23:34 Andor Molnar ha scritto: > Personally I'd like to check whether the requested change has been > addressed as I expected and validate the contributor and myself are on the > same page. That's why I usually provide feedback with "request changes" (in > big RED color on

Re: [DISCUSS] Voting on pull requests

Personally I'd like to check whether the requested change has been addressed as I expected and validate the contributor and myself are on the same page. That's why I usually provide feedback with "request changes" (in big RED color on github indicating that the patch should not be merged yet.)

Re: [DISCUSS] Voting on pull requests

On Thu, Jun 13, 2019 at 11:08 AM Fangmin Lv wrote: > Agree to not commit if there is a -1, and we should align with that rule. > > I'm not sure if "request to change" is equal to -1 though, in theory all > comments may require to change something. It would be great for the > reviewers who

Re: [DISCUSS] Voting on pull requests

Agree to not commit if there is a -1, and we should align with that rule. I'm not sure if "request to change" is equal to -1 though, in theory all comments may require to change something. It would be great for the reviewers who provided opinions to review again, but it seems to me if it's not a

Re: [DISCUSS] Voting on pull requests

The community should absolutely stand by its bylaws. :) Those two pull requests (899 and 944) were mine so I'd like to sketch what I saw as a contributor and hopefully figure out a healthier way forward. Both were opened in the last two months and got reviewer action within days. There was a

Re: [DISCUSS] Voting on pull requests

Exactly. On 2019. 06. 06. 14:51, Flavio Junqueira wrote: > That's covered in the project bylaws, right? > > https://zookeeper.apache.org/bylaws.html > > > -Flavio > >> On 6 Jun 2019, at 13:49, Enrico Olivelli wrote: >> >> Il gio 6 giu 2019, 12:44

Re: [DISCUSS] Voting on pull requests

That's covered in the project bylaws, right? https://zookeeper.apache.org/bylaws.html -Flavio > On 6 Jun 2019, at 13:49, Enrico Olivelli wrote: > > Il gio 6 giu 2019, 12:44 Andor Molnar > ha scritto: > >> Hi folks, >> >>

Re: [DISCUSS] Voting on pull requests

Il gio 6 giu 2019, 12:44 Andor Molnar ha scritto: > Hi folks, > > I’ve seen 2 patches committed recently with “-1s" from committers on it. > > https://github.com/apache/zookeeper/pull/899 < > https://github.com/apache/zookeeper/pull/899> > https://github.com/apache/zookeeper/pull/944 < >

[DISCUSS] Voting on pull requests

Hi folks, I’ve seen 2 patches committed recently with “-1s" from committers on it. https://github.com/apache/zookeeper/pull/899 https://github.com/apache/zookeeper/pull/944 Not a big deal in this