Re: Cutting Zookeeper 3.5.6

2019-09-16 Thread Enrico Olivelli
Il giorno lun 16 set 2019 alle ore 14:02 Andor Molnar ha scritto: > After quickly checking 3.5 has only added two new exitcodes: “unable to > access datadir” and “unable to start admin server”, but previous exit codes > haven’t been changed. > > Between 3.5.x and 3.5.5 I haven’t seen any changes

Re: Cutting Zookeeper 3.5.6

2019-09-16 Thread Andor Molnar
After quickly checking 3.5 has only added two new exitcodes: “unable to access datadir” and “unable to start admin server”, but previous exit codes haven’t been changed. Between 3.5.x and 3.5.5 I haven’t seen any changes in ExitCodes, however it’s kind of a mess that ExitCode enum has been

Re: Cutting Zookeeper 3.5.6

2019-09-16 Thread Enrico Olivelli
Thank you Norbert I am investigating a potential problem in ZK 3.5 branch I am seeing in the upgrade of ZooKeeper in BookKeeper project regarding the exit codes of the shell (ZooKeeperMain) see https://github.com/apache/bookkeeper/pull/2112#issuecomment-531576441 If the problem is there and the

Re: Cutting Zookeeper 3.5.6

2019-09-16 Thread Norbert Kalmar
I merged it to master and 3.5 Thanks Enrico! On Sat, Sep 14, 2019 at 5:49 PM Enrico Olivelli wrote: > Too quick: > I see we have a "LICENSES" files issue, we changed netty dependency from > netty-all to separate bundles. > > I think we must have separate files, in order to be consistent with

Re: Cutting Zookeeper 3.5.6

2019-09-14 Thread Enrico Olivelli
Too quick: I see we have a "LICENSES" files issue, we changed netty dependency from netty-all to separate bundles. I think we must have separate files, in order to be consistent with other jars I will send a patch soon Enrico -rw-r--r--. 1 eolivelli eolivelli 11366 9 set 18.57

Re: Cutting Zookeeper 3.5.6

2019-09-14 Thread Enrico Olivelli
branch-3.5.6 is good to go now. I am preparing the release artifacts now. I hope I won't find any other show stopper on my way Enrico Il giorno ven 6 set 2019 alle ore 17:45 Enrico Olivelli ha scritto: > Hi, > I have moved all of the pending issue for 3.5.6 to 3.5.7. > > I did not have the

Re: Cutting Zookeeper 3.5.6

2019-09-06 Thread Enrico Olivelli
Hi, I have moved all of the pending issue for 3.5.6 to 3.5.7. I did not have the flag "do not send email", I hope I have not generated too much spam Enrico Il giorno lun 2 set 2019 alle ore 01:50 Patrick Hunt ha scritto: > Thanks for driving this Enrico. I created 3.5.7 version in JIRA to >

Re: Re: Cutting Zookeeper 3.5.6

2019-09-02 Thread Justin Ling Mao
awesome!!!. Looking forward to this release. - Original Message - From: Andor Molnar To: DevZooKeeper Subject: Re: Cutting Zookeeper 3.5.6 Date: 2019-09-02 00:28 Great +1 On Thu, Aug 29, 2019 at 4:37 PM Enrico Olivelli wrote: > Hello, > I am going to cut 3.5.6, if you have p

Re: Cutting Zookeeper 3.5.6

2019-09-01 Thread Patrick Hunt
Thanks for driving this Enrico. I created 3.5.7 version in JIRA to facilitate. LMK if there's more that you need. Patrick On Fri, Aug 30, 2019 at 10:59 AM Enrico Olivelli wrote: > Can any PMC create the 3.5.7 version on JIRA please ? > > I have to move all of the issues targeted 3.5.6 to that

Re: Cutting Zookeeper 3.5.6

2019-08-30 Thread Norbert Kalmar
I agree, fix version should, in my opinion, only be used when the patch is already merged. On Fri, Aug 30, 2019 at 7:59 PM Enrico Olivelli wrote: > Can any PMC create the 3.5.7 version on JIRA please ? > > I have to move all of the issues targeted 3.5.6 to that version. > > IMHO we should not

Re: Cutting Zookeeper 3.5.6

2019-08-30 Thread Michael Han
I said I will prepare a patch, and I managed to find sometime today to put up https://github.com/apache/zookeeper/pull/1069 I don't want us to rush something in, so please take time to review this. As Brian pointed out, there is not lots of code here, just some thinking and consensus from

Re: Cutting Zookeeper 3.5.6

2019-08-30 Thread Enrico Olivelli
Can any PMC create the 3.5.7 version on JIRA please ? I have to move all of the issues targeted 3.5.6 to that version. IMHO we should not target issues directly to 3.5 branch if not strictly needed. We have a lot of issues, 181, targeted to 3.5.6 and not resolved. This is my search

Re: Cutting Zookeeper 3.5.6

2019-08-30 Thread Enrico Olivelli
I am preparing for the release. It is the first time for me so I have to setup a bunch of things, like GPG KEYS. The procedure (1) is very detailed, I hope I won't encounter issues I am not sure I will be able to be ready for a VOTE tonight. I hope I will be able to prepare a good RC during

Re: Cutting Zookeeper 3.5.6

2019-08-30 Thread Enrico Olivelli
Il ven 30 ago 2019, 02:56 Brian Nixon ha scritto: > I agree that ZOOKEEPER-3056 would be super nice to have in 3.5.6. > Does anyway want to pick it up? I can want until early next week. Otherwise I will start tonight (within 6-7 hours) Enrico > Don't know what shape the solution should be

Re: Cutting Zookeeper 3.5.6

2019-08-29 Thread Brian Nixon
I agree that ZOOKEEPER-3056 would be super nice to have in 3.5.6. Don't know what shape the solution should be but don't think it requires that much code - just thinking and community agreement. On Thu, Aug 29, 2019 at 4:31 PM Michael Han wrote: > ZOOKEEPER-3056 would be nice to have, I'll

Re: Cutting Zookeeper 3.5.6

2019-08-29 Thread Michael Han
ZOOKEEPER-3056 would be nice to have, I'll try to have a patch ready soon, but it's not a blocker given workarounds available (unless community votes we really need this for 3.5.6). On Thu, Aug 29, 2019 at 8:16 AM Zili Chen wrote: > Great! > > IIRC it is possible to add a customized kanban on

Re: Cutting Zookeeper 3.5.6

2019-08-29 Thread Zili Chen
Great! IIRC it is possible to add a customized kanban on JIRA site, specifically, to track all issues marked as "blocker" and to the target release. If we make use of that we can ensure no blockers before released. Best, tison. Andor Molnar 于2019年8月29日周四 下午10:47写道: > Great +1 > > On Thu, Aug

Re: Cutting Zookeeper 3.5.6

2019-08-29 Thread Andor Molnar
Great +1 On Thu, Aug 29, 2019 at 4:37 PM Enrico Olivelli wrote: > Hello, > I am going to cut 3.5.6, if you have patches to cherry pick or you are > aware of blocker issues for such release please tell me as soon as > possible. > > I will start the procedure tomorrow > > > Enrico >

Cutting Zookeeper 3.5.6

2019-08-29 Thread Enrico Olivelli
Hello, I am going to cut 3.5.6, if you have patches to cherry pick or you are aware of blocker issues for such release please tell me as soon as possible. I will start the procedure tomorrow Enrico