Re: JAVA 11 build is broken on 3.5

Hi folks, Looks like we’re in a very good shape: all builds of 3.5 release are green now. Are you thinking of anything which would be good to get in before the stable release? Regards, Andor > On 2019. Jan 9., at 22:18, Andor Molnár wrote: > > Thank you guys for your support. > > I leave

Re: JAVA 11 build is broken on 3.5

Thank you guys for your support. I leave this open for the community to decide, but if none of the binding voters (committers, PMCs) respond in 1 week, I'll take responsibility and commit the patches. I know holidays are still going on, but 3.5 release is important we should make progress.

Re: JAVA 11 build is broken on 3.5

I agree with backporting Netty 4 and the related patches to 3.5.5. +1 (non binding) (and I might have already voted) If it took so long to release a stable 3.5, I don't think we should leave a known bug in the system, which has such an impact (not supporting current LTS java). The PRs shouldn't

Re: JAVA 11 build is broken on 3.5

Il giorno mer 9 gen 2019 alle ore 21:16 Andor Molnar ha scritto: > > So, you guys saying we should upgrade to Netty 4 and backport the following > patches too: > > ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak > ZOOKEEPER-3163 Use session map to improve the performance

Re: JAVA 11 build is broken on 3.5

So, you guys saying we should upgrade to Netty 4 and backport the following patches too: ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak ZOOKEEPER-3163 Use session map to improve the performance when closing session in Netty ZOOKEEPER-3146 Limit the maximum client

Re: JAVA 11 build is broken on 3.5

Also worth consideration for the Netty fixes backport bundle: ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak Our experience with Netty has been positive so far though I don't think we have enough info to declare it is stable. It makes a lot of sense to me for 3.5 to use

Re: JAVA 11 build is broken on 3.5

I got another one: ZOOKEEPER-3163 Use session map to improve the performance when closing session in Netty So, that doesn't seem too many. We can talk about backporting them, but I don't think they're super critical for the first stable release. Regarding 3.4, I need to validate the embedded

Re: JAVA 11 build is broken on 3.5

Il giorno ven 4 gen 2019 alle ore 17:04 Norbert Kalmar ha scritto: > > +1 for Netty 4 in 3.5 > > Pretty much all the pros and cons has been said before me. > I would only add that this is not a new functionality that we wan't to > backport. It's a criticall(ish?) bugfix, which requires quite a

Re: JAVA 11 build is broken on 3.5

+1 for Netty 4 in 3.5 Pretty much all the pros and cons has been said before me. I would only add that this is not a new functionality that we wan't to backport. It's a criticall(ish?) bugfix, which requires quite a bit of change unfortunately. Regards, Norbert On Fri, Jan 4, 2019 at 4:36 PM

Re: JAVA 11 build is broken on 3.5

What are those patches exactly? Comparing the ported version of 3.5 with master I’ve only found 2 patches which are missing: ZOOKEEPER-3146 Limit the maximum client connections per IP in NettyServerCnxnFactory ZOOKEEPER-3177 Refactor request throttle logic in NIO and Netty to keep the same

Re: JAVA 11 build is broken on 3.5

Il giorno ven 4 gen 2019 alle ore 14:23 Andor Molnar ha scritto: > > Hi team / Enrico, > > I’d like to get feedback from the community on the following patch (moving > the discussion from GitHub to here): > > https://issues.apache.org/jira/browse/ZOOKEEPER-3204 >

JAVA 11 build is broken on 3.5

Hi team / Enrico, I’d like to get feedback from the community on the following patch (moving the discussion from GitHub to here): https://issues.apache.org/jira/browse/ZOOKEEPER-3204 https://github.com/apache/zookeeper/pull/753