Thanks for reporting the issue. I think it is because `filter` in Py3
returns iterator instead of list. I will check all these cases and file a
ticket.
Best,
tison.
Andor Molnar 于2020年4月1日周三 下午11:04写道：
> Hey Tison,
>
> I’ve found a bug in the Py3 script after entering Jira fix version:
>
>
Hey Tison,
I’ve found a bug in the Py3 script after entering Jira fix version:
Enter comma-separated fix version(s) []: 3.7.0
Traceback (most recent call last):
File "zk-merge-pr.py", line 533, in
main()
File "zk-merge-pr.py", line 519, in main
resolve_jira_issues(commit_title,
Thanks for your kind help!
Best,
tison.
Norbert Kalmar 于2020年3月31日周二 下午7:37写道：
> I know it's been only a day since the vote, but we already have multiple
> +1, three of them from PMC members and no -1, so I'll commit the patch.
> Thanks everyone, especially Tison for making the patch!
>
> -
I know it's been only a day since the vote, but we already have multiple
+1, three of them from PMC members and no -1, so I'll commit the patch.
Thanks everyone, especially Tison for making the patch!
- Norbert
On Tue, Mar 31, 2020 at 12:14 AM Brian Nixon
wrote:
> I agree with the consensus,
I agree with the consensus, maintaining a single version is preferable to
maintaining two.
On Mon, Mar 30, 2020 at 2:28 PM tison wrote:
> Never mind. Updated pr based on the consensus.
>
> Best,
> tison.
>
>
> Enrico Olivelli 于2020年3月31日周二 上午2:10写道：
>
> > Tison,
> > can you please update your
Never mind. Updated pr based on the consensus.
Best,
tison.
Enrico Olivelli 于2020年3月31日周二 上午2:10写道：
> Tison,
> can you please update your PR and drop the PY2 script ?
>
> I apologize, I asked you to keep it, we could have done it simpler :-)
>
> Enrico
>
> Il giorno lun 30 mar 2020 alle ore
Tison,
can you please update your PR and drop the PY2 script ?
I apologize, I asked you to keep it, we could have done it simpler :-)
Enrico
Il giorno lun 30 mar 2020 alle ore 18:43 Patrick Hunt
ha scritto:
>
> p3 is fine with me. Trying to maintain multiple can be a hassle and p2 is
> EOL
p3 is fine with me. Trying to maintain multiple can be a hassle and p2 is
EOL already.
Patrick
On Mon, Mar 30, 2020 at 5:19 AM Norbert Kalmar
wrote:
> +1 for v3 only (I have both v2/v3 interpreters, but as you mentioned, we
> should only need to maintain 1 script).
>
> - Norbert
>
> On Mon,
+1 for v3 only (I have both v2/v3 interpreters, but as you mentioned, we
should only need to maintain 1 script).
- Norbert
On Mon, Mar 30, 2020 at 1:35 PM Enrico Olivelli wrote:
> Il giorno lun 30 mar 2020 alle ore 13:33 Andor Molnar
> ha scritto:
> >
> > Hi folks,
> >
> > We have a nice PR
Il giorno lun 30 mar 2020 alle ore 13:33 Andor Molnar
ha scritto:
>
> Hi folks,
>
> We have a nice PR about upgrading the commit script to Python3:
>
> https://github.com/apache/zookeeper/pull/1295
>
> I think we could just drop the previous v2 version with no problem, but folks
> on the PR
Hi folks,
We have a nice PR about upgrading the commit script to Python3:
https://github.com/apache/zookeeper/pull/1295
I think we could just drop the previous v2 version with no problem, but folks
on the PR would like to keep it.
Source control keeps the old version anyway and we wouldn’t
11 matches
Mail list logo
