[dev-platform] Re: Deprecating SpiderMonkey Rooting Typedefs

2022-06-01 Thread Bobby Holley
I've submitted a patch in bug 1772234 to update the style guide. On Fri, May 27, 2022 at 10:45 AM Bobby Holley wrote: > Hi Folks, > > We've long had two ways to specify SpiderMonkey rooting types in C++: via > the canonical definition (e.g., JS::Handle) and the a set of > shortcut typedefs

Re: [dev-platform] Re: Deprecating SpiderMonkey Rooting Typedefs

2022-06-01 Thread Kagami Rosylight
Currently the use of [[deprecated]] is disallowed, though: https://firefox-source-docs.mozilla.org/code-quality/coding-style/using_cxx_in_firefox_code.html#notes > |[[deprecated]]|: If we have deprecated code, we should be removing it rather than marking it as such. Marking things as

[dev-platform] Re: Deprecating SpiderMonkey Rooting Typedefs

2022-06-01 Thread Mirko Brodesser
On Friday, May 27, 2022 at 7:45:18 PM UTC+2 Bobby Holley wrote: > Hi Folks, > > We've long had two ways to specify SpiderMonkey rooting types in C++: via > the canonical definition (e.g., JS::Handle) and the a set of > shortcut typedefs defined in TypeDecls.h (e.g., JS::HandleObject). > >