Reviewed-by: Guo Dong
-Original Message-
From: Vang, Judah
Sent: Friday, April 29, 2022 11:04 AM
To: devel@edk2.groups.io
Cc: Wang, Jian J ; Dong, Guo ; Ni,
Ray ; Maurice Ma ; You, Benjamin
; Rhodes, Sean ; Mistry, Nishant
C
Subject: [Patch v2 21/28] UefiPayloadPkg: Add
Fix build warning in PlatformInfo.c.
Fix script invocation issues in build_board.py for AML
content build in WilsonCityRvp and JunctionCity.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
.../WhitleyOpenBoardPkg/JunctionCity/build_board.py | 11 ---
Please help review this patch when possible.
Thanks,
Michael
On 4/22/2022 10:02 AM, Michael Kubacki wrote:
Reminder to review this patch.
On 4/18/2022 7:43 PM, Michael Kubacki wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3478
Adds support for getting
Another reminder to merge this series. Chasel has added his review and
that is in this branch:
https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1
Thanks,
Michael
On 4/22/2022 10:04 AM, Michael Kubacki wrote:
Reminder to review this series.
Ankit
Thanks for the patches
On Mon, 25 Apr 2022 at 19:06, Sami Mujawar wrote:
>
> Hi Michael,
>
> Thank you for this patch.
>
> These changes look good to me.
>
> Reviewed-by: Sami Mujawar
>
> Regards,
>
> Sami Mujawar
>
> On 20/04/2022 09:44 pm, mikub...@linux.microsoft.com wrote:
> > From: Michael
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
RPMC confidentiality feature requires HMAC-SHA256 support during
SMM phase. This allows the protected variable's data to be
encrypted in the SPI flash.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: Nishant C Mistry
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add reference to null ProtectedVariableLib.
Cc: Jian J Wang
Cc: Rebecca Cran
Cc: Peter Grehan
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
OvmfPkg/Bhyve/BhyveX64.dsc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add reference to null ProtectedVariableLib.
Cc: Jian J Wang
Cc: Sebastien Boeuf
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
OvmfPkg/CloudHv/CloudHvX64.dsc | 1 +
1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add reference to null ProtectedVariableLib.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Min Xu
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Tom Lendacky
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add reference to null ProtectedVariableLib.
Cc: Jian J Wang
Cc: Gerd Hoffmann
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
OvmfPkg/Microvm/MicrovmX64.dsc | 3 ++-
1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add reference to null ProtectedVariableLib.
Cc: Jian J Wang
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add reference to null ProtectedVariableLib.
Cc: Jian J Wang
Cc: Andrew Fish
Cc: Ray Ni
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
EmulatorPkg/EmulatorPkg.dsc | 3
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Need reference to ProtectVariableNullLib otherwise build fails.
Cc: Jian J Wang
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add reference for ProtectedVariableLib so build is successful.
Cc: Jian J Wang
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Make reference to new Null ProtectVariableLib.
The null ProtectedVariableLib is used by default.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add references to the different *ProtectedVariableLib.inf.
Also add references to VariableKeyLibNull.inf,
EncryptionVariableLibNull.inf, ProtectedVariableNull.inf.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Nishant C Mistry
Signed-off-by: Jian
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Provide null ecryption variable libraries.
These will be used by default for platforms that don't
support protected variable encryption.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Update RPMC APIs with index parameter because sometimes
there are more than 1 RPMC counter on the platform.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add new KeyService types and defines.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
SecurityPkg/Include/Ppi/KeyServicePpi.h | 57
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Fix GetVariableKey API to match changes in header files.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add encryption/decryption of protected variable functionality.
Add functions to get/set cipher data of a protected variable.
This is use for supporting confidentiality for protected
variables.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Nishant C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add new variable encryption/decryption function prototypes.
Add new variable digest structure. Add new Protected
variable function prototypes. Update RPMC APIs to Add
an index because there is could more than one counter.
Cc: Jian J Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Provide function that retrieves the key for protected
variables.
Cc: Jian J Wang
Cc: Jiewen Yao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Provide new APIs for retrieving variable information.
Add new function stubs for retrieving Protected
variable information.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add Null versions of the ProtectedVariable Library.
This will be the default libraries for platforms that
do not support ProtectedVariable.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add EncryptionVariableLib.h for providing encryption and
decryption services for protected variables.
Add ProtectedVariableLib.h for providing integrity or
variables.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nishant C Mistry
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
New ProtectVariable GUIDs for passing variable information
from PEI phase to SMM phase.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
Signed-off-by: Judah Vang
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add reference to gEfiPeiVariableStoreDiscoveredPpiGuid which
contains information whether variable store is available.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C Mistry
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
The gEdkiiProtectedVariableGlobalGuid HOB contains the global
configuration data structure which is verified in PEI Phase.
The gEdkiiMetaDataHmacVariableGuid is used for saving the
meta data HMAC variable.
The
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Added NameSize and State to AUTH_VARIABLE_INFO struct.
The size of the name and state is needed when creating
the variable digest.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
Signed-off-by: Nishant C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Discover if Variable Store Info HOB has been published
by platform driver. It contains information in regards
to HOB or NV Variable Store availability
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
For a more detail description of the UEFI variable protected feature you can
view the Readme.md located at the following location:
https://github.com/judahvang/edk2/tree/rpmc-update
Judah Vang (28):
MdeModulePkg: Add new GUID for Variable Store Info
SecurityPkg: Add new GUIDs for
I agree that would be a useful tool and in the case of changes such as
this that provide backward compatibility with existing functionality,
particularly helpful.
Some packages such as MdePkg
(https://github.com/tianocore/edk2/blob/master/MdePkg/MdeLibs.dsc.inc)
and NetworkPkg
Reviewed-by: Guo Dong
-Original Message-
From: Tan, Dun
Sent: Wednesday, April 27, 2022 11:46 PM
To: devel@edk2.groups.io
Cc: Tan, Dun ; Ni, Ray ; Dong, Guo
; You, Benjamin ; Rhodes, Sean
; Liu, Zhiguang
Subject: [Patch V2] UefiPayloadPkg: Add definition for PayloadCommandLine HOB
The Standard_Error_Output.log file isn't even really useful (it should
show a diff), but there's something wrong with the coding style in Bhyve.c:
Files with formatting errors:
Formatting errors in Bhyve/AcpiPlatformDxe/Bhyve.c
--
Rebecca Cran
On 4/29/22 07:55, Ard Biesheuvel wrote:
(+
(+ sean, mike)
I tried to merge this but it is rejected by CI, and I got lost in the
maze of CI status and report pages. Could someone please figure out
what's wrong?
https://github.com/tianocore/edk2/pull/2841
On Wed, 27 Apr 2022 at 12:07, Corvin Köhne wrote:
>
> QemuFwCfg is much more
On Tue, 26 Apr 2022 at 03:29, wrote:
>
> From: Michael Kubacki
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> Platforms: This series introduces a new library class called
> VariableFlashInfoLib. Platforms using the variable modules will
> need to specify these library classes.
On Fri, 29 Apr 2022 at 15:39, Pierre Gondois wrote:
>
> Hello Ard,
> Sami is on leave for the next 2 weeks.
> Also, just in case, this patch-set has a dependency on:
> https://edk2.groups.io/g/devel/message/89348
>
Yes, that is why I asked him to review: he is the DynamicTablesPkg
maintainer, so
On Tue, 26 Apr 2022 at 04:19, wrote:
>
> From: Michael Kubacki
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>
> Adds an instance for the library class VariableFlashInfoLib that
> was recently introduced in MdeModulePkg. This change is made to
> allow the new variable driver to
Hello Ard,
Sami is on leave for the next 2 weeks.
Also, just in case, this patch-set has a dependency on:
https://edk2.groups.io/g/devel/message/89348
Regards,
Pierre
On 4/29/22 15:35, Ard Biesheuvel wrote:
On Wed, 27 Apr 2022 at 17:00, PierreGondois wrote:
From: Pierre Gondois
On Wed, 27 Apr 2022 at 17:00, PierreGondois wrote:
>
> From: Pierre Gondois
>
> DEPENDENCY:
> This patch set relies on a fix sent at:
> https://edk2.groups.io/g/devel/message/89348
>
> The DynamicTablesPkg can now generate the AML description of the
> PCI/CPU topology information. Use these new
On Thu, 28 Apr 2022 at 11:53, Edward Pickup wrote:
>
> When booting Linux on FVP RevC, Linux reports the following error:
>
> ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit
>
> This issue is due to the RC Address Limit not being configured in the
> configuration manager for
Signed-off-by: Gerd Hoffmann
Acked-by: Liming Gao
---
.../CompilerIntrinsicsLib.inf| 16
1 file changed, 16 insertions(+)
diff --git a/MdePkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
Signed-off-by: Gerd Hoffmann
Acked-by: Liming Gao
---
.../Library/CompilerIntrinsicsLib/Ia32/Gcc.c | 22 ---
1 file changed, 22 deletions(-)
diff --git a/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
b/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
index
Implementations for those functions already exist,
so remove them to avoid duplicate symbols.
Signed-off-by: Gerd Hoffmann
Acked-by: Liming Gao
---
.../Library/CompilerIntrinsicsLib/Ia32/Gcc.c | 47 ---
1 file changed, 47 deletions(-)
diff --git
Move intrinsics for ia32 from CryptoPkg/Library/IntrinsicLib
to MdePkg/Library/CompilerIntrinsicsLib. Also move strcmp.
Remove CryptoPkg/Library/IntrinsicLib.
Use MdePkg/Library/CompilerIntrinsicsLib instead.
Update all references.
Signed-off-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Acked-by:
Does not exist and is not needed.
Signed-off-by: Gerd Hoffmann
Acked-by: Liming Gao
---
MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
b/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
index
It's not an exact match, edk2 expects "BSD-2-Clause-Patent" but
http://opensource.org/licenses/bsd-license.php references in comments
is "BSD-2-Clause".
Guess I need an explicit Intel explicitly agreeing to this even though
that is a rather minor change ...
Signed-off-by: Gerd Hoffmann
First step in creating a single, common compiler intrinsics library for
everybody who needs it. Move the ArmPkg library to MdePkg, update all
references. No code changes.
Signed-off-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Acked-by: Ard Biesheuvel
Acked-by: Liming Gao
---
Copy over unmodified (except for running through uncrustify), from
https://github.com/tianocore/edk2-libc/tree/master/StdLib/LibC/CRT
Signed-off-by: Gerd Hoffmann
Acked-by: Liming Gao
---
.../Library/CompilerIntrinsicsLib/Ia32/Gcc.c | 283 ++
Update #if conditions so the 64bit version is picked for X64 too.
Signed-off-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Acked-by: Ard Biesheuvel
Acked-by: Liming Gao
---
MdePkg/Library/CompilerIntrinsicsLib/memcmp_ms.c | 2 +-
MdePkg/Library/CompilerIntrinsicsLib/memcpy_ms.c | 2 +-
Signed-off-by: Gerd Hoffmann
Acked-by: Liming Gao
---
.../{memset_ms.c => types_ms.h} | 29 +--
.../Library/CompilerIntrinsicsLib/memcpy_ms.c | 6 +---
.../CompilerIntrinsicsLib/memmove_ms.c| 6 +---
.../Library/CompilerIntrinsicsLib/memset_ms.c | 6 +---
This is an attept to start cleaning up the messy compiler intrinsics
situation. Today we don't have a core intrinsics library, resulting
in everybody creating their own. ArmPkg has one, CryptoPkg has one.
I'm sure there are many more.
This doesn't make sense. Given we can't avoid compiler
On Mon, Apr 25, 2022 at 11:43:49PM +0200, Ojeda Leon, Nicolas via groups.io
wrote:
> Read the "hardware-info" item from fw-cfg to extract specifications
> of PCI host bridges and analyze the 64-bit apertures of them to
> find out the highest 64-bit MMIO address required which determines
> the
Hi,
> > > Can Linux allocate resource for PCI(E) devices? How does it deal with the
> > > IO type?
> >
> > Yes. Details depend a bit on the specific configuration, but in general
> > linux will try assign io address space to pcie root ports and devices
> > plugged into those ports. A
I am asking this because I met a VS2019 build issue when I installed the
VS2022. I had to uninstall it.
Not sure about the latest status.
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Friday, April 29, 2022 5:13 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Sean Brogan
Subject:
Hi tool experts,
I noticed that VS2022 17.1 has been released. Does BaseTools support VS2022? if
no, any plan?
Thanks,
Ray
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89393): https://edk2.groups.io/g/devel/message/89393
Mute This
>
> Hi,
>
> > > I'd say the risk for regressions is rather low, though, given that it
> > > only affects configurations that would fail PCI resource allocation
> > > today. Or am I missing something?
> > >
> > > In any case, the PCIe spec is clear about this: I/O space is optional,
> > > and
On Fri, Apr 29, 2022 at 02:41:25PM +0800, gaoliming wrote:
> Gerd:
> Do you plan to catch this change into edk2 202205 stable tag?
That would be great, yes.
Working on v3 of the series right now (solving conflicts),
will the update post soon.
> For this patch set, Acked-by: Liming Gao
Hi,
> > I'd say the risk for regressions is rather low, though, given that it
> > only affects configurations that would fail PCI resource allocation
> > today. Or am I missing something?
> >
> > In any case, the PCIe spec is clear about this: I/O space is optional,
> > and we need to
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
> Sent: Friday, April 29, 2022 3:00 PM
> To: Gerd Hoffmann
> Cc: Ni, Ray ; devel@edk2.groups.io; Pawel Polawski
> ; Ard Biesheuvel
> ; Gao, Liming ; Wu, Hao
> A ; Oliver Steffen
> ; Leif Lindholm ; Justen,
>
On Fri, 29 Apr 2022 at 08:50, Gerd Hoffmann wrote:
>
> On Wed, Apr 27, 2022 at 03:08:50AM +, Ni, Ray wrote:
> > Ard,
> > can you explain more?
> >
> > Your code changes the PciHostBridge driver to ignore the failure of IO
> > allocation.
> > If IO requirement of certain PCI(E) devices can be
On Wed, Apr 27, 2022 at 03:08:50AM +, Ni, Ray wrote:
> Ard,
> can you explain more?
>
> Your code changes the PciHostBridge driver to ignore the failure of IO
> allocation.
> If IO requirement of certain PCI(E) devices can be ignored, can you change
> the IncompatiblePciDevice protocol
Gerd:
Do you plan to catch this change into edk2 202205 stable tag?
For this patch set, Acked-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: Gerd Hoffmann
> 发送时间: 2022年4月12日 22:07
> 收件人: devel@edk2.groups.io
> 抄送: Maurice Ma ; Andrew Fish
> ; Pawel Polawski ; Benjamin You
> ; Yuwei
Zhuoran:
Ray is the maintainer of PcAtChipsetPkg. Can you collect his feedback on
this change?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Zhuoran Chao
> 发送时间: 2022年4月29日 13:43
> 收件人: devel@edk2.groups.io; Gao, Liming
> 抄送: Ni, Ray
> 主题: Re: [edk2-devel] [PATCH]
65 matches
Mail list logo
