From: Abner Chang
Check the memory block pointer before freeing it.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Abner Chang
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git
[AMD Official Use Only - General]
Hi Mike,
Below are the tickets pulled out from BZ, is there any one you think is not
necessary now?
Abner
713 EDK2Documentmichael.d.kin...@intel.com CONF---
Update EDK II C Coding standard to state a stronger preference for 80
Hi xianglai,
I reply inline.
在 2022/10/21 15:11, xianglai li 写道:
> Serial Port library for LoongarchQemuPkg
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054
>
> Signed-off-by: xianglai li
> ---
> .../LoongArchQemuPkg/Include/Library/Cpu.h| 387 +++
>
Hi Igor,
Yes, we should get the URI to computer system collection by parsing
"/redfish/v1".
Hi Abner,
What do you think about this? And if we like to select authentication method
for Redfish communication in this way, we need to update RedfishCredentialLib.h
because now the authentication
Hi Mike,
This is not my realm of expertise. I'm just trying to fix an issue that I ran
into when enabling crypto.
Can I suggest that someone like the maintainers or someone who knows how the
build works update the build?
Judah
-Original Message-
From: Kinney, Michael D
Sent:
++More for reviewal!
-Original Message-
From: Clark-williams, Zachary
Sent: Friday, October 28, 2022 1:10 PM
To: Kinney, Michael D ; Rabeda, Maciej
; Luo, Heng ; Kuo, Scottie
; Kuo, Ted ; Dutkiewicz, Michal
; devel@edk2.groups.io
Subject: RE: [PATCH v4] NetworkPkg/WifiProfileSync: Add
Thanks for the forward Mike!
Maciej and All,
If you could please review the PR below. I would like to get this review
completed within the week.
Thanks,
Zack
-Original Message-
From: Kinney, Michael D
Sent: Thursday, October 27, 2022 1:09 PM
To: Rabeda, Maciej ; Kinney, Michael D
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4130
Remove TestBaseCryptLibHostAccel.inf and instead use FILE_GUID
override in DSC file to run the same unit test INF against
OpensslLibFull.inf and OpensslLibFullAccel.inf
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
On Thu, Oct 27, 2022 at 15:53:58 +, Michael D Kinney wrote:
> Reviewed-by: Michael D Kinney
Thanks.
Since this is a trivial fix, I just pushed this patch as 4722554cd0a7.
Waiting for Graeme to come back and ack 2/2 on Monday.
/
Leif
> > -Original Message-
> > From:
Hi Nickle,
I think this is a good idea to send a request to the URI which requires the
authentication and then analyze the header of response.
The only thing I would like to discuss is a hardcoded URI -
"/redfish/v1/Systems".
Shouldn't we parse "redfish/v1" json response and get the URI from
Always use the module name with FILE_GUID to generate the host-based
unit test executable image and symbol files. This allows the same
host-based unit test INF file to be used more than once in a single
DSC file with FILE_GUID override. This is valuable when there is a
requirement to run the
From: Pierre Gondois
The ArmMonitorLib provides an abstract interface to issue
an HyperVisor Call (HVC) or System Monitor Call (SMC) depending
on the default conduit.
The PcdMonitorConduitHvc PCD allows to select the default conduit.
The new library relies on the ArmHvcLib and ArmSmcLib
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The EFI_RNG_PROTOCOL published by RngDxe has been updated to
implement the EFI_RNG_ALGORITHM_RAW using the Arm TRNG interface
to provide access to entropy.
Therefore, enable EFI_RNG_PROTOCOL for the Kvmtool
From: Pierre Gondois
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
Add RngDxe support for Arm. This implementation uses the ArmTrngLib
to support the RawAlgorithm and doens't support the RNDR instruction.
To re-use the RngGetRNG(), RngGetInfo() and
From: Pierre Gondois
To re-use the AArch64/RngDxe.c for an Arm implementation,
rename AArch64/RngDxe.c to ArmRngDxe.c.
Acked-by: Leif Lindholm
Signed-off-by: Pierre Gondois
---
.../RngDxe/{AArch64/RngDxe.c => ArmRngDxe.c}| 0
From: Pierre Gondois
PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm
used by the RNDR CPU instruction to generate a random number.
Add a debug warning if the Pcd is not set.
Signed-off-by: Pierre Gondois
---
.../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 10
From: Pierre Gondois
gEfiRngAlgorithmSp80090Ctr256Guid was used as the default algorithm
in RngGetRNG(). The commit below set the default algorithm to
PcdCpuRngSupportedAlgorithm, which is a zero GUID by default.
As the Pcd value is not defined for any platform in the edk2-platfoms
repository,
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
RawAlgorithm is used to provide access to entropy that is suitable
for cryptographic applications. Therefore, add RawAlgorithm support
that provides access to entropy using the ArmTrngLib.
Also remove
From: Pierre Gondois
RngGetBytes() relies on the RngLib. The RngLib might use the RNDR
instruction if the FEAT_RNG feature is present. RngGetInfo and
RngGetRNG both must check that RngGetBytes() is working before
advertising/using it.
To do so, allocate an array storing the available
From: Pierre Gondois
This patch:
-Update RngGetBytes() documentation to align the function
definition and declaration.
-Improve input parameter checking. Even though 'This'
it is not used, the parameter should always point to the
current EFI_RNG_PROTOCOL.
-Removes TimerLib inclusion as
From: Pierre Gondois
RngGetInfo() is one of the 2 functions of the EFI_RNG_PROTOCOL.
RngGetInfo() is currently a mere wrapper around
ArchGetSupportedRngAlgorithms() which is implemented differently
depending on the architecture used.
RngGetInfo() does nothing more than calling
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
Rename RdRandGenerateEntropy() to GenerateEntropy() to provide a
common interface to generate entropy on other architectures.
GenerateEntropy() is intended to generate high quality entropy.
Also move the
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0,
Platform Design Document
(https://developer.arm.com/documentation/den0098/latest/)
defines an interface between an Operating System (OS)
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0,
Platform Design Document
(https://developer.arm.com/documentation/den0098/latest/)
defines an interface between an Operating System (OS)
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator (TRNG) library defines an
interface to access the entropy source on a platform. On platforms
that do not have access to an entropy source, a NULL instance of
the TRNG
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The NIST Special Publications 800-90A, 800-90B and 800-90C
provide recommendations for random number generation. The
NIST 800-90C, Recommendation for Random Bit Generator (RBG)
Constructions, defines the
From: Pierre Gondois
Sort the section containing HVC/SMC libraries prior to
adding new libraries in this specific section.
Reviewed-by: Leif Lindholm
Signed-off-by: Pierre Gondois
---
ArmPkg/ArmPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmPkg/ArmPkg.dsc
From: Pierre Gondois
Add a Null instance of ArmHvcLib in case of library dependencies.
Reviewed-by: Leif Lindholm
Signed-off-by: Pierre Gondois
---
ArmPkg/ArmPkg.dsc | 1 +
ArmPkg/Library/ArmHvcLibNull/ArmHvcLibNull.c | 29 +++
From: Pierre Gondois
The ArmMonitorLib provides an abstract interface to issue
an HyperVisor Call (HVC) or System Monitor Call (SMC) depending
on the default conduit.
The PcdMonitorConduitHvc PCD allows to select the default conduit.
Reviewed-by: Leif Lindholm
Signed-off-by: Pierre Gondois
From: Sami Mujawar
Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for
monitor calls. PcdMonitorConduitHvc is defined as FALSE by default,
meaning the SMC conduit is enabled as default.
Adding PcdMonitorConduitHvc allows selection of HVC conduit to be used
by virtual firmware
From: Pierre Gondois
Bugzilla: Bug 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0, specification
defines an interface between an Operating System (OS) executing at EL1 and
Firmware (FW) exposing a conditioned entropy
Hi Abner,
Have you reviewed the open BZs against the EDK II C Coding Standard.
Are there any other issues that are considered important to fix before
making a new official release?
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via
Hi Igor, Abner,
Thanks for your comments. A quick summary as below:
- BIOS is not supported to disable bootstrap credential service. For security
purposes, BIOS should shutdown credential service with its internal control
mechanism.
- Credential libraries need a cache mechanism to prevent
Hi Bob,
I had run the check and ran it again and this is what I get
C:\Work\Tianocore\edk2-platforms> c:\python38\python
..\edk2\BaseTools\Scripts\PatchCheck.py
.\0001-edk2Platforms-Silicon-Add-VAB-FIT-record-types-suppo.patch
Checking patch file:
Hi Abner,
Yes, you are right that NVRAM variables were deprecated by DMTF.
But we can use our own boot time NVRAM variable to keep FW credentials. That
variable will not be accessible from OS, but since we agreed not to disable
bootstrap credentials service on exit boot event, then OS may get
Hi Sami,
On 10/26/22 14:34, Sami Mujawar wrote:
Hi Pierre,
I have one comment marked inline as [SAMI].
Other than that change this patch should be good.
Yes indeed, thanks for spotting it and for making the modification,
Regards,
Pierre
Regards,
Sami Mujawar
On 10/10/2022 10:20 am,
Hi Sami,
On 10/26/22 14:34, Sami Mujawar wrote:
Hi Pierre,
I have one comment marked inline as [SAMI].
I believe other than that change this patch should be good.
Yes indeed, thanks for spotting it and for making the modification,
Regards,
Pierre
Regards,
Sami Mujawar
On 10/10/2022
Hi Sami,
On 10/26/22 14:34, Sami Mujawar wrote:
Hi Pierre,
There are some minor updates that are required for this patch marked inline as
[SAMI].
If you agree, I will make these changes before merging.
Yes indeed, thanks for spotting it and for making the modification,
Regards,
Pierre
Hi Sami,
On 10/26/22 14:34, Sami Mujawar wrote:
Hi Pierre,
There are some minor changes required marked inline as [SAMI].
If you agree, I will make the changes before merging.
Yes indeed, thanks for spotting it and for making the modification,
Regards,
Pierre
Regards,
Sami Mujawar
On
Hi Sami,
On 10/26/22 14:35, Sami Mujawar wrote:
Hi Pierre,
There is a change required for this patch marked inline as [SAMI].
If you agree, I will make the changes before merging.
Yes indeed, this is a rebase error,
thanks for spotting it,
Regards,
Pierre
Regards,
Sami Mujawar
On
Can you do rename SmmCpuFeaturesLibCommon.c to IntelSmmCpuFeaturesLib.c?
This helps to keep the change history because I see that almost all content
from Common.c is moved to Intelxxx.c.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent:
On Thu, Oct 27, 2022 at 20:10:33 +0200, Ard Biesheuvel wrote:
> On Thu, 27 Oct 2022 at 19:31, Rebecca Cran wrote:
> >
> > Modern platforms use TF-A, so there's no need for support of
> > secondary cores in EDK2 since TF-A will keep them in a holding
> > pen until the PSCI_CPU_ON SMC call is
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Friday, October 28, 2022 11:51 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R ; Kinney, Michael D
>
> Subject: [Patch V2] UefiCpuPkg: Restore HpetTimer after
> CpuExceptionHandlerLib test
>
Cc Mike.
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Tuesday, October 25, 2022 4:51 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
>
> Subject: [edk2-devel] [PATCH] BaseTools: Fix build option overrides Pcd
>
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Friday, October 28, 2022 4:24 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem
> ; Gerd Hoffmann ; James
> Bottomley ; Yao, Jiewen ;
> Tom Lendacky
> Subject: [PATCH V2 1/1] OvmfPkg/VmgExitLig: HALT on
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4125
EPT-violation #VE should be always on shared memory, which means the
shared bit of the GuestPA should be set. But in current #VE Handler
it is not checked. When it occurs, stop TD immediately and log out
the error.
Cc:
Hi mikub...@linux.microsoft.com,
gaolim...@byosoft.com.cn,michael.d.kin...@intel.com, vasudev...@ami.com,
sundares...@ami.com
Created PULL request for Coverity Issue changes.
UFS PR: https://github.com/tianocore/edk2/pull/3552
BugZilla ID: https://bugzilla.tianocore.org/show_bug.cgi?id=3989 (
Hi mikub...@linux.microsoft.com,
gaolim...@byosoft.com.cn,michael.d.kin...@intel.com, vasudev...@ami.com,
sundares...@ami.com
Created PULL request for Coverity Issue changes.
SCSI PR: https://github.com/tianocore/edk2/pull/3544
BugZilla ID: https://bugzilla.tianocore.org/show_bug.cgi?id=3994
[AMD Official Use Only - General]
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Igor
> Kulchytskyy via groups.io
> Sent: Thursday, October 27, 2022 10:42 PM
> To: devel@edk2.groups.io; nick...@nvidia.com; Chang, Abner
>
> Cc: Nick Ramirez
> Subject: Re: [edk2-devel]
Thanks for the patch.
1) I suggest to say "EPT-violation #VE on private memory is not allowed!"
2) The VMM is not trusted. We need put an unconditional CpuDeadLoop() after
TDVMCALL_HALT.
3) Please test both shared address and private address in EPT-violation case.
Thank you
Yao Jiewen
> +
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4125
EPT-violation #VE should be always on shared memory, which means the
shared bit of the GuestPA should be set. But in current #VE Handler
it is not checked. When it occurs, stop TD immediately and log out
the error.
Cc:
51 matches
Mail list logo
