回复: [edk2-devel] [Patch V2 3/7] UnitTestFrameworkPkg: Add googletest submodule and GoogleTestLib

2022-11-07 Thread gaoliming via groups.io
Mike: For new submodule, I think it is also required to be mentioned in License Details section in Edk2\ReadMe.rst Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2022年11月5日 4:25 > 收件人: devel@edk2.groups.io > 抄送: Michael Kubacki ; Sean Brogan > > 主题:

回复: [edk2-devel] 回复: [Patch 1/1] BaseTools/Source/C: Use /Z7 instead of /Zi for host tools

2022-11-07 Thread gaoliming via groups.io
Mike: I submit https://bugzilla.tianocore.org/show_bug.cgi?id=4145 to remove debug symbol in the C tools generation. I am OK to merge current change first. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2022年11月8日 10:00

回复: [edk2-devel] [Patch V2 7/7] MdePkg/Test: Add port of BaseSafeIntLib unit tests to GoogleTest

2022-11-07 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2022年11月5日 4:25 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Zhiguang Liu > > 主题: [edk2-devel] [Patch V2 7/7] MdePkg/Test: Add port of BaseSafeIntLib > unit tests to GoogleTest > > REF:

[edk2-devel] 回复: [Patch V2 2/7] MdePkg/Include/Library: Undefine _ASSERT() if already defined

2022-11-07 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2022年11月5日 4:25 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Zhiguang Liu > > 主题: [Patch V2 2/7] MdePkg/Include/Library: Undefine _ASSERT() if already > defined > > REF:

[edk2-devel] 回复: [Patch V2 1/7] MdePkg/Include: Update Base.h to improve C++ compatibility

2022-11-07 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2022年11月5日 4:25 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Zhiguang Liu > > 主题: [Patch V2 1/7] MdePkg/Include: Update Base.h to improve C++ > compatibility > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, November 8, 2022 #cal-reminder

2022-11-07 Thread gaoliming via groups.io
Few new issues are submitted. Let’s cancel this week meeting. Thanks Liming 发件人: devel@edk2.groups.io 代表 Group Notification 发送时间: 2022年11月8日 10:30 收件人: devel@edk2.groups.io 主题: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, November 8, 2022 #cal-reminder Reminder:

[edk2-devel] Access 64bit address space in 32bit mode

2022-11-07 Thread Yoshinoya
Hello Is it possible to access 64bit address space in 32bit mode? For example, opcode prefix 0x66/67 could let code running in 16bit mode to access 32bit data/address. Or, establishing page table is a must requirement for accessing 64bit address space. Thanks -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-stable202211] [PATCH v3 1/1] CryptoPkg: Sha1 functions causing build errors

2022-11-07 Thread Yao, Jiewen
Thank you. Merged https://github.com/tianocore/edk2/pull/3612 > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, November 8, 2022 9:58 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Vang, > Judah ; Kinney, Michael D > > Cc: Wang, Jian J ; Xiaoyu Lu > ; Jiang, Guomin ;

Re: [edk2-devel] [PATCH] UefiCpuPkg/ResetVector:Add Option to reserve 4K region at 4GB

2022-11-07 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Duggapu, Chinni B > Sent: Monday, November 7, 2022 2:48 PM > To: devel@edk2.groups.io > Cc: Duggapu, Chinni B ; Ni, Ray > > Subject: [PATCH] UefiCpuPkg/ResetVector:Add Option to reserve 4K region > at 4GB > > From: "Duggapu, Chinni B"

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, November 8, 2022 #cal-reminder

2022-11-07 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, November 8, 2022 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] 回复: [Patch 1/1] BaseTools/Source/C: Use /Z7 instead of /Zi for host tools

2022-11-07 Thread Michael D Kinney
Hi Liming, I think a BZ feature request for BaseTools to support building with or without symbols would be good to submit for future stable tag. I would like to see this patch be added to the current stable tag. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On

Re: [edk2-devel] [edk2-stable202211] [PATCH v3 1/1] CryptoPkg: Sha1 functions causing build errors

2022-11-07 Thread Michael D Kinney
I agree. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Monday, November 7, 2022 5:26 PM > To: Vang, Judah ; devel@edk2.groups.io > Cc: Wang, Jian J ; Xiaoyu Lu ; > Jiang, Guomin ; Mistry, > Nishant C > Subject: [edk2-devel] [edk2-stable202211]

[edk2-devel] [edk2-stable202211] [PATCH V4 0/3] Rename VmgExitLib to CcExitLib

2022-11-07 Thread Yao, Jiewen
Hi I suggest we catch this to edk2-stable202211. I already give R-B for V3 before soft-freeze. The V4 just merges 2 patch into 1, based upon other feedback. Thank you Yao, Jiewen > -Original Message- > From: Xu, Min M > Sent: Tuesday, November 8, 2022 9:15 AM > To:

[edk2-devel] [edk2-stable202211] [PATCH v3 1/1] CryptoPkg: Sha1 functions causing build errors

2022-11-07 Thread Yao, Jiewen
Hello I suggest we add this to edk2-stable202211, since this is an important bug fix. The V1 and V2 patch are sent before soft freeze. V3 patch splits V2. Thank you Yao Jiewen > -Original Message- > From: Vang, Judah > Sent: Tuesday, November 8, 2022 4:02 AM > To:

回复: [edk2-devel] 回复: [edk2-devel] [PATCH] ShellPkg:Improved Smbios Type 9 data under smbiosview

2022-11-07 Thread gaoliming via groups.io
Create PR https://github.com/tianocore/edk2/pull/3611 to merge it. Thanks Liming 发件人: devel@edk2.groups.io 代表 gaoliming via groups.io 发送时间: 2022年11月7日 12:19 收件人: devel@edk2.groups.io; saina...@ami.com 抄送: zhichao@intel.com 主题: 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] ShellPkg:Improved

[edk2-devel] [PATCH V4 3/3] Maintainers: Update the VmgExitLib to CcExitLib

2022-11-07 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib is renamed as CcExitLib. The related section in Maintainers.txt should be updated as well. Cc: Michael D Kinney Cc: Liming Gao Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom

[edk2-devel] [PATCH V4 2/3] OvmfPkg/UefiCpuPkg: Add CcExit prefix to the APIs of CcExitLib

2022-11-07 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 APIs which are defined in CcExitLib.h are added with the CcExit prefix. This is to make the APIs' name more meaningful. This change impacts OvmfPkg/UefiCpuPkg. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem Aktas

[edk2-devel] [PATCH V4 1/3] OvmfPkg/UefiCpuPkg/UefiPayloadPkg: Rename VmgExitLib to CcExitLib

2022-11-07 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib once was designed to provide interfaces to support #VC handler and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is introduced, this library is updated to support #VE as well. Now the name of

[edk2-devel] [PATCH V4 0/3] Rename VmgExitLib to CcExitLib

2022-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib once was designed to provide interfaces to support #VC handler and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is introduced, this library is updated to support #VE as well. Now the name of VmgExitLib cannot

回复: [edk2-devel] 回复: [Patch 1/1] BaseTools/Source/C: Use /Z7 instead of /Zi for host tools

2022-11-07 Thread gaoliming via groups.io
Mike: I agree there is no impact with debug symbol in the binary C tools. But, the release version binary C tools should be better for the developer. If you think this change is big, I will submit one BZ for future stable tag release. Thanks Liming > -邮件原件- > 发件人:

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, November 7, 2022 #cal-notice

2022-11-07 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, November 7, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623293 ) *Description:* TianoCore

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, November 7, 2022 #cal-reminder

2022-11-07 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, November 7, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623293 ) *Description:*

[edk2-devel] [PATCH v1 0/1] Enable AES and HKDF

2022-11-07 Thread Judah Vang
https://bugzilla.tianocore.org/show_bug.cgi?id=3992 Need crypto AES to be supported for PEI phase and need crypto KDF to be supported for SMM phase. Update Readme to show AES and HKDF defaults. Judah Vang (1): CryptoPkg: Need to enable crypto functions

[edk2-devel] [PATCH v1 1/1] CryptoPkg: Need to enable crypto functions

2022-11-07 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. Update Readme.md Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry

[edk2-devel] [PATCH v3 0/1] CryptoPkg bug fix

2022-11-07 Thread Judah Vang
https://bugzilla.tianocore.org/show_bug.cgi?id=3991 There is a #define to deprecate Sha1 functions but not all the Sha1 function are wrapped around this #define causing a build error. The fix is to wrap all Sha1 functions with the #define. Judah Vang (1): CryptoPkg: Sha1 functions causing

[edk2-devel] [PATCH v3 1/1] CryptoPkg: Sha1 functions causing build errors

2022-11-07 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3991 Fix build issue when DiSABLE_SHA1_DEPRECATED_INTERFACES is defined. Percolate the #ifndef DiSABLE_SHA1_DEPRECATED_INTERFACES to all the Sha1 functions. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry

Re: [edk2-devel] [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.

2022-11-07 Thread Ankit Sinha
Reviewed-by: Ankit Sinha > -Original Message- > From: Xu, Wei6 > Sent: Monday, November 7, 2022 3:58 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael ; Desimone, > Nathaniel L ; Sinha, Ankit > > Subject: [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID > to PNP0C02.

Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes

2022-11-07 Thread Judah Vang
Jiewen, Thanks. Running the CI now. https://github.com/tianocore/edk2/pull/3609 Judah -Original Message- From: Yao, Jiewen Sent: Monday, November 7, 2022 10:48 AM To: Vang, Judah ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Also, please ensure

Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes

2022-11-07 Thread Yao, Jiewen
Also, please ensure your patch can pass tiano CI. I cannot find the PR to CI for those features. Would you please point to me? Thank you Yao Jiewen > -Original Message- > From: Vang, Judah > Sent: Tuesday, November 8, 2022 2:45 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Subject:

Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes

2022-11-07 Thread Judah Vang
Sure, I can do that. I will resubmit as separate patches. -Original Message- From: Yao, Jiewen Sent: Monday, November 7, 2022 10:42 AM To: devel@edk2.groups.io; Vang, Judah Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Hey Would you please split this patch set to two

Re: [edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

2022-11-07 Thread Judah Vang
Hi all, I resubmitted the patches with an update to the CryptoPkg/Readme. The CryptoPkg.dsc has already been updated with the AES and KDF feature changes. Thanks! Judah -Original Message- From: Kinney, Michael D Sent: Monday, October 24, 2022 10:22 AM To: devel@edk2.groups.io; Vang,

Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes

2022-11-07 Thread Yao, Jiewen
Hey Would you please split this patch set to two different one? They are two different HSDs. Please aware that we are in software freeze phase now. I suggest we include 3991 in this release, because it is an important bug fix. I suggest we defer 3992 to next release, because it is feature

[edk2-devel] [PATCH v2 2/2] CryptoPkg: Need to enable crypto functions

2022-11-07 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 V2: Update Readme.md V1: Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry

[edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes

2022-11-07 Thread Judah Vang
https://bugzilla.tianocore.org/show_bug.cgi?id=3991 https://bugzilla.tianocore.org/show_bug.cgi?id=3992 There is a #define to deprecate Sha1 functions but not all the Sha1 function are wrapped around this #define causing a build error. The fix is to wrap all Sha1 functions with the #define. Need

[edk2-devel] [PATCH v2 1/2] CryptoPkg: Sha1 functions causing build errors

2022-11-07 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3991 Fix build issue when DiSABLE_SHA1_DEPRECATED_INTERFACES is defined. Percolate the #ifndef DiSABLE_SHA1_DEPRECATED_INTERFACES to all the Sha1 functions. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry

Re: [edk2-devel] 1024 VCPU limitation

2022-11-07 Thread Michael D Kinney
Hi Pawel, I see the following union involved in the size of this structure. typedef union { IA32_HANDOFF_STATUS IA32HealthFlags; X64_HANDOFF_STATUSx64HealthFlags; ITANIUM_HANDOFF_STATUSItaniumHealthFlags; } EFI_SEC_PLATFORM_INFORMATION_RECORD; IA32 is 4 bytes per CPU X64

Re: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch

2022-11-07 Thread Michael D Kinney
Hi Abner, Thanks for the review. I agree we should try to get a few more of these resolved for Version 2.3. +Michael Kubacki for Uncrustify configuration settings discussion on the column width and args per line in function call topics. We need to know what the current Uncrustify

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Allow for specified CPU names

2022-11-07 Thread Jeff Brasen via groups.io
This was the simplest approach that I had to solve this issue, but not sure if it would be better to do something smarter. A couple other ideas I had where: - Specify the affinity level that CPUs use and use the levels above that for the containers. - Have a new object that has the container

[edk2-devel] [PATCH] DynamicTablesPkg: Allow for specified CPU names

2022-11-07 Thread Jeff Brasen via groups.io
Allow object to specify the name of processor and processor container nodes and the UID of processor containers. This allows these to be more accurately referenced from other tables. For example for the _PSL method or the UID in the APMT table. The UID and Name for processor container may

Re: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch

2022-11-07 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Mike, You probably missed this email. I checked the below C coding standard spec related BZ and had some comments in line below. > -Original Message- > From: Chang, Abner > Sent: Saturday, October 29, 2022 11:33 AM > To: Kinney, Michael D ;

Re: [edk2-devel] [PATCH v2] CryptoPkg/Readme.md: typo and grammar fixes

2022-11-07 Thread Yao, Jiewen
Merged https://github.com/tianocore/edk2/pull/3608 > -Original Message- > From: Laszlo Ersek > Sent: Monday, November 7, 2022 6:09 PM > To: Yao, Jiewen ; Kinney, Michael D > ; devel@edk2.groups.io > Cc: Zurcher, Christopher ; Jiang, > Guomin ; Wang, Jian J ; > Lu, Xiaoyu1 > Subject: Re:

Re: [edk2-devel] 回复: [PATCH v3 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-11-07 Thread JC
Hi Pedro, this is just a test email Thanks, JC -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96032): https://edk2.groups.io/g/devel/message/96032 Mute This Topic: https://groups.io/mt/94861914/21656 Group Owner:

Re: [edk2-devel] 回复: [PATCH v3 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-11-07 Thread JC
test mail On Mon, Nov 7, 2022 at 9:14 AM Pedro Falcato wrote: > Thanks! > > On Mon, 7 Nov 2022, 01:32 gaoliming via groups.io, byosoft.com...@groups.io> wrote: > >> Create https://github.com/tianocore/edk2/pull/3604 to merge this patch. >> >> >> >> Thanks >> >> Liming >> >> *发件人:*

[edk2-devel] edk2-libc fopen() fails

2022-11-07 Thread Joaqu� Cono Bolillo via groups . io
Hi Rebecca, to my knowledge, you are the maintainer of the AppPkg, that my team is currently using to analyse a very sporadic reboot failure (stuck, about 5 failures out of 100 reboots) on a x86-64 platform that our company is going to ship soon. Since the failure appears while Windows boots, it

[edk2-devel] [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.

2022-11-07 Thread Xu, Wei6
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4141 PRMT device is an unknown device in Device Manager if there is no Windows Driver installed for it. It will cause WHQL Signed Driver test failure. To complete WHQL certification, update PRMT Device CID to PNP0C02. In this way, PRMT Device

[edk2-devel] [PATCH v1 0/1] PrmPkg: Fix WHQL Signed Driver Test failure for PRMT device.

2022-11-07 Thread Xu, Wei6
This patch is to fix the WHQL Signed Driver Test failure when there is no driver installed for PRMT device. The Bugzila link: https://bugzilla.tianocore.org/show_bug.cgi?id=4141 The forked branch for review: https://github.com/xuweiintel/edk2/tree/prm_cid Cc: Michael Kubacki Cc: Nate DeSimone

[edk2-devel] 1024 VCPU limitation

2022-11-07 Thread Paweł Poławski
Hi All, I am trying to run edk2 with more than 1024 VCPU. It looks like it is not possible at the moment and results in an ASSERT trigger. In the past the topic has been analyzed by Laszlo Ersek [1]. It turns out that the limit is result of HOB default allocation being limited to ~64KB, quoting

Re: [edk2-devel] [PATCH v2] CryptoPkg/Readme.md: typo and grammar fixes

2022-11-07 Thread Laszlo Ersek
On 11/06/22 02:19, Yao, Jiewen wrote: > Acked-by: Jiewen Yao Thanks for the ACKs; Jiewen, can you please merge the patch? Thanks Laszlo > >> -Original Message- >> From: Kinney, Michael D >> Sent: Friday, November 4, 2022 11:29 PM >> To: Laszlo Ersek ; devel@edk2.groups.io; Kinney,

Re: [edk2-devel][PATCH v1] IntelFsp2Pkg: Adding FspHelperLib

2022-11-07 Thread Ashraf Ali S
Hi., Instead of Hardcoded FSP ImageBase as 0x1C in FspHelper.nasm, can we have struct from there we can get it. So that in future if the Header is changing assembly code will not get impacted. Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.  -Original Message- From: Kuo, Ted

[edk2-devel][PATCH v1] IntelFsp2Pkg: Adding FspHelperLib

2022-11-07 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4128 Adding FspHelperLib for platform code to consume. There will be another patch raised later for FspSecCore to consume FspHelperLib. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Cc: Chinni B Duggapu Cc: Amy Chan

Re: [edk2-devel] 回复: [PATCH v3 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-11-07 Thread Pedro Falcato
Thanks! On Mon, 7 Nov 2022, 01:32 gaoliming via groups.io, wrote: > Create https://github.com/tianocore/edk2/pull/3604 to merge this patch. > > > > Thanks > > Liming > > *发件人:* devel@edk2.groups.io *代表 *Pedro Falcato > *发送时间:* 2022年11月5日 8:25 > *收件人:* devel@edk2.groups.io;