[AMD Official Use Only - AMD Internal Distribution Only]
Thanks for the clarification, Mike.
Thanks
Abner
From: Kinney, Michael D
Sent: Wednesday, May 29, 2024 10:44:41 PM
To: Chang, Abner ; devel@edk2.groups.io
Cc: Kinney, Michael D
Subject: RE: GitHub PR
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Mike,
Wondering if we also plan to apply GitHub PR process on edk2-platforms repo? Or
other repos under tianocore? I found there is another email thread "Enable
GitHub PR, protected branches, and 'push' label" on edk2-platforms, but no
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 10:08 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
[AMD Official Use Only - AMD Internal Distribution Only]
This patch set was reviewed on GitHub PR.
Hi Abdul, please go ahead to push this patch.
Thanks!
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Tuesday, May 28, 2024 11:28 AM
> To:
From: Abner Chang
Cc: Paul Grimes
Cc: Abdul Lateef Attar
Cc: Igniculus Fu
Cc: Ken Yao
Cc: Eric Xing
Cc: Duke Zhai
Signed-off-by: Abner Chang
---
Platform/AMD/Readme.md | 64 --
1 file changed, 49 insertions(+), 15 deletions(-)
diff --git
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Maintainers.txt | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 877620a1b0..af688c3813 100644
--- a/Maintainers.txt
+++
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Monday, May 20, 2024 9:50 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Grimes, Paul
> Subject:
[AMD Official Use Only - AMD Internal Distribution Only]
Already reviewed internally.
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Monday, May 20, 2024 6:24 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ;
[AMD Official Use Only - AMD Internal Distribution Only]
Already reviewed internally.
Reviewed-by: Abner Chang
Hi Abdul, please add the tag [edk2-platforms] in subject next time when send
the patch for edk2-platforms changes.
Thanks
Abner
> -Original Message-
> From:
[AMD Official Use Only - AMD Internal Distribution Only]
That is awesome! Thank you!
Abner
> -Original Message-
> From: Nhi Pham
> Sent: Thursday, May 16, 2024 4:50 PM
> To: Chang, Abner ; devel@edk2.groups.io;
> nick...@nvidia.com; Rebecca Cran
> Cc: Isaac Oram ; Attar, AbdulLateef
From: Nhi Pham
> >>>> Sent: Monday, May 13, 2024 5:02 PM
> >>>> To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang
> >>>> ; Rebecca Cran
> >>>> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul
> >>>> Lateef) ; Tinh Nguyen
EFI variable until exist boot service.
> > > > Also, give some more descriptions on the code you invoke to
> GetAuthInfo.
> > >
> > > Thanks for your comment. I add descriptions to explain above before
> > > calling GetAuthInfo(). Version 2 path is here:
> > >
>
ments, clicking links, or responding.
>
>
> Abner:
> This change is good to me. Reviewed-by: Liming Gao
>
>
> But, this is not critical issue. So, I suggest to merge it after the stable
> tag.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks! Will merge later after the hard freeze.
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, May 16, 2024 9:04 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Nick
>
fo(). Version 2 path is here:
> https://edk2.groups.io/g/devel/message/118889
>
> Regards,
> Nickle
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Chang,
> Abner
> > via groups.io
> > Sent: Tuesday, April 23, 2024 3:42 PM
> >
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Abner Chang
Hi Nickle,
Do you have the corresponding PR for this? I will merge it after hard freeze.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nickle
> Wang via groups.io
> Sent:
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Mike, Liming and Zhiguang,
Could you please check this patch sent two weeks ago? The corresponding BZ
ticket is 4775. We overlooked tracking this issue and missed the 202405 stable
release. As this impacts the build, do you think we
[AMD Official Use Only - AMD Internal Distribution Only]
Already reviewed off-line.
For this patch set, Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Wednesday, May 15, 2024 11:50 AM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ;
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 8, 2024 4:09 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH]
[AMD Official Use Only - General]
Hi MdeModulePkg maintainers,
Please review this patch as we would like to merge it before the upcoming hard
freeze.
Thanks
Abner
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming
[AMD Official Use Only - General]
Hi MdeModulePkg maintainers,
Please review this patch as we would like to merge it before the upcoming hard
freeze.
Thanks
Abner
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming
[AMD Official Use Only - General]
Hi MdeModulePkg maintainers,
Please review this patch as we would like to merge it before the upcoming hard
freeze.
Thanks
Abner
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Friday, May 3, 2024 9:57 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: rename
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Friday, May 3, 2024 9:56 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH] RedfishPkg: Rename x-uefi-redfish to
[AMD Official Use Only - General]
Acked-by: Abner Chang
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Ray Ni ;
> Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
>
> Subject: [PATCH v1 6/6] MdeModulePkg:
[AMD Official Use Only - General]
We had reviewed this patch internally before sending this to community.
Reviewed-by: Abner Chang
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Attar, AbdulLateef (Abdul
[AMD Official Use Only - General]
Acked-by: Abner Chang
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Ray Ni ;
> Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
>
> Subject: [PATCH v1 4/6]
[AMD Official Use Only - General]
Acked-by: Abner Chang
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Ray Ni ;
> Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
>
> Subject: [PATCH v1 3/6] MdeModulePkg:
[AMD Official Use Only - General]
We had reviewed this patch internally before sending this to community.
Reviewed-by: Abner Chang
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Attar, AbdulLateef (Abdul
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Chesley, Brit
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Attar, AbdulLateef (Abdul
> Lateef)
> Subject: [PATCH v1 1/6] MdePkg/SpiConfiguration: Correct
[AMD Official Use Only - General]
Hi Brit,
We have to fix the CI failure.
Thanks
Abner
> -Original Message-
> From: Chesley, Brit
> Sent: Tuesday, April 30, 2024 10:06 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Ray Ni ;
> Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
>
>
[AMD Official Use Only - General]
Thanks for reviewing this, the change is merged.
Abner
From: Attar, AbdulLateef (Abdul Lateef)
Sent: Tuesday, April 30, 2024 3:36 PM
To: Chang, Abner ; devel@edk2.groups.io
Cc: Nickle Wang
Subject: Re: [edk2-platforms][PATCH] ManageabilityPkg: Remove the
From: Abner Chang
BZ# 4695
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Nickle Wang
---
.../ManageabilityPkg/ManageabilityPkg.dsc | 72 ++-
1 file changed, 56 insertions(+), 16 deletions(-)
diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc
[AMD Official Use Only - General]
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, April 23, 2024 3:09 PM
> To: Igor Kulchytskyy ; Chang, Abner
> ; devel@edk2.groups.io
> Cc: Nick Ramirez
> Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg:
> introduce
[AMD Official Use Only - General]
Hi Sean,
I was struggling when introduce IPMI KCS base IO PCD in Mde, although it is a
industry value but seems it is fine to have it in ManageabilityPkg. How do you
think if we relocate those IPMI PCDs back to ManageabilityPkg?
Thanks
Abner
From: Sean
[AMD Official Use Only - General]
Hi Nickle,
One comment and few questions,
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, April 18, 2024 8:28 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH]
[AMD Official Use Only - General]
I guess my RB misled contributors thought the patch is good to merge. However,
I was thinking Eric's team should give the final RB after the validation as
they are the maintainers for the subordinate VanGoghBoard platform. Suppose the
impacted packages should
al Message-----
> > From: devel@edk2.groups.io On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Sunday, August 13, 2023 12:37 PM
> > To: devel@edk2.groups.io
> > Cc: Michael D Kinney ; Andrew Fish
> > ; Leif Lindholm ; Attar,
> > AbdulLateef (Abdul Lateef) ;
[AMD Official Use Only - General]
Right, Abdul's RB is sufficient!
Thanks
Abner
From: Ni, Ray
Sent: Friday, April 19, 2024 11:35:17 AM
To: Wu, Jiaxin ; devel@edk2.groups.io
Cc: Zeng, Star ; Gerd Hoffmann ; Kumar,
Rahul R ; Dong, Guo ; Rhodes, Sean
; Lu,
[AMD Official Use Only - General]
Reviewed-by:
Thanks
> -Original Message-
> From: Lendacky, Thomas
> Sent: Monday, April 15, 2024 11:01 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Roth, Michael ; Min Xu
> ; Leif Lindholm ; Michael D
> Kinney ; Chang, Abner
[AMD Official Use Only - General]
Hi maintainers,
Please help to check this update as we added an entry for Bus\Spi under
MdeModulePkg.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Sunday, August 13, 2
ht
> statement.
>
> Regards,
> Nickle
>
> > -----Original Message-
> > From: devel@edk2.groups.io On Behalf Of Chang,
> Abner
> > via groups.io
> > Sent: Wednesday, April 10, 2024 9:43 AM
> > To: Nickle Wang ; devel@edk2.groups.io
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Monday, April 1, 2024 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [edk2-redfish-client][PATCH v2 2/2]
[AMD Official Use Only - General]
Hi Nickle,
I don't see the obvious coding error in this patch. However, I think we can
remove HPE copyright from Redfish secure boot feature driver, as this is a new
feature driver and HPE doesn't have contributions to these files, right? If so,
then please
[AMD Official Use Only - General]
Thanks Igor. This patch set is merged.
Abner
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Thursday, April 4, 2024 9:34 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Nickle Wang
> Subject: RE: [EXTERNAL] [PATCH V3 0/6] Config language
From: Nickle Wang
"MenuPath" is the attribute in BIOS attribute registry. To support
reporting this attribute, we need to include the formset without
x-uefi-redfish support in database. So driver can find menu path to
target attribute in BIOS menu.
Signed-off-by: Nickle Wang
Cc: Abner Chang
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Nickle Wang
Reviewed-by: Nickle Wang
---
EmulatorPkg/EmulatorPkg.dsc | 21 +
1 file changed, 21 insertions(+)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index 85134b07816..5fa1ed345a3 100644
---
From: Abner Chang
Add the condition check when delete HII string.
Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP"
and the statement value type = EFI_IFR_TYPE_STRING.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
Reviewed-by: Nickle Wang
---
From: Abner Chang
Add RedfishPlatformConfigDxe debug capability that aligns
with edk2 Redfish debug mechanism.
- PcdRedfishPlatformConfigDebugProperty, add PCD to control
RedfishPlatformConfigDxe subordinate of Redfish debug
capabilities.
- PcdRedfishPlatformConfigFeatureProperty, add PCD
From: abnchang
Build up the x-uefi-redfish string database for the Redfish confg
language searching, instead of using HII String protocol.
This can improve the time consumption lot on searching strings.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
Reviewed-by:
From: Abner Chang
PR # 5517
In V3, adddressed comments from Nickle and Igor.
In V2, add patch 6/6 contibuted by Nvidia for updating BIOS
menu path implementation based on the performance improvement.
In this patch set,
1 We enhance the config language searching algorithm.
As the performance
From: Abner Chang
Introduce DEBUG_REDFISH macro for the debug message
of edk2 Redfish components.
DEBUG_REDFISH can be used in any edk2 Redfish component
with Redfish DebugCatagory as the first parameter.
Whether the debug message is output or not depends on
the platform setting of
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Maintainers.txt | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 799f27f914c..7d9cdca611f 100644
--- a/Maintainers.txt
+++
From: abnchang
BZ#: 4471
SPI NOR Flash JEDEC Serial Flash Discoverable Driver
implementation.
Signed-off-by: Abner Chang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdeModulePkg/MdeModulePkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
From: Abner Chang
BZ#: 4473
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Jian J Wang
Cc: Abdul Lateef Attar
---
MdeModulePkg/MdeModulePkg.dec | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec
From: abnchang
BZ#: 4472
Add definition of JEDEC Serial Flash Discoverable Parameters
(SFDP) specification.
https://www.jedec.org/standards-documents/docs/jesd216b
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
From: abnchang
BZ#: 4471
Update definitions according to PI spec 1.8 errata A
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdePkg/Include/Protocol/SpiConfiguration.h | 10 +-
From: Abner Chang
Sending V4 for review as SPI related ECR is approved by
PIWG in PI spec 1.8A
In V5: Correct patch 6/6, as some source files are fixed in this patch.
In RESEND V4: Add Cc in patch 6/6
In V4: Enhance timeout algorithm
In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to
From: abnchang
BZ#: 4471
SPI NOR Flash JEDEC Serial Flash Discoverable Driver
implementation.
Signed-off-by: Abner Chang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdeModulePkg/MdeModulePkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
---
.../Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c | 12 ++--
.../Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c | 12 ++--
Maintainers.txt
From: Abner Chang
BZ#: 4473
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Jian J Wang
Cc: Abdul Lateef Attar
---
MdeModulePkg/MdeModulePkg.dec | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec
From: abnchang
BZ#: 4472
Add definition of JEDEC Serial Flash Discoverable Parameters
(SFDP) specification.
https://www.jedec.org/standards-documents/docs/jesd216b
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
From: Abner Chang
Sending V4 for review as SPI related ECR is approved by
PIWG in PI spec 1.8A
In RESEND V4: Add Cc in patch 6/6
In V4: Enhance timeout algorithm
In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to
MdeModulePkg.dec.
In V2: Add maintainer entry for Bus/Spi.
This patch
From: abnchang
BZ#: 4471
Update definitions according to PI spec 1.8 errata A
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdePkg/Include/Protocol/SpiConfiguration.h | 10 +-
[AMD Official Use Only - General]
Hi Nickle, I will rename it and send out the V3 together with Igor's comments
addressed.
Thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, March 27, 2024 10:40 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy
[AMD Official Use Only - General]
Hi Igor, my responses to your three comments in line.
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Thursday, April 4, 2024 8:44 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Nickle Wang
> Subject: RE: [EXTERNAL] [PATCH V2 1/6]
>
From: Abner Chang
Signed-off-by: Abner Chang
M: Andrew Fish
M: Leif Lindholm
M: Michael D Kinney
---
Maintainers.txt | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 799f27f914c..7d9cdca611f 100644
--- a/Maintainers.txt
+++
From: abnchang
BZ#: 4471
SPI NOR Flash JEDEC Serial Flash Discoverable Driver
implementation.
Signed-off-by: Abner Chang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdeModulePkg/MdeModulePkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
From: abnchang
BZ#: 4472
Add definition of JEDEC Serial Flash Discoverable Parameters
(SFDP) specification.
https://www.jedec.org/standards-documents/docs/jesd216b
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
From: Abner Chang
BZ#: 4473
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Jian J Wang
Cc: Abdul Lateef Attar
---
MdeModulePkg/MdeModulePkg.dec | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec
From: abnchang
BZ#: 4471
Update definitions according to PI spec 1.8 errata A
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdePkg/Include/Protocol/SpiConfiguration.h | 10 +-
From: Abner Chang
Sending V4 for review as SPI related ECR is approved by
PIWG in PI spec 1.8A
IN V4: Enhance timeout algorithm
In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to
MdeModulePkg.dec.
In V2: Add maintainer entry for Bus/Spi.
This patch fixes the missing SPI defintions per
[AMD Official Use Only - General]
Hi Nickle,
Use Uri makes sense to me. Thanks! Please go ahead to merge it.
Reviewed-by: Abner Chang .
> -Original Message-
> From: Nickle Wang
> Sent: Monday, April 1, 2024 10:38 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
>
ups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Thursday, March 28, 2024 2:54 PM
> To: Nickle Wang ; devel@edk2.groups.io; Mike
> Maslenkin
> Cc: Igor Kulchytskyy
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2]
> RedfishClientPkg: Set SettingsObject
[AMD Official Use Only - General]
Acked-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Saturday, March 30, 2024 1:23 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Michael D Kinney
> ; Liming Gao ;
> Zhiguang Liu
>
[AMD Official Use Only - General]
Please update AMD copyright to 2024.
Thanks
Abner
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Friday, March 29, 2024 11:17 AM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang,
> Abner ; Michael D Kinney
> ; Liming
[AMD Official Use Only - General]
Hi @Mike Maslenkin, would you like to review this patch again as I addressed
your comments in V5 patch set.
Thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, March 26, 2024 8:14 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc:
[AMD Official Use Only - General]
Hi Igor,
If time is allowed, please also review this patch set.
Thanks
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, March 27, 2024 3:42 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy
> Subject: RE: [PATCH V2
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Nickle Wang
---
EmulatorPkg/EmulatorPkg.dsc | 21 +
1 file changed, 21 insertions(+)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index 85134b07816..5fa1ed345a3 100644
---
From: Nickle Wang
"MenuPath" is the attribute in BIOS attribute registry. To support
reporting this attribute, we need to include the formset without
x-uefi-redfish support in database. So driver can find menu path to
target attribute in BIOS menu.
Signed-off-by: Nickle Wang
Cc: Abner Chang
From: Abner Chang
Add the condition check when delete HII string.
Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP"
and the statement value type = EFI_IFR_TYPE_STRING.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
---
From: Abner Chang
Add RedfishPlatformConfigDxe debug capability that aligns
with edk2 Redfish debug mechanism.
- PcdRedfishPlatformConfigDebugProperty, add PCD to control
RedfishPlatformConfigDxe subordinate of Redfish debug
capabilities.
- PcdRedfishPlatformConfigFeatureProperty, add PCD
From: Abner Chang
Introduce DEBUG_REDFISH macro for the debug message
of edk2 Redfish components.
DEBUG_REDFISH can be used in any edk2 Redfish component
with Redfish DebugCatagory as the first parameter.
Whether the debug message is output or not depends on
the platform setting of
From: abnchang
Build up the x-uefi-redfish string database for the Redfish confg
language searching, instead of using HII String protocol.
This can improve the time consumption lot on searching strings.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
---
From: Abner Chang
PR # 5491
In V2, add patch 6/6 contibuted by Nvidia for updating BIOS
menu path implementation based on the performance improvement.
In this patch set,
1 We enhance the config language searching algorithm.
As the performance of searching config language using HII GetString
[AMD Official Use Only - General]
For this patch set, Reviewed-by: Abner Chang
Hi Nickle, please also take a look at this change. Thanks
Abner
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, March 23, 2024 8:01 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor
e config language
> > >
> > > Caution: This message originated from an External Source. Use proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > Hi Abner,
> > >
> > > > On 22. 3. 2024., at 1
From: Abner Chang
Use SetRedfishSettingsObjectsUri to set the config language
for SettingsObject URI.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 +
From: Abner Chang
Set SettingsObject URI in @Redfish.Settings resource as the config
language which is the same as the config language of parent URI
that mandates @Redfish.Settings.
With this, we can find the config language of the properties in
SettingsObject URI.
Signed-off-by: Abner Chang
dk2-redfish-client][PATCH V3 1/2]
> RedfishClientPkg: Set SettingsObject URI as the config language
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> > On 22
From: Abner Chang
Set SettingsObject URI in @Redfish.Settings resource as the config
language which is the same as the config language of parent URI
that mandates @Redfish.Settings.
With this, we can find the config language of the properties in
SettingsObject URI.
Signed-off-by: Abner Chang
From: Abner Chang
Use SetRedfishSettingsObjectsUri to set the config language
for SettingsObject URI.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 1 +
From: Abner Chang
Add RedfishPlatformConfigDxe debug capability that aligns
with edk2 Redfish debug mechanism.
- PcdRedfishPlatformConfigDebugProperty, add PCD to control
RedfishPlatformConfigDxe subordinate of Redfish debug
capabilities.
- PcdRedfishPlatformConfigFeatureProperty, add PCD
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Nickle Wang
---
EmulatorPkg/EmulatorPkg.dsc | 21 +
1 file changed, 21 insertions(+)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index 85134b07816..5fa1ed345a3 100644
---
From: Abner Chang
Add the condition check when delete HII string.
Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP"
and the statement value type = EFI_IFR_TYPE_STRING.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
---
From: abnchang
Build up the x-uefi-redfish string database for the Redfish confg
language searching, instead of using HII String protocol.
This can improve the time consumption lot on searching strings.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
---
From: Abner Chang
Introduce DEBUG_REDFISH macro for the debug message
of edk2 Redfish components.
DEBUG_REDFISH can be used in any edk2 Redfish component
with Redfish DebugCatagory as the first parameter.
Whether the debug message is output or not depends on
the platform setting of
From: Abner Chang
PR # 5491
In this patch set,
1 We enhance the config language searching algorithm.
As the performance of searching config language using HII GetString is
pretty slow. For the example, 1800 HII BIOS options takes over 30 mins
to build up the metadata required for Redfish
1 - 100 of 1182 matches
Mail list logo
