Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-05-06 Thread Chao Li
Hi Ard, Thanks, Chao On 2024/5/6 18:24, Ard Biesheuvel wrote: On Mon, 6 May 2024 at 12:02, Chao Li wrote: Hi Gerd, Thanks, Chao On 2024/3/19 16:03, Gerd Hoffmann wrote: Hi, I can't tell the implementation scheme of the current lib and existing lib implementation scheme which one is

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-05-06 Thread Ard Biesheuvel
On Mon, 6 May 2024 at 12:02, Chao Li wrote: > > Hi Gerd, > > > Thanks, > Chao > On 2024/3/19 16:03, Gerd Hoffmann wrote: > > Hi, > > I can't tell the implementation scheme of the current lib and existing > lib implementation scheme which one is better, Could you give we some > advice? > > I'd

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-05-06 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/19 16:03, Gerd Hoffmann wrote: Hi, I can't tell the implementation scheme of the current lib and existing lib implementation scheme which one is better, Could you give we some advice? I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-19 Thread Gerd Hoffmann
On Tue, Mar 19, 2024 at 05:10:39PM +0800, Chao Li wrote: > He Gerd, > > > Speaking of this series: maybe split it into two? The first part > > of this series with the Mde*Pkg + UefiPkg changes looks almost ready > > to merge to me, so maybe we can get that in while still sorting out > > the

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-19 Thread Chao Li
He Gerd, Thanks, Chao On 2024/3/19 16:03, Gerd Hoffmann wrote: Hi, I can't tell the implementation scheme of the current lib and existing lib implementation scheme which one is better, Could you give we some advice? I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-19 Thread Gerd Hoffmann
Hi, > > > I can't tell the implementation scheme of the current lib and existing > > > lib implementation scheme which one is better, Could you give we some > > > advice? > > I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as > > it is not really loongarch-specific. > > >

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-18 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/18 23:21, Gerd Hoffmann wrote: On Sat, Mar 16, 2024 at 06:19:00PM +0800, lixianglai wrote: Hi Gerd: On Mon, Mar 11, 2024 at 02:39:24AM -0700, Chao Li wrote: Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. What are the differences to the

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-18 Thread Gerd Hoffmann
On Sat, Mar 16, 2024 at 06:19:00PM +0800, lixianglai wrote: > Hi Gerd: > > On Mon, Mar 11, 2024 at 02:39:24AM -0700, Chao Li wrote: > >> Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. > > What are the differences to the ArmVirtPkg version? > In this lib we have assigned the

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-16 Thread xianglai
Hi Gerd: > On Mon, Mar 11, 2024 at 02:39:24AM -0700, Chao Li wrote: >> Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. > What are the differences to the ArmVirtPkg version? In this lib we have assigned the following three pcd variables: PcdFlashNvStorageVariableBase

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 02:39:24AM -0700, Chao Li wrote: > Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. What are the differences to the ArmVirtPkg version? Is it possible to have a FdtNorFlashQemuLib which is shared between arm and loongarch? And maybe risc-v too? take

[edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-11 Thread Chao Li
Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan Qian Signed-off-by: Chao Li Co-authored-by: Xianglai Li