Re: [edk2-devel] [PATCH v5 07/19] MdeModulePkg: Add new Variable functionality

2022-11-13 Thread Wang, Jian J
convention. Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wang, Jian > J > Sent: Monday, November 14, 2022 11:43 AM > To: Vang, Judah ; devel@edk2.groups.io > Cc: Gao, Liming ; Wu, Hao A > ; Mistry, Nishant C > Subject: Re: [edk

Re: [edk2-devel] [PATCH v5 07/19] MdeModulePkg: Add new Variable functionality

2022-11-13 Thread Wang, Jian J
Hi Judah, See my comments (starting with [JianJW]) inline below. > -Original Message- > From: Vang, Judah > Sent: Sunday, November 06, 2022 3:35 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Hao A ; Mistry, > Nishant C > Subject: [PATCH v5 07/19] MdeModulePkg:

[edk2-devel] [PATCH v5 07/19] MdeModulePkg: Add new Variable functionality

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V5: Add PEI Variable Protection into a new directory and leave the existing PEI Variable unchanged. V3: Update GetNvVariableStore() to call GetVariableFlashNvStorageInfo() and SafeUint64ToUint32(). V1: Provide new APIs for retrieving