Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal

Hi Ray please help to merge this if no concerns, thanks. On Tue 11. Oct 2022 at 01:50, Sheng Lean Tan via groups.io wrote: > Thanks Ray for the review. > FYI Sean has also push the github PR here: > > https://github.com/tianocore/edk2/pull/3389 > > > -- Best Regards, *Lean Sheng Tan*

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 10/25/2022 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 10/25/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] 回复: [PATCH V4 00/10] Introduce Lazy-accept for Tdx guest

Hi, Liming In Dionna's latest patch-sets the name of accept_all_unaccepted_memory has been changed to BZ3987_MEMORY_ACCEPTANCE_PROTOCOL. https://edk2.groups.io/g/devel/message/95525 https://edk2.groups.io/g/devel/message/95530 So now these 2 protocols are named as

Re: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Define a SMBIOS Structure/Table type

[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Sami Mujawar > Sent: Tuesday, October 18, 2022 11:34 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; alexei.fedo...@arm.com; > pierre.gond...@arm.com; gmahade...@nvidia.com; Chang, Abner > ;

Re: [edk2-devel] [PATCH v1 2/2] DynamicTablesPkg: Add SMBIOS table dispatcher

[AMD Official Use Only - General] > -Original Message- > From: Sami Mujawar > Sent: Tuesday, October 18, 2022 11:34 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; alexei.fedo...@arm.com; > pierre.gond...@arm.com; gmahade...@nvidia.com; Chang, Abner > ; jbra...@nvidia.com;

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/3] Silicon/Intel: Fix invalid DEBUG() macros

The series has been pushed as ba4318a~..8ea6ec3 Thanks, Nate -Original Message- From: mikub...@linux.microsoft.com Sent: Wednesday, October 12, 2022 7:16 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Luo, Heng ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject:

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/3] Silicon/Intel: Fix invalid DEBUG() macros

For the series... Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Wednesday, October 12, 2022 7:16 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Luo, Heng ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [edk2-platforms][PATCH v2 0/3]

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: FSP should support input UPD as NULL.

Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Sunday, October 23, 2022 9:05 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2Pkg: FSP should support input UPD as NULL. REF:

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 10/24/2022 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* 10/24/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610036 ) *Description:* TianoCore community,

[edk2-devel] [edk2-libc Patch 0/1] Py3 UEFI help built-in function issue fix

This patch fixes help built-in function issue which reported by following BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4107 Ajay Kadapathri (1): Python/Python3.6.8: help built-in function issue fix .../Python/Python-3.6.8/PyMod-3.6.8/Include/pyconfig.h | 5 + 1 file changed, 5

[edk2-devel] [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4107 Observed that help built-in function in Python UEFI interpreter is not giving the full help text information of python constructs such as functions, objects , class and etc. This patch request fixes this issue, once this patch is applied

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

Hey! Sorry if this was asked. I was wondering if this patchset is in some git repo which I pull from as I struggle to get a buildable tree by applying this patchset to whatever I can find. I tried https://github.com/deeglaze/edk2.git ( https://github.com/deeglaze/edk2.git ) enable_umv7 but it

[edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

OpenCore folks established an ASAN-equipped project to fuzz Ext4Dxe, which was able to catch these (mostly harmless) issues. Signed-off-by: Pedro Falcato Cc: Vitaly Cheptsov Cc: Marvin Häuser Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Library/BaseLib/SafeString.c | 24

[edk2-devel] Event: Tools, CI, Code base construction meeting series - 10/24/2022 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* 10/24/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610036 ) *Description:* TianoCore

[edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

OpenCore folks established an ASAN-equipped project to fuzz Ext4Dxe, which was able to catch these (mostly harmless) issues. Signed-off-by: Pedro Falcato Cc: Vitaly Cheptsov Cc: Marvin Häuser Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Library/BaseLib/SafeString.c | 20

[edk2-devel] [PATCH v8 3/7] MdeModulePkg: Notify BeforeExitBootServices in CoreExitBootServices

Location of notification is has been specified in UEFI v2.9. Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Ard Biesheuvel Cc: "Min M. Xu" Cc: Andrew Fish Cc: "Michael D. Kinney" Cc: Ray Ni Signed-off-by: Dionna Glaze --- MdeModulePkg/Core/Dxe/DxeMain.inf

[edk2-devel] [PATCH v8 7/7] OvmfPkg/PlatformPei: SEV-SNP make >=4GB unaccepted

Instead of eagerly accepting all memory in PEI, only accept memory under the 4GB address. This allows a loaded image to use the MEMORY_ACCEPTANCE_PROTOCOL to disable the accept behavior and indicate that it can interpret the memory type accordingly. This classification is safe since

[edk2-devel] [PATCH v8 6/7] OvmfPkg: Implement AcceptAllUnacceptedMemory in CocoDxe

This protocol implementation disables the accept-all-memory behavior of the BeforeExitBootServices event this driver adds. Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Ard Biesheuvel Cc: "Min M. Xu" Cc: Andrew Fish Cc: "Michael D. Kinney" Signed-off-by:

[edk2-devel] [PATCH v8 5/7] MdePkg: Introduce the MemoryAcceptance protocol

The default behavior for unaccepted memory is to accept all memory when ExitBootServices is called. An OS loader can use this protocol to disable this behavior to assume responsibility for memory acceptance and to affirm that the OS can handle the unaccepted memory type. This is a candidate for

[edk2-devel] [PATCH v8 4/7] OvmfPkg: Introduce CocoDxe driver

This driver is meant as a join point for all Confidential Compute technologies to put shared behavior that doesn't belong anywhere else. The first behavior added here is to accept all unaccepted memory at ExitBootServices if the behavior is not disabled. This allows safe upgrades for OS loaders

[edk2-devel] [PATCH v8 2/7] MdePkg: Add EFI_EVENT_BEFORE_EXIT_BOOT_SERVICES_GUID

Event group as defined in UEFI standard v2.9. Cc: Ard Biescheuvel Cc: "Min M. Xu" Cc: Gerd Hoffmann Cc: James Bottomley Cc: Tom Lendacky Cc: Jiewen Yao Cc: Erdem Aktas Signed-off-by: Dionna Glaze --- MdePkg/Include/Guid/EventGroup.h | 5 + MdePkg/MdePkg.dec| 5 -

[edk2-devel] [PATCH v8 1/7] OvmfPkg: Realize EfiMemoryAcceptProtocol in AmdSevDxe

From: Sophia Wolf When a guest OS does not support unaccepted memory, the unaccepted memory must be accepted before returning a memory map to the caller. EfiMemoryAcceptProtocol is defined in MdePkg and is implemented / Installed in AmdSevDxe for AMD SEV-SNP memory acceptance. Cc: Gerd

[edk2-devel] [PATCH v8 0/7] Add safe unaccepted memory behavior

These seven patches build on the lazy-accept patch series "Introduce Lazy-accept for Tdx guest" by adding SEV-SNP support for the MemoryAccept protocol, and importantly making eager memory acceptance the default behavior. We implement a standardized event group from UEFI v2.9,

Re: [edk2-devel] [Patch v2 00/11] Remove all UGA support

Hi, What is the status of this patch series and BZ? I think it would be really good to remove UGA usage from edk2 for the next stable tag release. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin Jiang > Sent: Thursday, July 14, 2022 6:51 PM > To:

Re: [edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

Hi Judah, There was an update to CryptoPkg pushed yesterday. 1) There is a CryptoPkg/Readme.md with tables and DSC content for services that are enabled in each phase. I think that needs updates too for the AES and KDF features. 2) The CryptoPkg.dsc file has recommended settings for PEI,

Re: [edk2-devel] [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types support in FitGen.c

@Gao, Liming, Can you please review the patch and let me know if this can be merged? Thanks in advance for your help. Regards, Pavamana -Original Message- From: Hv, Pavamana Sent: Wednesday, October 19, 2022 8:57 PM To: devel@edk2.groups.io Cc: Hv,

[edk2-devel] [PATCH 11/11] ArmPlatformPkg: Retire NorFlashDxe driver

The NorFlashDxe driver in ArmPlatformPkg was shared between development platforms built by ARM Ltd, and virtual platforms that were once modeled after Versatile Express, but have very little in common with actual bare metal implementations. Both sides have migrated to a domain specific version of

[edk2-devel] [PATCH 10/11] ArmVirtPkg/ArmVirtKvmTool: Migrate to OVMF's VirtNorFlashDxe

Migrate to the virt specific NOR flash driver as the ArmPlatformPkg is going away. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtKvmTool.dsc| 4 ++-- ArmVirtPkg/ArmVirtKvmTool.fdf| 2 +-

[edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirtQemu: migrate to OVMF's VirtNorFlashDxe

Switch to the virt specific NorFlashDxe driver implementation that was added recently. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.dsc | 4 ++-- ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 2 +- ArmVirtPkg/ArmVirtQemuKernel.dsc

[edk2-devel] [PATCH 08/11] OvmfPkg/VirtNorFlashDxe: use EFI_MEMORY_WC and drop AlignedCopyMem()

NOR flash emulation under KVM involves switching between two modes, where array mode is backed by a read-only memslot, and programming mode is fully emulated, i.e., the memory region is not backed by anything, and the faulting accesses are forwarded to the VMM by the hypervisor, which translates

[edk2-devel] [PATCH 07/11] OvmfPkg/VirtNorFlashDxe: avoid switching between modes in a tight loop

Currently, when dealing with small updates that can be written out directly (i.e., if they only involve clearing bits and not setting bits, as the latter requires a block level erase), we iterate over the data one word at a time, read the old value, compare it, write the new value, and repeat,

[edk2-devel] [PATCH 05/11] OvmfPkg/VirtNorFlashDxe: drop block I/O protocol implementation

We never boot from NOR flash, and generally rely on the firmware volume PI protocols to expose the contents. So drop the block I/O protocol implementation from VirtNorFlashDxe. Signed-off-by: Ard Biesheuvel --- OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 49 ++

[edk2-devel] [PATCH 06/11] OvmfPkg/VirtNorFlashDxe: avoid array mode switch after each word write

NorFlashWriteSingleWord() switches into programming mode and back into array mode for every single word that it writes. Under KVM, this involves tearing down the read-only memslot, and setting it up again, which is costly and unnecessary. Instead, move the array mode switch into the callers, and

[edk2-devel] [PATCH 02/11] OvmfPkg/VirtNorFlashDxe: clone ArmPlatformPkg's NOR flash driver

QEMU's mach-virt is loosely based on ARM Versatile Express, and inherits its NOR flash driver, which is now being used on other QEMU emulated architectures as well. In order to permit ourselves the freedom to optimize this driver for use under KVM emulation, let's clone it into OvmfPkg, so we

[edk2-devel] [PATCH 03/11] OvmfPkg/VirtNorFlashDxe: remove CheckBlockLocked feature

We inherited a feature from the ArmPlatformPkg version of this driver that never gets enabled. Let's remove it. Signed-off-by: Ard Biesheuvel --- OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 35 +--- OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.inf | 3 -- 2 files changed, 8

[edk2-devel] [PATCH 04/11] OvmfPkg/VirtNorFlashDxe: remove disk I/O protocol implementation

We only use NOR flash for firmware volumes, either for executable images or for the variable store. So we have no need for exposing disk I/O on top of the NOR flash partitions so let's remove it. Signed-off-by: Ard Biesheuvel --- OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 129

[edk2-devel] [PATCH 01/11] OvmfPkg: clone NorFlashPlatformLib into VirtNorFlashPlatformLib

Create a new library class in Ovmf that duplicates the existing NorFlashPlatformLib, but which will be tied to the VirtNorFlashDxe driver that will be introduced in a subsequent patch. This allows us to retire the original from ArmPlatformPkg. Signed-off-by: Ard Biesheuvel ---

[edk2-devel] [PATCH 00/11] ArmVirtPkg: introduce VirtNorFlashDxe

Create a new driver VirtNorFlashDxe that targets QEMU and KvmTool's NOR flash emulation specifically, and retire the ArmPlatformPkg one. This permits new virt implementations to wire up QEMU's NOR flash emulation without having to rely on ARM specific packages. It also permits us to implement

[edk2-devel] [PATCH V1 2/2] CryptoPkg: Need to enable crypto functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [PATCH V1 1/2] CryptoPkg: Sha1 functions causing build errors

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3991 Fix build issue when DiSABLE_SHA1_DEPRECATED_INTERFACES is defined. Percolate the #ifndef DiSABLE_SHA1_DEPRECATED_INTERFACES to all the Sha1 functions. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry

[edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

https://bugzilla.tianocore.org/show_bug.cgi?id=3991 https://bugzilla.tianocore.org/show_bug.cgi?id=3992 There is a #define to deprecate Sha1 functions but not all the Sha1 function are wrapped around this #define causing a build error. The fix is to wrap all Sha1 functions with the #define. Need

Re: [edk2-devel] [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix

pushed 01c9d00fef1b086d64c6d0f383e0d299d8cf8fb7 Mike > -Original Message- > From: Kinney, Michael D > Sent: Monday, October 24, 2022 8:09 AM > To: Kadapathri, Ajay ; devel@edk2.groups.io; > Kinney, Michael D > Cc: Rebecca Cran ; Jayaprakash, N > > Subject: RE: [edk2-libc Patch 1/1]

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

> > Hey! > > Sorry if this was asked. I was wondering if this patchset is in some git repo > which I pull from as I struggle to get a buildable tree by applying this > patchset to whatever I can find. > > I tried https://github.com/deeglaze/edk2.git enable_umv7 but it does not > build

Re: [edk2-devel] [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function issue fix

Reviewed-by: Michael D Kinney > -Original Message- > From: Kadapathri, Ajay > Sent: Friday, October 21, 2022 3:57 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Kinney, Michael D > ; Jayaprakash, N > > Subject: [edk2-libc Patch 1/1] Python/Python3.6.8: help built-in function >

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString

On Wed, 12 Oct 2022 at 10:52, Gerd Hoffmann wrote: > > On Tue, Oct 11, 2022 at 09:34:17AM -0600, Rebecca Cran wrote: > > On 10/11/22 01:59, Gerd Hoffmann wrote: > > > > > > Next question is how to set them. I think it makes sense to have some > > > sensible defaults, but still allow to override

Re: [edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COMMAND

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel Sent: Monday, October 24, 2022 2:17 PM To: devel@edk2.groups.io Cc: quic_llind...@quicinc.com; Gao, Liming ; Feng, Bob C ; rebe...@bsdio.com; Ard Biesheuvel Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COMMAND

Liming, Bob: could i get an ack on this please? Our CI is currently broken due to this issue. On Mon, 24 Oct 2022 at 08:16, Ard Biesheuvel wrote: > > Commit ("2355f0c09c52 BaseTools: Fix check for ${PYTHON_COMMAND} in > Tests/GNUmakefile") fixed a latent issue in the BaseTools/Tests > Makefile,

[edk2-devel] [edk2-platforms][PATCH V4 04/14] Platform/Loongson: Add QemuFwCfgLib.

QemuFwCfgLib for PEI phase. This library obtains the QemuFWCfg base address by directly parsing the fdt, and reads and writes the data in the QemuFWCfg by operating on the QemuFWCfg base address. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li ---

[edk2-devel] [edk2-platforms][PATCH V4 05/14] Platform/Loongson: Add MmuLib.

Read the memory map information through the QemuFwCfg interface, then build the page table through the memory map information, and finally enable Mmu. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Include/Library/MmuLib.h | 85 ++

[edk2-devel] [edk2-platforms][PATCH V4 06/14] Platform/Loongson: Add StableTimerLib.

This library provides a delay interface and a timing interface. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Include/Library/StableTimer.h | 43 .../Library/StableTimerLib/Count.S| 35 +++

[edk2-devel] [edk2-platforms][PATCH V4 02/14] Platform/Loongson: Support SEC And Add Readme.md

Add SEC Code And Readme.md for LoongArchQemu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- Maintainers.txt | 4 + .../Include/LoongArchAsmMacro.h | 23 + .../Loongson/LoongArchQemuPkg/Loongson.dec|

[edk2-devel] [edk2-platforms][PATCH V4 03/14] Platform/Loongson: Add PeiServicesTablePointerLib.

Use a register to save PeiServicesTable pointer, This lib Provides PeiServicesTable pointer saving and retrieval services. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../PeiServicesTablePointer.c | 78 +++

[edk2-devel] [edk2-platforms][PATCH V4 01/14] Platform/Loongson: Add Serial Port library

Serial Port library for LoongarchQemuPkg REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Include/Library/Cpu.h| 387 +++ .../Include/LoongArchQemuPlatform.h | 97 +++ .../Library/SerialPortLib/SerialPortLib.c

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V4 32/34] OvmfPkg: RiscVVirt: Add Qemu Virt platform support

On Sat, Oct 22, 2022 at 07:16:07AM +, Chang, Abner wrote: > [AMD Official Use Only - General] > > Acked-by: Abner Chang > > Thanks for making RiscVVirt happened. > Abner > Thanks a lot!, Abner. I received some comments from Ard for which I need to update few patches. I am planning to send

Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs

Sounds great! > -Original Message- > From: Kinney, Michael D > Sent: Monday, October 24, 2022 1:44 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin ; > Zurcher, Christopher ; Rebecca Cran > ; Ard Biesheuvel ; Li, Yi1 >

[edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COMMAND

Commit ("2355f0c09c52 BaseTools: Fix check for ${PYTHON_COMMAND} in Tests/GNUmakefile") fixed a latent issue in the BaseTools/Tests Makefile, but inadvertently broke the BaseTools build for cases where PYTHON_COMMAND is not set. As it turns out, running 'command' without a command argument makes