Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

2024-05-06 Thread Wu, Jiaxin
Thanks Jiewen. From: Yao, Jiewen Sent: Tuesday, May 7, 2024 12:59 PM To: Wu, Jiaxin ; Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel Cc: Zeng, Star ; Gerd Hoffmann ; Kumar, Rahul R ; Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua ; Abdul Lateef Attar ; Abner Chang ; Tom Lendacky

Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

2024-05-06 Thread Yao, Jiewen
Acked-by: Jiewen Yao From: Wu, Jiaxin Sent: Tuesday, May 7, 2024 11:39 AM To: Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel ; Yao, Jiewen Cc: Zeng, Star ; Gerd Hoffmann ; Kumar, Rahul R ; Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua ; Abdul Lateef Attar ; Abner Chang ; Tom Lendacky

Re: [edk2-devel] [PATCH v2] MdePkg: Add MmUnblockMemoryLib to MdeLibs.dsc

2024-05-06 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: Zhang, Hongbin1 > Sent: Monday, April 29, 2024 2:25 PM > To: devel@edk2.groups.io > Cc: Zhang, Hongbin1 ; Kinney, Michael D > ; Ni, Ray ; Liming Gao > ; Liu, Zhiguang ; Wu, > Jiaxin ; Xie, Yuanhao > Subject: [PATCH v2] MdePkg: Add

Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

2024-05-06 Thread Wu, Jiaxin
Hi Jiewen and Ard, @Yao, Jiewen, @Ard Biesheuvel, do you agree we merge the change related to OVMF package since you are the OVMF maintainers. Please help check /review. The patches have been acked/tested by the Gerd. [PATCH v4

[edk2-devel] 回复: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers

2024-05-06 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Chang, Abner > 发送时间: 2024年5月6日 19:09 > 收件人: Chesley, Brit ; devel@edk2.groups.io > 抄送: Liming Gao ; Ray Ni ; Attar, > AbdulLateef (Abdul Lateef) > 主题: RE: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers > > [AMD Official Use Only - General] >

[edk2-devel] 回复: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

2024-05-06 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Chang, Abner > 发送时间: 2024年5月6日 19:09 > 收件人: Chesley, Brit ; devel@edk2.groups.io > 抄送: Liming Gao ; Ray Ni ; Attar, > AbdulLateef (Abdul Lateef) > 主题: RE: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers > > [AMD Official Use Only - General] >

[edk2-devel] 回复: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

2024-05-06 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Chang, Abner > 发送时间: 2024年5月6日 19:08 > 收件人: Chesley, Brit ; devel@edk2.groups.io > 抄送: Liming Gao ; Ray Ni ; Attar, > AbdulLateef (Abdul Lateef) > 主题: RE: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib > instance > > [AMD

Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

2024-05-06 Thread Xianglei Cai
Thanks Liming. The patch already merged: MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error · tianocore/edk2@c12bbc1 (github.com) From: gaoliming Sent: Tuesday, May 7, 2024 9:27 AM To:

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-05-06 Thread Chao Li
Hi Ard, Thanks, Chao On 2024/5/6 18:24, Ard Biesheuvel wrote: On Mon, 6 May 2024 at 12:02, Chao Li wrote: Hi Gerd, Thanks, Chao On 2024/3/19 16:03, Gerd Hoffmann wrote: Hi, I can't tell the implementation scheme of the current lib and existing lib implementation scheme which one is

Re: [edk2-devel] [PATCH v4 0/3] TCG_Sp800_155_PlatformId_Event3 support

2024-05-06 Thread Yao, Jiewen
Merged https://github.com/tianocore/edk2/pull/5628 > -Original Message- > From: Dionna Glaze > Sent: Tuesday, May 7, 2024 2:08 AM > To: devel@edk2.groups.io > Cc: Dionna Glaze ; Kinney, Michael D > ; Liming Gao ; Liu, > Zhiguang ; Yao, Jiewen ; > Kumar, Rahul R ; Ard Biesheuvel > ; Gerd

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

2024-05-06 Thread gaoliming via groups.io
Yes. I just add PUSH label. If it passes CI, it will be merged. 发件人: devel@edk2.groups.io 代表 Xianglei Cai 发送时间: 2024年5月7日 9:24 收件人: gaoliming ; Shih, More ; devel@edk2.groups.io 抄送: Ni, Ray ; Lewandowski, Krzysztof ; Huang, Jenny 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe:

Re: [edk2-devel] [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

2024-05-06 Thread Xianglei Cai
Hi Liming, I create one pull request: https://github.com/tianocore/edk2/pull/5630. Is it helpful for merge the change? Thanks, Xianglei -Original Message- From: Cai, Xianglei Sent: Thursday, April 25, 2024 5:59 PM To: gaoliming ; devel@edk2.groups.io Cc: Ni, Ray ; Lewandowski,

Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

2024-05-06 Thread Xianglei Cai
Hi Liming, I create one pull request: MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error by Xianglei-Cai · Pull Request #5631 · tianocore/edk2 (github.com). Is it helpful for merge the change? Thanks, Xianglei From: gaoliming Sent:

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

2024-05-06 Thread gaoliming via groups.io
I will merge it this week. 发件人: Shih, More 发送时间: 2024年5月6日 11:34 收件人: Cai, Xianglei ; gaoliming ; devel@edk2.groups.io 抄送: Ni, Ray ; Lewandowski, Krzysztof ; Huang, Jenny 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error Hi Gaoliming,

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, May 6, 2024 #cal-notice

2024-05-06 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, May 6, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, May 6, 2024 #cal-reminder

2024-05-06 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, May 6, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] Assistance Needed: ArmVirtPkg

2024-05-06 Thread Doug Flick via groups.io
All, In order to patch Tianocore Bugzilla issues and CVEs: 4541 – Bug 08 - edk2/NetworkPkg: Predictable TCP ISNs (tianocore.org) and 4542 – Bug 09 - edk2/NetworkPkg: Use of a Weak PseudoRandom Number Generator

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add MM_STANDALONE LibraryClasses

2024-05-06 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, February 9, 2024 2:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Liming Gao > ; Dong, Eric > Subject: [PATCH v1] MinPlatformPkg: Add MM_STANDALONE LibraryClasses > >

[edk2-devel] [PATCH v4 3/3] OvmfPkg: Add sp800155Event3 support

2024-05-06 Thread Dionna Glaze via groups.io
The signatures for event2 or event3 are now valid TCG SP800155 event types. Fixes uncrustify formatting. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Gerd Hoffmann Reviewed-by: Jiewen Yao Signed-off-by: Dionna Glaze --- OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 15 ++- 1 file changed, 10

[edk2-devel] [PATCH v4 2/3] SecurityPkg: Recognize sp800155Event3 event

2024-05-06 Thread Dionna Glaze via groups.io
The signatures for event2 or event3 are now valid TCG SP800155 event types. Fixes uncrustify formatting. Cc: Jiewen Yao Cc: Rahul Kumar Reviewed-by: Jiewen Yao Signed-off-by: Dionna Glaze --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 15 ++- 1 file changed, 10 insertions(+), 5

[edk2-devel] [PATCH v4 1/3] MdePkg: Add TcgSp800155Event3 type info

2024-05-06 Thread Dionna Glaze via groups.io
TCG PC Client Platform Firmware Profile 1.06 revision 52 of December 2023 added a new event signature and extended information about where a reference measurement document for the firmware can be found. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Jiewen Yao

[edk2-devel] [PATCH v4 0/3] TCG_Sp800_155_PlatformId_Event3 support

2024-05-06 Thread Dionna Glaze via groups.io
In December 2023, the TCG published the PC Client Platform Firmware Profile version 1.06 revision 52. This revision includes a new event type for NIST SP 800-155 recommended signed BIOS reference measurements. The new type allows for the event log auditor to find local or remote copies of the

Re: [edk2-devel] [PATCH v3 0/3] TCG_Sp800_155_PlatformId_Event3 support

2024-05-06 Thread Dionna Glaze via groups.io
I had not passed some tests, apologies. I fixed the spacing issue and build failure with too many )s in https://github.com/tianocore/edk2/pull/5615. Shall I email a v4? On Sun, May 5, 2024 at 8:28 PM Yao, Jiewen wrote: > > Hi Dionna > I tried to create PR but I saw failure - >

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

2024-05-06 Thread G Edhaya Chandran
Hi Heinrich, The folder structure for edk2-test-rc2_202405 is created: https://members.uefi.org/wg/utwg/document/folder/128 With Warm Regards, Edhay > -Original Message- > From: Heinrich Schuchardt > Sent: Sunday, May 5, 2024 5:22 PM > To: G Edhaya Chandran > Cc:

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install Windows11.

2024-05-06 Thread Nate DeSimone
Pushed as 0ab97ab > -Original Message- > From: Hsueh, DoraX > Sent: Monday, May 6, 2024 2:50 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [PATCH]

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install Windows11.

2024-05-06 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Hsueh, DoraX > Sent: Monday, May 6, 2024 2:50 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject:

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Update to reference RaptorLakeFspBinPkg FSP

2024-05-06 Thread Nate DeSimone
Pushed as 7e51d29 > -Original Message- > From: Hsueh, DoraX > Sent: Monday, May 6, 2024 2:42 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Desimone, Nathaniel L > > Subject: [PATCH] AlderlakeOpenBoardPkg: Update to

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Update to reference RaptorLakeFspBinPkg FSP

2024-05-06 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Hsueh, DoraX > Sent: Monday, May 6, 2024 2:42 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Desimone, Nathaniel L > > Subject: [PATCH] AlderlakeOpenBoardPkg:

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Ard Biesheuvel
On Mon, 6 May 2024 at 17:57, Kinney, Michael D wrote: > > Hi Ard, > > Thais is an attribute of Mergify. I do not see a way to change that > behavior. > > I do not know if using the GitHub merge capability or other merge services > provides different behavior here or not. > > This specific

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Michael D Kinney
Hi Ard, Thais is an attribute of Mergify. I do not see a way to change that behavior. I do not know if using the GitHub merge capability or other merge services provides different behavior here or not. This specific request is not related to the change to GitHub PRs for code review. There is

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Ard Biesheuvel
On Mon, 6 May 2024 at 17:11, Kinney, Michael D wrote: > > That information is in GitHub in the PR conversation. > > If you follow the link from the commit to the PR, the PR conversation shows > who set the 'push' label. > But that is GitHub proprietary metadata, no? Is it not possible to set the

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Michael D Kinney
That information is in GitHub in the PR conversation. If you follow the link from the commit to the PR, the PR conversation shows who set the 'push' label. Mike > -Original Message- > From: r...@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Monday, May 6, 2024 3:01 AM > To:

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

2024-05-06 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Chang, Abner Sent: Thursday, May 02, 2024 11:49 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg: rename

Re: [edk2-devel] [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

2024-05-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi MdeModulePkg maintainers, Please review this patch as we would like to merge it before the upcoming hard freeze. Thanks Abner > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming

Re: [edk2-devel] [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers

2024-05-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi MdeModulePkg maintainers, Please review this patch as we would like to merge it before the upcoming hard freeze. Thanks Abner > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming

Re: [edk2-devel] [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

2024-05-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi MdeModulePkg maintainers, Please review this patch as we would like to merge it before the upcoming hard freeze. Thanks Abner > -Original Message- > From: Chesley, Brit > Sent: Thursday, May 2, 2024 3:05 AM > To: devel@edk2.groups.io > Cc: Liming

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-05-06 Thread Ard Biesheuvel
On Mon, 6 May 2024 at 12:02, Chao Li wrote: > > Hi Gerd, > > > Thanks, > Chao > On 2024/3/19 16:03, Gerd Hoffmann wrote: > > Hi, > > I can't tell the implementation scheme of the current lib and existing > lib implementation scheme which one is better, Could you give we some > advice? > > I'd

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-05-06 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/19 16:03, Gerd Hoffmann wrote: Hi, I can't tell the implementation scheme of the current lib and existing lib implementation scheme which one is better, Could you give we some advice? I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Ard Biesheuvel
This reminds me: would it be possible to keep track of who merged a PR? (i.e., the person that set the 'push' label) Currently, commits just appear on the branch with the original author and the committer field set to something non-descript, e.g., commit 275d0a39c42ad73a6e4929822f56f5d8c16ede96

[edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install Windows11.

2024-05-06 Thread dorax . hsueh
From: DoraX Hsueh https://bugzilla.tianocore.org/show_bug.cgi?id=4665 1. Since installing windows does not meet the minimum system requirements, Added TPM related code to meet the requirements. 2. Support stage 6, add FvAdvancedPreMemory. Cc: Sai Chaganty Cc: Rosen Chuang Cc: Saloni

[edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Update to reference RaptorLakeFspBinPkg FSP

2024-05-06 Thread dorax . hsueh
From: DoraX Hsueh https://bugzilla.tianocore.org/show_bug.cgi?id=4771 Due to AlderLakeFspBinPkg will not be maintained going forward, ADL Openboard will reference RaptorLakeFspBinPkg FSP. Cc: Sai Chaganty Cc: Rosen Chuang Cc: Saloni Kasbekar Cc: Nate DeSimone Signed-off-by: DoraX Hsueh

Re: [edk2-devel] [Question] VM failed to start with secure boot and TPM 2.0

2024-05-06 Thread Zhoujian (jay) via groups.io
Add Maintainers and Reviewers: Jiewen Yao mailto:jiewen@intel.com>> Rebecca Cran mailto:rebe...@bsdio.com>> Corvin Köhne mailto:corv...@freebsd.org>> Could you give us some advice? Thanks From: Zhoujian (jay) Sent: Monday, April 29, 2024 12:07 PM To: 'devel@edk2.groups.io' Cc: zhengyaohui

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Adds integer to the AML package node

2024-05-06 Thread PierreGondois
Hello Abdul, With the changes below: Reviewed-by: Pierre Gondois On 5/6/24 05:08, Abdul Lateef Attar wrote: Adds an AmlAddIntegerPackageEntry() API to generate AML code, which adds an integer value to the package node. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar