[edk2-devel] [PATCH v1 01/28] MdeModulePkg: Add a new GUID

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add a new Variable Store Guid. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/MdeModulePkg.dec | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v1 02/28] SecurityPkg: Add new GUIDs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new GUIDs Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/SecurityPkg.dec | 43 +++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/SecurityPkg

[edk2-devel] [PATCH v1 04/28] MdeModulePkg: Add reference to new Ppi Guid

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to gEfiPeiVariableStoreDiscoveredPpiGuid Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdePkg/Include/Ppi/ReadOnlyVariable2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[edk2-devel] [PATCH v1 13/28] SecurityPkg: Fix GetVariableKey API

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c | 6 +++--- 1 file changed, 3

[edk2-devel] [PATCH v1 12/28] SecurityPkg: Add new variable types and functions

: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Include/Library/RpmcLib.h| 15 +--- SecurityPkg/Include/Library/VariableKeyLib.h | 37 +++- 2 files changed, 16 insertions(+), 36 deletions(-) diff --git a/SecurityPkg/Include/Library/RpmcLib.h

[edk2-devel] [PATCH v1 06/28] MdeModulePkg: Add new include files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add EncryptionVariableLib.h for confidentiality and ProtectedVariableLib.h for integrity Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Library/EncryptionVariableLib.h | 165

[edk2-devel] [PATCH v1 15/28] SecurityPkg: Add VariableKey library function

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide VariableKey function that retrieves the key for integrity and/or confidentiality of variables Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/VariableKeyLib

[edk2-devel] [PATCH v1 19/28] SecurityPkg: Add references to new *.inf files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add references to the different *ProtectedVariableLib.inf. Also add references to VariableKeyLibNull.inf, EncryptionVariableLibNull.inf, ProtectedVariableNull.inf. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah

[edk2-devel] [PATCH v1 16/28] SecurityPkg: Add EncryptionVariable lib with AES

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add encryption/decryption of protected variable functionality. Add functions to get/set cipher data of a protected variable. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library

[edk2-devel] [PATCH v1 14/28] SecurityPkg: Add null encryption variable libs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide null ecryption variable libraries. These will be used by default. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/EncryptionVariableLibNull/EncryptionVariableLibNull.inf

[edk2-devel] [PATCH v1 08/28] MdeModulePkg: Add new Variable functionality

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide new APIs for retrieving variable information. Add new function stubs for retrieving Protected variable information. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Universal

[edk2-devel] [PATCH v1 20/28] ArmVirtPkg: Add reference to ProtectedVariableNull

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Need reference to ProtectVariableNullLib. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Nishant C Mistry Signed-off-by: Judah Vang --- ArmVirtPkg/ArmVirtQemu.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[edk2-devel] [PATCH v1 18/28] MdeModulePkg: Reference Null ProtectedVariableLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Make reference to new Null ProtectVariableLib by default. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/MdeModulePkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[edk2-devel] [PATCH v1 24/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Jiewen Yao Cc: Min Xu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Tom Lendacky Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/AmdSev/AmdSevX64

[edk2-devel] [PATCH v1 22/28] EmulatorPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Andrew Fish Cc: Ray Ni Cc: Nishant C Mistry Signed-off-by: Judah Vang --- EmulatorPkg/EmulatorPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v1 27/28] OvmfPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Sebastien Boeuf Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/OvmfPkg/CloudHv

[edk2-devel] [PATCH v1 25/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Rebecca Cran Cc: Peter Grehan Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Bhyve/BhyveX64.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[edk2-devel] [PATCH v1 28/28] CryptoPkg: Enable cypto HMAC KDF library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 RPMC features requires HMAC-SHA256 support during SMM phase. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- 1

[edk2-devel] [PATCH v1 23/28] OvmfPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/OvmfPkgIa32.dsc| 3 ++- OvmfPkg

[edk2-devel] [PATCH v1 11/28] SecurityPkg: Update RPMC APIs with index

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Update RPMC APIs with index parameter. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

[edk2-devel] [PATCH v1 26/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg

[edk2-devel] [PATCH v1 21/28] UefiPayloadPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Cc: Nishant C Mistry Signed-off-by: Judah Vang --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 +++- 1 file

[edk2-devel] [PATCH v1 05/28] MdeModulePkg: Add new ProtectedVariable GUIDs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new ProtectVariable GUIDs. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Guid/ProtectedVariable.h | 22 1 file changed, 22 insertions(+) diff --git

[edk2-devel] [PATCH v1 10/28] SecurityPkg: Add new KeyService types and defines

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new KeyService types and defines. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Include/Ppi/KeyServicePpi.h | 57 1 file changed, 57 insertions(+) diff --git

[edk2-devel] [PATCH v1 07/28] MdeModulePkg: Add Null ProtectedVariable Library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add Null ProtectedVariable Library. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Library/ProtectedVariableLibNull/ProtectedVariableLibNull.inf | 34 ++ MdeModulePkg/Library

Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID

I'd like to re-use something like this one. I'm still reviewing it but so far I've only seen a couple of changes. https://github.com/jwang36/edk2-staging/tree/ProtectedVariable/libsv2#readme I can also send out of the cover letter patch. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] [PATCH v3 17/28] SecurityPkg: Add Protected Variable Services

Min, I prefer not to do this since there is already 28 patches. The line changes are mostly from the .h and .c files, I do not think there is much benefit from moving the the .inf files to a different patch.  Doing something like that will still leave 5800 lines changes in this patch. Judah

[edk2-devel] [PATCH v3 03/28] MdeModulePkg: Update AUTH_VARIABLE_INFO struct

Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Library/AuthVariableLib.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Include/Library/AuthVariableLib.h b/MdeModulePkg/Include/Library/AuthVariableLib.h index 37aceba699e6..32391bbf2b61 100644

[edk2-devel] [PATCH v3 01/28] MdeModulePkg: Add new GUID for Variable Store Info

Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/MdeModulePkg.dec | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 2bcb9f9453af..5c1dda004808 100644 --- a/MdeModulePkg

[edk2-devel] [PATCH v3 07/28] MdeModulePkg: Add Null ProtectedVariable Library

-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Library/ProtectedVariableLibNull/ProtectedVariableLibNull.inf | 34 ++ MdeModulePkg/Library/ProtectedVariableLibNull/ProtectedVariable.c | 449 2 files changed, 483 insertions(+) diff --git

[edk2-devel] [PATCH v3 06/28] MdeModulePkg: Add new include files

-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Library/EncryptionVariableLib.h | 165 + MdeModulePkg/Include/Library/ProtectedVariableLib.h | 700 2 files changed, 865 insertions(+) diff --git a/MdeModulePkg/Include/Library

[edk2-devel] [PATCH v3 02/28] SecurityPkg: Add new GUIDs for

. The gEdkiiProtectedVariableContextGuid contains the Protected Variable context saved in PEI phase to be used later. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/SecurityPkg.dec | 43 +++- 1 file changed

[edk2-devel] [PATCH v3 04/28] MdeModulePkg: Add reference to new Ppi Guid

Signed-off-by: Judah Vang --- MdePkg/Include/Ppi/ReadOnlyVariable2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Ppi/ReadOnlyVariable2.h b/MdePkg/Include/Ppi/ReadOnlyVariable2.h index 926c0bc82a43..c5a8470565bb 100644 --- a/MdePkg/Include/Ppi

[edk2-devel] [PATCH v3 15/28] SecurityPkg: Add VariableKey library function

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide function that retrieves the key for protected variables. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library

[edk2-devel] [PATCH v3 12/28] SecurityPkg: Add new variable types and functions

Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Include/Library/RpmcLib.h| 15 +--- SecurityPkg/Include/Library/VariableKeyLib.h | 37 +++- 2 files changed, 16 insertions(+), 36

[edk2-devel] [PATCH v3 10/28] SecurityPkg: Add new KeyService types and defines

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new KeyService types and defines. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Include/Ppi/KeyServicePpi.h | 57

[edk2-devel] [PATCH v3 08/28] MdeModulePkg: Add new Variable functionality

Wang Cc: Liming Gao Cc: Hao A Wu Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Universal/Variable/Pei/VariablePei.inf | 10 +- MdeModulePkg/Universal/Variable/Pei/Variable.h| 80 +- MdeModulePkg/Universal

[edk2-devel] [PATCH v3 11/28] SecurityPkg: Update RPMC APIs with index

-by: Judah Vang --- SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c index 792e48250e5d..557aeb6abf09 100644 --- a/SecurityPkg/Library

[edk2-devel] [PATCH v3 00/28] UEFI variable protection

() is not supported in PEI phase. FreePool() does not free the allocated pool in PEI phase causing a memory leak. Judah Vang (28): MdeModulePkg: Add new GUID for Variable Store Info SecurityPkg: Add new GUIDs for MdeModulePkg: Update AUTH_VARIABLE_INFO struct MdeModulePkg: Add reference

[edk2-devel] [PATCH v3 28/28] CryptoPkg: Enable cypto HMAC KDF and AES library

Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/SysCall/BaseMemAllocation.c | 11 ++- CryptoPkg/Library

[edk2-devel] [PATCH v3 05/28] MdeModulePkg: Add new ProtectedVariable GUIDs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 New ProtectVariable GUIDs for passing variable information from PEI phase to SMM phase. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [PATCH v3 16/28] SecurityPkg: Add EncryptionVariable lib with AES

-by: Judah Vang --- SecurityPkg/Library/EncryptionVariableLib/EncryptionVariableLib.inf | 43 ++ SecurityPkg/Library/EncryptionVariableLib/EncryptionVariable.h | 49 ++ SecurityPkg/Library/EncryptionVariableLib/EncryptionVariable.c | 734 3 files changed, 826

[edk2-devel] [PATCH v3 13/28] SecurityPkg: Fix GetVariableKey API

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library

[edk2-devel] [PATCH v3 18/28] MdeModulePkg: Reference Null ProtectedVariableLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Make reference to new Null ProtectVariableLib. The null ProtectedVariableLib is used by default. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [PATCH v3 19/28] SecurityPkg: Add references to new *.inf files

J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/SecurityPkg.dsc | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index d883747474e4..08777c57a5e9 100644 --- a/SecurityPkg

[edk2-devel] [PATCH v3 14/28] SecurityPkg: Add null encryption variable libs

-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/EncryptionVariableLibNull/EncryptionVariableLibNull.inf | 38 +++ SecurityPkg/Library/EncryptionVariableLibNull/EncryptionVariable.c | 107 SecurityPkg/Library/EncryptionVariableLibNull

[edk2-devel] [PATCH v3 20/28] ArmVirtPkg: Add reference to ProtectedVariableNull

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Need reference to ProtectVariableNullLib otherwise build fails. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [PATCH v3 21/28] UefiPayloadPkg: Add ProtectedVariable reference

Signed-off-by: Judah Vang --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 4d9bbc80c866..dca0970ad61c 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg

[edk2-devel] [PATCH v3 24/28] OvmfPkg: Add ProtectedVariableLib reference

Mistry Signed-off-by: Judah Vang --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc index 6b3827f7f6ed..52c390cde2f0 100644 --- a/OvmfPkg/AmdSev/AmdSevX64.dsc +++ b/OvmfPkg/AmdSev

[edk2-devel] [PATCH v3 22/28] EmulatorPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Andrew Fish Cc: Ray Ni Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- EmulatorPkg/EmulatorPkg.dsc | 3

[edk2-devel] [PATCH v3 26/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 ++- 1

[edk2-devel] [PATCH v3 25/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Rebecca Cran Cc: Peter Grehan Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Bhyve/BhyveX64.dsc

[edk2-devel] [PATCH v3 23/28] OvmfPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah

[edk2-devel] [PATCH v3 27/28] OvmfPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Sebastien Boeuf Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + 1

[edk2-devel] [PATCH v3 0/3] CryptoPkg bug fixes

for SMM phase. Judah Vang (3): CryptoPkg: Fix memoryleak in BaseMemAllocation CryptoPkg: Sha1 functions causing build errors CryptoPkg: Need to enable crypto functions CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf

[edk2-devel] [PATCH v3 1/3] CryptoPkg: Fix memoryleak in BaseMemAllocation

Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseCryptLib/SysCall/BaseMemAllocation.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/CryptoPkg

[edk2-devel] [PATCH v3 2/3] CryptoPkg: Sha1 functions causing build errors

Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c b/CryptoPkg/Library

[edk2-devel] [PATCH v3 3/3] CryptoPkg: Need to enable crypto functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [Patch v2 07/28] MdeModulePkg: Add Null ProtectedVariable Library

-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Library/ProtectedVariableLibNull/ProtectedVariableLibNull.inf | 34 ++ MdeModulePkg/Library/ProtectedVariableLibNull/ProtectedVariable.c | 449 2 files changed, 483 insertions(+) diff --git

[edk2-devel] [Patch v2 08/28] MdeModulePkg: Add new Variable functionality

Signed-off-by: Judah Vang --- MdeModulePkg/Universal/Variable/Pei/VariablePei.inf | 10 +- MdeModulePkg/Universal/Variable/Pei/Variable.h| 80 +- MdeModulePkg/Universal/Variable/Pei/VariableParsing.h | 309 +++ MdeModulePkg/Universal/Variable/Pei/VariableStore.h | 116

[edk2-devel] [Patch v2 11/28] SecurityPkg: Update RPMC APIs with index

-by: Judah Vang --- SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c index 792e48250e5d..557aeb6abf09 100644 --- a/SecurityPkg/Library

[edk2-devel] [Patch v2 10/28] SecurityPkg: Add new KeyService types and defines

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new KeyService types and defines. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Include/Ppi/KeyServicePpi.h | 57

[edk2-devel] [Patch v2 13/28] SecurityPkg: Fix GetVariableKey API

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library

[edk2-devel] [Patch v2 16/28] SecurityPkg: Add EncryptionVariable lib with AES

Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/EncryptionVariableLib/EncryptionVariableLib.inf | 43 ++ SecurityPkg/Library/EncryptionVariableLib/EncryptionVariable.h | 49 ++ SecurityPkg/Library/EncryptionVariableLib

[edk2-devel] [Patch v2 12/28] SecurityPkg: Add new variable types and functions

Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Include/Library/RpmcLib.h| 15 +--- SecurityPkg/Include/Library/VariableKeyLib.h | 37 +++- 2 files changed, 16 insertions(+), 36

[edk2-devel] [Patch v2 14/28] SecurityPkg: Add null encryption variable libs

-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/EncryptionVariableLibNull/EncryptionVariableLibNull.inf | 38 +++ SecurityPkg/Library/EncryptionVariableLibNull/EncryptionVariable.c | 107 SecurityPkg/Library/EncryptionVariableLibNull

[edk2-devel] [Patch v2 18/28] MdeModulePkg: Reference Null ProtectedVariableLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Make reference to new Null ProtectVariableLib. The null ProtectedVariableLib is used by default. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [Patch v2 19/28] SecurityPkg: Add references to new *.inf files

J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/SecurityPkg.dsc | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index 73a93c2285b1..6d8318c6e4bf 100644 --- a/SecurityPkg

[edk2-devel] [Patch v2 15/28] SecurityPkg: Add VariableKey library function

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide function that retrieves the key for protected variables. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library

[edk2-devel] [Patch v2 20/28] ArmVirtPkg: Add reference to ProtectedVariableNull

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Need reference to ProtectVariableNullLib otherwise build fails. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [Patch v2 21/28] UefiPayloadPkg: Add ProtectedVariable reference

Signed-off-by: Judah Vang --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 17b30589e77c..fe835eed1bc7 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg

[edk2-devel] [Patch v2 23/28] OvmfPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah

[edk2-devel] [Patch v2 22/28] EmulatorPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Andrew Fish Cc: Ray Ni Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- EmulatorPkg/EmulatorPkg.dsc | 3

[edk2-devel] [Patch v2 25/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Rebecca Cran Cc: Peter Grehan Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Bhyve/BhyveX64.dsc

[edk2-devel] [Patch v2 27/28] OvmfPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Sebastien Boeuf Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + 1

[edk2-devel] [Patch v2 24/28] OvmfPkg: Add ProtectedVariableLib reference

Mistry Signed-off-by: Judah Vang --- OvmfPkg/AmdSev/AmdSevX64.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc index f0700035c116..b0072f5fb0d3 100644 --- a/OvmfPkg/AmdSev/AmdSevX64.dsc +++ b/OvmfPkg/AmdSev

[edk2-devel] [Patch v2 28/28] CryptoPkg: Enable cypto HMAC KDF library

Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib

[edk2-devel] [Patch v2 26/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 ++- 1

[edk2-devel] [Patch v2 02/28] SecurityPkg: Add new GUIDs for

. The gEdkiiProtectedVariableContextGuid contains the Protected Variable context saved in PEI phase to be used later. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/SecurityPkg.dec | 43 +++- 1 file changed

[edk2-devel] [Patch v2 03/28] MdeModulePkg: Update AUTH_VARIABLE_INFO struct

Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Library/AuthVariableLib.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Include/Library/AuthVariableLib.h b/MdeModulePkg/Include/Library/AuthVariableLib.h index 37aceba699e6..32391bbf2b61 100644

[edk2-devel] [Patch v2 04/28] MdeModulePkg: Add reference to new Ppi Guid

Signed-off-by: Judah Vang --- MdePkg/Include/Ppi/ReadOnlyVariable2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Ppi/ReadOnlyVariable2.h b/MdePkg/Include/Ppi/ReadOnlyVariable2.h index 926c0bc82a43..c5a8470565bb 100644 --- a/MdePkg/Include/Ppi

[edk2-devel] [Patch v2 06/28] MdeModulePkg: Add new include files

-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Library/EncryptionVariableLib.h | 165 + MdeModulePkg/Include/Library/ProtectedVariableLib.h | 700 2 files changed, 865 insertions(+) diff --git a/MdeModulePkg/Include/Library

[edk2-devel] [Patch v2 05/28] MdeModulePkg: Add new ProtectedVariable GUIDs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 New ProtectVariable GUIDs for passing variable information from PEI phase to SMM phase. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [Patch v2 00/28] UEFI variable protection

For a more detail description of the UEFI variable protected feature you can view the Readme.md located at the following location: https://github.com/judahvang/edk2/tree/rpmc-update Judah Vang (28): MdeModulePkg: Add new GUID for Variable Store Info SecurityPkg: Add new GUIDs

[edk2-devel] [Patch v2 01/28] MdeModulePkg: Add new GUID for Variable Store Info

Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/MdeModulePkg.dec | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index cf79292ec877..f39827e4eacd 100644 --- a/MdeModulePkg

[edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

crypto AES to be supported for PEI phase and need crypto KDF to be supported for SMM phase. Judah Vang (2): CryptoPkg: Sha1 functions causing build errors CryptoPkg: Need to enable crypto functions CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf| 2 +- CryptoPkg/Library/BaseCryptLib

[edk2-devel] [PATCH V1 1/2] CryptoPkg: Sha1 functions causing build errors

Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c b/CryptoPkg/Library

[edk2-devel] [PATCH V1 2/2] CryptoPkg: Need to enable crypto functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3992 Enable CryptAes for PEI phase. Enable CryptHkdf for SMM phase. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

Re: [edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

will generate a build error instead of a runtime ASSERT(). Which behavior do you prefer? Best regards, Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Judah > Vang > Sent: Monday, October 24, 2022 9:42 AM > To: devel@edk2.groups.io > Subject: [

Re: [edk2-devel] [PATCH V1 0/2] CryptoPkg bug fixes

hose services to be disabled in the Crypto >Protocol/PPI. The defines to deprecate MD5 and SH1 extend into the > BaseCryptLib >instance implementations such that a call to those services when static > linking >will generate a build error instead of a runtime ASSERT()

[edk2-devel] [PATCH v4 03/28] MdeModulePkg: Add new ProtectedVariable GUIDs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 New ProtectVariable GUIDs for passing variable information from PEI phase to SMM phase. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang Reviewed

[edk2-devel] [PATCH v4 02/28] MdeModulePkg: Add reference to new Ppi Guid

Signed-off-by: Judah Vang Reviewed-by: Jian J Wang --- MdePkg/Include/Ppi/ReadOnlyVariable2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Ppi/ReadOnlyVariable2.h b/MdePkg/Include/Ppi/ReadOnlyVariable2.h index 926c0bc82a43..c5a8470565bb 100644 --- a/MdePkg

[edk2-devel] [PATCH v4 05/28] MdeModulePkg: Add new GUID for Variable Store Info

Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang Reviewed-by: Jian J Wang --- MdeModulePkg/MdeModulePkg.dec | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 7d989108324a..e812e016ccca 100644

[edk2-devel] [PATCH v4 07/28] MdeModulePkg: Add new Variable functionality

Wang Cc: Liming Gao Cc: Hao A Wu Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang Acked-by: Hao A Wu --- MdeModulePkg/Universal/Variable/Pei/VariablePei.inf | 10 +- MdeModulePkg/Universal/Variable/Pei/Variable.h| 80

[edk2-devel] [PATCH v4 04/28] MdeModulePkg: Add new include files

for protected variables. Add ProtectedVariableLib.h for providing integrity or variables. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Library/EncryptionVariableLib.h | 165

[edk2-devel] [PATCH v4 01/28] MdeModulePkg: Update AUTH_VARIABLE_INFO struct

Mistry Signed-off-by: Judah Vang Reviewed-by: Jian J Wang --- MdeModulePkg/Include/Library/AuthVariableLib.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Include/Library/AuthVariableLib.h b/MdeModulePkg/Include/Library/AuthVariableLib.h index 37aceba699e6

[edk2-devel] [PATCH v4 09/28] MdeModulePkg: Reference Null ProtectedVariableLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Make reference to new Null ProtectVariableLib. The null ProtectedVariableLib is used by default. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [PATCH v4 06/28] MdeModulePkg: Add Null ProtectedVariable Library

: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Library/ProtectedVariableLibNull/ProtectedVariableLibNull.inf | 34 ++ MdeModulePkg/Library/ProtectedVariableLibNull/ProtectedVariable.c | 336

[edk2-devel] [PATCH v4 10/28] SecurityPkg: Add new GUIDs for

. The gEdkiiProtectedVariableContextGuid contains the Protected Variable context saved in PEI phase to be used later. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang Reviewed-by: Jian J Wang --- SecurityPkg/SecurityPkg.dec | 43

[edk2-devel] [PATCH v4 11/28] SecurityPkg: Add new KeyService types and defines

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: revert copyright date change. V1: Add new KeyService types and defines. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg

  1   2   >