Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

I must have just overlooked this. And also, there is no automation, there are just regular expressions ;) On Tue, Feb 5, 2019 at 5:02 PM Anderson, Charles R wrote: > Igor, your change broke my package. Whatever automation you used should > have taken into account that %post sections don't end

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

Igor, your change broke my package. Whatever automation you used should have taken into account that %post sections don't end until the next RPM directive. %ifarch does not end a %post section. diff --git a/ocp.spec b/ocp.spec index 0d6fd28..2495ab5 100644 --- a/ocp.spec +++ b/ocp.spec @@

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

> Yup. I don't fancy reimplementing user/group management in rpm directly, > I'm thinking more about integrating with existing solutions one way or > the other. Sysusers is a good candidate since, as you point out, it has > a declarative syntax already. The biggest problems with any approach >

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Wed, 2018-12-12 at 17:20 -0500, Ben Cotton wrote: > https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets > > == Summary == > Remove scriptlets which are not needed anymore (ldconfig, > gtk-update-icon-cache, etc.). > > == Owner == > * Name: [[User:ignatenkobrain|Igor Gnatenko]] > *

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On 1/4/19 12:15 PM, Zbigniew Jędrzejewski-Szmek wrote: On Fri, Jan 04, 2019 at 10:56:05AM +0200, Panu Matilainen wrote: On 1/3/19 5:02 PM, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Jan 03, 2019 at 12:00:13PM +0200, Panu Matilainen wrote: On 1/3/19 11:47 AM, Dridi Boukelmoune wrote: On

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Fri, Jan 04, 2019 at 10:56:05AM +0200, Panu Matilainen wrote: > On 1/3/19 5:02 PM, Zbigniew Jędrzejewski-Szmek wrote: > > On Thu, Jan 03, 2019 at 12:00:13PM +0200, Panu Matilainen wrote: > > > On 1/3/19 11:47 AM, Dridi Boukelmoune wrote: > > > > > > > > > > > > On Thu, Jan 3, 2019, 09:59 Panu

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On 1/3/19 5:02 PM, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Jan 03, 2019 at 12:00:13PM +0200, Panu Matilainen wrote: On 1/3/19 11:47 AM, Dridi Boukelmoune wrote: On Thu, Jan 3, 2019, 09:59 Panu Matilainen mailto:pmati...@redhat.com> wrote: On 1/2/19 7:52 PM, Jason L Tibbitts III

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, Jan 03, 2019 at 12:00:13PM +0200, Panu Matilainen wrote: > On 1/3/19 11:47 AM, Dridi Boukelmoune wrote: > > > > > > On Thu, Jan 3, 2019, 09:59 Panu Matilainen > wrote: > > > > On 1/2/19 7:52 PM, Jason L Tibbitts III wrote: > > >> "FV" == Fabio

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On 1/3/19 11:47 AM, Dridi Boukelmoune wrote: On Thu, Jan 3, 2019, 09:59 Panu Matilainen wrote: On 1/2/19 7:52 PM, Jason L Tibbitts III wrote: >> "FV" == Fabio Valentini mailto:decatho...@gmail.com>> writes: > > FV> - unless those other,

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, Jan 3, 2019, 09:59 Panu Matilainen On 1/2/19 7:52 PM, Jason L Tibbitts III wrote: > >> "FV" == Fabio Valentini writes: > > > > FV> - unless those other, main icon theme packages have also added > > FV> %transfiletrigger* scriptlets, like I've done for elementary and > > FV> Paper. >

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On 1/2/19 7:52 PM, Jason L Tibbitts III wrote: "FV" == Fabio Valentini writes: FV> - unless those other, main icon theme packages have also added FV> %transfiletrigger* scriptlets, like I've done for elementary and FV> Paper. Perhaps it should be mandatory for icon themes to add the

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

> "FV" == Fabio Valentini writes: FV> - unless those other, main icon theme packages have also added FV> %transfiletrigger* scriptlets, like I've done for elementary and FV> Paper. Perhaps it should be mandatory for icon themes to add the necessary file triggers so that no package will ever

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Fri, Dec 21, 2018, 21:28 Robert-André Mauchin On mercredi 12 décembre 2018 23:20:54 CET Ben Cotton wrote: > > https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets > > > > == Summary == > > Remove scriptlets which are not needed anymore (ldconfig, > > gtk-update-icon-cache, etc.). >

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On mercredi 12 décembre 2018 23:20:54 CET Ben Cotton wrote: > https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets > > == Summary == > Remove scriptlets which are not needed anymore (ldconfig, > gtk-update-icon-cache, etc.). > > == Owner == > * Name: [[User:ignatenkobrain|Igor

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

If I manage to get this approved and done before mass rebuild, I'll just push changes without bumping anything. If it will happen during/after mass rebuild, I'll also bump. I'm hoping to complete it before mass rebuild. On Thu, Dec 20, 2018 at 6:55 PM Kevin Fenzi wrote: > > On 12/20/18 2:35 AM,

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

> "MH" == Miro Hrončok writes: MH> Is there anything we can do to prevent maintains to override the MH> change with their next "magical sync" from jira/RDO/github/whatever? MH> I mean we already say they should not do that, but can we somehow MH> make sure they actually won't? This

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

Hi, On 20-12-18 18:45, Kevin Fenzi wrote: On 12/20/18 2:35 AM, Dominik 'Rathann' Mierzejewski wrote: On Thursday, 20 December 2018 at 11:29, Richard Hughes wrote: On Thu, 20 Dec 2018 at 10:16, Hans de Goede wrote: So I say +100 to just pushing the changes directly, as said people can always

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On 12/20/18 2:35 AM, Dominik 'Rathann' Mierzejewski wrote: > On Thursday, 20 December 2018 at 11:29, Richard Hughes wrote: >> On Thu, 20 Dec 2018 at 10:16, Hans de Goede wrote: >>> So I say +100 to just pushing the changes directly, as said >>> people can always revert them. >> >> Completely

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, 2018-12-20 at 17:09 +0100, Fabio Valentini wrote: > On Thu, Dec 20, 2018, 16:57 Adam Williamson wrote: > > > On Thu, 2018-12-20 at 11:50 +0100, Miro Hrončok wrote: > > > On 12. 12. 18 23:20, Ben Cotton wrote: > > > > https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets > > > >

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

No, it's automation which just pushes new thing for them. People basically don't care. On Thu, Dec 20, 2018, 17:55 Zbigniew Jędrzejewski-Szmek On Thu, Dec 20, 2018 at 11:50:38AM +0100, Miro Hrončok wrote: > > On 12. 12. 18 23:20, Ben Cotton wrote: > >

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, Dec 20, 2018 at 11:50:38AM +0100, Miro Hrončok wrote: > On 12. 12. 18 23:20, Ben Cotton wrote: > >https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets > > > >== Summary == > >Remove scriptlets which are not needed anymore (ldconfig, > >gtk-update-icon-cache, etc.). > > > Is

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, Dec 20, 2018, 16:57 Adam Williamson On Thu, 2018-12-20 at 11:50 +0100, Miro Hrončok wrote: > > On 12. 12. 18 23:20, Ben Cotton wrote: > > > https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets > > > > > > == Summary == > > > Remove scriptlets which are not needed anymore

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, 2018-12-20 at 11:50 +0100, Miro Hrončok wrote: > On 12. 12. 18 23:20, Ben Cotton wrote: > > https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets > > > > == Summary == > > Remove scriptlets which are not needed anymore (ldconfig, > > gtk-update-icon-cache, etc.). > > Is there

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On 12. 12. 18 23:20, Ben Cotton wrote: https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets == Summary == Remove scriptlets which are not needed anymore (ldconfig, gtk-update-icon-cache, etc.). Is there anything we can do to prevent maintains to override the change with their

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On 19. 12. 18 11:22, Igor Gnatenko wrote: On Wed, Dec 19, 2018 at 2:20 AM Jason L Tibbitts III wrote: "ZJ" == Zbigniew Jędrzejewski-Szmek writes: ZJ> I think it's pretty clear: all the standard invocations of ZJ> scriptlets that have by replaced by transfiletriggers will be ZJ> removed,

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thursday, 20 December 2018 at 11:29, Richard Hughes wrote: > On Thu, 20 Dec 2018 at 10:16, Hans de Goede wrote: > > So I say +100 to just pushing the changes directly, as said > > people can always revert them. > > Completely agree. For my packages I'd totally prefer things just > magically

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, 20 Dec 2018 at 10:16, Hans de Goede wrote: > So I say +100 to just pushing the changes directly, as said > people can always revert them. Completely agree. For my packages I'd totally prefer things just magically be done without any action on my part. Richard.

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, Dec 20, 2018 at 5:17 AM Hans de Goede wrote: > > Hi, > > On 20-12-18 10:54, Raphael Groner wrote: > >> So what process should I use? Pull Requests or just removing obsolete > >> stuff? > >> I'm ready to do either way. Should I leave this to FESCo? > > > > My vote would go for Pull

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

Hi, On 20-12-18 10:54, Raphael Groner wrote: So what process should I use? Pull Requests or just removing obsolete stuff? I'm ready to do either way. Should I leave this to FESCo? My vote would go for Pull Requests to give the packagers a (limited) chance to look into the proposal

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

> So what process should I use? Pull Requests or just removing obsolete stuff? > I'm ready to do either way. Should I leave this to FESCo? My vote would go for Pull Requests to give the packagers a (limited) chance to look into the proposal individually. Maybe after some elapsed time have

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

Ok, so I put my preferred way of doing it: https://fedoraproject.org/w/index.php?title=Changes%2FRemoveObsoleteScriptlets=revision=530714=530690 Once there will be FESCo ticket (which actually should have been sent yesterday), I'll definitely would like to hear FESCo opinion and ready to change

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Thu, Dec 20, 2018 at 07:38:29AM +0100, Igor Gnatenko wrote: > So what process should I use? Pull Requests or just removing obsolete > stuff? I'm ready to do either way. Should I leave this to FESCo? The choice of implementation details is yours. You can always ask FESCo for opinion, but I

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

So what process should I use? Pull Requests or just removing obsolete stuff? I'm ready to do either way. Should I leave this to FESCo? On Wed, Dec 19, 2018 at 8:00 PM Jason L Tibbitts III wrote: > > > "KL" == Kalev Lember writes: > > KL> I agree with Zbyszek, I think it would be best to

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Wed, Dec 19, 2018 at 12:49:51PM -0600, Jason L Tibbitts III wrote: > > "KL" == Kalev Lember writes: > > KL> I agree with Zbyszek, I think it would be best to push the changes > KL> directly to git. > > But then we're back to the same problem: Do you remove the ldconfig > calls entirely

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

> "KL" == Kalev Lember writes: KL> I agree with Zbyszek, I think it would be best to push the changes KL> directly to git. But then we're back to the same problem: Do you remove the ldconfig calls entirely or do you add the macros? Prepare for flames if you get it wrong, even though it's

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Wed, Dec 19, 2018, 15:09 Zbigniew Jędrzejewski-Szmek On Wed, Dec 19, 2018 at 11:22:21AM +0100, Igor Gnatenko wrote: > > I've updated change which is explicitly mentions that I'm going to > > send Pull Requests to packages, so it should not make anyone unhappy. > > Are you sure this is a viable

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Wed, Dec 19, 2018 at 11:22:21AM +0100, Igor Gnatenko wrote: > On Wed, Dec 19, 2018 at 2:20 AM Jason L Tibbitts III > wrote: > > > > > "ZJ" == Zbigniew Jędrzejewski-Szmek writes: > > > > ZJ> I think it's pretty clear: all the standard invocations of > > ZJ> scriptlets that have by

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Wed, Dec 19, 2018 at 2:20 AM Jason L Tibbitts III wrote: > > > "ZJ" == Zbigniew Jędrzejewski-Szmek writes: > > ZJ> I think it's pretty clear: all the standard invocations of > ZJ> scriptlets that have by replaced by transfiletriggers will be > ZJ> removed, along with the whole

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

> "ZJ" == Zbigniew Jędrzejewski-Szmek writes: ZJ> I think it's pretty clear: all the standard invocations of ZJ> scriptlets that have by replaced by transfiletriggers will be ZJ> removed, along with the whole %post/%postun sections if its the only ZJ> thing in them. I do think it would be

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On Mon, Dec 17, 2018 at 11:31:46AM -0800, Japheth Cleaver wrote: > On 12/12/2018 2:20 PM, Ben Cotton wrote: > >https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets > > > >== Summary == > >Remove scriptlets which are not needed anymore (ldconfig, > >gtk-update-icon-cache, etc.). > > >

Re: Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

On 12/12/2018 2:20 PM, Ben Cotton wrote: https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets == Summary == Remove scriptlets which are not needed anymore (ldconfig, gtk-update-icon-cache, etc.). *snip* == Upgrade/compatibility impact == Installed F30 RPMs on F28/EL6/EL7 might not

Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets == Summary == Remove scriptlets which are not needed anymore (ldconfig, gtk-update-icon-cache, etc.). == Owner == * Name: [[User:ignatenkobrain|Igor Gnatenko]] * Email: ignatenkobr...@fedoraproject.org == Scope == * Proposal

Fedora 30 System-Wide Change proposal: Remove Obsolete Scriptlets

https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets == Summary == Remove scriptlets which are not needed anymore (ldconfig, gtk-update-icon-cache, etc.). == Owner == * Name: [[User:ignatenkobrain|Igor Gnatenko]] * Email: ignatenkobr...@fedoraproject.org == Scope == * Proposal