Re: Package review skipped and straight to repos?

2015-12-01 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 01, 2015 at 08:19:04AM -0500, Matthew Miller wrote: > On Sun, Nov 29, 2015 at 10:09:58PM +, Zbigniew Jędrzejewski-Szmek wrote: > FWIW, I'm not sure that's really true. The fedora-review tool makes it > very easy to do a low-effort review and still produce a pretty > checklist.

Re: Package review skipped and straight to repos?

2015-12-01 Thread Matthew Miller
On Sun, Nov 29, 2015 at 10:09:58PM +, Zbigniew Jędrzejewski-Szmek wrote: > Package review is public and happens in the review bug. We also > require (in the sense of having a strong custom, maybe even if it's > not written anywhere explicitly), a checklist style review. This allows If we want

Re: Package review skipped and straight to repos?

2015-11-30 Thread Alexander Ploumistos
On Mon, Nov 30, 2015 at 10:53 AM, Florian Weimer wrote: > Apparently, ABRT reports crashes for packages not part of Fedora. Thanks, I'd guessed that much, but I wanted some confirmation. > A possible fix would be to look at the signing key in the RPM database > and report

Re: Package review skipped and straight to repos?

2015-11-30 Thread Michael Schwendt
On Mon, 30 Nov 2015 09:53:24 +0100, Florian Weimer wrote: > Apparently, ABRT reports crashes for packages not part of Fedora. Not only that, but those shortened reports are also submitted for locally modified software. Such as someone hacking the software during development or breaking it during

Re: Package review skipped and straight to repos?

2015-11-30 Thread James Hogarth
On 29 November 2015 at 21:53, Sérgio Basto wrote: > On Sáb, 2015-11-28 at 14:56 -0700, Kevin Fenzi wrote: > > On Sat, 28 Nov 2015 21:11:48 + > > James Hogarth wrote: > > > > > I was flicking through package review requests to see if anything > > >

Re: Package review skipped and straight to repos?

2015-11-30 Thread Florian Weimer
On 11/28/2015 11:53 PM, Alexander Ploumistos wrote: > On Sun, Nov 29, 2015 at 12:21 AM, Till Maas wrote: >> On Sun, Nov 29, 2015 at 12:10:07AM +0200, Alexander Ploumistos wrote: >>> How come datagrepper lists FAF reports for the package from 2015-07-20, >>> when it hadn't

Re: Package review skipped and straight to repos?

2015-11-30 Thread Rex Dieter
Alexander Ploumistos wrote: > On Mon, Nov 30, 2015 at 10:53 AM, Florian Weimer > wrote: >> Apparently, ABRT reports crashes for packages not part of Fedora. > > Thanks, I'd guessed that much, but I wanted some confirmation. > >> A possible fix would be to look at the

Re: Package review skipped and straight to repos?

2015-11-29 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Nov 29, 2015 at 09:53:40PM +, Sérgio Basto wrote: > On Sáb, 2015-11-28 at 14:56 -0700, Kevin Fenzi wrote: > > On Sat, 28 Nov 2015 21:11:48 + > > James Hogarth wrote: > > > > > I was flicking through package review requests to see if anything > > > jumped

Re: Package review skipped and straight to repos?

2015-11-29 Thread Sérgio Basto
On Sáb, 2015-11-28 at 14:56 -0700, Kevin Fenzi wrote: > On Sat, 28 Nov 2015 21:11:48 + > James Hogarth wrote: > > > I was flicking through package review requests to see if anything > > jumped out as interesting when I saw this: > > > >

Re: Package review skipped and straight to repos?

2015-11-28 Thread Alexander Ploumistos
How come datagrepper lists FAF reports for the package from 2015-07-20, when it hadn't been included yet? -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org

Re: Package review skipped and straight to repos?

2015-11-28 Thread Till Maas
On Sun, Nov 29, 2015 at 12:10:07AM +0200, Alexander Ploumistos wrote: > How come datagrepper lists FAF reports for the package from 2015-07-20, > when it hadn't been included yet? Who said it was not included? It was until now. It will be gone from the mirrors after the next update push. Regards

Re: Package review skipped and straight to repos?

2015-11-28 Thread Till Maas
On Sat, Nov 28, 2015 at 09:11:48 +, James Hogarth wrote: > I was flicking through package review requests to see if anything jumped > out as interesting when I saw this: > > https://bugzilla.redhat.com/show_bug.cgi?id=1280422 > > Thought I'd take a look as I hadn't had time to review it

Re: Package review skipped and straight to repos?

2015-11-28 Thread Kevin Fenzi
On Sat, 28 Nov 2015 21:11:48 + James Hogarth wrote: > I was flicking through package review requests to see if anything > jumped out as interesting when I saw this: > > https://bugzilla.redhat.com/show_bug.cgi?id=1280422 > > Thought I'd take a look as I hadn't had

Re: Package review skipped and straight to repos?

2015-11-28 Thread Alexander Ploumistos
On Sun, Nov 29, 2015 at 12:21 AM, Till Maas wrote: > On Sun, Nov 29, 2015 at 12:10:07AM +0200, Alexander Ploumistos wrote: >> How come datagrepper lists FAF reports for the package from 2015-07-20, >> when it hadn't been included yet? > > Who said it was not included? It was

Package review skipped and straight to repos?

2015-11-28 Thread James Hogarth
I was flicking through package review requests to see if anything jumped out as interesting when I saw this: https://bugzilla.redhat.com/show_bug.cgi?id=1280422 Thought I'd take a look as I hadn't had time to review it when it first appeared and the requester had fixed the github breaking

Re: Package review skipped and straight to repos?

2015-11-28 Thread Parag Nemade
Hi, On Sun, Nov 29, 2015 at 3:27 AM, Till Maas wrote: > On Sat, Nov 28, 2015 at 09:11:48 +, James Hogarth wrote: > >> I was flicking through package review requests to see if anything jumped >> out as interesting when I saw this: >> >>