Re: [OMPI devel] C style rules / reformatting

of Nathan Hjelm via devel Date: Tuesday, May 18, 2021 at 11:24 AM To: Open MPI Developers Cc: Nathan Hjelm Subject: Re: [OMPI devel] C style rules / reformatting It really is a shame that could not go forward. There are really three end goals in mind: 1) Consistency. We all have different coding

Re: [OMPI devel] C style rules / reformatting

It really is a shame that could not go forward. There are really three end goals in mind: 1) Consistency. We all have different coding styles and following a common coding style is more and more considered a best practice. The number of projects using clang-format grows continuously. I find

Re: [OMPI devel] C style rules / reformatting

That sounds awesome; many thanks, Joseph. On May 18, 2021, at 10:53 AM, Joseph Schuchart via devel mailto:devel@lists.open-mpi.org>> wrote: Jeff, all, I am looking into uncrustify [1], which is highly configurable and has the ability to ignore many of its >700 rules available. Some of the

Re: [OMPI devel] C style rules / reformatting

Jeff, all, I am looking into uncrustify [1], which is highly configurable and has the ability to ignore many of its >700 rules available. Some of the ignored rules seem broken, for which I have filed a bug already [2]. Right now it seems that there is no way to ignore the indentation of

Re: [OMPI devel] C style rules / reformatting

Thanks for the datapoint, Wesley! On May 18, 2021, at 10:20 AM, Wesley Bland mailto:w...@wesbland.com>> wrote: Hey folks, As a datapoint, in MPICH, we use GNU indent for this. Script to format code (either one file or the entire code tree) -

Re: [OMPI devel] C style rules / reformatting

Hey folks, As a datapoint, in MPICH, we use GNU indent for this. Script to format code (either one file or the entire code tree) - https://github.com/pmodels/mpich/blob/main/maint/code-cleanup.bash

[OMPI devel] C style rules / reformatting

FYI: It was decided last week that we will abandon the current effort to reformat master / v5.0.x according to style rules. SHORT VERSION We have already reformatted opal/ and tests/. But the two PRs for reformatting ompi/ brought up a whole bunch of issues that do not seem resolvable via