Re: Garbled IPv6 printout

2019-03-31 Thread Kurt Roeckx via devel
On Sat, Mar 30, 2019 at 08:05:41PM -0700, Hal Murray wrote: > > A sockaddr is not meant to store the address, ... > > But the API wants a sockaddr. >int accept(int sockfd, struct sockaddr *addr, socklen_t *addrlen); > There is no hint in the man page that an IPv6 address won't fit. > >

Re: Garbled IPv6 printout

2019-03-30 Thread Hal Murray via devel
> A sockaddr is not meant to store the address, ... But the API wants a sockaddr. int accept(int sockfd, struct sockaddr *addr, socklen_t *addrlen); There is no hint in the man page that an IPv6 address won't fit. sockaddr ends with sa_data[14]; That's not big enough for an IPv6

Re: Garbled IPv6 printout

2019-03-30 Thread Gary E. Miller via devel
Yo Hal! On Sat, 30 Mar 2019 14:35:18 -0700 Hal Murray via devel wrote: > I just pushed a fix. It was an interesting quirk. Looks good to me: 2019-03-30T15:02:20 ntpd[5666]: NTSc: nts_probe connecting to kong.rellim.com:12 3 => [2001:470:e815:0:225:90ff:fef3:55da]:123 I also see the ntp

Re: Garbled IPv6 printout

2019-03-30 Thread Kurt Roeckx via devel
On Sat, Mar 30, 2019 at 02:35:18PM -0700, Hal Murray via devel wrote: > I just pushed a fix. It was an interesting quirk. The API for accepet > includes a pointer and length to a place to put the IP Address of the remote > site. The type of that place is struct sockaddr. sockaddr is generic,

Garbled IPv6 printout

2019-03-30 Thread Hal Murray via devel
I just pushed a fix. It was an interesting quirk. The API for accepet includes a pointer and length to a place to put the IP Address of the remote site. The type of that place is struct sockaddr. sockaddr is generic, presumably big enough for the biggest address format. They botched