Re: [Development] qmlcachegen and QQC2 styles

2024-05-10 Thread Fabian Kosmale via Development
satisfying situation when moving to more modern QML practices. I'd like to ask about possible ways forward so that we can fully benefit from qmlcachegen while keeping the ability to have different QQC2 styles. Cheers Nico -- Fabian Kosmale Manager R The Qt Company GmbH Erich-Thilo-Str. 10 D-12

Re: [Development] QtProtobuf and QtGrpc final API review

2024-04-22 Thread Fabian Kosmale via Development
Hi, before diving into the API: Do we have more recent documentation than https://doc-snapshots.qt.io/qt6-dev/qtprotobuf-index.html? I have the following issue: The API provides both a set of abstract interfaces which can be used to _implement_ grpc support, as well as an actual implementation

Re: [Development] Qt Examples need to be self-contained

2024-03-07 Thread Fabian Kosmale via Development
Hi, just for clarification: If we factor out shared resources into a library, then that wouldn't be one big QtExamplesShared module, but rather one library per module (unless something actually needs to be shared across multiple modules, e.g. icons). Anything else would require moving examples

Re: [Development] Documentation and Q_GADGET / Q_PROPERTY

2024-01-15 Thread Fabian Kosmale via Development
Hi, my opinion is that the clazy warning should be treated as a false positive. In general, a Q_GADGET can't have signals (at least not with the current design of the metaobject) system, so the warning really doesn't make sense. So I'd say for gadgets, we should just fix clazy (and other

Re: [Development] Stepping down as Android maintainer

2024-01-08 Thread Fabian Kosmale via Development
Hi, first of all, thanks to BogDan for all the work he did on the Android port. We've come quite a way since the initial days of the Necessitas project! Next, I'll second the +1 for Assam - he has been very helpful and responsive with addressing issues on the Android platform in all areas,

Re: [Development] Request for early MOC support for C++20 Modules

2023-12-15 Thread Fabian Kosmale via Development
Hi Elias, let's get your second question out of the way: Doesn't Q_PROPERTY(Qstring text MEMBER m_text) cover that already? Now, for the actual question, moc supporting modules: That certainly wasn't a priority before CMake had official support for modules, but granted, they do now support

[Development] Nominating Semih Yavuz as an approver for the Qt project

2023-12-07 Thread Fabian Kosmale via Development
Hi, I would like to nominate Semih Yavuz for approver rights to the Qt project. Semih has been working on the Qt project since September 2022. He has been mainly focusing on the QML tooling story, including work on qmlformat and the QML language server. In addition, he is also taking care of

Re: [Development] Proposing new Qt Creator module: Qt Creator Solutions

2023-11-30 Thread Fabian Kosmale via Development
Hi, I agree that it would be nice to properly separate Solutions (to enforce their reusability, and to make it easier to include the module into other projects). I'm also convinced that Jarek would do a good job as the maintainer of the module. I have however two questions: 1. How this will

Re: [Development] Qt v6.6.0 and v6.6.1 from online installer differences?

2023-11-30 Thread Fabian Kosmale via Development
Hi, this change (https://codereview.qt-project.org/c/qt/qtbase/+/512774) was intentional and aimed to resolve https://bugreports.qt.io/browse/QTBUG-117514. However, given the lack of a changelog, I don't believe the BIC break between 6.6.0 and 6.6.1 was intentional. I hope Marc or Thiago have

Re: [Development] Deprecating QSharedMemory and QSystemSemaphore

2023-11-20 Thread Fabian Kosmale via Development
Hi, to have some reply in this thread: First of all, I agree with Thiago's assessment of the API's weaknesses. I believe there might be ways to make the issues less likely in practice but I don't see a way to fix this either. Certainly not without some new API to at least have an atomic

Re: [Development] Nominating Adrian Herrmann as approver for the Qt project

2023-08-22 Thread Fabian Kosmale via Development
+1 I've discussed parts of the asyncio improvements as well as some QML-Python integration related work with Adrian, and I trust that he'll wield the approve rights responsibly. Fabian Von: Development im Auftrag von Shyamnath Premnadh via

Re: [Development] std::optional for Q_PROPERTY

2023-07-20 Thread Fabian Kosmale via Development
Hi, as far as QMetaType is concerned: We need a way to have some introspection on the "contained" type. That can't really be shoehorned into the current QMetaTypeInterface, because that one has neither enough space, nor a useable function pointer that could be hijacked. However, incrementing the

Re: [Development] QTBUG-111330: moc help needed: parsing QtDBus Q_NOREPLY

2023-07-15 Thread Fabian Kosmale via Development
Hi, https://codereview.qt-project.org/c/qt/qtbase/+/466471 should have fixed the issue, and should be in 6.5.2 and later. 6.5.1 and .0 should have a revert of the commit that caused the regression, so all versions of Qt 6.5 should work. Fabian -- Fabian Kosmale Manager The Qt Company GmbH

Re: [Development] API style guide: scoped enum or not?

2023-06-20 Thread Fabian Kosmale via Development
on this particular point? That QML allows using an enum value without scope if the C++ enum is scoped seems like a bug to me, although I assume that changing this will come with some incompatibility fallout. Volker -- Fabian Kosmale Manager R The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin

Re: [Development] Header review process: follow-up on comments

2023-05-02 Thread Fabian Kosmale via Development
responsibility during header review, but esp with qtbase that is also a lot of people. What can we do to make this a better process that doesn’t end up with changes being made very late (with 6.5 we had some the day before the release candidate, IIRC)? Volker -- Fabian Kosmale Manager R

Re: [Development] Nominating Amir Masoud Abdol as approver

2023-03-29 Thread Fabian Kosmale via Development
://codereview.qt-project.org/q/reviewer:amir.abdol%2540qt.io -- Fabian Kosmale Manager R The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] QTBUG-111330: moc help needed: parsing QtDBus Q_NOREPLY

2023-03-13 Thread Fabian Kosmale via Development
Hi, I can look into fixing this from the moc side. Is there any smaller, self-contained reproducer than KWallet? Regards, Fabian Von: Development im Auftrag von Thiago Macieira Gesendet: Montag, 13. März 2023 16:38 An: development@qt-project.org

Re: [Development] Problems porting Qt5.15 to Qt 6.2 for OS/2

2022-11-15 Thread Fabian Kosmale via Development
__ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development <https://lists.qt-project.org/listinfo/development> ___ Development mailing list Development@qt-project.org https://lists.qt-project.o

[Development] Nominating Sami Shalayel as approver

2022-11-04 Thread Fabian Kosmale via Development
Hi, I'd like to nominate Sami Shalayel as an approver for the Qt project. Sami is employed by the Qt Company and has been working since May on Qt, mostly on QtDeclarative, with a focus on qmltc. He made several good contributions there, and also participates in the review process of QML related

Re: [Development] Nominating Christian Ehrlicher and Andy Shaw as Qt SQL co-maintainers

2022-09-26 Thread Fabian Kosmale
Hi, for the sake of process, I'd like Alex's confirmation that he indeed was CCed on your mail; but otherwise I'm certain that both Christian and Andy will do a good job maintaining Qt SQL. So +1 Fabian Von: Development im Auftrag von Volker

Re: [Development] QMetaType and non-const references

2022-07-19 Thread Fabian Kosmale
Hi, besides treating T& and T (which I think is fine for 6.4), anything else should probably only be done in 6.5. I don't currently see much interdependence in the changes you proposed, however we should carefully check that DBus, Qt Remote Objects and QML don't get accidentally broken.

Re: [Development] QMetaType and non-const references

2022-07-19 Thread Fabian Kosmale
Hi, I think the most uncontroversial part is not treating T& as T; I fully agree with it. I think it is fine to reject them in QMetaType::fromType. It is a SC breaking change, but I expect it to only affect template code, which can rather easily fix it by explicitly using remove_ref. Can be done

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Fabian Kosmale
Hi, with the naive approach, old code that used to fail would leak one ICU converter per constructed QStringConverter. I've outlined an approach in the patch which would however avoid that issue (old code would keep failing to create a converter). Only adding support in the XML classes would

[Development] Asking for a FF exception for ICU based QStringConverter

2022-06-08 Thread Fabian Kosmale
Hi, unfortunately, we did not manage to get a QStringConverter backend based on ICU into Qt in time for FF (https://codereview.qt-project.org/c/qt/qtbase/+/393373). This is a feature strongly requested by KDE as an enabler for their KDE Frameworks 6 port [1] and from various users in APAC,

Re: [Development] Problem with QML garbage collection (Qt 5.15)

2022-05-02 Thread Fabian Kosmale
Hi Alberto, I think your issue might be QTBUG-91390 (ListModel does not keep objects with JS ownership alive in 5.15). That was fixed in Qt 6.2 (https://codereview.qt-project.org/c/qt/qtdeclarative/+/354140), but due to the behaviour change never backported to any version of 5.15. The

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-27 Thread Fabian Kosmale
Hi, I certainly would like to use vocabulary types like std::span in our API rather sooner than later. I have some questions regarding your proposal, though. Did I understand you correctly that we - would still guard any such method with an #if __cplusplus >= ..., - would compile our shipped

Re: [Development] Nominating Volker Hilsheimer as co-maintainer of Qt Widgets

2022-01-25 Thread Fabian Kosmale
+1 Volker has been doing a great job fixing issues, stabilizing tests and improving the unit test coverage in the Widgets module Von: Development im Auftrag von Richard Gustavsen Gesendet: Dienstag, 25. Januar 2022 09:38 An: Qt development mailing

Re: [Development] Feature freeze exception for QML Language Server

2021-12-10 Thread Fabian Kosmale
, and currently only a single user, we might instead add it as a 3rdparty module in declarative only used by the tool, if that would make things easier. Regards, Fabian Von: Lars Knoll Gesendet: Freitag, 10. Dezember 2021 09:36 An: Fabian Kosmale Cc: Qt

[Development] Feature freeze exception for QML Language Server

2021-12-09 Thread Fabian Kosmale
Hi, I'd like to request a feature freeze exception for adding an initial version of a QML language server (QTBUG-98759). It is meant to exist as a tool in the qtdeclarative repository, depending on the library in the new Qt Language Server repository

[Development] Heads-up: Issue on dev branch

2021-09-16 Thread Fabian Kosmale
everything should work again. Sorry for any inconvenience this may have caused -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen Sitz der Gesellschaft

Re: [Development] moc output from non-local tool build

2021-09-14 Thread Fabian Kosmale
window should be. 2 years sounds fine to me, but it might be better to express this in terms of Qt minor releases. -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha

Re: [Development] Nominating Ivan Solovev as approver

2021-06-15 Thread Fabian Kosmale
+1 -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen Sitz der Gesellschaft: Berlin Registergericht: Amtsgericht Charlottenburg, HRB 144331 B

Re: [Development] QMetaType support for QFuture

2021-05-10 Thread Fabian Kosmale
still need a way to detect that the contained type is in fact a QFuture (though QMetaType::name might be enough in that case). -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi

Re: [Development] Nominating Andreas Buhr as approver

2021-04-29 Thread Fabian Kosmale
+1 Andreas has been tremendously helpful in the work on the property system, and had contributed both patches and reviews to various other areas. I'm sure he'll do a good job as an approver. -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm

Re: [Development] Question about QtDeclarative Internals

2021-04-21 Thread Fabian Kosmale
envision registerModule to work? What is your QJSValue supposed to contain: - A string with the JS code of the module? - An URL? - A C++ object which ought to provide methods that can then be used in the JS engine? Regards, Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich

Re: [Development] How to deprecate enum values (was: "Deprecated/Obsolete API that survived the transition from Qt 5 to Qt 6")

2021-04-08 Thread Fabian Kosmale
There is a Q_DECL_ENUMERATOR_DEPRECATED to mark enumerators as deprecated. -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen Sitz der

Re: [Development] QHash references stability in Qt6

2021-03-18 Thread Fabian Kosmale
Yes, as described in https://doc.qt.io/qt-6/qtcore-changes-qt6.html#stability-of-references, Qt 6's QHash does indeed intentionally no longer promise reference stability when it grows or elements are removed. -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489

Re: [Development] Nominating Andrei Golubev as Approver

2021-03-18 Thread Fabian Kosmale
+1 Disclosure: We're working on the same team. -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen Sitz der Gesellschaft: Berlin Registergericht

Re: [Development] Stepping down as Qt Virtual Keyboard maintainer

2021-03-11 Thread Fabian Kosmale
+1 for Jarkko as the Qt Virtual Keyboard maintainer (the nomination is now officially seconded, as required by https://wiki.qt.io/The_Qt_Governance_Model) -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io

[Development] QMetaType::NeedsConstruction vs QTypeInfo::isComplex

2021-03-01 Thread Fabian Kosmale
of those two options should we choose? What are the actual use-cases of that flag anyway? -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen Sitz

Re: [Development] Nominating Max Goldstein as an approver

2020-12-14 Thread Fabian Kosmale
+ 1 Max also didn't shy away from diving into the lesser known parts of qtdeclarative like qv4codegen.cpp when adding support nullish coalescing. I'm sure he'll be a responsible approver. The usual disclosure regarding team and office applies. -- Fabian Kosmale Software Engineer The Qt

Re: [Development] QVariant::operator< deprecation fallout

2020-11-22 Thread Fabian Kosmale
::compare, as the former does a fuzzy compare for floating point values, and the latter and a strict comparison. Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Vareli

Re: [Development] New property system

2020-10-01 Thread Fabian Kosmale
leave determining that detail to Ville, and it shouldn't matter in practice anwyay. Regards, Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni

Re: [Development] Codereview scheduled maintenance break on Monday 24-Aug 6 am CET

2020-08-26 Thread Fabian Kosmale
I had that too, and so did Alexandru. The fix is apparently to clear the cache and reload the page afterwards. Regards, Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika

Re: [Development] Qt 6: Assigning QPalette to ApplicationWindow.palette no longer supported?

2020-08-24 Thread Fabian Kosmale
we've come to a decision. What should work (both in 5.x and 6.0) is to use https://doc.qt.io/qt-5/qguiapplication.html#setPalette Does that functionality cover your use case? Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm

Re: [Development] QProperty and library coding guide

2020-07-21 Thread Fabian Kosmale
quite complex over the last 10 days of trying, and the resulting code has not always been a step into the direction of maintainability. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development -- -- Fabia

Re: [Development] Switch the main "Qt Build System"

2020-06-08 Thread Fabian Kosmale
Hi Alexandru, first of all, congratulations on the cmake port progress. But do we have a list of tests which currently only build with qmake? I know that at least that the tst_moc port hasn't been merged yet, and I doubt that it's the only one. Regards, Fabian -- Fabian Kosmale Software

[Development] QMetaMethod in Qt 6

2020-05-27 Thread Fabian Kosmale
orks too, most of the time. It can however negatively affect compile times and breaks completely in the case of circular dependencies. -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsfü

Re: [Development] Circular dependencies for Q_PROPERTY

2020-04-27 Thread Fabian Kosmale
, and there was some discussion around tooling, but I'm not aware of any outcomes so far. Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho Sitz der

Re: [Development] Proposal: Deprecate QVector in Qt 6

2020-04-23 Thread Fabian Kosmale
here? Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331

Re: [Development] Maintainers, your action needed; Qt 5.15.0 Changes Files

2020-04-20 Thread Fabian Kosmale
webengine is on page 2 as far as I can tell. -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho Sitz der Gesellschaft: Berlin, Registergericht

Re: [Development] Make Qt6 JNI API safer to use

2020-03-06 Thread Fabian Kosmale
in Qt. [1] https://ned14.github.io/outcome/ ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development -- -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm

Re: [Development] QML 3 and JavaScript

2019-11-12 Thread Fabian Kosmale
here is still to break as few code as possible. Kind regards, Fabian Am 11.11.19 um 19:36 schrieb Kevin Kofler: > [...] > Then what's the point of maintaining the whole old version, if it won't be > compatible anyway? > -- -- Fabian Kosmale Software Engineer The Qt Company GmbH

Re: [Development] Oslo, we have a problem [char8_t]

2019-07-06 Thread Fabian Kosmale
complain to the committee that their change breaks code… Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho Sitz der Gesellschaft: Berlin

Re: [Development] Oslo, we have a problem [char8_t]

2019-07-06 Thread Fabian Kosmale
nullptr) + test("Hallo!") + test(u8"Ça va?") + test(0) == 6); return 0; } godbolt.org Fabian -- Fabian Kosmale Software Engineer The Qt Company GmbH Erich-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi,