Re: [PATCH] multipath-tools: fix an assignment ambiguity

2024-01-22 Thread Martin Wilck
On Mon, 2024-01-22 at 23:42 +0100, Xose Vazquez Perez wrote: > spotted by indent: > ./kpartx/gpt.c:623: Warning:old style assignment ambiguity in "=-". > Assuming "= -" > > Cc: Martin Wilck > Cc: Benjamin Marzinski > Cc: Christophe Varoqui > Cc: DM-DEVEL ML > Signed-off-by: Xose Vazquez Perez

Re: [PATCH v3 0/4] brd discard patches

2024-01-22 Thread Ming Lei
On Mon, Jan 22, 2024 at 05:30:07PM +0100, Mikulas Patocka wrote: > Hi > > > On Fri, 19 Jan 2024, Ming Lei wrote: > > > Hi Mikulas, > > > > On Thu, Aug 10, 2023 at 12:07:07PM +0200, Mikulas Patocka wrote: > > > Hi > > > > > > Here I'm submitting the ramdisk discard patches for the next merge

Re: [PATCH 3/7] md: test for MD_RECOVERY_DONE in stop_sync_thread

2024-01-22 Thread Benjamin Marzinski
On Mon, Jan 22, 2024 at 05:34:54PM +0100, Mikulas Patocka wrote: This test always hangs for me as well. You can try this for a reproducer Create a F39 Cloud image VM on a host machine (tweaking the root-ssh-key if necessary): # wget

[PATCH 47/82] dm verity: Refactor intentional wrap-around test

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

[PATCH] multipath-tools: fix an assignment ambiguity

2024-01-22 Thread Xose Vazquez Perez
spotted by indent: ./kpartx/gpt.c:623: Warning:old style assignment ambiguity in "=-". Assuming "= -" Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- kpartx/gpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 3/7] md: test for MD_RECOVERY_DONE in stop_sync_thread

2024-01-22 Thread Mikulas Patocka
On Thu, 18 Jan 2024, Song Liu wrote: > > Hmm, that's strange - I get a hang with this stacktrace sometimes > > instantly, sometimes in 30 seconds. I test it on the current kernel from > > Linus' git - 052d534373b7ed33712a63d5e17b2b6cdbce84fd. > > It works for me. I guess there is some

Re: [PATCH v3 0/4] brd discard patches

2024-01-22 Thread Mikulas Patocka
Hi On Fri, 19 Jan 2024, Ming Lei wrote: > Hi Mikulas, > > On Thu, Aug 10, 2023 at 12:07:07PM +0200, Mikulas Patocka wrote: > > Hi > > > > Here I'm submitting the ramdisk discard patches for the next merge window. > > If you want to make some more changes, please let me now. > > brd discard

Re: [PATCH RFC 5/5] md: use md_reap_sync_thread() directly for dm-raid

2024-01-22 Thread Yu Kuai
Hi, 在 2024/01/20 18:37, Yu Kuai 写道: The root cause is still not clear yet, however, let's convert dm-raid back to use md_reap_sync_thread() directly. This is not safe but at least there won't be new regressions. We can decide what to do after figuring out the root cause. I think I finally

Re: [PATCH 0/5] md: fix/prevent dm-raid regressions

2024-01-22 Thread Song Liu
On Mon, Jan 22, 2024 at 12:24 AM Yu Kuai wrote: > > Hi, > > 在 2024/01/21 12:41, Song Liu 写道: > > On Sat, Jan 20, 2024 at 2:41 AM Yu Kuai wrote: > >> > >> From: Yu Kuai > >> > >> There are some problems that we fixed in md/raid, and some apis is changed. > >> However, dm-raid rely the old

Re: [PATCH 0/5] md: fix/prevent dm-raid regressions

2024-01-22 Thread Yu Kuai
Hi, 在 2024/01/21 12:41, Song Liu 写道: On Sat, Jan 20, 2024 at 2:41 AM Yu Kuai wrote: From: Yu Kuai There are some problems that we fixed in md/raid, and some apis is changed. However, dm-raid rely the old apis(noted that old apis is problematic in corner cases), and now there are