Re: [dm-devel] [PATCH v3 2/3] block: allow use of per-cpu bio alloc cache by block drivers

2022-03-24 Thread Christoph Hellwig
On Thu, Mar 24, 2022 at 04:35:25PM -0400, Mike Snitzer wrote: > Refine per-cpu bio alloc cache interfaces so that DM and other block > drivers can properly create and use the cache: > > DM uses bioset_init_from_src() to do its final bioset initialization, > so must update bioset_init_from_src()

Re: [dm-devel] [git pull] device mapper changes for 5.18

2022-03-24 Thread pr-tracker-bot
The pull request you sent on Wed, 23 Mar 2022 16:38:49 -0400: > git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > tags/for-5.18/dm-changes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b1f8ccdaae0310332d16f65bf0f622f9d4ae2391 Thank you! --

Re: [dm-devel] [PATCH] multipath-tools: update mpp->force_readonly in ev_add_path

2022-03-24 Thread Benjamin Marzinski
On Thu, Mar 24, 2022 at 11:08:09AM -0600, Uday Shankar wrote: > Thanks to Benjamin for the review and to Martin for taking the patch. > > > https://github.com/openSUSE/multipath-tools/tree/queue > Benjamin, does RedHat take patches from this repo? The > device-mapper-multipath spec file seems to

[dm-devel] [PATCH] multipath-tools: add Martin and Benjamin as maintainers

2022-03-24 Thread Xose Vazquez Perez
Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- README.md | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 15478625..10ddf463 100644 --- a/README.md +++ b/README.md @@

Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-24 Thread Ryusuke Konishi
On Wed, Mar 23, 2022 at 3:42 PM Christoph Hellwig wrote: > > On Wed, Mar 23, 2022 at 06:38:22AM +0900, Ryusuke Konishi wrote: > > This looks because the mask of GFP_KERNEL is removed along with > > the removal of mpage_alloc(). > > > > > The default value of the gfp flag is set to

Re: [dm-devel] [kbuild-all] Re: [device-mapper-dm:dm-5.19 132/132] drivers/md/dm.c:1542:18: error: 'result' undeclared

2022-03-24 Thread Chen, Rong A
: 7f8ac95a6464b895e3d2b6175f7ee64a4c10fcfe [132/132] dm: push error handling down to __split_and_process_bio config: s390-buildonly-randconfig-r005-20220323 (https://download.01.org/0day-ci/archive/20220324/202203240638.crxqjfy5-...@intel.com/config) compiler: s390-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget

Re: [dm-devel] libmpathpersist: Getting undefined symbol during compilation

2022-03-24 Thread boli sudha
Thanks Benjamin, Thanks for your reply. After I posted this question, I went through the source code and figured out that these functions are defined as weak. So they are not getting added to the library and binaries which are using them are re-defining these definitions. I will try the

Re: [dm-devel] [PATCH 01/19] fs: remove mpage_alloc

2022-03-24 Thread Ryusuke Konishi
On Wed, Mar 23, 2022 at 6:19 AM Guenter Roeck wrote: > > On Mon, Jan 24, 2022 at 10:10:49AM +0100, Christoph Hellwig wrote: > > open code mpage_alloc in it's two callers and simplify the results > > because of the context: > > > > - __mpage_writepage always passes GFP_NOFS and can thus always

[dm-devel] dm-integrity resize crashes kernel

2022-03-24 Thread Ondrej Kozina
Hi, I've hit a dm-integrity crash when re-extending dm-integrity device. The trick is that underlying device needs to change its size as well. There's reproducer attached which I have tested on top of scsi_debug device but it's not limited to scsi_debug. Tested kernel version: 5.17.0, My

Re: [dm-devel] [RFC 0/4] Support kdump with LUKS encryption by reusing LUKS master key

2022-03-24 Thread Guilherme G. Piccoli
On 20/03/2022 22:41, Coiby Xu wrote: > [...] > > I believe some users have security concern for where to save vmcore. > This use case exactly fits your description and your proposed solution > shall be good for this type of users. But I think many more users may > just choose to encrypt the hard

Re: [dm-devel] [PATCH v2 0/4] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset

2022-03-24 Thread Mike Snitzer
On Thu, Mar 24 2022 at 3:39P -0400, Christoph Hellwig wrote: > On Wed, Mar 23, 2022 at 03:45:20PM -0400, Mike Snitzer wrote: > > I tried to address your review of the previous set. Patch 1 and 2 can > > obviously be folded but I left them split out for review purposes. > > Feel free to see if

Re: [dm-devel] [PATCH v2 0/4] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset

2022-03-24 Thread Christoph Hellwig
On Wed, Mar 23, 2022 at 03:45:20PM -0400, Mike Snitzer wrote: > I tried to address your review of the previous set. Patch 1 and 2 can > obviously be folded but I left them split out for review purposes. > Feel free to see if these changes are meaningful for nvme's use. > Happy for either you to

Re: [PATCH v6 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops

2022-03-24 Thread Christoph Hellwig
On Wed, Mar 23, 2022 at 06:43:06PM +, Jane Chu wrote: > > it onto ->direct_access. But nothing in this series actually checks > > for it as far as I can tell. > > The flag is checked here, again, I'll spell out the flag rather than > using it as a boolean. Yes. The whole point of a flags