On 2022-06-17 01:49, Damien Le Moal wrote:
>>> Why do you need to change dm_set_zones_restrictions() at all ?
>>>
>> When the device mapper is created, the q->limits gets inherited from the
>> underlying device. The chunk sectors of the target and the device will
>> be the same but we want the
On 6/15/22 13:02, Mike Snitzer wrote:
On Wed, Jun 15 2022 at 1:50P -0400,
Guenter Roeck wrote:
On 6/15/22 08:29, Mike Snitzer wrote:
On Wed, Jun 15 2022 at 10:36P -0400,
Guenter Roeck wrote:
On Mon, Jun 13, 2022 at 11:13:21AM +0200, Greg KH wrote:
On Fri, Jun 10, 2022 at 11:11:00AM
On Tue, Jun 14 2022 at 5:09P -0400,
Christoph Hellwig wrote:
> max_io_len always passes an explicitly non-zero chunk_sectors into
> blk_max_size_offset. That means much of blk_max_size_offset is not
> needed and can be open coded to simplify the code.
>
> Signed-off-by: Christoph Hellwig
>
On Tue, Jun 14 2022 at 5:09P -0400,
Christoph Hellwig wrote:
> Factor out a helper from blk_max_size_offset so that it can be reused
> independently.
>
> Signed-off-by: Christoph Hellwig
> ---
> include/linux/blkdev.h | 19 +--
> 1 file changed, 13 insertions(+), 6
On 4/1/22 12:20, Martin Wilck wrote:
On Mon, 2022-03-28 at 19:57 +0200, Xose Vazquez Perez wrote:
On 3/28/22 19:48, Martin Wilck wrote:
On Mon, 2022-03-28 at 19:04 +0200, Xose Vazquez Perez wrote:
Cc: Martin Wilck
Cc: Benjamin Marzinski
Cc: Christophe Varoqui
Cc: DM-DEVEL ML
Starting with the commit 63a225c9fd20, device mapper has an optimization
that it will take cheaper table lock (dm_get_live_table_fast instead of
dm_get_live_table) if the bio has REQ_NOWAIT. The bios with REQ_NOWAIT
must not block in the target request routine, if they did, we would be
blocking
The code in dm-long rounds up bitset_size to 32 bits. It then uses
find_next_zero_bit_le on the allocated region. find_next_zero_bit_le
accesses the bitmap using unsigned long pointers. So, on 64-bit
architectures, it may access 4 bytes beyond the allocated size.
This bug was found by running the
dm_put_live_table_bio is called from the end of dm_submit_bio. However, at
this point, the bio may be already finished and the caller may have freed
the bio. Consequently, dm_put_live_table_bio accesses the stale "bio"
pointer.
This patch fixes the bug by loading the bi_opf value and passing this
On Thu, Jun 16, 2022 at 12:09:35PM +0200, Pankaj Raghav wrote:
> On 2022-06-15 22:28, Bart Van Assche wrote:
> >> + if (!is_power_of_2(zone->len) && zone->capacity < zone->len) {
> >> + pr_warn("%s: Invalid zone capacity for non power of 2
> >> zone size",
> >> +
Hi Damien,
On 2022-06-15 13:49, Damien Le Moal wrote:
> On 6/15/22 19:19, Pankaj Raghav wrote:
>> Only power of 2(po2) zoned devices were supported in linux but now non
>> power of 2(npo2) zoned device support has been added to the block layer.
>>
>> Filesystems such as F2FS and btrfs have support
On 2022-06-15 13:01, Damien Le Moal wrote:
> On 6/15/22 19:19, Pankaj Raghav wrote:
>> dm_zone_endio() updates the bi_sector of orig bio for zoned devices that
>> uses either native append or append emulation and it is called before the
>> endio of the target. But target endio can still update the
On 2022-06-15 21:54, Randy Dunlap wrote:
> Hi--
>
> On 6/15/22 03:19, Pankaj Raghav wrote:
>
>> ---
>> drivers/md/Kconfig| 9 +
>> drivers/md/Makefile | 2 +
>> drivers/md/dm-zone.c | 9 +
>> drivers/md/dm-zoned-npo2-target.c | 268
On 2022-06-15 22:28, Bart Van Assche wrote:
isk_name, zone->len);
>> + if (zone->len == 0) {
>> + pr_warn("%s: Invalid zone size", disk->disk_name);
>> + return -ENODEV;
>> + }
>> +
>> + /*
>> + * Don't allow zoned device with non power_of_2 zone
drivers/md/dm-table.c
>> +++ b/drivers/md/dm-table.c
>> @@ -251,7 +251,7 @@ static int device_area_is_invalid(struct dm_target *ti,
>> struct dm_dev *dev,
>> if (bdev_is_zoned(bdev)) {
>> unsigned int zone_sectors = bdev_zone_sectors(bdev);
>>
>> -if (start &
On Tue, Jun 14, 2022 at 11:09:33AM +0200, Christoph Hellwig wrote:
> Now that blk_max_size_offset has a single caller left, fold it into that
> and clean up the naming convention for the local variables there.
>
> Signed-off-by: Christoph Hellwig
> ---
> block/blk-merge.c | 9 +++--
>
On Tue, Jun 14, 2022 at 11:09:29AM +0200, Christoph Hellwig wrote:
> Factor out a helper from blk_max_size_offset so that it can be reused
> independently.
>
> Signed-off-by: Christoph Hellwig
> ---
> include/linux/blkdev.h | 19 +--
> 1 file changed, 13 insertions(+), 6
16 matches
Mail list logo
