Re: changed behavior for dovecot-lda in 2.3.x

2018-04-08 Thread Stephan Bosch
Op 4/7/2018 om 10:16 PM schreef Martin Waschbüsch:
> Hi all,
>
> Hey all, I upgraded to dovecot 2.3.1 (from 2.2.34) and noticed that the 
> behavior for dovecot-lda changed. Apparently it no longer accepts -f "" or -f 
> "<>?
> With 2.2.34, both were accepted now I get:
>
> root@mail:~# /usr/local/libexec/dovecot/dovecot-lda -f "<>"
> lda(root): Fatal: Invalid -f parameter: Null path not allowed
>
> or
>
> root@mail:~# /usr/local/libexec/dovecot/dovecot-lda -f ""
> lda(root): Fatal: Invalid -f parameter: Path is empty string
>
> I guess this must be a bug? I mean, envelope sender *must* be empty for 
> bounces.

That is definitely a bug. Fix is available here:

https://github.com/stephanbosch/dovecot-core/commits/lda-fix-allow-empty-sender

Fix will be merged after internal review.

Regards,

Stephan.



Re: changed behavior for dovecot-lda in 2.3.x

2018-04-07 Thread Martin Waschbüsch

> Am 07.04.2018 um 22:16 schrieb Martin Waschbüsch :
> 
> Hi all,
> 
> Hey all, I upgraded to dovecot 2.3.1 (from 2.2.34) and noticed that the 
> behavior for dovecot-lda changed. Apparently it no longer accepts -f "" or -f 
> "<>?
> With 2.2.34, both were accepted now I get:
> 
> root@mail:~# /usr/local/libexec/dovecot/dovecot-lda -f "<>"
> lda(root): Fatal: Invalid -f parameter: Null path not allowed
> 
> or
> 
> root@mail:~# /usr/local/libexec/dovecot/dovecot-lda -f ""
> lda(root): Fatal: Invalid -f parameter: Path is empty string
> 
> I guess this must be a bug? I mean, envelope sender *must* be empty for 
> bounces.

In the list-archive, I saw at least one other person seemed to have had the 
same problem.
Anyway, I fixed my immediate problem and created a pull-request which seems 
like the right thing to do:

https://github.com/dovecot/core/pull/73 


perhaps this helps someone else, too.

Thx,

Martin