Removed centralized exiting of function (goto statement), since it was the only
used in one single location with only a return statement.
Signed-off-by: Arthur Borsboom
---
drivers/gpu/drm/gma500/psb_drv.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
Cleanup of code by following i915 constant/variable names and ordering
Cleanup of code by following directions from kernel documentation: Codingstyle
Cleanup of code by following directions from kernel documentation: DRM
Signed-off-by: Arthur Borsboom
---
drivers/gpu/drm/gma500/psb_drv.c | 132
Improve readability by adding/changing inline documentation
Signed-off-by: Arthur Borsboom
---
drivers/gpu/drm/gma500/psb_drv.c | 56 +---
drivers/gpu/drm/gma500/psb_drv.h | 24 +++--
2 files changed, 63 insertions(+), 17 deletions(-)
diff --git
On Thu, Mar 13, 2014 at 1:28 PM, Thomas Hellstrom
wrote:
> But a compiler can't (or shouldn't) make that assumption. Just as an
> (adapted) example, imagine that
> each test had a 20% probability of returning an error. The probability
> of the function returning an error would
> then be 68%..
hives/dri-devel/attachments/20140313/45c26bd8/attachment.html>
are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140313/79014235/attachment.html>
On 13.03.2014 16:48, Inki Dae wrote:
> Hi Tomasz,
>
> 2014-03-13 23:05 GMT+09:00 Tomasz Figa :
>> Hi Inki,
>>
>>
>> On 13.03.2014 08:33, Inki Dae wrote:
>>>
>>> Hi Sean,
>>>
>>> Merged your all patch series except for dt binding patches - it needs
>>> more cleanups about ddc and phy - and I had a
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20140313/bfb2d17b/attachment.html>
The DRM_PANEL_SIMPLE is needed by the eukrea
mbimxsd51's displays.
Signed-off-by: Denis Carikli
---
- New patch, splitting it would be overkill.
---
arch/arm/configs/imx_v6_v7_defconfig |2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig
Signed-off-by: Denis Carikli
---
ChangeLog v9->v11:
- Now uses the drm-panel instead of the display-timings.
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- The backlight is now on at boot.
ChangeLog v6->v7:
- Shrinked even more the Cc list.
ChangeLog v5->v6:
The CMO-QVGA, DVI-SVGA and DVI-VGA are added.
Signed-off-by: Denis Carikli
---
ChangeLog v10->v11:
- Now uses the drm-panel instead of the display-timings.
This is to get regulator support, which is lacking in
the imx-drm driver when using the display-timings.
ChangeLog v9->v10:
- Rebased
-
Signed-off-by: Denis Carikli
---
ChangeLog v10->v11:
- New patch.
---
.../bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt |7 ++
.../bindings/panel/eukrea,mbimxsd51-dvi-svga.txt |7 ++
.../bindings/panel/eukrea,mbimxsd51-dvi-vga.txt|7 ++
drivers/gpu/drm/panel/panel-simple.c
The previous hardware behaviour was kept if the
flags are not set.
Signed-off-by: Denis Carikli
---
ChangeLog v10->v11:
- This patch was splitted-out and adapted from:
"Prepare imx-drm for extra display-timings retrival."
- The display-timings dt specific part was removed.
- The flags names
We need a way to pass signal polarity informations
between DRM panels, and the display drivers.
To do that, a pol_flags field was added to drm_display_mode.
Signed-off-by: Denis Carikli
---
ChangeLog v10->v11:
- Since the imx-drm won't be able to retrive its regulators
from the device tree
The imx-drm driver can't use the de-active and
pixelclk-active display-timings properties yet.
Instead the data-enable and the pixel data clock
polarity are hardcoded in the imx-drm driver.
So theses properties are now set to keep
the same behaviour when imx-drm will start
using them.
Signed-off-by: Denis Carikli
---
ChangeLog v9->v10:
- New patch which was splitted out from:
"staging: imx-drm: Use de-active and pixelclk-active display-timings.".
- Fixes many issues in "staging: imx-drm: Use de-active and pixelclk-active
display-timings.":
- More clear meaning of the
According to the datasheet, setting the di0_polarity_disp_clk
field in the GENERAL di register sets the output clock polarity
to active high.
Signed-off-by: Denis Carikli
---
ChangeLog v9->v10:
- New patch that is now needed by the
"staging: imx-drm: Use de-active and pixelclk-active" patch.
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Signed-off-by: Denis Carikli
Acked-by: Philipp Zabel
---
ChangeLog v9->v10:
- Rebased.
- Added Philipp Zabel's Ack.
- Included Lothar Wa?mann's suggestion about
Signed-off-by: Denis Carikli
Acked-by: Philipp Zabel
---
ChangeLog v8->v9:
- Rebased.
- Added Philipp Zabel's ack.
- Shortened the patch title.
ChangeLog v8->v9:
- Removed the Cc. They are now set in git-send-email directly.
- Rebased.
ChangeLog v7->v8:
- Shrinked even more the Cc list.
That new macro is needed by the imx_drm staging driver
for supporting the QVGA display of the eukrea-cpuimx51 board.
Signed-off-by: Denis Carikli
Acked-by: Mauro Carvalho Chehab
Acked-by: Laurent Pinchart
Acked-by: Philipp Zabel
---
ChangeLog v9->v10:
- Rebased on top of:
"211e7f2 [media]
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20140313/355088f0/attachment.html>
...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140313/ed68eb8e/attachment.html>
hments/20140313/e99ef81c/attachment.html>
This patch changes i2c_client for ddc to i2c_adapter
because ddc needs only i2c_adapter.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
This patch returns error in case of using APB PHY.
Exynos5420 SoC and maybe later would use APB PHY instead of
I2C PHY so such case should be considered.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 26 +++---
1 file
Hi Sean,
Merged your all patch series except for dt binding patches - it needs
more cleanups about ddc and phy - and I had a little change just for
cleanup.
And some more cleanups and enhanced feature set on top of your patch
series would be merged, and then they will go to -next.
Thanks,
Inki
2014-03-12 20:16 GMT+09:00 Tomasz Figa :
> On 12.03.2014 11:08, Inki Dae wrote:
>>
>> 2014-03-07 19:00 GMT+09:00 Andrzej Hajda :
>>>
>>> On 03/05/2014 03:56 AM, Inki Dae wrote:
Hi Andrzej,
Thanks for your contributions.
2014-02-12 20:31 GMT+09:00 Andrzej Hajda :
>
Hi Inki,
On 13.03.2014 08:33, Inki Dae wrote:
> Hi Sean,
>
> Merged your all patch series except for dt binding patches - it needs
> more cleanups about ddc and phy - and I had a little change just for
> cleanup.
> And some more cleanups and enhanced feature set on top of your patch
> series
Le 13/03/2014 14:38, Ilia Mirkin a ?crit :
> On Sun, Mar 9, 2014 at 10:51 AM, Marcin Slusarz
> wrote:
>> [ 326.168487] ==
>> [ 326.168491] [ INFO: possible circular locking dependency detected ]
>> [ 326.168496] 3.13.6 #1270 Not tainted
>> [
On 03/13/2014 08:08 AM, Inki Dae wrote:
> 2014-03-12 20:16 GMT+09:00 Tomasz Figa :
>> On 12.03.2014 11:08, Inki Dae wrote:
>>> 2014-03-07 19:00 GMT+09:00 Andrzej Hajda :
On 03/05/2014 03:56 AM, Inki Dae wrote:
> Hi Andrzej,
>
> Thanks for your contributions.
>
> 2014-02-12
It doesn't appear to be used anywhere.
Signed-off-by: Thomas Hellstrom
Reviewed-by: David Herrmann
---
drivers/gpu/drm/drm_stub.c |5 -
include/drm/drmP.h |2 --
2 files changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
index
Add a drm_is_legacy() helper, constify argument to drm_is_render_client(),
and use / change helpers where appropriate.
v2: s/drm_is_legacy/drm_is_legacy_client/ and adapt to new code context.
Signed-off-by: Thomas Hellstrom
---
drivers/gpu/drm/drm_crtc.c |4 ++--
drivers/gpu/drm/drm_fops.c
Like for render-nodes, there is no point in maintaining the master concept
for control nodes, so set the struct drm_file::master pointer to NULL.
At the same time, make sure DRM_MASTER | DRM_CONTROL_ALLOW ioctls are always
allowed when called through the control node. Previously the caller also
Helps reviewing and understanding these checks.
v2: Remove misplaced newlines.
Signed-off-by: Thomas Hellstrom
Reviewed-by: David Herrmann
---
drivers/gpu/drm/drm_drv.c | 113 ++---
1 file changed, 75 insertions(+), 38 deletions(-)
diff --git
control- and render nodes are intended to be master-less.
v2: Replace tests for !legacy with tests for !mode_group for readability.
Signed-off-by: Thomas Hellstrom
Reviewed-by: David Herrmann
---
drivers/gpu/drm/drm_crtc.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
After a previous patch series and a discussion with Daniel Vetter and
David Herrmann, I've reworked the patches a bit. Please review.
Patch 1,2 and 5 already reviewed.
Thanks,
Thomas
Hi Dave,
Here's my drm documentation update and driver api polish pull request.
Alex reviewed the entire pile, I've applied a little bit of spelling
polish in a few places since then and otherwise the Usual Suspects (David,
Rob, ...) don't seem up to have another look at it (I've poked them on
On 03/13/2014 01:15 PM, David Herrmann wrote:
> Hi
>
> On Thu, Mar 13, 2014 at 1:11 PM, Thomas Hellstrom
> wrote:
>> Hi.
>>
>> Thanks for reviewing. I'll incorporate your suggestions, except this
>> one, and resend.
>>
>>
>> On 03/13/2014 12:19 PM, David Herrmann wrote:
>>> Hi
>>>
>>> On Thu,
Hi
On Thu, Mar 13, 2014 at 1:11 PM, Thomas Hellstrom
wrote:
> Hi.
>
> Thanks for reviewing. I'll incorporate your suggestions, except this
> one, and resend.
>
>
> On 03/13/2014 12:19 PM, David Herrmann wrote:
>> Hi
>>
>> On Thu, Mar 13, 2014 at 11:57 AM, Thomas Hellstrom
>> wrote:
> ...
>
> -
Hi.
Thanks for reviewing. I'll incorporate your suggestions, except this
one, and resend.
On 03/13/2014 12:19 PM, David Herrmann wrote:
> Hi
>
> On Thu, Mar 13, 2014 at 11:57 AM, Thomas Hellstrom
> wrote:
...
- if (cmd & IOC_IN) {
- if
Hi
On Thu, Mar 13, 2014 at 11:57 AM, Thomas Hellstrom
wrote:
> Like for render-nodes, there is no point in maintaining the master concept
> for control nodes, so set the struct drm_file::master pointer to NULL.
>
> At the same time, make sure DRM_MASTER | DRM_CONTROL_ALLOW ioctls are always
>
Hi
On Thu, Mar 13, 2014 at 11:57 AM, Thomas Hellstrom
wrote:
> Helps reviewing and understanding these checks.
>
> Signed-off-by: Thomas Hellstrom
> ---
> drivers/gpu/drm/drm_drv.c | 116
> ++---
> 1 file changed, 78 insertions(+), 38 deletions(-)
>
>
Hi
On Thu, Mar 13, 2014 at 11:57 AM, Thomas Hellstrom
wrote:
> control- and render nodes are intended to be master-less.
>
> Signed-off-by: Thomas Hellstrom
> ---
> drivers/gpu/drm/drm_crtc.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git
Hmm. Screwed up git-send-email a bit :(
Resending with new subject.
/Thomas
On 03/13/2014 11:57 AM, Thomas Hellstrom wrote:
> After a previous patch series and a discussion with Daniel Vetter and
> David Herrmann, I've reworked the patches a bit. Please review.
>
> Patch 5 is already reviewed.
It doesn't appear to be used anywhere.
Signed-off-by: Thomas Hellstrom
Reviewed-by: David Herrmann
---
drivers/gpu/drm/drm_stub.c |5 -
include/drm/drmP.h |2 --
2 files changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
index
Add a drm_is_legacy() helper, constify argument to drm_is_render_client(),
and use / change helpers where appropriate.
Signed-off-by: Thomas Hellstrom
---
drivers/gpu/drm/drm_crtc.c | 10 +-
drivers/gpu/drm/drm_fops.c |5 ++---
include/drm/drmP.h |9 +++--
3 files
Like for render-nodes, there is no point in maintaining the master concept
for control nodes, so set the struct drm_file::master pointer to NULL.
At the same time, make sure DRM_MASTER | DRM_CONTROL_ALLOW ioctls are always
allowed when called through the control node. Previously the caller also
Helps reviewing and understanding these checks.
Signed-off-by: Thomas Hellstrom
---
drivers/gpu/drm/drm_drv.c | 116 ++---
1 file changed, 78 insertions(+), 38 deletions(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index
control- and render nodes are intended to be master-less.
Signed-off-by: Thomas Hellstrom
---
drivers/gpu/drm/drm_crtc.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 3b7d32d..c9d895a 100644
After a previous patch series and a discussion with Daniel Vetter and
David Herrmann, I've reworked the patches a bit. Please review.
Patch 5 is already reviewed.
/Thomas
>From Thomas Hellstrom # This line is ignored.
From: Thomas Hellstrom
Subject:
In-Reply-To:
Now that the drm_display_mode also provides aspect
ratio for all resolutions, this patch adds its usage
to set the active aspect ratio of AVI info frame
packets as per CEA-861-D standard's Table 9.
This is also needed to abide by the 7-27
compliance test of HDMI.
Signed-off-by: Shirish S
---
This patch adds support for the below mentioned
pixel clocks in Exynos5250.
Without them, following display modes won?t
be supported:
71 MHz - 1280x800 at 60Hz RB
73.25 MHz - 800x600 at 120Hz RB
88.75 MHz - 1440x900 at 60Hz RB
115.5 MHz - 1024x768 at 120Hz RB
119 MHz -
On Sun, Mar 9, 2014 at 10:51 AM, Marcin Slusarz
wrote:
> [ 326.168487] ==
> [ 326.168491] [ INFO: possible circular locking dependency detected ]
> [ 326.168496] 3.13.6 #1270 Not tainted
> [ 326.168500]
part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140313/f349901d/attachment.html>
Hi,
Rob Clark [robdclark at gmail.com]:
> you probably should use the KMS interface directly, rather than fbdev.
> Then you can modeset, do actual pageflips, get vblank events, etc.
> A couple examples:
Thanks for the hint. I compiled modeset buth was overwhelmed with the mode
string (-s
Dave,
A single fix for the new device code.
The following changes since commit 45db98e54242f3ae94bdcfbfe754e743252eb168:
Merge branch 'drm-fixes-3.14' of git://people.freedesktop.org/~agd5f/linux
into drm-fixes (2014-03-07 09:27:22 +1000)
are available in the git repository at:
.
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20140313/fd9c40bd/attachment.html>
On 13/03/14 01:05, Ilia Mirkin wrote:
[snip]
>
> Not really. drm->drm_version will be 0 if ver fails.
>
Indeed, dev is calloc'ated by its callers, and if they mess around with
that's their own fault.
Sorry for the noise.
-Emil
On 13/03/14 00:49, Ilia Mirkin wrote:
> On Wed, Mar 12, 2014 at 4:45 PM, Emil Velikov
> wrote:
>> Current handling relies on atoi which does not detect errors
>> additionally, any integer value will be considered as a valid
>> percent.
>>
>> Resolve that by using strtol and limiting the value
On 13/03/14 00:45, Ilia Mirkin wrote:
> On Wed, Mar 12, 2014 at 4:45 PM, Emil Velikov
> wrote:
>> In theory it's possible for any of the nouveau_getparam calls to
>> fail whist the last one being successful.
>>
>> Thus at least one of the following (hard requirements) drmVersion,
>> chipset and
Hi!
This cost me two half-written mails...
So far it happened once, so it may be very infrequent; but I do not
think I seen similar failure from i915 before, so it may be an
regression. Well...
-22 should be EINVAL afaict.
Any ideas?
On Thu, Mar 13, 2014 at 12:30:39AM +0100, Pavel Machek wrote:
> Hi!
>
> This cost me two half-written mails...
>
> So far it happened once, so it may be very infrequent; but I do not
> think I seen similar failure from i915 before, so it may be an
> regression. Well...
It's a userspace
https://bugs.freedesktop.org/show_bug.cgi?id=75127
--- Comment #12 from Sandeep ---
I'm still bisecting, should be done after a few more revisions.
--
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was
63 matches
Mail list logo